mirrors/gnss-sdr
1
0
Fork 0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2024-07-04 02:43:15 +00:00
Code Issues Releases Wiki Activity
8,074 Commits 7 Branches 21 Tags 98 MiB
0c3ac1127b
Commit Graph

3870 Commits

Author SHA1 Message Date
Carles Fernandez
1c4e4d3c67
Remove all warnings raised by bugprone-* clang-tidy checks in tracking blocks 2020-07-10 21:13:17 +02:00
Carles Fernandez
05c139b8be
Reduce number of warnings raised by bugprone-* clang-tidy checks in tracking blocks 2020-07-10 19:52:28 +02:00
Carles Fernandez
33cee4a759
Remove all warnings raised by bugprone-* clang-tidy checks in acquisition adapters 2020-07-10 13:35:15 +02:00
Carles Fernandez
5ad319e133
Remove all warnings raised by bugprone-* clang-tidy checks in acquisition blocks 2020-07-10 12:52:58 +02:00
Carles Fernandez
f2ccad7327
Fix input power computation 2020-07-10 11:28:53 +02:00
Carles Fernandez
c04948fd02
Reduce number of warnings raised by bugprone-* clang-tidy checks 2020-07-10 00:37:55 +02:00
Carles Fernandez
09bcd1981c Replace std::endl by \n character. There is no need to always flush the stream. 2020-07-07 18:53:50 +02:00
Carles Fernandez
aca0330325
Include what you use 2020-07-05 23:07:41 +02:00
Carles Fernandez
06aeae4da3
Fix clang-format CI job 2020-07-05 20:22:34 +02:00
Carles Fernandez
d3b7557dcf
Sort constants 
no more GPS_L1_PI, GPS_L2_PI, etc. Values are written in a single point.
 2020-07-05 20:20:02 +02:00
Carles Fernandez
a82664d345
Avoid unnecessary pointer copy 2020-07-04 19:16:31 +02:00
Carles Fernandez
8340eab627
Return the right input item size 2020-07-04 01:06:32 +02:00
Carles Fernandez
7d34866717
Add Rodrigo Muñoz to the list of Contributors 2020-07-03 23:55:01 +02:00
Carles Fernandez
fcf1b97c30
Fix call to overloded property in GCC 2020-07-03 21:52:40 +02:00
Carles Fernandez
cec63d3aad
Fix call to overloded property 2020-07-03 21:37:57 +02:00
Carles Fernandez
fb8e5e5c47
Fix a bug in signal sources that made the number of samples parameter ignored when too large (Fixes: #396) 2020-07-03 20:18:42 +02:00
Carles Fernandez
bb540c7b48
Replace const std::string by constexpr char 2020-07-03 11:36:38 +02:00
Carles Fernandez
c412d0a3f5
Fix clang warning: equality comparison with extraneous parentheses 2020-07-02 10:53:51 +02:00
Marc Majoral
6ae4ddb3b8 init nread_elements to prevent compiler warning. 2020-07-02 10:33:36 +02:00
Carles Fernandez
7634934995
Fix ccplint job 2020-07-01 20:04:40 +02:00
Carles Fernandez
d8f7214ad2
Merge branch 'fix_fpga_post_proc_mode_progr_termination' of https://github.com/mmajoral/gnss-sdr into mmajoral-fix_fpga_post_proc_mode_progr_termination 2020-07-01 20:02:48 +02:00
Carles Fernandez
11520ae3c0
Make save_matfile const 
Some private member reordering
 2020-07-01 19:52:52 +02:00
Marc Majoral
6068006df2 Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into fix_fpga_post_proc_mode_progr_termination 2020-07-01 17:44:42 +02:00
Marc Majoral
975f22f53d fixed program termination when using the FPGA in post-processing mode: the DMA process was not properly checking enable_DMA. 2020-07-01 17:42:40 +02:00
Carles Fernandez
5944cc6ee4
Always initialize private member item_size_ 2020-06-30 10:00:41 +02:00
Carles Fernandez
830681f5dd
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next 2020-06-29 16:01:55 +02:00
Marc Majoral
5b2f7a0617 increased the number of bits of the PRN code resampler 2020-06-29 15:59:48 +02:00
Carles Fernandez
2b3d4b321d
Make the adapters take the configuration pointer as const 2020-06-29 09:07:41 +02:00
Carles Fernandez
0c4bdfac48
Use INT8_MIN/MAX instead of SCHAR_MIN/MAX for consistency and portability 2020-06-28 13:25:23 +02:00
Carles Fernandez
23e13a7002
Fix CMake warnings 2020-06-27 19:48:33 +02:00
Carles Fernandez
a01dfa4052
Fix clang-format and clang-tidy jobs 2020-06-27 11:52:59 +02:00
Carles Fernandez
54a4c213ec
Update changelog 2020-06-27 11:39:14 +02:00
Carles Fernandez
1569f238ac
Fix clang-format jbb 2020-06-27 10:56:51 +02:00
Carles Fernandez
c784dfe125
Fix a bug that could cause a crash on receiver stopping 
If a channel event was happening after flowgraph stop and before flowgraph disconnection, it caused a crash. This was avoided by sleeping the control thread during 500 ms after disconnection and before the block destructors were called, so the event could be processed, but this was not a robust solution.
 2020-06-27 09:52:59 +02:00
Carles Fernandez
03d350551f
Sort private members in headers 2020-06-26 22:07:41 +02:00
Carles Fernandez
06ce79490b
Sort private members in headers 2020-06-26 18:37:31 +02:00
Carles Fernandez
660dd594dc
Return the right item_size 2020-06-25 14:54:01 +02:00
Carles Fernandez
63b7c00b16
Sort private members in headers 2020-06-25 11:58:01 +02:00
Carles Fernandez
5a3db5a53d
Add debug internal logging for destructors. Sort destructor order 2020-06-25 02:50:07 +02:00
Carles Fernandez
df7c466de0
Sort data members in headers 2020-06-24 22:27:51 +02:00
Carles Fernandez
ba022cc5f7
Improve consistency of CMake scripts 2020-06-24 11:42:45 +02:00
Carles Fernandez
d2a90370d5
Sort private members 2020-06-24 11:34:14 +02:00
Carles Fernandez
75aaf409cd
Remove unused variable 2020-06-24 11:28:35 +02:00
Carles Fernandez
70b823609a
Sort private members 2020-06-24 11:27:31 +02:00
Carles Fernandez
a9811ee2f4
Do not use pointer to string as data member 2020-06-24 02:43:37 +02:00
Carles Fernandez
b5c2367788
Merge branch 'Acquisition' of https://github.com/piyush0411/gnss-sdr into piyush0411-Acquisition 2020-06-23 11:47:24 +02:00
Carles Fernandez
037a1fcb5f
Improve headers, large data members first. Improve nav message interfaces 2020-06-23 09:47:58 +02:00
Carles Fernandez
afa16c6769
Remove sleeps 2020-06-20 22:18:38 +02:00
Carles Fernandez
87989ead0a
Fix for clang-tidy 2020-06-19 15:37:28 +02:00
Carles Fernandez
bc0cc69d76
Fix clang-format job 2020-06-19 13:01:22 +02:00
Carles Fernandez
0d5b5894b4
Sort header files 2020-06-19 12:39:28 +02:00
Carles Fernandez
f6058c6b61
Use unique_ptr for fft 2020-06-19 10:26:06 +02:00
Carles Fernandez
3e23b4a08c
Indicate with a prefix the private data members for clarity, use unique_ptr instead of shared_ptr 2020-06-19 03:51:50 +02:00
Carles Fernandez
317d72dd4c
Indicate with a prefix the private data members for clarity 2020-06-19 03:22:01 +02:00
Carles Fernandez
7ef64860c4
Indicate with a prefix the private data members for clarity 2020-06-19 02:15:56 +02:00
Carles Fernandez
8abcc2e24b
Indicate with a prefix the private data members for clarity 2020-06-19 01:36:36 +02:00
Carles Fernandez
45c20f08ac
Use unique_ptr instead of shared_ptr for d_gnss_synchro_history, and code cleaning 2020-06-19 00:32:19 +02:00
Carles Fernandez
b08082e1be
Raw pointer interface for the Monitor_Pvt sink 2020-06-18 20:40:53 +02:00
Carles Fernandez
eea1afea18
Merge branch 'next' into Acquisition 2020-06-18 19:48:53 +02:00
Carles Fernandez
81af1a531b
Redesign of pointer management 
Avoid indirection caused by passing shared_ptr by reference

The block factory does not have responsability on the lifetime of their inputs

Define std::make_unique when using C++11 and make use of it

Printers are turned into unique_ptr to express ownership

Printers do not participate on the lifelime of the data, so they take const raw pointers

Modernize tests code
 2020-06-18 11:49:28 +02:00
piyush0411
7cd6b5c260 Modified Adapter for Signal Generator 2020-06-18 02:10:19 +05:30
Carles Fernandez
7307e82d48
Fix for gcc < 8 2020-06-16 14:00:12 +02:00
Carles Fernandez
8932427d7a
Fix for gcc < 8 2020-06-16 13:35:00 +02:00
Carles Fernandez
026e0f5c1b
Fix for old gcc 2020-06-16 13:04:02 +02:00
Carles Fernandez
771fbf1365
Make use of std::rotl (C++20) if available 2020-06-16 12:22:37 +02:00
Carles Fernandez
094f8f2ee9
Remove unneded reset of the acquisition grid 2020-06-16 08:29:10 +02:00
piyush0411
c36ce57450 Fixed some errors in Signal Generator File 2020-06-15 20:05:53 +05:30
piyush0411
e1af7818ce Updated Signal Generator File 2020-06-15 18:27:27 +05:30
piyush0411
ff7affb666 Fixed some errors and typos 2020-06-15 18:26:07 +05:30
Carles Fernandez
bd4a354f9a
Fix ENABLE_CLANG_TIDY option 2020-06-14 13:00:36 +02:00
Carles Fernandez
b712c98a5b
Make clang-tidy happy 2020-06-13 21:13:46 +02:00
Carles Fernandez
dcf9bc52c4
Clarify source definition 2020-06-13 14:32:08 +02:00
Carles Fernandez
d40c225ade
Add BLAS::BLAS AND LAPACK::LAPACK imported targets 2020-06-13 13:43:00 +02:00
Carles Fernandez
ee84f60fb4
Simplify CMake scripts 2020-06-13 10:56:49 +02:00
Carles Fernandez
0df4277d36
Unify criteria in target definitions, more informative names 2020-06-13 00:32:40 +02:00
Carles Fernandez
d14e69ef5a
Do not pollute the source directory if the software is built from an out-of-source-tree directory 
External sources and data are now always stored in a ./thirdparty folder under the building directory.

A copy of the generated binaries will be stored under gnss-sdr/install, if the building directory is inside the source tree, or in an ./install folder under the building directory if it is outside the source tree.
Fix a bug that broke compilation if the user configured the building without extra testing in a first instance, and then switched the testing buiding options to ON in a later build.

Fix extra test building if GPSTk was already installed and Boost >= 1.71
 2020-06-12 20:51:26 +02:00
piyush0411
1bfc821487 Updated CMakeLists.txt file 2020-06-12 17:30:45 +05:30
Carles Fernandez
034d25c8d3
Do not emit warnings due to Protocol Buffers generated code 2020-06-11 15:16:40 +02:00
Carles Fernandez
65a25a47c5
Speed optimization by reserving memory for a std::vector 2020-06-11 13:39:38 +02:00
Carles Fernandez
44eba473a4
Replace a macro by a lambda 2020-06-11 13:32:18 +02:00
Carles Fernandez
836e074f98
Add building option ENABLE_STRIP to enable the generation of stripped binaries (without debgging information). Set to OFF by default 2020-06-10 17:22:03 +02:00
Carles Fernandez
34a250246a
Simplify initializations in system_parameters library 2020-06-10 10:15:59 +02:00
Carles Fernandez
72c820f9ee
Fix cmakelint job 2020-06-09 01:17:48 +02:00
Carles Fernandez
904bef433f
Fix cmakelint job 2020-06-09 01:10:31 +02:00
piyush0411
4cccd97bb5 PCPS based Acquisition Files for FPGA 2020-06-09 01:02:52 +05:30
Carles Fernandez
2a3d682f1f
Make use of target_sources(), make use of target propagation to reduce redundancy in dependencies, some fixes for Clang and CMake < 3.11. Use generic lambdas with auto 2020-06-08 20:04:01 +02:00
Carles Fernandez
4913756a05
Replace <boost/bind.hpp> by <boost/bind/bind.hpp> 2020-06-06 23:41:38 +02:00
Carles Fernandez
d2e9b0aece
Fix for Boost 1.73 2020-06-06 20:07:00 +02:00
Carles Fernandez
cd2dfe0bc2
Fix for Boost 1.73 2020-06-06 14:11:19 +02:00
piyush0411
9e38cc4ef5 Added PCPS based Acquisition Files 2020-06-06 14:25:46 +05:30
Carles Fernandez
017445040b
Merge branch 'Processing_Files' of https://github.com/piyush0411/gnss-sdr into piyush0411-Processing_Files 2020-06-04 14:11:35 +02:00
piyush0411
2b66cd1da2 Changed two files. 2020-06-04 07:51:37 +05:30
piyush0411
261d841deb Further Modifications done 2020-06-03 18:06:31 +05:30
piyush0411
bc0b32bc64 Made the changes. 2020-06-03 01:33:53 +05:30
piyush0411
2700c1c262 Fixed a typo 2020-06-01 21:23:41 +05:30
piyush0411
3f17a207fd Modified Signal Processing Files 2020-06-01 19:59:42 +05:30
Carles Fernandez
487971fd83
Merge branch 'fix-enum' into next 
Fix deprecated enum usage (in Clang 10, arithmetic between different enumeration types is deprecated [-Wdeprecated-anon-enum-enum-conversion])

Fix defect detected by Coverity Scan in Rtcm_Message class (Destination buffer too small: Buffer this->data_ contains 0 characters and is not null-terminated. Copying 6 characters from it overruns this->data_)
 2020-05-30 12:31:08 +02:00
Carles Fernandez
2f3f63309b
Fix for GCC 4.9 using std::array instead of char array 2020-05-30 09:40:20 +02:00
Carles Fernandez
3ca193fd9b
Fix warning in Clang 10 2020-05-30 00:44:37 +02:00
Carles Fernandez
0897811d16
Fix for GCC 4.9 2020-05-29 09:46:30 +02:00
Carles Fernandez
8c2d1d6ad1
Initialize buffer 2020-05-29 01:23:24 +02:00
Carles Fernandez
eef5cadab0
Fix deprecated enum usage 2020-05-28 23:27:36 +02:00
Carles Fernandez
f731a7c0f1
Fix for Boost >= 1.73 in old compilers 2020-05-18 22:50:34 +02:00
Carles Fernandez
1077970962
Revert "Fix for Boost < 1.60" 
This reverts commit 832c2558c6.
 2020-05-18 21:36:22 +02:00
Carles Fernandez
832c2558c6
Fix for Boost < 1.60 2020-05-18 19:55:44 +02:00
Carles Fernandez
b408a2ef29
Fix for Boost 1.73: qualify placeholders with their full namespace 2020-05-18 18:58:39 +02:00
Carles Fernandez
a73e08c017
Improve README files 2020-05-16 16:11:50 +02:00
Carles Fernandez
35ee34673a
Fix signature of copy and move operators 2020-05-16 14:39:34 +02:00
Carles Fernandez
13ca2b08b8
Fix multi-line comment (fixes -Wcomment) 2020-05-14 22:15:29 +02:00
Carles Fernandez
1745b71f13
Update gsl-lite version to 0.37.0 2020-05-14 19:36:04 +02:00
Carles Fernandez
052dd1fc85
Fix Python version detection 2020-05-10 18:31:54 +02:00
Carles Fernandez
33696780bf
Do no require six module if python is 3.x 2020-05-10 18:20:20 +02:00
Carles Fernandez
a7928bf14c
Import python six module only if python is 2.7 2020-05-10 18:15:09 +02:00
Carles Fernandez
0637365d6c
Remove python-six as a dependency if Python version is 3.x 2020-05-10 17:31:39 +02:00
Carles Fernandez
b43daff65f
Fix warning in CMake 3.17 2020-05-09 12:15:54 +02:00
Carles Fernandez
2b11bd6ba9
Uniformize interface of Galileo E5a functions 2020-05-08 09:50:05 +02:00
Carles Fernandez
1d703b4b48
Fix for using std::span when available, and gsl::span as a fallback 2020-05-07 23:11:11 +02:00
Carles Fernandez
eaee82280a
Make use of std::span when available 2020-05-07 21:47:45 +02:00
Carles Fernandez
af993e907b
Make clang-tidy happy (readability-identifier-naming filter) 2020-05-07 12:13:49 +02:00
Carles Fernandez
1726880898
Make lambda function of internal-linkage only, so it is only visible in its own translation unit. This fixes building with gcc 10.0.1, which complains about multiple definitions of the same lambda. 2020-05-07 09:31:39 +02:00
Carles Fernandez
0164d8b37c
Fixes for old GCC 2020-04-26 12:35:08 +02:00
Carles Fernandez
c27622a738
Fixes for old GCC 2020-04-26 12:28:24 +02:00
Carles Fernandez
5bde93f08c
Fix issues with boost::condition 2020-04-26 10:20:03 +02:00
Carles Fernandez
f5fc4d4119
Use lambda instead of boost::bind 2020-04-26 09:10:53 +02:00
Carles Fernandez
9c9a7b5bc6
Use lambda instead of boost::build when genenic lambdas are available in the compiler 2020-04-25 22:17:15 +02:00
Carles Fernandez
b9c84a451e
Improve internal handling of Gnss_Synchro objects 
Added noexcept move constructor and move assignment operator.
Small refactor of includes
 2020-04-25 16:08:33 +02:00
Carles Fernandez
16f45254a3
Fix building of OpenCL and CUDA blocks 2020-04-04 12:52:39 +02:00
Carles Fernandez
27f6b0c290
Fixes for GNU Radio 3.9 2020-04-03 00:41:51 +02:00
Carles Fernandez
865a54ddff
Apply clang-format 2020-04-03 00:17:22 +02:00
Carles Fernandez
3519107131
Add compatibility with the new GNU Radio 3.9 API that uses C++11 standard smart pointers instead of Boost smart pointers 2020-04-02 23:59:35 +02:00
Carles Fernandez
5f974a8f17
Replace boost::shared_ptr by std::shared_ptr 2020-04-02 13:23:20 +02:00
Carles Fernandez
7a5907eaf7
Drop compile-time CPU detection 2020-04-02 11:10:20 +02:00
Carles Fernandez
2df45a2d06
Remove tabs 2020-03-31 00:34:26 +02:00
Marc Majoral
0a14a1aa42 fixed DMA input file configuration options 2020-03-30 17:43:09 +02:00
Carles Fernandez
b8f5da341b
Fix redundant comparison 
Use std::llabs instead of abs
 2020-03-16 11:51:50 +01:00
Carles Fernandez
1a2f7c7d9d
Bump version to 0.0.12 
Add REUSE badge to README file
 2020-03-12 20:13:49 +01:00
Carles Fernandez
52b2b8b9d8
Use variable instead of function in constructor 2020-03-12 19:15:11 +01:00
Carles Fernandez
f233184a31
Fix receiver if the System V message queue is not available (Fixes: #361) 2020-03-10 19:56:47 +01:00
Javier
f73a4ac950 Correct Carrier Phase observable for inverted PLL lock in L2,L5 E1, and E5 2020-03-09 11:38:48 +01:00
Carles Fernandez
4a9dcff5b9 Add missing definition 2020-03-09 10:05:22 +01:00
Carles Fernandez
b4017f7aab
Fix carrier phase observable initialization in the FPGA side 2020-03-08 12:00:03 +01:00
Carles Fernandez
e58264bb0e
Remove unused parameter 2020-03-07 14:41:17 +01:00
Javier
e4dd4349c6 Fixed Carrier phase observable initialization. GNSS-SDR Observables quality verified with RTK positioning modes using RINEX files 2020-03-07 12:57:48 +01:00
Javier
79a47a8a49 Revert "Remove unuseful accumulated carrier 180 degres phase shift in GPS CA telemetry decoder" 
This reverts commit ea15b54a88.
 2020-03-07 11:36:47 +01:00
Carles Fernandez
4b3f777425
Add cmake modules to cmakelint job and fix errors 2020-03-01 12:29:21 +01:00
Carles Fernandez
e638019d93
Fix formatting errors detected by cmakelint 2020-03-01 11:53:01 +01:00
Carles Fernandez
299cb1a2ee
Remove usage of uninitialized variables in CMake scripts 
Remove all warnings emitted by cmake --warn-uninitialized ..
 2020-02-29 14:33:09 +01:00
Carles Fernandez
581ba96904
Use cmake -E rm instead of -E remove if CMake >= 3.17 2020-02-28 20:57:28 +01:00
Javier
ea15b54a88 Remove unuseful accumulated carrier 180 degres phase shift in GPS CA telemetry decoder 2020-02-28 10:32:59 +01:00
Carles Fernandez
716fa970c4
More markdown fixes 2020-02-27 19:50:08 +01:00
Carles Fernandez
17a7044add Wrap README text into 80 character-length lines, so they are easier to read from the terminal. 
Formatted by https://prettier.io/, options: --parser markdown --print-width 80 --prose-wrap always
 2020-02-27 18:42:43 +01:00
Carles Fernandez
f275091ba4
Fix clang-tidy readability-inconsistent-declaration-parameter-name check 2020-02-27 08:19:24 +01:00
Carles Fernandez
c470d43432
Fix shadowed variables 
See MISRA C++:2008, 2-10-2 - Identifiers declared in an inner scope shall not hide an identifier declared in an outer scope
and https://rules.sonarsource.com/cpp/RSPEC-1117\?search\=shadow
 2020-02-26 22:40:00 +01:00
Carles Fernandez
538c1e6182 Fix shadowed variables 2020-02-26 18:16:04 +01:00
Carles Fernandez
86a1dc5ca3 Add new conf parameter PVT.rinex_name to specify a custom name for generated RINEX files. 
A command-line flag --RINEX_name, which overrides the configuration if defined, is also available
 2020-02-25 14:43:15 +01:00
Carles Fernandez
be8ea389b5
Fix multi-line comment warning 2020-02-24 21:01:59 +01:00
Carles Fernandez
a5b5c0c5ca
Update GSL implementation 2020-02-24 20:48:55 +01:00
Carles Fernandez
2c5e286747
Set default value for early_late_space_narrow_chips parameter to 0.15 2020-02-24 20:24:20 +01:00
Carles Fernandez
ba7a938304
Add option to enable/disable carrier aiding in the code loop (enabled by default) 2020-02-24 20:18:28 +01:00
Carles Fernandez
0986e4a66e cpplint: Should have a space between // and comment [whitespace/comments] 2020-02-24 15:11:08 +01:00
Carles Fernandez
29c1971c24 cpplint: Should have a space between // and comment [whitespace/comments] 2020-02-24 15:05:32 +01:00
Carles Fernandez
e0b54cf8fe Rearrange attributes to simplify macros 2020-02-24 11:39:15 +01:00
Carles Fernandez
5698c9c2ea Disable complex math NaN/INFO range checking for performance 2020-02-24 11:38:18 +01:00
Carles Fernandez
ce16b0e1a4
Fix initialization 2020-02-23 13:45:57 +01:00
Carles Fernandez
649a1d7be6
cpplint: Do not use variable-length arrays [runtime/arrays] 2020-02-23 13:39:31 +01:00
Carles Fernandez
299608c4fc
cpplint: fix readability/utf8 2020-02-23 02:47:21 +01:00
Carles Fernandez
3c4ec48d43
cpplint: fix whitespace/semicolon 2020-02-23 02:45:51 +01:00
Carles Fernandez
a77142b8ca
cpplint: fix build/include_what_you_use, runtime/explicit filters 2020-02-22 16:36:31 +01:00
Carles Fernandez
39c4b85abf Apply clang-format 2020-02-20 16:32:59 +01:00
Carles Fernandez
a7511326b3 Merge remote-tracking branch 'cf/refactor' into next 2020-02-20 15:24:42 +01:00
Carles Fernandez
1b093794c9 More consistent data types 2020-02-20 11:25:29 +01:00
Carles Fernandez
c6fc6eb020 Apply performance-type-promotion-in-math-fn fix. 
Remove unused include, reorder header
 2020-02-20 10:50:12 +01:00
Carles Fernandez
b6c2911f39
Fix instantiation of tracking blocks with empty configuration 2020-02-20 08:23:57 +01:00
Carles Fernandez
3b965654d6
Refactor of tracking adapters 
Avoid code duplication
Based on @odrisci suggestion at #336
 2020-02-20 00:07:03 +01:00
Carles Fernandez
9b0460fb3f
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into normalize-discriminator 2020-02-17 08:43:14 +01:00
Carles Fernandez
ac7a77fd47
Minor fixes 2020-02-17 08:02:59 +01:00
Carles Fernandez
448995f8b0
Improve documentation 2020-02-17 08:00:52 +01:00
Carles Fernandez
d477c8ee28
Document change in discriminator implementation 2020-02-14 19:00:42 +01:00
Carles Fernandez
0f4bd21805
Use Use C11 aligned_alloc 
See https://github.com/gnuradio/volk/pull/334
 2020-02-13 19:44:24 +01:00
Carles Fernandez
0914ba5d8c
Merge branch 'normalize-discriminator' of https://github.com/carlesfernandez/gnss-sdr into normalize-discriminator 2020-02-13 18:46:25 +01:00
Carles Fernandez
52b9dfb8c0
Do not add extra work for nothing 2020-02-13 18:45:57 +01:00
Carles Fernandez
b8f2182a01 Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into normalize-discriminator 2020-02-13 11:09:16 +01:00
Carles Fernandez
10fc3fc48e
Add missing dependency 2020-02-12 08:30:25 +01:00
Carles Fernandez
c155a5074d
Add missing dependency 2020-02-12 07:58:32 +01:00
Carles Fernandez
2ded19342f
Improve headers 2020-02-12 00:04:29 +01:00
Carles Fernandez
cb95c65d19
Remove Gflags as a public dependency of algorithms_libs 2020-02-11 22:02:22 +01:00
Carles Fernandez
d65daac971
Code formatting (cpplint.py --filter=-,+whitespace/tab,+whitespace/comments) 2020-02-11 21:47:13 +01:00
Carles Fernandez
207b01a6c0
Make the carrier smoothing parameter an integer 2020-02-11 19:34:21 +01:00
Carles Fernandez
dfc02b2e5c Sort dependencies, remove unused ones 2020-02-11 17:27:54 +01:00
Carles Fernandez
0545369941 Remove unused dependency 2020-02-11 16:48:35 +01:00
Carles Fernandez
349cb431d6 Remove unused includes and dependencies 2020-02-11 16:28:58 +01:00
Carles Fernandez
17e27ace25 Move Matio dependency to private 2020-02-11 15:36:57 +01:00
Carles Fernandez
68388bd6c5 Sort out dependencies 2020-02-11 13:20:03 +01:00
Carles Fernandez
39f4adb058 Remove unused dependencies 2020-02-11 12:56:33 +01:00
Carles Fernandez
8c16ceca14 Move gnss_sdr_flags dependency to private 2020-02-11 12:19:48 +01:00
Carles Fernandez
d88cd25f03 Add new carrier_smoothing_factor flag 
Fix some public/private dependency issues
Add enable_carrier_smoothing flag to position_test
 2020-02-10 19:51:33 +01:00
Carles Fernandez
ce9d4b48e9 Fix CMakeLists files, clean dependencies relationships 2020-02-10 12:17:10 +01:00
Carles Fernandez
edc6444e5b Add SPDX license identifier in header 2020-02-10 11:13:15 +01:00
Javier
b2a17b23c5 Move debug acquisition messages from LOG(INFO) to DLOG(INFO) 2020-02-10 11:00:03 +01:00
Javier
b1c0e86751 New receiver feature: optional carrier smoothing of code range observables 2020-02-10 10:59:10 +01:00
Carles Fernandez
aeaf68fe47
Fix detection of Volk version if pkg-config is not present 2020-02-10 01:16:58 +01:00
Carles Fernandez
d1cb49b127
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into normalize-discriminator 2020-02-08 18:18:15 +01:00
Carles Fernandez
b7a75453d3
Fix comments syntax in Markdown 2020-02-08 10:52:42 +01:00
Carles Fernandez
955348b080
Remove trailing underscore in header guards 2020-02-08 10:10:46 +01:00
Carles Fernandez
4d0d263280
Make the software package compliant with the REUSE Specification v3.0 (see https://reuse.software/spec/) 
Update license headers to SPDX format (see https://spdx.org/)
Add license to all files
Add CI job in GitHub Actions to ensure compliance
 2020-02-08 01:20:02 +01:00
Carles Fernandez
bb8416402c
Fix normalization in dll_nc_e_minus_l_normalized discriminator (see #333) 2020-02-07 10:58:33 +01:00
Carles Fernandez
7d24203472
Apply new interface of dll_nc_e_minus_l_normalized 2020-02-07 10:10:27 +01:00
Carles Fernandez
0f0c3e7e1d Update links 2020-02-06 17:33:29 +01:00
Carles Fernandez
3a3d26fb0c Merge branch 'no-steering' into next 2020-02-06 17:25:01 +01:00
Carles Fernandez
93b210c142 Disable clock steering by default 2020-02-06 17:24:30 +01:00
Javier
18a5b917c4 Adding carrier phase observable initialization to match the pseudorange length 2020-02-06 16:56:42 +01:00
Carles Fernandez
a8fb2a6fb5
Update configurations (remove use_CFAR_algorithm parameter) 2020-02-05 22:15:50 +01:00
Carles Fernandez
d6ec2a7b2c
Update links (mainly from http to https, fix broken links) 2020-02-05 21:24:46 +01:00
Carles Fernandez
e75a1f19d6
Update links 2020-02-05 10:20:32 +01:00
Carles Fernandez
3f7ad8d8a7
Fix markdown 2020-02-02 13:25:15 +01:00
Carles Fernandez
56608db347
Reorder README 2020-02-02 13:23:37 +01:00
Carles Fernandez
715b7dc404
Reorder README 2020-02-02 13:23:23 +01:00
Carles Fernandez
2fe4e37ae8
Add license badge and BibTex entry for reference 2020-02-01 14:47:21 +01:00
Carles Fernandez
75b2dbf10e
Improve wording, fix broken link 2020-02-01 14:27:49 +01:00
Carles Fernandez
c00cd6bba0 Set RTCM parameter half_cycle_ambiguity_indicato (DF420) to false 2020-01-29 10:42:16 +01:00
Carles Fernandez
9023f19794
Use C++ comments for final #endif in headers 2020-01-26 22:23:22 +01:00
Carles Fernandez
eb40d9dbb5
Minor fixes 2020-01-26 14:09:49 +01:00
Carles Fernandez
dc3bf0172a
Update references and links to ICDs 2020-01-25 13:07:03 +01:00
Javier
650d637ee2 Better fix for bug fix that prevented PVT when disabled rx_clock_correction, issue #343 2020-01-22 12:16:48 +01:00
Javier
d387e1bf1a Bug fix that prevented PVT when disabled rx_clock_correction, issue #343 2020-01-22 11:24:07 +01:00
Carles Fernandez
eda1fcaaf2
Fix docs: add brief description in header to all files 2020-01-21 19:53:33 +01:00
Carles Fernandez
120032c8bd
Fix building with custom build types 
None, NoOptWithASM, Coverage, O2WithASM, O3WithASM and ASAN can now be used in CMAKE_BUILD_TYPE, in addition to Debug, Release, RelWithDebInfo and MinSizeRel.
Custom build types passed to volk_gnsssdr

Handle of custom build types when building tests
Fixes for clang
 2020-01-19 22:13:50 +01:00
Carles Fernandez
98ea7dc276
Fix detection of AVX and NEON 
Let the compiler know where to find volk/volk_common.h when testing for AVX and NEON

Make use of __VOLK_VOLATILE

Replace <inttypes.h> by <stdint.h> in volk/volk_common.h, fixes configuration in macOS
 2020-01-14 12:51:55 +01:00
Carles Fernandez
931d69b76e
Fix ARM NEON detection 2020-01-13 23:12:34 +01:00
Carles Fernandez
69e349d832
Fix guards 2020-01-13 03:12:19 +01:00
Carles Fernandez
6d51ea4ec7
Merge branch 'simple-cmake' into next 2020-01-13 03:04:05 +01:00
Carles Fernandez
bc9725c745
Simplify cmake scripts, fix volk_gnsssdr cross-compilation, update ProtocolBuffers to 3.11.2 2020-01-13 01:49:00 +01:00
Carles Fernandez
c57350cbc7
Fix build for macOS, fix warning about non-virtual destructor 2020-01-12 23:13:44 +01:00
Marc Majoral
c9ac1c10db Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fix_fpga_unit_tests 2019-12-16 18:51:15 +01:00
Marc Majoral
eb0df94336 updated fpga-related unit tests + fixed fpga acquisition log of sample stamp + stop tracking message unlocks channel (the fpga multicorrelator stops blocking the flow of samples) 2019-12-16 18:44:22 +01:00
Carles Fernandez
24a2d6c5d9 Update README to reflect how to build on Raspberry Pi 2019-12-16 10:12:15 -03:00
Carles Fernandez
5f97d52998 CMake fixes 
Remove Boost usage from lib, and fix it in apps to be used only if std::filesystem is not found.
Be more precise in specifying whether include directories are PUBLIC or PRIVATE.
Some whitespace tweaks
 2019-12-15 12:43:07 -03:00
Carles Fernandez
a3168bcafe
Fix bug in rtklib_conversions of glonass ephemeris (Fixes: #344) 2019-12-05 15:58:26 +01:00
Carles Fernandez
80fbeb4fe5
Revert "cmake: Use standard way of getting python prefix" 
This reverts commit f6311abc87.
 2019-11-30 21:14:12 +01:00
Carles Fernandez
f6311abc87
cmake: Use standard way of getting python prefix 2019-11-30 20:48:13 +01:00
Carles Fernandez
0038853c52
Clean CMake files 2019-11-30 20:30:22 +01:00
Carles Fernandez
b552616b99
Find Python 3 with CMake < 3.12 2019-11-30 17:42:44 +01:00
Carles Fernandez
21d19ebd93
Fix typo 2019-11-30 14:19:25 +01:00
Carles Fernandez
51c8732ff1
Look for python3 in first place even if CMake < 3.12 2019-11-30 14:18:39 +01:00
Carles Fernandez
52a6347fd4
Add missing include 2019-11-30 01:09:07 +01:00
Carles Fernandez
1604d86381
Remove unused variable 2019-11-30 00:55:13 +01:00
Carles Fernandez
96bf6587e7
Fix memory leaks (Fixes: #342) 2019-11-30 00:31:07 +01:00
Carles Fernandez
1d8024df98
Apply clang-format 2019-11-29 16:40:03 +01:00
Carles Fernandez
aa9adf3fd6
Replace deprecated exec_program by execute_process 2019-11-29 13:20:49 +01:00
Carles Fernandez
c88fffc5b2
Fix uninstall target 2019-11-29 13:02:02 +01:00
Carles Fernandez
625561a655
Remove deprecated cstdbool header 2019-11-25 22:47:31 +01:00
Carles Fernandez
bc7edede7c
Fixes for MSVC 2019-11-25 21:48:52 +01:00
Carles Fernandez
6993890587
Remove old comments 2019-11-24 22:25:18 +01:00
Carles Fernandez
82508e9aba
Merge branch 'odrisci-fix_pcps_threshold' into next. Fixes: #331 2019-11-24 21:24:16 +01:00
Carles Fernandez
64a1fcafb2
Boost_ADDITIONAL_VERSIONS is deprecated 2019-11-24 21:20:37 +01:00
Carles Fernandez
f6bcc27508
Apply clang-format and clang-tidy 2019-11-24 13:06:32 +01:00
Carles Fernandez
abc12aaab3
Do not read use_CFAR_algorithm from configuration 
Now it is just an internal flag not exposed to the configuration.
Added a control to ensure pfa and pfa2 are between 0.0 and 1.0
 2019-11-24 12:18:21 +01:00
Carles Fernandez
f2a537e403
Remove old code from acquisition adapters 2019-11-24 11:33:32 +01:00
Carles Fernandez
a6300b7ccb
Fix parameter reading 2019-11-23 22:34:46 +01:00
Carles Fernandez
acfc6f7903
Initialize all members 2019-11-23 19:26:01 +01:00
Carles Fernandez
e0f8bdd8cc
Fix initializations 2019-11-23 19:10:36 +01:00
Carles Fernandez
d6528a4d13
Fix GPS L5 adapter 2019-11-23 11:23:36 +01:00
Carles Fernandez
7ab1c3233f
Fix for homebrew 2019-11-22 21:40:42 +01:00
Carles Fernandez
17fd01ee3f
Use sha256 instead of sha1 for hash algorithm 2019-11-17 21:01:03 +01:00
Carles Fernandez
815a910619
Make use of ORC if available 2019-11-17 13:42:29 +01:00
Carles Fernandez
134ddd8561
Fix existing conf files using threshold instead of pfa 2019-11-17 12:24:03 +01:00
Carles Fernandez
0cd60b5fa1
Fix for old compilers 2019-11-16 20:09:14 +01:00
Carles Fernandez
4363dfcc9f
Fix for old compilers 2019-11-16 19:21:02 +01:00
Carles Fernandez
c7866ef385
Remove unused private members, replace std::bind by lambdas, apply clang-tidy and clang-format 
Fix position_test with default parameters
 2019-11-16 18:00:04 +01:00
Carles Fernandez
a7d19789f3
Merge branch 'fix_pcps_threshold' of https://github.com/odrisci/gnss-sdr into odrisci-fix_pcps_threshold 2019-11-16 12:40:22 +01:00
Carles Fernandez
1a9e25aa76
Add __clang__ specific attributes 2019-11-16 12:25:39 +01:00
Carles Fernandez
5728730c2a
cmake: use sha1 instead of md5 for unique target name hash 
See https://github.com/gnuradio/volk/issues/238
 2019-11-16 11:50:41 +01:00
Cillian O'Driscoll
7a7fd9a7b2 Fixed two missed references to "ic8" -> cbyte 2019-11-15 11:47:46 +00:00
Cillian O'Driscoll
feab31ae6b Reverted to gnss-sdr style naming for item_types 
i8->byte
ic8->cbyte
...
fc32->gr_complex
 2019-11-15 11:39:05 +00:00
Cillian O'Driscoll
3d27940b0a Applied clang-format 2019-11-08 13:47:08 +00:00
Cillian O'Driscoll
db57db839f Fixed unused variable warning 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
00c76b8683 Added other pcps adapters to the new format 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
a1fe98f833 Updates to get tests passing [acq refactor] 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
6a969b1ea3 Fixes for crashing tests in acq_conf 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
1bfb60d11c Ported galileo acquisition to new approach 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
3071aa1fcd [WIP] Simplifying acquisition config 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
75c57e90e5 [WIP] Fixing threshold setting in pcps_acquisition 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
695f3a9456 Added item type helpers 2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
a1df1eeb9c Fix missing factor two pi in clock correction 
This was leading to large code/carrier divergence in the rinex output
 2019-11-08 14:21:46 +01:00
Carles Fernandez
c1a26e01ff
Fix building with Xcode 
Now gnss-sdr can be built with Xcode (using the CMake flag -GXcode). Before this commit, this was only possible with volk_gnsssdr already installed.
Reason of failing was that Xcode does not like targets that have only object files. See https://gitlab.kitware.com/cmake/cmake/issues/17457
 2019-11-07 17:55:00 +01:00
Carles Fernandez
39382d38e9 Apply clang-format 2019-11-05 16:07:24 +01:00
Marc Majoral
83b202a5f7 Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into improve_fpga_extended_correlation 2019-11-05 15:04:20 +01:00
Carles Fernandez
bf0cba714c Apply clang-format 2019-11-05 14:45:41 +01:00
Carles Fernandez
4ac164a176 Merge branch 'odrisci-add_clock_drift' into next 2019-11-05 14:44:18 +01:00
Carles Fernandez
85c4786528 Apply clang-format 2019-11-05 14:43:41 +01:00
Marc Majoral
0e9fc67e0e Improved prn length estimation when performing extended correlation in the FPGA. 2019-11-05 13:05:01 +01:00
Carles Fernandez
f3de26ceec Apply clang-tidy 2019-11-05 12:42:56 +01:00
Cillian O'Driscoll
2a57b6e8d5 Added user_clk_drift_ppm to monitor_pvt 2019-11-05 09:45:11 +00:00
Cillian O'Driscoll
828d3cd525 [WIP] Adding velocity and clock drift 2019-11-05 09:17:41 +00:00
Cillian O'Driscoll
f9f7884d05 Applied clang-format to the previous commit 2019-11-05 09:17:41 +00:00
Cillian O'Driscoll
216e8dfa26 Added velocity and clock drift to PVT 
Interestingly RTKLIB does not store the clock drift in its sol_t
datatype, so I added this to the unused element dtr[5]. This may not be
compatible with future versions of RTKLIB.

Here we store velocity in ENU coordinates and the clock drift in parts
per million (PPM)
 2019-11-05 09:17:41 +00:00
Carles Fernandez
34d203a138
Fix Galileo date 2019-11-04 21:10:27 +01:00
Carles Fernandez
8f12cbc466
Include Visual Studio 14 2019-11-04 21:09:11 +01:00
Carles Fernandez
4e5a8885b1
Document triple-band modes in comments 2019-11-03 13:13:47 +01:00
Carles Fernandez
b17e58ed5a
Cosmetic changes 2019-11-02 12:23:28 +01:00
Carles Fernandez
75c2dcc929
Remove unused variable 2019-11-01 21:02:43 +01:00
Carles Fernandez
4816ae64f7
Add toolchain files for ARM processors 2019-11-01 19:29:28 +01:00
Carles Fernandez
62ace8d9e4
Move CMAKE_ASM_FLAGS to arm toolchain files 2019-11-01 11:17:52 +01:00
Carles Fernandez
d14111c85d
Improve license text wording 
Fix for AppleClang compiler >= 11
 2019-10-30 21:27:57 +01:00
Marc Majoral
8bb25dc682 removed the messages related to the fft blk exponent 2019-10-28 20:21:47 +01:00
Carles Fernandez
37f427844d Apply clang-format 2019-10-28 13:00:18 +01:00
Marc Majoral
f3485bb39b Throttle the DMA to give more time to other signal processing tasks. 2019-10-28 12:51:11 +01:00
Carles Fernandez
124531ba39
Accelerate writing of secondary code 
And other cosmetic changes
 2019-10-27 22:42:58 +01:00
Carles Fernandez
b4e4c849b1
More usage of volk_gnsssdr::vector 2019-10-27 21:34:19 +01:00
Carles Fernandez
9a9c8825ed
Improved usage of reserve/resize 2019-10-27 12:51:01 +01:00
Carles Fernandez
82089979fe
Fix usage of resize instead of reserve 2019-10-27 11:25:31 +01:00
Carles Fernandez
b1166de1a0
Introduce volk:gnsssdr::vector 
The usual benefits of using objects as opposed to pointers (RAII) + the type information is manifest (no void* pointers)
The best of both worlds: automatic destruction, aligned memory
 2019-10-26 22:24:42 +02:00
Marc Majoral
e0ef72eb75 fixed comments 2019-10-24 21:16:51 +02:00
Marc Majoral
6872097892 fixed the FPGA device file numbers used by the E5A tracking class. 2019-10-24 21:16:51 +02:00
Carles Fernandez
a9b0ff184d
Add energy-saving options for AD9361 
New flag rf_shutdown, true by default, allows setting the RX and TX streams ON when set to false.
New parameters rx1_enable and rx2_enable, true by default, allow to disable the secondary RX channel when not used
 2019-10-13 23:38:06 +02:00
Carles Fernandez
7126185515
Add and apply readability-braces-around-statements check 2019-10-11 19:24:20 +02:00
Carles Fernandez
61c22ed53b
Set default freq_dds_tx_hz parameter to 10 kHz 2019-10-11 12:02:53 +02:00
Carles Fernandez
054a20b5bf
Apply clang-format to the whole code tree 2019-10-11 11:57:33 +02:00
Carles Fernandez
3307edc1c9 Add Gnuradio::analog target for old gr-iio versions 2019-10-10 12:26:19 +02:00
Carles Fernandez
3f21367587 Fix building in some configurations 2019-10-10 10:40:37 +02:00
Carles Fernandez
cb99011de8
Fix building 2019-10-10 08:12:25 +02:00
Carles Fernandez
a6c6e53982
Fix building in Debian Buster 2019-10-10 07:38:27 +02:00
Carles Fernandez
8eca3f7cf0
Fix debian10 building 2019-10-09 22:55:20 +02:00
Carles Fernandez
94bef678af
Set definition to PRIVATE 2019-10-09 22:24:29 +02:00
Carles Fernandez
7e823123a2
Improve doc provided in terminal 2019-10-09 22:17:44 +02:00
Carles Fernandez
b0c00eb5b0
Fix for old versions of libad9361 2019-10-09 22:08:08 +02:00
Carles Fernandez
54698bd211
Apply clang-format 2019-10-09 21:15:20 +02:00
Carles Fernandez
fb0093aaab
clang-tidy: apply performance-unnecessary-value-param fix 2019-10-09 21:13:28 +02:00
Carles Fernandez
e4a39188f5
Implement FIR filter configuration 2019-10-09 20:50:06 +02:00
Carles Fernandez
c081c2ea57 Add work on FIR configuration 2019-10-09 19:05:31 +02:00
Carles Fernandez
43a8090dc6
Add work in the AD9361 manager 2019-10-09 09:18:29 +02:00
Carles Fernandez
09078b6486 Implement more conf options for AD9361 FIR filters, work in progress 2019-10-08 19:34:18 +02:00
Carles Fernandez
0dbba0500d Add more parameter guards 2019-10-08 16:38:30 +02:00
Carles Fernandez
df4a218ab4 Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into fir 2019-10-08 14:55:40 +02:00
Carles Fernandez
4208ffb4fb Work in the FIR filter 2019-10-08 14:55:16 +02:00
Carles Fernandez
daa30c992c Remove unused parameters 2019-10-08 14:47:28 +02:00
Carles Fernandez
bdabbf7f85 Implement phase_dds_deg parameter, fix guard for tx_bandwidth 2019-10-08 12:57:37 +02:00
Carles Fernandez
48a62594eb
Add work on RF configuration parameters for AD9361 2019-10-07 22:45:09 +02:00
Carles Fernandez
b5c253fd8f
Implement more configuration options for AD9361 2019-10-06 19:07:24 +02:00
Carles Fernandez
1e0c789c84
Prepare for gr-iio integration into GNU Radio 2019-10-05 21:12:54 +02:00
Carles Fernandez
c9e03557b7
Remove tabs 2019-10-05 03:16:31 +02:00
Marc Majoral
dbf0c38d37 applied clang-format 2019-10-03 16:37:18 +02:00
Marc Majoral
5d2047c300 replaced the device_base parameter by the dev_file_num parameter. dev_file_num specifies for each GNSS signal the first /dev/uio<X> driver that is associated to an FPGA HW accelerator that can be used for the tracking process of that GNSS signal. This parameter depends on the FPGA compilation and it is independant of the number of channels that are used for the tracking of other GNSS signals. 2019-10-03 16:37:18 +02:00
Marc Majoral
f2b2eb2f1a replaced .device_base by .dev_file_num parameter. The .dev_file_num parameter points for each type of GNSS signal, the number of the first uio device file that is used for the tracking process. 2019-10-03 16:37:18 +02:00
Marc Majoral
d20284fbc0 removed unused parameters 2019-10-02 15:25:46 +02:00
Carles Fernandez
8c31c19c09
Merge branch 'file_dma' into next 2019-10-02 00:19:22 +02:00
Marc Majoral
3a9e48c31c applied clang-format 2019-10-01 23:44:07 +02:00
Marc Majoral
e9470f566e fixed L1 and L2/L5 frequency band selection. 2019-10-01 23:13:28 +02:00
Marc Majoral
b932c5ef98 added the enable_DMA_ flag, which is used to stop the DMA when the user quits gnss-sdr, and the receiver is using the FPGA and the receiver is working in post-processing mode. 2019-10-01 22:26:30 +02:00
Marc Majoral
03cc2698bd removed the assert() function, which did not work properly. 2019-10-01 15:53:45 +02:00