Carles Fernandez
f2a537e403
Remove old code from acquisition adapters
2019-11-24 11:33:32 +01:00
Carles Fernandez
c7866ef385
Remove unused private members, replace std::bind by lambdas, apply clang-tidy and clang-format
...
Fix position_test with default parameters
2019-11-16 18:00:04 +01:00
Cillian O'Driscoll
3d27940b0a
Applied clang-format
2019-11-08 13:47:08 +00:00
Cillian O'Driscoll
db57db839f
Fixed unused variable warning
2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
a1fe98f833
Updates to get tests passing [acq refactor]
2019-11-08 13:44:07 +00:00
Cillian O'Driscoll
75c57e90e5
[WIP] Fixing threshold setting in pcps_acquisition
2019-11-08 13:44:07 +00:00
Marc Majoral
8bb25dc682
removed the messages related to the fft blk exponent
2019-10-28 20:21:47 +01:00
Carles Fernandez
9a9c8825ed
Improved usage of reserve/resize
2019-10-27 12:51:01 +01:00
Carles Fernandez
82089979fe
Fix usage of resize instead of reserve
2019-10-27 11:25:31 +01:00
Carles Fernandez
b1166de1a0
Introduce volk:gnsssdr::vector
...
The usual benefits of using objects as opposed to pointers (RAII) + the type information is manifest (no void* pointers)
The best of both worlds: automatic destruction, aligned memory
2019-10-26 22:24:42 +02:00
Marc Majoral
d20284fbc0
removed unused parameters
2019-10-02 15:25:46 +02:00
Carles Fernandez
269d9010cd
Apply clang-tidy with ENABLE_OPENCL set to ON
2019-09-14 11:27:23 +02:00
Carles Fernandez
d137fda820
Apply clang-tidy
2019-09-13 13:35:26 +02:00
Carles Fernandez
e80122f4ff
Apply clang tidy checks and clang-format
2019-09-13 08:56:37 +02:00
Carles Fernandez
02318c0382
Give to global parameters more meaningful name
2019-08-31 11:37:29 +02:00
Carles Fernandez
95f688dcb0
Mark all constructors callable with one argument as explicit
2019-08-23 21:25:44 +02:00
Carles Fernandez
d4bb6e5731
Always have a space between // and comment
2019-08-18 22:16:13 +02:00
Carles Fernandez
c31d9dea40
Fix errors risen by include_what_you_use
2019-08-17 13:56:54 +02:00
Carles Fernandez
3d146019dd
Apply modernize-redundant-void-arg clang-tidy fix
2019-08-14 02:14:29 +02:00
Carles Fernandez
3e3af9de5a
Add new configuration option ENABLE_ARMA_NO_DEBUG
...
When enabled, defines the ARMA_NO_DEBUG macro in Armadillo, disabling bound checking.
Disabled by default, but it is set automatically to ON if ENABLE_PACKAGING is set to ON
2019-08-12 11:33:51 +02:00
Carles Fernandez
4ec498514c
Build OpenCL block only if enabled with -DENABLE_OPENCL=ON
2019-08-02 14:59:05 +02:00
Carles Fernandez
2ec6ed6ec6
Clean usage of Guidelines Support Library
2019-07-29 21:47:46 +02:00
Carles Fernandez
4933ae3e0d
No Armadillo bound checking if compiled in Release mode
2019-07-29 21:22:44 +02:00
Carles Fernandez
822185ff93
Fixes by clang-tidy, clang-format and codespell
2019-07-26 13:58:15 +02:00
Carles Fernandez
d626ca1f88
Merge branch 'fpga_extended_coherent_integration' of https://github.com/mmajoral/gnss-sdr into mmajoral-fpga_extended_coherent_integration
2019-07-26 13:12:46 +02:00
Carles Fernandez
a4d6800e22
Update copyright year
...
Applied on files changed since last release
clang-format applied
2019-07-26 12:38:20 +02:00
Marc Majoral
7f594a356b
doppler center frequency for the grid search
2019-07-24 13:02:14 +02:00
Marc Majoral
ad7c1afea1
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-24 11:30:04 +02:00
Carles Fernandez
bd99a0674c
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next
2019-07-23 19:32:55 +02:00
Marc Majoral
f30d8a60ec
updated doxygen comments
2019-07-23 19:05:43 +02:00
Carles Fernandez
bf1ac2cb50
Simplify GSL usage
2019-07-23 19:01:18 +02:00
Carles Fernandez
05faf97b70
Switch to automatically managed static memory
2019-07-23 18:54:32 +02:00
Javier Arribas
27b1baf0b7
completing the acquisition assistance option from primary frequencies (e.g. L1, E1) to secondary frequencies (e.g. L5, E5)
2019-07-23 17:56:02 +02:00
Marc Majoral
6ee9fedd76
moved #defines to static consts + used clang-format + removed code that was commented out
2019-07-23 15:20:59 +02:00
Marc Majoral
d9d3696880
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-22 17:53:26 +02:00
Carles Fernandez
be86771ede
Move default destructor to header file, so compiler can make a better job
2019-07-21 19:32:52 +02:00
Carles Fernandez
0ddb063784
Modernize code
...
Automatize memory management
De-clutter clan-tidy warnings by fixing obvious issues
2019-07-19 18:23:36 +02:00
Marc Majoral
8b0e170a56
applied clang-format
2019-07-19 11:55:53 +02:00
Marc Majoral
dd996bc2e2
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-18 11:35:34 +02:00
Carles Fernandez
d7460022ed
Avoid C arrays
...
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-c-arrays.html
2019-07-14 14:09:12 +02:00
Carles Fernandez
4adb05570a
Fix typos detected by codespell
2019-07-09 11:52:53 +02:00
Marc Majoral
c8ccd5ef91
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-04 12:55:36 +02:00
Carles Fernandez
f1022385b0
Improve memory management
...
In class definitions, first write the public interface, then private
2019-07-01 21:54:52 +02:00
Carles Fernandez
d72542861f
Replace raw pointers by smart pointers. Remove delete
2019-06-30 12:51:23 +02:00
Carles Fernandez
751f54990c
Introduce gsl::span. Bound checking at compile time, no overhead at runtime
...
See https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md
2019-06-29 01:28:30 +02:00
Carles Fernandez
e28062de87
Modernize OpenCL code
2019-06-24 19:25:51 +02:00
Carles Fernandez
de79147def
Fix OpenCL test if the OpenCL Platform is not ready
2019-06-24 14:33:08 +02:00
Carles Fernandez
9318fe540d
Fixes for modern OpenCL versions
2019-06-24 13:39:34 +02:00
Carles Fernandez
a2dcf223f0
Create OpenCL imported target
2019-06-24 11:25:18 +02:00
Marc Majoral
0bb38ce38b
removed some not used variables + code optimization
2019-06-20 14:28:47 +02:00
Marc Majoral
05d006d1f9
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-06-18 18:25:24 +02:00
Marc Majoral
33d1115246
added support for extended coherent integration in the FPGA. The code still needs to be optimized and cleaned.
2019-06-18 18:22:01 +02:00
Carles Fernandez
8d424a13b6
Replace boost::filesystem by std::experimental::filesystem when the later is available
2019-06-12 20:39:29 +02:00
Carles Fernandez
ca6b4b545b
Replace Boost::filesystem by std::filesystem if C++17 support is available
2019-06-10 21:41:13 +02:00
Carles Fernandez
307373e362
Avoid unnecessary copy of channel_fsm
2019-04-22 13:03:01 +02:00
Marc Majoral
bf3f66278f
closed the acquisition device driver in the proper way + updated fpga block expponent.
2019-04-15 16:39:05 +02:00
Marc Majoral
7a06434928
removed unnecessary function in fpga_acquisition class
2019-04-12 15:16:31 +02:00
Javier Arribas
a79280d029
FPGA compilation error fix
2019-04-09 20:01:30 +02:00
Javier Arribas
141e101363
Bug fix that restores the acquisition and tracking destructor calls due to circular smart pointer references
2019-04-09 17:39:48 +02:00
Carles Fernandez
cc162dac9e
Code cleaning
2019-04-08 11:14:41 +02:00
Marc Majoral
ff024e7292
cleaned unused code and added some comments.
2019-04-04 19:55:02 +02:00
Marc Majoral
eda3f21fb9
added the reading of the high_dyn parameter in the tracking adapter modules + added max_num_acqs parameter for the FPGA acquisition.
2019-04-04 16:10:29 +02:00
Marc Majoral
4164d28abf
solved a bug: the acquisition device driver was not properly closed if double acquisition was enabled and the second acquisition was not successful.
2019-03-27 12:35:36 +01:00
Marc Majoral
47b405f92d
commented out debug messages that increase the time between accquisition and tracking
2019-03-27 11:57:31 +01:00
Marc Majoral
63cee0e63b
In order to reduce the CPU workload, the FPGA acquisition does not close and open the device driver in between the first and the second acquisition anymore.
2019-03-26 16:35:19 +01:00
Marc Majoral
cbc8131677
optimized the computation of FPGA acquisition doppler shift and dopper step registers
...
removed unnecessary function call
2019-03-26 16:22:49 +01:00
Marc Majoral
2b46c79ba7
optimized the process of computing and writing the fft of the local code to the acquisition HW accelerator.
...
The writing of the local code is still performed by processor instructions in a loop.
THe FPGA L2 classes were updated accordingly.
2019-03-26 12:26:08 +01:00
Marc Majoral
905a85670c
currently optimizing the FPGA-related code
2019-03-25 19:45:54 +01:00
Marc Majoral
2bae20d2fd
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into fpga
...
added second acquisition to reduce the time between acquisition and tracking when using the FPGA
moved the process of writing of the tracking local code to the HW accelerator from the start_tracking() function to the set_gnss_synchro() function (this is only applicable for the FPGA case)
there was a bug in the computation of the tracking starting position for the L1/E1 band when using the FPGA, only high sample counter values (>31 bits) were affected, due to a uint64_t*float mult.
2019-03-22 19:03:46 +01:00
Carles Fernandez
88b60aa6b1
Remove unused includes
2019-03-20 18:08:39 +01:00
Javier Arribas
55b1f316ed
Removing gnuradio block inheritance in FPGA acquisition
2019-03-20 16:57:50 +01:00
Marc Majoral
6da82535ba
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into fpga
2019-03-20 16:35:55 +01:00
Javier Arribas
0be8c657de
Reducing the latency in the acquisition to tracking transition
2019-03-20 15:13:17 +01:00
Marc Majoral
a24d26f427
set the default sampling frequency of the HW source to 12.5 Msps and the default bandpass bandwidth to 12.5 MHz + other minor changes
2019-03-19 10:14:09 +01:00
Marc Majoral
bef7e42fb9
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into fpga
2019-03-18 19:37:19 +01:00
Carles Fernandez
dd7a52c93b
Fix headers
2019-03-06 21:54:39 +01:00
Carles Fernandez
9ce827437c
Improve includes (IWYU)
2019-03-06 16:10:18 +01:00
Carles Fernandez
5b8ab9f591
Improve includes (IWYU)
2019-03-06 13:49:14 +01:00
Carles Fernandez
e7ea5c1fdd
Remove superfluous 'using google::LogMessage'
2019-03-03 13:39:35 +01:00
Carles Fernandez
fcfe63ba08
Fix defects detected by coverity scan
2019-03-01 20:49:45 +01:00
Marc Majoral
5a2dc274cf
but solved: double acquisition was using uint32_t for the initial doppler estimation. Therefore when the first estimated doppler was negative it was reset to zero.
2019-03-01 20:37:14 +01:00
Carles Fernandez
df0a77ee0d
Fix warnings
...
more protection on read/write failures and some code cleaning
2019-03-01 10:11:36 +01:00
Carles Fernandez
7c71ed9404
Merge branch 'fpga' of https://github.com/gnss-sdr/gnss-sdr into merge-fpga
...
Applied checks and formatting
2019-02-28 21:45:30 +01:00
Marc Majoral
ea86546d99
implemented double acquisition for the FPGA
2019-02-28 20:49:35 +01:00
Marc Majoral
c32e0b427a
coding style + removed some unnecessary memory arrays in the FPGA E5A tracking adapter class.
2019-02-27 17:27:31 +01:00
Marc Majoral
8d770d9be9
more code cleaning
...
removed some non used variables
2019-02-27 13:30:09 +01:00
Marc Majoral
5e22e4c50a
cleaned the FPGA acquisition code
2019-02-26 18:28:14 +01:00
Marc Majoral
cf0a37300a
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into fpga
2019-02-25 19:21:00 +01:00
Carles Fernandez
62a7e54359
Introduce readability-identifier-naming check
...
This commit enforces naming style for Classes and global constants:
Camel_Snake_Case for Classes
UPPER_CASE for global constants
CamelCase for abstract classes
2019-02-22 10:47:24 +01:00
Carles Fernandez
9bc771bed6
Deploy a new option -DENABLE_CLANG_TIDY to integrate clang-tidy checks and fixes into the compilation process, if found. It defaults to OFF
2019-02-21 09:59:06 +01:00
Carles Fernandez
31383258b0
clang-tidy: apply checks
2019-02-12 15:56:18 +01:00
Carles Fernandez
111c6291ec
Revert "clang-tidy: apply performance-unnecessary-value-param check"
...
This reverts commit eae967ed1a
.
2019-02-12 12:07:40 +01:00
Carles Fernandez
0c4b68c92d
clang-tidy: apply performance-move-const-arg check
...
See https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html
2019-02-12 02:07:06 +01:00
Carles Fernandez
eae967ed1a
clang-tidy: apply performance-unnecessary-value-param check
...
See https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
2019-02-12 01:00:36 +01:00
Carles Fernandez
73b7341904
clang-tidy: apply readability-braces-around-statements plus code formatting
...
See http://releases.llvm.org/7.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-braces-around-statements.html
Code formatting applied with:
find ../src/ -iname *.h -o -iname *.cc | xargs clang-format -i
2019-02-11 21:13:02 +01:00
Carles Fernandez
6abebac5eb
Make use of cstdint type names
2019-02-11 17:51:20 +01:00
Carles Fernandez
b9c115bdf8
clang-tidy: apply modernize-use-using check
2019-02-11 13:13:06 +01:00
Carles Fernandez
4b2b205e21
Avoid throwing exceptions from destructors
...
Detected by clang-tidy check bugprone-exception-escape
2019-02-10 21:55:51 +01:00
Carles Fernandez
75bd492d96
Change CMake target names to more meaningful ones, reflecting the code tree
2019-02-10 18:34:28 +01:00
Carles Fernandez
ce051e040f
Improve target design
2019-02-10 01:13:02 +01:00