Carles Fernandez
0066d581a1
Fix warning raised by clang-tidy check cert-flp30-c
...
Loop induction expression should not have floating-point type
2019-08-16 15:37:39 +02:00
Carles Fernandez
e89a92469b
Remove all c-style casts
2019-08-16 15:19:31 +02:00
Carles Fernandez
3abf82ca2c
Fix possible memory leak
2019-08-16 13:02:11 +02:00
Carles Fernandez
d298bdf0a9
Remove unused functions with defects in memory management
2019-08-14 20:06:48 +02:00
Carles Fernandez
c52a3dd4b5
Remove unused variables
2019-08-14 12:48:09 +02:00
Carles Fernandez
8a34fa8041
Fix typo
2019-08-14 11:58:35 +02:00
Carles Fernandez
80c4cdd1cb
Avoid usage of variable length arrays, which is a C99 feature
2019-08-14 11:58:00 +02:00
Carles Fernandez
3c92d6a7c6
Improve initialization of random engines
2019-08-14 11:56:55 +02:00
Carles Fernandez
4eb8f2c14e
Avoid C99 extensions in initializations
2019-08-14 11:10:51 +02:00
Carles Fernandez
ad617a0c26
Fix receiver reference number in comments
2019-08-14 10:14:43 +02:00
Carles Fernandez
5f176b084c
Replace defines by constants and move them to the implementation
2019-08-14 02:34:00 +02:00
Carles Fernandez
3d146019dd
Apply modernize-redundant-void-arg clang-tidy fix
2019-08-14 02:14:29 +02:00
Carles Fernandez
151a52d3d6
Move default constructor to header file
2019-08-14 01:17:47 +02:00
Carles Fernandez
4560712791
Apply modernize-use-default-member-init and readability-redundant-member-init clang-tidy checks
2019-08-14 00:56:53 +02:00
Carles Fernandez
a66ef4fb34
Apply modernize-redundant-void-arg clang-tidy check
2019-08-14 00:47:48 +02:00
Carles Fernandez
e693e3f1a4
Fix -Wstringop-truncation warning
2019-08-13 22:03:58 +02:00
Carles Fernandez
2771d5b5f2
Remove unused private members
2019-08-13 21:27:17 +02:00
Carles Fernandez
ad477fd12f
Fix warning (unused parameter)
2019-08-13 21:26:36 +02:00
Carles Fernandez
bbaa9310ec
Ensure that buffers are always terminated
2019-08-13 20:49:48 +02:00
Carles Fernandez
76515228b0
Avoid garbage values
2019-08-13 14:35:21 +02:00
Carles Fernandez
8867a9327c
Avoid null pointer argument in call to string comparison function
2019-08-13 13:52:43 +02:00
Carles Fernandez
c04ec18ef7
Fix typo
2019-08-13 13:50:07 +02:00
Carles Fernandez
0873d11407
Avoid usage of double as a loop index
2019-08-13 13:49:30 +02:00
Carles Fernandez
1bfa866354
Remove usage of deprecated bzero, replaced by memset
2019-08-13 13:48:17 +02:00
Carles Fernandez
6c5a4c4859
Remove usage of strcpy
...
See CWE-119 https://cwe.mitre.org/data/definitions/119.html
2019-08-13 13:10:45 +02:00
Carles Fernandez
d469c694e2
Apply default clang-tidy check
2019-08-13 01:06:47 +02:00
Carles Fernandez
487010346f
Apply readability-isolate-declaration clang-tidy check
2019-08-13 00:19:31 +02:00
Carles Fernandez
b16ee3d919
Apply readability-redundant-control-flow check
2019-08-12 22:54:27 +02:00
Carles Fernandez
3e3af9de5a
Add new configuration option ENABLE_ARMA_NO_DEBUG
...
When enabled, defines the ARMA_NO_DEBUG macro in Armadillo, disabling bound checking.
Disabled by default, but it is set automatically to ON if ENABLE_PACKAGING is set to ON
2019-08-12 11:33:51 +02:00
Carles Fernandez
ba2ffb96f3
Merge branch 'next' into release0011
2019-08-04 22:13:06 +02:00
Carles Fernandez
070996cdb4
Apply clang-tidy check readability-else-after-return
2019-08-04 13:15:03 +02:00
Carles Fernandez
75c71afd30
Merge branch 'next' into release0011
2019-08-04 08:28:19 +02:00
Carles Fernandez
2e93dbe8dc
Make build Reproducible
2019-08-03 20:31:53 +02:00
Carles Fernandez
1a11b5a2ec
Remove unnecessary links and includes to boost::thread
2019-08-03 19:51:50 +02:00
Carles Fernandez
ef90e09a36
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into release0011
2019-08-02 15:01:10 +02:00
Carles Fernandez
4ec498514c
Build OpenCL block only if enabled with -DENABLE_OPENCL=ON
2019-08-02 14:59:05 +02:00
Carles Fernandez
c79b8ea4f3
Build OpenCL block only if enabled with -DENABLE_OPENCL=ON
2019-08-02 14:52:40 +02:00
Carles Fernandez
6072cc6c5a
Merge branch 'next' into release0011
2019-08-02 11:51:16 +02:00
Carles Fernandez
041a34ecf9
Fix granurality of output_rate_ms to 20 ms
2019-08-02 11:44:51 +02:00
Carles Fernandez
d2539d66ef
Merge branch 'next' into release0011
2019-08-02 10:40:37 +02:00
Carles Fernandez
687e3b2e47
Revert "Revert "Remove unused variable""
...
This reverts commit 68afadab74
2019-08-02 07:42:25 +02:00
Carles Fernandez
68afadab74
Revert "Remove unused variable"
...
This reverts commit c8a03dc4af
2019-08-01 22:03:04 +02:00
Carles Fernandez
8cb2563341
Move obs_data to private member, so we ask for memory only once
2019-08-01 21:10:02 +02:00
Carles Fernandez
c8a03dc4af
Remove unused variable
2019-08-01 20:12:53 +02:00
Carles Fernandez
e686c38353
Code formatting, adapt overflow fix to new variable name
2019-08-01 20:09:35 +02:00
Carles Fernandez
a204278490
Merge branch 'obs_jump_fix' of https://github.com/gnss-sdr/gnss-sdr into raspi
2019-08-01 19:24:00 +02:00
Carles Fernandez
850c93798e
Avoid stack overflow in rtklib_solver
2019-08-01 19:23:38 +02:00
Javier Arribas
8b3c87dcfa
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into obs_jump_fix
2019-08-01 18:14:21 +02:00
Javier Arribas
f2becaa7b9
Final bug fix for the observables clock correction jumps
2019-08-01 18:11:36 +02:00
Marc Majoral
dae5b715cd
removed unnecessary calculations
2019-08-01 18:08:01 +02:00
Javier Arribas
12aae85f3c
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into obs_jump_fix
2019-08-01 17:25:15 +02:00
Carles Fernandez
86f40ae4eb
Fix comparison sign
2019-08-01 12:31:12 +02:00
Javier Arribas
9eac73630a
Add clock correction + interpolation to annotated observables
2019-07-31 18:16:09 +02:00
Carles Fernandez
cdfe4c43d9
Revert "Remove unused public member"
...
This reverts commit 1f476957e3
2019-07-31 10:21:32 +02:00
Carles Fernandez
cc54b4a122
Enforce rule 15.1 of the High Integrity C++ Coding Standard
...
See https://www.perforce.com/resources/qac/high-integrity-c-coding-standard-exception-handling
2019-07-30 12:51:36 +02:00
Carles Fernandez
2fe38e937a
Fix wrong assignment
2019-07-30 08:06:53 +02:00
Carles Fernandez
1f476957e3
Remove unused public member
2019-07-30 08:06:05 +02:00
Carles Fernandez
89632374a0
Fix runtime error in ARM architectures
2019-07-29 21:51:47 +02:00
Carles Fernandez
2ec6ed6ec6
Clean usage of Guidelines Support Library
2019-07-29 21:47:46 +02:00
Carles Fernandez
4933ae3e0d
No Armadillo bound checking if compiled in Release mode
2019-07-29 21:22:44 +02:00
Carles Fernandez
271399fc22
Fix bug: avoid RTKLIB memory corruption
...
Avoid alloc-dealloc-mismatch caused by uniqnav
Reserve memory for get_PVT as std::arrays in header file, so we do not have to ask for new memory each time we execute get_PVT
Remove unused public member count_valid_position
2019-07-28 13:59:29 +02:00
Carles Fernandez
9f8f9e8af9
Apply code cleaning before release
2019-07-28 12:01:11 +02:00
Carles Fernandez
f349d7c29b
Bump version to 0.0.11
2019-07-27 13:31:12 +02:00
Carles Fernandez
9772f8ef07
Replace raw pointers by smart pointers
2019-07-27 11:24:39 +02:00
Carles Fernandez
8aaf6019e9
Better usage of the GSL, other minor cleaning
2019-07-27 11:22:08 +02:00
Carles Fernandez
712d9ff06b
Code uniformization
2019-07-26 15:48:29 +02:00
Carles Fernandez
822185ff93
Fixes by clang-tidy, clang-format and codespell
2019-07-26 13:58:15 +02:00
Carles Fernandez
d818aacde4
Avoid name clash with system macro in macOS
2019-07-26 13:22:11 +02:00
Carles Fernandez
d626ca1f88
Merge branch 'fpga_extended_coherent_integration' of https://github.com/mmajoral/gnss-sdr into mmajoral-fpga_extended_coherent_integration
2019-07-26 13:12:46 +02:00
Carles Fernandez
a4d6800e22
Update copyright year
...
Applied on files changed since last release
clang-format applied
2019-07-26 12:38:20 +02:00
Marc Majoral
694c5d9dcb
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-26 10:11:55 +02:00
Marc Majoral
6f656bc744
solved minor bug in cn0_and_tracking_lock_status
2019-07-26 10:10:12 +02:00
Carles Fernandez
ddc6b822fb
Simplify code
2019-07-26 03:51:43 +02:00
Carles Fernandez
e31b31952b
Sort includes, minor cleaning
2019-07-26 01:38:53 +02:00
Carles Fernandez
56b65df044
Improve initialization
...
Works in Linux and MacOS
2019-07-26 00:55:16 +02:00
Carles Fernandez
9f60ff3e24
Make use of cstdint type names
...
Fix google-runtime-int warning
2019-07-25 23:46:06 +02:00
Carles Fernandez
cc86642b15
Fix type
2019-07-25 23:35:10 +02:00
Carles Fernandez
634f9631c6
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next
2019-07-25 23:05:29 +02:00
Carles Fernandez
b4f3720ff1
Fix guard
2019-07-25 21:37:57 +02:00
Carles Fernandez
2b8e5140e5
Do not write value that is never read
2019-07-25 21:36:07 +02:00
Carles Fernandez
342485d28d
Remove unused private members
2019-07-25 21:34:42 +02:00
Javier Arribas
c45257a26b
Bug fix: Restore telecommand functionality
2019-07-25 16:38:19 +02:00
Marc Majoral
f6b8959993
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-24 13:04:37 +02:00
Marc Majoral
7f594a356b
doppler center frequency for the grid search
2019-07-24 13:02:14 +02:00
Carles Fernandez
ad389f7b1a
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next
2019-07-24 12:17:57 +02:00
Marc Majoral
0b8a408b9a
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-24 12:02:17 +02:00
Javier Arribas
f18a9adb55
Correct data type in acquisition set doppler center
2019-07-24 12:00:25 +02:00
Marc Majoral
ad7c1afea1
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-24 11:30:04 +02:00
Marc Majoral
48fe6086e4
updated the handling of the scoped_lock mutex in the fpga tracking loops + used clang-format.
2019-07-24 11:26:16 +02:00
Carles Fernandez
2a64b57574
Remove unused parameter
2019-07-23 21:08:45 +02:00
Carles Fernandez
bd99a0674c
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next
2019-07-23 19:32:55 +02:00
Marc Majoral
f30d8a60ec
updated doxygen comments
2019-07-23 19:05:43 +02:00
Carles Fernandez
6796a73820
Avoid pointer arithmetics
2019-07-23 19:04:01 +02:00
Carles Fernandez
bf1ac2cb50
Simplify GSL usage
2019-07-23 19:01:18 +02:00
Carles Fernandez
05faf97b70
Switch to automatically managed static memory
2019-07-23 18:54:32 +02:00
Javier Arribas
27b1baf0b7
completing the acquisition assistance option from primary frequencies (e.g. L1, E1) to secondary frequencies (e.g. L5, E5)
2019-07-23 17:56:02 +02:00
Marc Majoral
6ee9fedd76
moved #defines to static consts + used clang-format + removed code that was commented out
2019-07-23 15:20:59 +02:00
Marc Majoral
00993d9719
replaced #defines by static consts + removed unused tracking parameter + removed unnecessary comments
2019-07-22 19:58:37 +02:00
Marc Majoral
d9d3696880
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-22 17:53:26 +02:00
Carles Fernandez
09b6b2305e
Handle redefinition of Boost_VERSION variable in CMake 3.15
...
See Policy CMP0093 https://cmake.org/cmake/help/v3.15/policy/CMP0093.html#policy:CMP0093
CMake 3.15 policies enabled by default (see https://cmake.org/cmake/help/v3.15/manual/cmake-policies.7.html#manual:cmake-policies(7) )
2019-07-22 14:13:57 +02:00
Marc Majoral
8d813f05d1
updated the calculation of the FPGA integration length variable
2019-07-22 11:47:33 +02:00
Carles Fernandez
a172b755f7
Fix typo
2019-07-21 19:37:13 +02:00
Carles Fernandez
be86771ede
Move default destructor to header file, so compiler can make a better job
2019-07-21 19:32:52 +02:00
Carles Fernandez
6e5c79d144
Fix compiler ambiguity
2019-07-21 13:12:46 +02:00
Carles Fernandez
37fdfca5ec
Miscellaneous improvements
...
Improve modularity of CMake design
Improve building speed in multicore processors
Files command_event.* moved to core/libs
Remove Armadillo from public core_receiver interface
Uniformize name format for classes
Apply some fixes by clang-tidy
Improve documentation
2019-07-21 12:55:59 +02:00
Carles Fernandez
471428f867
Fix typos detected by codespell
2019-07-20 12:55:46 +02:00
Carles Fernandez
f440a0e9f1
Avoid passing big parameters by value
...
clang-tidy check: performance-unnecessary-value-param
See https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
2019-07-20 11:39:08 +02:00
Carles Fernandez
49e64f94f6
Code cleaning, initializations
2019-07-20 11:13:28 +02:00
Carles Fernandez
03a77b06ea
Format file
2019-07-20 03:02:43 +02:00
Carles Fernandez
ef9c02bac2
Miscellaneous changes: fix typos, warnings
2019-07-20 02:53:31 +02:00
Carles Fernandez
739c008f49
Merge branch 'newsatdispatcher' of https://github.com/gnss-sdr/gnss-sdr into telemetry
2019-07-19 23:12:38 +02:00
Carles Fernandez
0ddb063784
Modernize code
...
Automatize memory management
De-clutter clan-tidy warnings by fixing obvious issues
2019-07-19 18:23:36 +02:00
Marc Majoral
851d36cb9b
minor code optimizations + replaced #defines by constants in the tracking adapters
2019-07-19 17:23:00 +02:00
Marc Majoral
f426294385
removed unnecessary messages
2019-07-19 13:04:39 +02:00
Marc Majoral
3225d92f1b
removed unused variable
2019-07-19 12:24:25 +02:00
Javier Arribas
0035cd06dd
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into newsatdispatcher
2019-07-19 12:01:51 +02:00
Marc Majoral
becd3c4a3d
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-19 12:00:14 +02:00
Marc Majoral
8b0e170a56
applied clang-format
2019-07-19 11:55:53 +02:00
Carles Fernandez
35852c7efb
clang-tidy fixes
...
Reduce number of hicpp-signed-bitwise warnings
See https://rules.sonarsource.com/c/RSPEC-854
2019-07-18 22:57:45 +02:00
Carles Fernandez
6a15b84687
Simplify code
2019-07-18 22:03:56 +02:00
Carles Fernandez
9f90384375
Unify operator name for exclusive or, use bitset instead of array for bools
2019-07-18 20:01:54 +02:00
Carles Fernandez
4628011e9e
Unify operator name for exclusive or
2019-07-18 19:47:27 +02:00
Carles Fernandez
b8fb52fe3c
Remove not needed moves
2019-07-18 19:43:08 +02:00
Marc Majoral
8c84702f27
implemented the stop_tracking() function
2019-07-18 19:12:17 +02:00
Marc Majoral
dd996bc2e2
Merge branch 'next' of https://github.com/mmajoral/gnss-sdr into fpga_extended_coherent_integration
2019-07-18 11:35:34 +02:00
Marc Majoral
4c22a1ce1a
the tracking module is now sending 1 synchro_data per data symbol.
2019-07-17 18:01:27 +02:00
Carles Fernandez
50cfb6cdf5
Fix building until gnss-sdr
2019-07-16 19:20:37 +02:00
Javier Arribas
1313edd716
Partial implementation of the new event queue and its dependencies. Still NOT usable
2019-07-16 17:41:12 +02:00
Javier Arribas
cae1c5a73a
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into newsatdispatcher
2019-07-16 12:29:20 +02:00
Carles Fernandez
76222945bd
Add missing include, reordering
2019-07-16 12:02:13 +02:00
Javier Arribas
e7dc926dad
Improving the concurrent queue and fix missing dependencies
2019-07-16 11:07:02 +02:00
Javier Arribas
61d320fb05
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into newsatdispatcher
2019-07-16 10:29:02 +02:00
Carles Fernandez
c36cb0cf4b
Fix B3I code generation
2019-07-16 08:53:59 +02:00
Carles Fernandez
e7e936f97e
Use std::bitset<N> instead of std::array<bool, N>
2019-07-15 15:13:18 +02:00
Carles Fernandez
8e0445264a
Do not use bitwise operators with signed operands
...
Use of signed operands with bitwise operators is in some cases subject to undefined or implementation defined behavior. Therefore, bitwise operators should only be used with operands of unsigned integral types.
2019-07-15 12:17:29 +02:00
Carles Fernandez
ec9aa207b0
Do not use bitwise operators with signed operands
...
Use of signed operands with bitwise operators is in some cases subject to undefined or implementation defined behavior. Therefore, bitwise operators should only be used with operands of unsigned integral types.
2019-07-15 12:14:39 +02:00
Javier Arribas
1961766863
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into newsatdispatcher
2019-07-15 12:07:55 +02:00
Carles Fernandez
7436188f34
Remove unused variable
2019-07-15 12:00:11 +02:00
Carles Fernandez
e820eb0bc4
Revert "Keep eph_data and geph_data as std::array"
...
This reverts commit d07a2c2a80
2019-07-15 11:57:32 +02:00
Javier Arribas
2238a2194d
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into newsatdispatcher
2019-07-15 11:32:52 +02:00
Carles Fernandez
d07a2c2a80
Keep eph_data and geph_data as std::array
...
std::vector has more overhead that is not needed here.
Remove usused variable sat
2019-07-15 10:07:15 +02:00
Carles Fernandez
0e54fad652
Merge branch 'bds_fix' of https://github.com/dmiralles2009/gnss-sdr into dmiralles2009-bds_fix
2019-07-15 09:48:31 +02:00
Damian Miralles
410269069a
bds: Bug fixes in carrier wavelength computation
...
Changed wavelength computation to native method within RTKLIb. The native method
should also help in the PVT computation of GLONASS satellites as it considers
the freq. offset when computing the wavelength. This also fixes typo in tracking
stage for MEO satellites of the BDS constellation.
Note: A similar approach to carrier wavelength computation should be applied to
the obs_data in rtk_solver. In theory, static allocation should not be needed for
the types.
2019-07-14 20:09:52 -05:00
Carles Fernandez
9572b37da7
Remove uses of bitwise operations on signed integer types
...
Based in the High Integrity C++ Standard, Section 5.6.1
See https://www.perforce.com/resources/qac/high-integrity-c-coding-standard-expressions
Removed some c arrays by std::array
2019-07-14 23:34:07 +02:00
Javier Arribas
bf40ed2be1
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into newsatdispatcher
2019-07-14 18:51:41 +02:00
Carles Fernandez
7ee1394f2f
Fix building with gcc 4.9
2019-07-14 14:48:05 +02:00
Carles Fernandez
d7460022ed
Avoid C arrays
...
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-c-arrays.html
2019-07-14 14:09:12 +02:00
Carles Fernandez
4dfb2cf5d2
Avoid out-of-bounds read
2019-07-14 03:17:57 +02:00
Carles Fernandez
89aa7c61e6
Avoid out-of-bounds read
2019-07-14 03:00:26 +02:00
Carles Fernandez
def3a8875a
Misc improvements
...
Remove cstdio
Remove usage of cstring and memcpy when it is not needed
Mark move cobstructor with noexcept
2019-07-14 02:28:28 +02:00
