Carles Fernandez
07b401e3bc
Improve error messages in case of wrong configuration for the FPGA offloading flowgraph
2021-02-23 21:40:53 +01:00
Carles Fernandez
df8cdc678d
Allow a receiver compiled with -DENABLE_FPGA=ON to execute regular flowgraphs
2021-02-23 16:48:18 +01:00
Carles Fernandez
3ec9749852
Do not instantiate the Signal Conditioner when the software is compiled with ENABLE_FPGA=ON
...
so that part can be removed from the configuration file when using the FPGA offloading flowgraph
2021-02-23 13:37:17 +01:00
Carles Fernandez
b4d9a3a84b
Remove redundant parameter SignalSource.enable_FPGA
2021-02-23 12:24:21 +01:00
Carles Fernandez
c2223e3dad
Create a base class for Gnss almanacs, unify parameter names
2021-02-23 11:57:24 +01:00
Carles Fernandez
a479d4c1eb
Remove failing extra unit test
2021-02-23 09:55:56 +01:00
Carles Fernandez
ae018f829c
Improve test
2021-02-23 09:55:14 +01:00
Carles Fernandez
cc66a27740
Fix ignored value
2021-02-22 20:17:26 +01:00
Carles Fernandez
81251f5ef3
Actually test something
2021-02-22 20:15:43 +01:00
Carles Fernandez
a0f10218fd
Fix ignored value
2021-02-22 20:13:46 +01:00
Carles Fernandez
489da500a1
Merge branch 'fix_FPGA_post_processing_mode' of https://github.com/mmajoral/gnss-sdr into mmajoral-fix_FPGA_post_processing_mode
2021-02-22 18:52:37 +01:00
Carles Fernandez
927b91096d
Reorder members definition
2021-02-22 14:09:54 +01:00
Carles Fernandez
146e1d7a63
Update .proto files for GPS and Galileo ephemeris data
2021-02-22 13:42:54 +01:00
Carles Fernandez
86d701b628
Remove more duplicated code
2021-02-22 10:02:21 +01:00
Carles Fernandez
b465f050f0
Apply clang-format
2021-02-21 12:15:38 +01:00
Carles Fernandez
2e53289653
Add more consistency in parameters name
2021-02-21 10:56:56 +01:00
Carles Fernandez
5a43a3cfce
Add missing include
2021-02-21 00:29:05 +01:00
Carles Fernandez
7971565a0d
Give more natural, consistent names to ephemeris / iono / utc parameters exposed outside the receiver via XML files
...
Create a base class for GPS, Galileo and BeiDou ephemeris, allowing to remove some duplicated code
Use BOOST_SERIALIZATION_NVP macro, less error prone than boost::serialization::make_nvp
Update .xsd files
2021-02-21 00:01:56 +01:00
Marc Majoral
79c968f279
modified some comments
2021-02-19 16:34:49 +01:00
Marc Majoral
f85a653285
stop the receiver in a controlled way on EOF or error condition.
...
+ add support for the following signal source configuration options: samples, repeat, seconds_to_skip, header_size
+ remove unused header files
2021-02-19 13:03:22 +01:00
Marc Majoral
b06722062d
removed unused header files
2021-02-18 18:46:59 +01:00
Carles Fernandez
8e23c60fca
Do not warn users twice about the overflow
...
clang-tidy checks applied: modernize-redundant-void-arg, performance-unnecessary-value-param
2021-02-18 13:17:46 +01:00
Carles Fernandez
29e3e120be
Merge branch 'mmajoral-fix_fpga_buff_mon' into next
2021-02-18 13:01:53 +01:00
Carles Fernandez
6c5f26fcf7
Avoid no symbols warning in MacOS
2021-02-18 13:01:48 +01:00
Marc Majoral
e4de9c54de
do not stop the receiver when buffer overflow is detected.
2021-02-18 12:32:44 +01:00
Carles Fernandez
73a728b3f6
Merge branch 'feature/signal_source_interface' of https://github.com/jwmelto/gnss-sdr into jwmelto-feature/signal_source_interface
2021-02-18 09:03:03 +01:00
Carles Fernandez
9403560427
Return back init() to connect()
2021-02-17 22:13:20 +01:00
Carles Fernandez
03e53477c7
Apply some mostly cosmetic changes
...
This is not so cosmetic: Moved init() chores from connect() to the constructor for consistency with other implementations. Not relevant here since files are not processed in real-time, but is it common practice in other blocks to set everything needed (and get all the resources) in the constructor, before connect()
Moved the constructor code to the top of the file, also for consistency with other files. This is an opinionated practice, I know, since one could expect the same order than in the header file.
Improved comment formatting for Doxygen
Added and removed some blank lines to match the style of other files (two blank lines within method implementations, no two consecutive blank lines inside the method. Again opinionated, but for the sake of consistency.
Included the <tuple> library (include what you use)
2021-02-17 22:07:22 +01:00
Jim Melton
704b99e633
another MacOS property ambiguity ... ARRRGGGHHH
2021-02-17 13:40:04 -07:00
Jim Melton
c221fd1c87
update copyright and move risky initializer into ctor body
2021-02-17 12:54:10 -07:00
Carles Fernandez
6d41fc8fb2
Fix Multichannel_File_Signal_Source
...
The constructor was not getting right the SignalSource.RF_channels value (role was moved before, so it was unusable)
2021-02-17 13:50:45 +01:00
Carles Fernandez
f703990a09
Fix building when using C++11
...
Update changelog
2021-02-17 09:43:05 +01:00
Carles Fernandez
0f735814df
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next
2021-02-16 18:34:31 +01:00
Javier Arribas
8ba3cfa86f
Send monitor ephemeris even in the case that it is not enabled the RINEX writter
2021-02-16 17:54:38 +01:00
Carles Fernandez
a7699c2050
Fix file headers
2021-02-16 17:15:48 +01:00
Carles Fernandez
3b3beb099a
Fix clang-tidy job, update headers
2021-02-16 17:00:22 +01:00
Carles Fernandez
19c03edf1f
Update file header
2021-02-16 16:42:10 +01:00
Carles Fernandez
060e276414
Merge branch 'buffer_monitor' of https://github.com/mmajoral/gnss-sdr into mmajoral-buffer_monitor
2021-02-16 16:11:15 +01:00
Jim Melton
ec7b4cc537
clang-tidy : change '1u' to '1U'
2021-02-16 00:34:49 -07:00
Jim Melton
e5bcf4700c
penultimate clang-tidy/clang-format complaint
2021-02-15 23:01:56 -07:00
Jim Melton
a8959bdd87
more clang-tidy cleanup/suppression
2021-02-15 22:56:30 -07:00
Jim Melton
c67f23c913
fix clang-tidy complaints
...
some of these are ridiculous and so have been silenced. I'm a huge fan
of static code analysis but I have a hard time believing that writing
"0U" is a qualitative improvement over "0u".
2021-02-15 21:30:50 -07:00
Jim Melton
35f07b76a0
the Mac compiler is really annoying (and not that arguably correct...)
2021-02-15 18:37:38 -07:00
Jim Melton
957a13e6ef
fix MacOS ambiguity error
2021-02-15 17:51:42 -07:00
Jim Melton
3b728d9c26
fix cast error
2021-02-15 17:15:38 -07:00
Jim Melton
ece5effa2d
penultimate clang-format fix
2021-02-15 16:34:16 -07:00
Jim Melton
bba9edd68c
change invalid block implementation from FATAL to ERROR
...
I'm not sure that there is any value in continuing with a bad configuration
but be careful about changing the semantics of existing code. You never know
what else may depend upon it.
2021-02-15 16:31:35 -07:00
Jim Melton
6e04a42c8a
clang-format
...
This was much worse than I thought. I had run clang-format at some point, but
apparently I subsequently made some non-compliant changes in pretty much every
file I touched.
2021-02-15 15:34:48 -07:00
Jim Melton
3bf2deb2ae
fixed failing unit test
...
I don't know how this didn't run before submitting the PR. CI tests are great!
The file-based signal sources were modified to not throw an exception on creation
but rather when connect() is called. The unit test was checking for an exception
upon construction.
2021-02-15 15:33:16 -07:00
Marc Majoral
440e8f1b3c
log FPGA buffer overflow with severity level ERROR + add some comments.
2021-02-15 22:27:03 +01:00
Jim Melton
fb6fef74e3
fix clang-tidy CI issues
2021-02-15 14:13:54 -07:00
Jim Melton
41c7a7ad7d
fix whitespace
2021-02-15 13:46:12 -07:00
Marc Majoral
b279c3bcbd
replace exception by receiver stop command
2021-02-15 21:44:05 +01:00
Jim Melton
75483e1d2d
refactor two_bit_packed_file_signal_source
...
(signed for DCO)
2021-02-15 13:15:50 -07:00
Jim Melton
353680bc99
add 2bit_cpx file source
2021-02-15 11:47:13 -07:00
Jim Melton
4399aa5d10
next round of abstraction. Add nsr_file_signal_source
2021-02-15 11:47:13 -07:00
Jim Melton
c8ecc907c9
save before checkin
2021-02-15 11:47:13 -07:00
Jim Melton
1854cec106
first subclass of file_source_base
...
Refactored the base implementation to add appropriate virtual hooks so subclasses
can easily extend without duplicating a lot of code.
2021-02-15 11:47:13 -07:00
Jim Melton
6d4ddc16e7
eliminate compile warning
...
Note this commit introduces a more appropriate pattern for exception
handling within loops, but did not change all occurrences.
2021-02-15 11:47:13 -07:00
Jim Melton
a3c9dd4325
remove commented code
2021-02-15 11:47:13 -07:00
Jim Melton
4282386a30
simplify get_right_block()
2021-02-15 11:47:13 -07:00
Jim Melton
e0eb4bd769
initial implementation of common file source base class
...
Only the file_signal_source uses it at this time; changing multi-channel
to use it can be done with a little work
2021-02-15 11:47:13 -07:00
Jim Melton
78362e7cba
add signal_source_interface
...
also adds a base implementation that most signal sources should inherit from.
The gen_signal_source is inexplicably different (probably as a test fixture,
commonality was not valued).
Only the file_signal_source has been tested; all the sources are modified in the same
way, but we all know the only proof of correctness is testing.
The block factory was simplified a bit. Handling for legacy config files was pulled out
of the flowgraph; now when the "0" instance of a component (Foo0) is created, if there is
no config for it, then the legacy version (Foo) will be tried. This is different from
passing -1 for the item number (which is still supported). Theoretically, all existing
config files should still work.
2021-02-15 11:47:13 -07:00
Jim Melton
8407acb7a7
WIP: initial commit for collaboration
2021-02-15 11:47:13 -07:00
Javier Arribas
39031b24ac
Completing UDP GPS and Galileo ephemeris server
2021-02-15 15:58:38 +01:00
Marc Majoral
c0e4b2aee5
dump the buffer monitor results to a file
2021-02-15 11:53:16 +01:00
Javier Arribas
1721431010
Adding GPS and Galileo protobuf serdes
2021-02-15 10:56:30 +01:00
Marc Majoral
d8c41a7171
removed whitespace
2021-02-14 13:40:52 +01:00
Marc Majoral
a3d2763970
removed header file
2021-02-13 17:29:30 +01:00
Marc Majoral
03e8f97d2e
real-time FPGA receiver buffer monitoring
2021-02-13 17:10:43 +01:00
Carles Fernandez
10fc0eb62e
Fix -Wsign-compare warning
2021-02-11 13:45:55 +01:00
Carles Fernandez
16dd5ec241
Apply clang-tidy check: readability-string-compare
2021-02-11 13:37:32 +01:00
Marc Majoral
915c2859f2
Use the Galileo E1 FPGA tracking multicorrelators for the GPS L1 C/A channels if not enough GPS L1 C/A tracking multicorrelators are present in the FPGA. This selection is done automatically only if the GPS L1 C/A channels are assigned to the GPS L1 C/A FPGA tracking multicorrelators (this may not be the case when testing).
...
+ renamed the device name variables.
2021-02-10 18:43:11 +01:00
Carles Fernandez
ba89685ce6
Remove wrong error message
2021-02-09 11:34:07 +01:00
Javier Arribas
7183618079
Fix config parameter names
2021-02-05 10:19:53 +01:00
Carles Fernandez
2a82c27954
Fix linking for std::filesystem in GCC 8
2021-01-31 14:13:25 +01:00
Carles Fernandez
3c17f0a9a7
Fix defect detected by Coverity Scan (uninitialized scalar variables)
2021-01-29 14:01:21 +01:00
Carles Fernandez
c7887a03e5
Fix defects detected by Coverity Scan
2021-01-28 20:14:00 +01:00
Carles Fernandez
bd87e4e9b7
Fix warning -Wstringop-truncation raised by GCC 11
2021-01-28 14:09:33 +01:00
Carles Fernandez
c5916d05c3
Fix warning Wstringop-overread raised by GCC 11
2021-01-28 13:56:30 +01:00
Carles Fernandez
5d42f1e14c
Extend segfault fix when RINEX output is disabled for other signals than GPS L1
2021-01-27 12:47:13 +01:00
Stefan van der Linden
a07217d34f
Fixed segfault when rinex output is disabled
2021-01-27 11:12:45 +01:00
Javier Arribas
5dd34b5e1b
Merge with next
2021-01-27 10:21:16 +01:00
Carles Fernandez
d249a7efcf
Avoid segmentation faults if the SignalConditioner is not well defined in the configuration
2021-01-26 23:11:06 +01:00
Carles Fernandez
24041058a6
Improve reported output in case of configuration error
2021-01-26 16:11:41 +01:00
Carles Fernandez
720215af30
Avoid segmentation fault if the item_type for the signal source is mismatched with the input item size of the Signal Conditioner
2021-01-26 15:20:37 +01:00
Carles Fernandez
862bdeea5c
Avoid segmentation fault if the Tracking item_type is not defined for the given implementation
2021-01-26 14:01:28 +01:00
Carles Fernandez
7f23b6d88b
Use C++ cast insted of C-style cast
2021-01-26 11:58:46 +01:00
Carles Fernandez
d738d893c6
Apply clang-format
2021-01-26 00:14:50 +01:00
Carles Fernandez
950111d0fe
Avoid warning when building googletest with CMake >= 3.19
2021-01-25 22:19:18 +01:00
Carles Fernandez
ecf20d38d6
Merge branch 'clang-tidy-fgpa' into next
2021-01-25 22:17:08 +01:00
Carles Fernandez
d6d1fff743
Apply clang-tidy fixes when -DENABLE_FPGA=ON
2021-01-25 22:07:59 +01:00
Carles Fernandez
ed5975d968
Merge branch 'coverity-fix' into improve-flowgraph
2021-01-25 13:37:05 +01:00
Carles Fernandez
2f627581ef
Fix error handling issues detected by Coverity Scan 2020.09
2021-01-25 13:35:47 +01:00
Carles Fernandez
cd1c9e46ba
Add some basic configuration checks
...
Avoid some segmentation faults caused by ill-formatted configuration files
2021-01-25 00:49:36 +01:00
Carles Fernandez
a21c60ecb2
Improve error handling when the flow graph fails to start
...
Avoid segmentation faults due to some common inconsistencies in the configuration file
E.g.: non-existing names for blocks implementation, some mismatched input/output item sizes
Provide hints to the user on how to fix the configuration in case of failure when starting the flow graph
2021-01-24 01:49:16 +01:00
Javier Arribas
253b4b9a97
Adding LimeSDR signal source adapter, not usable yet
2021-01-22 17:45:26 +01:00
Javier Arribas
b1fee5c9bc
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into pps_lime
2021-01-22 17:34:46 +01:00
Carles Fernandez
268fc1215c
Refactor private implementation of flowgraph connection and disconnection
2021-01-22 17:32:37 +01:00
Carles Fernandez
3773f3c71a
Do not apply clang-tidy fixes to protobuf-generated headers
2021-01-18 16:00:33 +01:00
