Apply clang-tidy

.clang-tidy

@@ -74,7 +74,6 @@ Checks: '-*,
         modernize-use-default-member-init,
         modernize-deprecated-headers,
         modernize-loop-convert,
-        modernize-pass-by-value,
         modernize-raw-string-literal,
         modernize-redundant-void-arg,
         modernize-return-braced-init-list,

src/algorithms/PVT/libs/rtklib_solver.cc

@@ -87,7 +87,7 @@ namespace errorlib = boost::system;
 #endif
 
 
-Rtklib_Solver::Rtklib_Solver(int nchannels, std::string dump_filename, bool flag_dump_to_file, bool flag_dump_to_mat, const rtk_t &rtk)
+Rtklib_Solver::Rtklib_Solver(int nchannels, const std::string &dump_filename, bool flag_dump_to_file, bool flag_dump_to_mat, const rtk_t &rtk)
 {
     // init empty ephemeris for all the available GNSS channels
     d_nchannels = nchannels;

src/algorithms/PVT/libs/rtklib_solver.h

@@ -89,7 +89,7 @@
 class Rtklib_Solver : public Pvt_Solution
 {
 public:
-    Rtklib_Solver(int nchannels, std::string dump_filename, bool flag_dump_to_file, bool flag_dump_to_mat, const rtk_t& rtk);
+    Rtklib_Solver(int nchannels, const std::string& dump_filename, bool flag_dump_to_file, bool flag_dump_to_mat, const rtk_t& rtk);
     ~Rtklib_Solver();
 
     bool get_PVT(const std::map<int, Gnss_Synchro>& gnss_observables_map, bool flag_averaging);

src/algorithms/channel/adapters/channel.cc

@@ -40,9 +40,9 @@
 #include <utility>  // for std::move
 
 
-Channel::Channel(ConfigurationInterface* configuration, uint32_t channel, std::shared_ptr<AcquisitionInterface> acq,
+Channel::Channel(ConfigurationInterface* configuration, uint32_t channel, const std::shared_ptr<AcquisitionInterface>& acq,
-    std::shared_ptr<TrackingInterface> trk, std::shared_ptr<TelemetryDecoderInterface> nav,
+    const std::shared_ptr<TrackingInterface>& trk, const std::shared_ptr<TelemetryDecoderInterface>& nav,
-    std::string role, std::string implementation, std::shared_ptr<Concurrent_Queue<pmt::pmt_t> > queue)
+    const std::string& role, const std::string& implementation, const std::shared_ptr<Concurrent_Queue<pmt::pmt_t> >& queue)
 {
     acq_ = std::move(acq);
     trk_ = std::move(trk);

src/algorithms/channel/adapters/channel.h

@@ -65,9 +65,9 @@ class Channel : public ChannelInterface
 {
 public:
     //! Constructor
-    Channel(ConfigurationInterface* configuration, uint32_t channel, std::shared_ptr<AcquisitionInterface> acq,
+    Channel(ConfigurationInterface* configuration, uint32_t channel, const std::shared_ptr<AcquisitionInterface>& acq,
-        std::shared_ptr<TrackingInterface> trk, std::shared_ptr<TelemetryDecoderInterface> nav,
+        const std::shared_ptr<TrackingInterface>& trk, const std::shared_ptr<TelemetryDecoderInterface>& nav,
-        std::string role, std::string implementation, std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::string& role, const std::string& implementation, const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~Channel() = default;  //!< Destructor
 

src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/kernels/volk_gnsssdr/volk_gnsssdr_16ic_16i_rotator_dot_prod_16ic_xn.h

@@ -334,7 +334,6 @@ static inline void volk_gnsssdr_16ic_16i_rotator_dot_prod_16ic_xn_a_sse3(lv_16sc
 #endif /* LV_HAVE_SSE3 */
 
 
-
 #ifdef LV_HAVE_SSE3
 #include <pmmintrin.h>
 

src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/kernels/volk_gnsssdr/volk_gnsssdr_16ic_16i_rotator_dotprodxnpuppet_16ic.h

@@ -131,7 +131,6 @@ static inline void volk_gnsssdr_16ic_16i_rotator_dotprodxnpuppet_16ic_a_sse3(lv_
 #endif  // SSE3
 
 
-
 #ifdef LV_HAVE_SSE3
 static inline void volk_gnsssdr_16ic_16i_rotator_dotprodxnpuppet_16ic_u_sse3(lv_16sc_t* result, const lv_16sc_t* local_code, const lv_16sc_t* in, unsigned int num_points)
 {
@@ -194,7 +193,6 @@ static inline void volk_gnsssdr_16ic_16i_rotator_dotprodxnpuppet_16ic_a_avx2(lv_
 #endif  // AVX2
 
 
-
 #ifdef LV_HAVE_AVX2
 static inline void volk_gnsssdr_16ic_16i_rotator_dotprodxnpuppet_16ic_u_avx2(lv_16sc_t* result, const lv_16sc_t* local_code, const lv_16sc_t* in, unsigned int num_points)
 {

src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/kernels/volk_gnsssdr/volk_gnsssdr_8ic_magnitude_squared_8i.h

@@ -189,7 +189,6 @@ static inline void volk_gnsssdr_8ic_magnitude_squared_8i_a_sse3(char* magnitudeV
 #endif /* LV_HAVE_SSSE3 */
 
 
-
 #ifdef LV_HAVE_ORC
 
 extern void volk_gnsssdr_8ic_magnitude_squared_8i_a_orc_impl(char* magnitudeVector, const lv_8sc_t* complexVector, unsigned int num_points);

src/algorithms/observables/gnuradio_blocks/hybrid_observables_gs.cc

@@ -66,7 +66,7 @@ namespace errorlib = boost::system;
 #endif
 
 
-hybrid_observables_gs_sptr hybrid_observables_gs_make(unsigned int nchannels_in, unsigned int nchannels_out, bool dump, bool dump_mat, std::string dump_filename)
+hybrid_observables_gs_sptr hybrid_observables_gs_make(unsigned int nchannels_in, unsigned int nchannels_out, bool dump, bool dump_mat, const std::string &dump_filename)
 {
     return hybrid_observables_gs_sptr(new hybrid_observables_gs(nchannels_in, nchannels_out, dump, dump_mat, std::move(dump_filename)));
 }
@@ -76,7 +76,7 @@ hybrid_observables_gs::hybrid_observables_gs(uint32_t nchannels_in,
     uint32_t nchannels_out,
     bool dump,
     bool dump_mat,
-    std::string dump_filename) : gr::block("hybrid_observables_gs",
+    const std::string &dump_filename) : gr::block("hybrid_observables_gs",
                                             gr::io_signature::make(nchannels_in, nchannels_in, sizeof(Gnss_Synchro)),
                                             gr::io_signature::make(nchannels_out, nchannels_out, sizeof(Gnss_Synchro)))
 {

src/algorithms/observables/gnuradio_blocks/hybrid_observables_gs.h

@@ -57,7 +57,7 @@ hybrid_observables_gs_sptr hybrid_observables_gs_make(
     unsigned int nchannels_out,
     bool dump,
     bool dump_mat,
-    std::string dump_filename);
+    const std::string& dump_filename);
 
 /*!
  * \brief This class implements a block that computes observables
@@ -76,14 +76,14 @@ private:
         uint32_t nchannels_out,
         bool dump,
         bool dump_mat,
-        std::string dump_filename);
+        const std::string& dump_filename);
 
     hybrid_observables_gs(
         uint32_t nchannels_in,
         uint32_t nchannels_out,
         bool dump,
         bool dump_mat,
-        std::string dump_filename);
+        const std::string& dump_filename);
 
     bool T_rx_TOW_set;  // rx time follow GPST
     bool d_dump;

src/algorithms/signal_source/adapters/file_signal_source.cc

@@ -44,7 +44,7 @@
 
 FileSignalSource::FileSignalSource(ConfigurationInterface* configuration,
     const std::string& role, unsigned int in_streams, unsigned int out_streams,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "./example_capture.dat";
     std::string default_item_type = "short";

src/algorithms/signal_source/adapters/file_signal_source.h

@@ -57,7 +57,7 @@ class FileSignalSource : public GNSSBlockInterface
 public:
     FileSignalSource(ConfigurationInterface* configuration, const std::string& role,
         unsigned int in_streams, unsigned int out_streams,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~FileSignalSource() = default;
 

src/algorithms/signal_source/adapters/multichannel_file_signal_source.cc

@@ -43,7 +43,7 @@
 
 MultichannelFileSignalSource::MultichannelFileSignalSource(ConfigurationInterface* configuration,
     const std::string& role, unsigned int in_streams, unsigned int out_streams,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "./example_capture.dat";
     std::string default_item_type = "short";

src/algorithms/signal_source/adapters/multichannel_file_signal_source.h

@@ -58,7 +58,7 @@ class MultichannelFileSignalSource : public GNSSBlockInterface
 public:
     MultichannelFileSignalSource(ConfigurationInterface* configuration, const std::string& role,
         unsigned int in_streams, unsigned int out_streams,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~MultichannelFileSignalSource() = default;
 

src/algorithms/signal_source/adapters/nsr_file_signal_source.cc

@@ -44,7 +44,7 @@
 
 NsrFileSignalSource::NsrFileSignalSource(ConfigurationInterface* configuration,
     const std::string& role, unsigned int in_streams, unsigned int out_streams,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_item_type = "byte";

src/algorithms/signal_source/adapters/nsr_file_signal_source.h

@@ -57,7 +57,7 @@ class NsrFileSignalSource : public GNSSBlockInterface
 public:
     NsrFileSignalSource(ConfigurationInterface* configuration, const std::string& role,
         unsigned int in_streams, unsigned int out_streams,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~NsrFileSignalSource() = default;
     inline std::string role() override

src/algorithms/signal_source/adapters/spir_file_signal_source.cc

@@ -43,7 +43,7 @@
 
 SpirFileSignalSource::SpirFileSignalSource(ConfigurationInterface* configuration,
     const std::string& role, unsigned int in_streams, unsigned int out_streams,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_item_type = "int";

src/algorithms/signal_source/adapters/spir_file_signal_source.h

@@ -55,7 +55,7 @@ class SpirFileSignalSource : public GNSSBlockInterface
 public:
     SpirFileSignalSource(ConfigurationInterface* configuration, const std::string& role,
         unsigned int in_streams, unsigned int out_streams,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~SpirFileSignalSource() = default;
     inline std::string role() override

src/algorithms/signal_source/adapters/two_bit_cpx_file_signal_source.cc

@@ -45,7 +45,7 @@ TwoBitCpxFileSignalSource::TwoBitCpxFileSignalSource(ConfigurationInterface* con
     const std::string& role,
     unsigned int in_streams,
     unsigned int out_streams,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue) : role_(role),
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue) : role_(role),
                                                                   in_streams_(in_streams),
                                                                   out_streams_(out_streams),
                                                                   queue_(std::move(queue))

src/algorithms/signal_source/adapters/two_bit_cpx_file_signal_source.h

@@ -61,7 +61,7 @@ public:
         const std::string& role,
         unsigned int in_streams,
         unsigned int out_streams,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~TwoBitCpxFileSignalSource() = default;
     inline std::string role() override

src/algorithms/signal_source/adapters/two_bit_packed_file_signal_source.cc

@@ -47,7 +47,7 @@ TwoBitPackedFileSignalSource::TwoBitPackedFileSignalSource(ConfigurationInterfac
     const std::string& role,
     unsigned int in_streams,
     unsigned int out_streams,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue) : role_(role),
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue) : role_(role),
                                                                   in_streams_(in_streams),
                                                                   out_streams_(out_streams),
                                                                   queue_(std::move(queue))

src/algorithms/signal_source/adapters/two_bit_packed_file_signal_source.h

@@ -60,7 +60,7 @@ class TwoBitPackedFileSignalSource : public GNSSBlockInterface
 public:
     TwoBitPackedFileSignalSource(ConfigurationInterface* configuration, const std::string& role,
         unsigned int in_streams, unsigned int out_streams,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     ~TwoBitPackedFileSignalSource() = default;
     inline std::string role() override

src/algorithms/tracking/gnuradio_blocks/dll_pll_veml_tracking.cc

@@ -1000,7 +1000,7 @@ void dll_pll_veml_tracking::run_dll_pll()
                     if (d_dll_filt_history.full())
                         {
                             float avg_code_error_chips_s = std::accumulate(d_dll_filt_history.begin(), d_dll_filt_history.end(), 0.0) / static_cast<float>(d_dll_filt_history.capacity());
-                            if (fabs(avg_code_error_chips_s) > 1.0)
+                            if (std::fabs(avg_code_error_chips_s) > 1.0)
                                 {
                                     float carrier_doppler_error_hz = static_cast<float>(d_signal_carrier_freq) * avg_code_error_chips_s / static_cast<float>(d_code_chip_rate);
                                     LOG(INFO) << "Detected and corrected carrier doppler error: " << carrier_doppler_error_hz << " [Hz] on sat " << Gnss_Satellite(systemName, d_acquisition_gnss_synchro->PRN);

src/algorithms/tracking/gnuradio_blocks/glonass_l1_ca_dll_pll_c_aid_tracking_cc.cc

@@ -65,7 +65,7 @@ glonass_l1_ca_dll_pll_c_aid_make_tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -88,7 +88,7 @@ void glonass_l1_ca_dll_pll_c_aid_tracking_cc::forecast(int noutput_items,
 }
 
 
-void glonass_l1_ca_dll_pll_c_aid_tracking_cc::msg_handler_preamble_index(pmt::pmt_t msg)
+void glonass_l1_ca_dll_pll_c_aid_tracking_cc::msg_handler_preamble_index(const pmt::pmt_t &msg)
 {
     // pmt::print(msg);
     DLOG(INFO) << "Extended correlation enabled for Tracking CH " << d_channel << ": Satellite " << Gnss_Satellite(systemName[sys], d_acquisition_gnss_synchro->PRN);
@@ -105,7 +105,7 @@ glonass_l1_ca_dll_pll_c_aid_tracking_cc::glonass_l1_ca_dll_pll_c_aid_tracking_cc
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,

src/algorithms/tracking/gnuradio_blocks/glonass_l1_ca_dll_pll_c_aid_tracking_cc.h

@@ -60,7 +60,7 @@ glonass_l1_ca_dll_pll_c_aid_tracking_cc_sptr
 glonass_l1_ca_dll_pll_c_aid_make_tracking_cc(
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -91,7 +91,7 @@ private:
     glonass_l1_ca_dll_pll_c_aid_make_tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -102,7 +102,7 @@ private:
     glonass_l1_ca_dll_pll_c_aid_tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -170,7 +170,7 @@ private:
     int32_t d_extend_correlation_ms;
     bool d_enable_extended_integration;
     bool d_preamble_synchronized;
-    void msg_handler_preamble_index(pmt::pmt_t msg);
+    void msg_handler_preamble_index(const pmt::pmt_t& msg);
 
     // Integration period in samples
     int32_t d_correlation_length_samples;

src/algorithms/tracking/gnuradio_blocks/glonass_l1_ca_dll_pll_c_aid_tracking_sc.cc

@@ -63,7 +63,7 @@ glonass_l1_ca_dll_pll_c_aid_make_tracking_sc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -86,7 +86,7 @@ void glonass_l1_ca_dll_pll_c_aid_tracking_sc::forecast(int noutput_items,
 }
 
 
-void glonass_l1_ca_dll_pll_c_aid_tracking_sc::msg_handler_preamble_index(pmt::pmt_t msg)
+void glonass_l1_ca_dll_pll_c_aid_tracking_sc::msg_handler_preamble_index(const pmt::pmt_t &msg)
 {
     // pmt::print(msg);
     DLOG(INFO) << "Extended correlation enabled for Tracking CH " << d_channel << ": Satellite " << Gnss_Satellite(systemName[sys], d_acquisition_gnss_synchro->PRN);
@@ -103,7 +103,7 @@ glonass_l1_ca_dll_pll_c_aid_tracking_sc::glonass_l1_ca_dll_pll_c_aid_tracking_sc
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,

src/algorithms/tracking/gnuradio_blocks/glonass_l1_ca_dll_pll_c_aid_tracking_sc.h

@@ -60,7 +60,7 @@ glonass_l1_ca_dll_pll_c_aid_tracking_sc_sptr
 glonass_l1_ca_dll_pll_c_aid_make_tracking_sc(
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -91,7 +91,7 @@ private:
     glonass_l1_ca_dll_pll_c_aid_make_tracking_sc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -102,7 +102,7 @@ private:
     glonass_l1_ca_dll_pll_c_aid_tracking_sc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -167,7 +167,7 @@ private:
     bool d_preamble_synchronized;
     double d_code_error_filt_chips_s;
     double d_code_error_filt_chips_Ti;
-    void msg_handler_preamble_index(pmt::pmt_t msg);
+    void msg_handler_preamble_index(const pmt::pmt_t& msg);
 
     // symbol history to detect bit transition
     std::deque<lv_16sc_t> d_E_history;

src/algorithms/tracking/gnuradio_blocks/glonass_l1_ca_dll_pll_tracking_cc.cc

@@ -62,7 +62,7 @@ glonass_l1_ca_dll_pll_make_tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float early_late_space_chips)
@@ -86,7 +86,7 @@ Glonass_L1_Ca_Dll_Pll_Tracking_cc::Glonass_L1_Ca_Dll_Pll_Tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float early_late_space_chips) : gr::block("Glonass_L1_Ca_Dll_Pll_Tracking_cc", gr::io_signature::make(1, 1, sizeof(gr_complex)),

src/algorithms/tracking/gnuradio_blocks/glonass_l1_ca_dll_pll_tracking_cc.h

@@ -57,7 +57,7 @@ glonass_l1_ca_dll_pll_tracking_cc_sptr
 glonass_l1_ca_dll_pll_make_tracking_cc(
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float early_late_space_chips);
@@ -85,7 +85,7 @@ private:
     glonass_l1_ca_dll_pll_make_tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float early_late_space_chips);
@@ -93,7 +93,7 @@ private:
     Glonass_L1_Ca_Dll_Pll_Tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float early_late_space_chips);

src/algorithms/tracking/gnuradio_blocks/glonass_l2_ca_dll_pll_c_aid_tracking_cc.cc

@@ -62,7 +62,7 @@ glonass_l2_ca_dll_pll_c_aid_make_tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -85,7 +85,7 @@ void glonass_l2_ca_dll_pll_c_aid_tracking_cc::forecast(int noutput_items,
 }
 
 
-void glonass_l2_ca_dll_pll_c_aid_tracking_cc::msg_handler_preamble_index(pmt::pmt_t msg)
+void glonass_l2_ca_dll_pll_c_aid_tracking_cc::msg_handler_preamble_index(const pmt::pmt_t &msg)
 {
     // pmt::print(msg);
     DLOG(INFO) << "Extended correlation enabled for Tracking CH " << d_channel << ": Satellite " << Gnss_Satellite(systemName[sys], d_acquisition_gnss_synchro->PRN);
@@ -102,7 +102,7 @@ glonass_l2_ca_dll_pll_c_aid_tracking_cc::glonass_l2_ca_dll_pll_c_aid_tracking_cc
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,

src/algorithms/tracking/gnuradio_blocks/glonass_l2_ca_dll_pll_c_aid_tracking_cc.h

@@ -58,7 +58,7 @@ glonass_l2_ca_dll_pll_c_aid_tracking_cc_sptr
 glonass_l2_ca_dll_pll_c_aid_make_tracking_cc(
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -89,7 +89,7 @@ private:
     glonass_l2_ca_dll_pll_c_aid_make_tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -100,7 +100,7 @@ private:
     glonass_l2_ca_dll_pll_c_aid_tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -168,7 +168,7 @@ private:
     int32_t d_extend_correlation_ms;
     bool d_enable_extended_integration;
     bool d_preamble_synchronized;
-    void msg_handler_preamble_index(pmt::pmt_t msg);
+    void msg_handler_preamble_index(const pmt::pmt_t& msg);
 
     // Integration period in samples
     int32_t d_correlation_length_samples;

src/algorithms/tracking/gnuradio_blocks/glonass_l2_ca_dll_pll_c_aid_tracking_sc.cc

@@ -61,7 +61,7 @@ glonass_l2_ca_dll_pll_c_aid_make_tracking_sc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -84,7 +84,7 @@ void glonass_l2_ca_dll_pll_c_aid_tracking_sc::forecast(int noutput_items,
 }
 
 
-void glonass_l2_ca_dll_pll_c_aid_tracking_sc::msg_handler_preamble_index(pmt::pmt_t msg)
+void glonass_l2_ca_dll_pll_c_aid_tracking_sc::msg_handler_preamble_index(const pmt::pmt_t &msg)
 {
     // pmt::print(msg);
     DLOG(INFO) << "Extended correlation enabled for Tracking CH " << d_channel << ": Satellite " << Gnss_Satellite(systemName[sys], d_acquisition_gnss_synchro->PRN);
@@ -101,7 +101,7 @@ glonass_l2_ca_dll_pll_c_aid_tracking_sc::glonass_l2_ca_dll_pll_c_aid_tracking_sc
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,

src/algorithms/tracking/gnuradio_blocks/glonass_l2_ca_dll_pll_c_aid_tracking_sc.h

@@ -58,7 +58,7 @@ glonass_l2_ca_dll_pll_c_aid_tracking_sc_sptr
 glonass_l2_ca_dll_pll_c_aid_make_tracking_sc(
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float pll_bw_narrow_hz,
@@ -89,7 +89,7 @@ private:
     glonass_l2_ca_dll_pll_c_aid_make_tracking_sc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -100,7 +100,7 @@ private:
     glonass_l2_ca_dll_pll_c_aid_tracking_sc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float pll_bw_narrow_hz,
@@ -165,7 +165,7 @@ private:
     bool d_preamble_synchronized;
     double d_code_error_filt_chips_s;
     double d_code_error_filt_chips_Ti;
-    void msg_handler_preamble_index(pmt::pmt_t msg);
+    void msg_handler_preamble_index(const pmt::pmt_t& msg);
 
     // symbol history to detect bit transition
     std::deque<lv_16sc_t> d_E_history;

src/algorithms/tracking/gnuradio_blocks/glonass_l2_ca_dll_pll_tracking_cc.cc

@@ -62,7 +62,7 @@ glonass_l2_ca_dll_pll_make_tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float early_late_space_chips)
@@ -86,7 +86,7 @@ Glonass_L2_Ca_Dll_Pll_Tracking_cc::Glonass_L2_Ca_Dll_Pll_Tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float early_late_space_chips) : gr::block("Glonass_L2_Ca_Dll_Pll_Tracking_cc", gr::io_signature::make(1, 1, sizeof(gr_complex)),

src/algorithms/tracking/gnuradio_blocks/glonass_l2_ca_dll_pll_tracking_cc.h

@@ -55,7 +55,7 @@ glonass_l2_ca_dll_pll_tracking_cc_sptr
 glonass_l2_ca_dll_pll_make_tracking_cc(
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float pll_bw_hz,
     float dll_bw_hz,
     float early_late_space_chips);
@@ -83,7 +83,7 @@ private:
     glonass_l2_ca_dll_pll_make_tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float early_late_space_chips);
@@ -91,7 +91,7 @@ private:
     Glonass_L2_Ca_Dll_Pll_Tracking_cc(
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float pll_bw_hz,
         float dll_bw_hz,
         float early_late_space_chips);

src/algorithms/tracking/gnuradio_blocks/gps_l1_ca_kf_tracking_cc.cc

@@ -64,7 +64,7 @@ gps_l1_ca_kf_make_tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float dll_bw_hz,
     float early_late_space_chips,
     bool bce_run,
@@ -95,7 +95,7 @@ Gps_L1_Ca_Kf_Tracking_cc::Gps_L1_Ca_Kf_Tracking_cc(
     int64_t fs_in,
     uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string &dump_filename,
     float dll_bw_hz,
     float early_late_space_chips,
     bool bce_run,

src/algorithms/tracking/gnuradio_blocks/gps_l1_ca_kf_tracking_cc.h

@@ -65,7 +65,7 @@ gps_l1_ca_kf_make_tracking_cc(uint32_t order,
     int64_t if_freq,
     int64_t fs_in, uint32_t vector_length,
     bool dump,
-    std::string dump_filename,
+    const std::string& dump_filename,
     float dll_bw_hz,
     float early_late_space_chips,
     bool bce_run,
@@ -98,7 +98,7 @@ private:
         int64_t if_freq,
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float dll_bw_hz,
         float early_late_space_chips,
         bool bce_run,
@@ -111,7 +111,7 @@ private:
         int64_t if_freq,
         int64_t fs_in, uint32_t vector_length,
         bool dump,
-        std::string dump_filename,
+        const std::string& dump_filename,
         float dll_bw_hz,
         float early_late_space_chips,
         bool bce_run,

src/algorithms/tracking/libs/tracking_discriminators.cc

@@ -53,6 +53,8 @@ double phase_unwrap(double phase_rad)
             return phase_rad;
         }
 }
+
+
 /*
  * FLL four quadrant arctan discriminator:
  * \f{equation}
@@ -64,13 +66,14 @@ double phase_unwrap(double phase_rad)
  */
 double fll_four_quadrant_atan(gr_complex prompt_s1, gr_complex prompt_s2, double t1, double t2)
 {
-    double cross;
+    float cross;
-    double dot;
+    float dot;
     dot = prompt_s1.real() * prompt_s2.real() + prompt_s1.imag() * prompt_s2.imag();
     cross = prompt_s1.real() * prompt_s2.imag() - prompt_s2.real() * prompt_s1.imag();
-    return atan2(cross, dot) / (t2 - t1);
+    return std::atan2(cross, dot) / (t2 - t1);
 }
 
+
 /*
  * FLL differential arctan discriminator:
  * \f{equation}
@@ -80,7 +83,7 @@ double fll_four_quadrant_atan(gr_complex prompt_s1, gr_complex prompt_s2, double
  */
 double fll_diff_atan(gr_complex prompt_s1, gr_complex prompt_s2, double t1, double t2)
 {
-    double diff_atan = atan(prompt_s2.imag() / prompt_s2.real()) - atan(prompt_s1.imag() / prompt_s1.real());
+    double diff_atan = std::atan(prompt_s2.imag() / prompt_s2.real()) - std::atan(prompt_s1.imag() / prompt_s1.real());
     if (std::isnan(diff_atan))
         {
             diff_atan = 0;
@@ -88,6 +91,7 @@ double fll_diff_atan(gr_complex prompt_s1, gr_complex prompt_s2, double t1, doub
     return phase_unwrap(diff_atan) / (t2 - t1);
 }
 
+
 /*
  * PLL four quadrant arctan discriminator:
  * \f{equation}

src/core/receiver/control_thread.cc

@@ -105,7 +105,7 @@ ControlThread::ControlThread()
 }
 
 
-ControlThread::ControlThread(std::shared_ptr<ConfigurationInterface> configuration)
+ControlThread::ControlThread(const std::shared_ptr<ConfigurationInterface> &configuration)
 {
     configuration_ = std::move(configuration);
     delete_configuration_ = false;

src/core/receiver/control_thread.h

@@ -77,7 +77,7 @@ public:
      *
      * \param[in] configuration Pointer to a ConfigurationInterface
      */
-    explicit ControlThread(std::shared_ptr<ConfigurationInterface> configuration);
+    explicit ControlThread(const std::shared_ptr<ConfigurationInterface> &configuration);
 
     /*!
      * \brief Destructor

src/core/receiver/gnss_block_factory.cc

@@ -315,7 +315,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetPVT(const std::shared_p
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1C(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     // "appendix" is added to the "role" with the aim of Acquisition, Tracking and Telemetry Decoder adapters
     // can find their specific configurations when they read the config
@@ -373,7 +373,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1C(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "1C", std::move(queue)));
+        "Channel", "1C", queue));
 
     return channel_;
 }
@@ -383,7 +383,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1C(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_2S(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     LOG(INFO) << "Instantiating Channel " << channel << " with Acquisition Implementation: "
               << acq << ", Tracking Implementation: " << trk << ", Telemetry Decoder implementation: " << tlm;
@@ -437,7 +437,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_2S(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "2S", std::move(queue)));
+        "Channel", "2S", queue));
 
     return channel_;
 }
@@ -447,7 +447,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_2S(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1B(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -504,7 +504,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1B(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "1B", std::move(queue)));
+        "Channel", "1B", queue));
 
     return channel_;
 }
@@ -514,7 +514,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1B(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_5X(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -571,7 +571,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_5X(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "5X", std::move(queue)));
+        "Channel", "5X", queue));
 
     return channel_;
 }
@@ -581,7 +581,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_5X(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1G(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -639,7 +639,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1G(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "1G", std::move(queue)));
+        "Channel", "1G", queue));
 
     return channel_;
 }
@@ -649,7 +649,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_1G(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_2G(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -707,7 +707,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_2G(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "2G", std::move(queue)));
+        "Channel", "2G", queue));
 
     return channel_;
 }
@@ -717,7 +717,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_2G(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_L5(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -774,7 +774,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_L5(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "L5", std::move(queue)));
+        "Channel", "L5", queue));
 
     return channel_;
 }
@@ -784,7 +784,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_L5(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_B1(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -841,7 +841,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_B1(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "B1", std::move(queue)));
+        "Channel", "B1", queue));
 
     return channel_;
 }
@@ -851,7 +851,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_B1(
 std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_B3(
     const std::shared_ptr<ConfigurationInterface>& configuration,
     const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-    std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue)
+    const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue)
 {
     std::stringstream stream;
     stream << channel;
@@ -908,7 +908,7 @@ std::unique_ptr<GNSSBlockInterface> GNSSBlockFactory::GetChannel_B3(
         std::move(acq_),
         std::move(trk_),
         std::move(tlm_),
-        "Channel", "B3", std::move(queue)));
+        "Channel", "B3", queue));
 
     return channel_;
 }

src/core/receiver/gnss_block_factory.h

@@ -82,39 +82,39 @@ public:
 private:
     std::unique_ptr<GNSSBlockInterface> GetChannel_1C(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_2S(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_1B(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_5X(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_L5(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_1G(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_2G(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_B1(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<GNSSBlockInterface> GetChannel_B3(const std::shared_ptr<ConfigurationInterface>& configuration,
         const std::string& acq, const std::string& trk, const std::string& tlm, int channel,
-        std::shared_ptr<Concurrent_Queue<pmt::pmt_t>> queue);
+        const std::shared_ptr<Concurrent_Queue<pmt::pmt_t>>& queue);
 
     std::unique_ptr<AcquisitionInterface> GetAcqBlock(
         const std::shared_ptr<ConfigurationInterface>& configuration,

src/core/receiver/gnss_flowgraph.cc

@@ -1440,7 +1440,7 @@ void GNSSFlowgraph::priorize_satellites(const std::vector<std::pair<int, Gnss_Sa
 }
 
 
-void GNSSFlowgraph::set_configuration(std::shared_ptr<ConfigurationInterface> configuration)
+void GNSSFlowgraph::set_configuration(const std::shared_ptr<ConfigurationInterface>& configuration)
 {
     if (running_)
         {

src/core/receiver/gnss_flowgraph.h

@@ -128,7 +128,7 @@ public:
     /*!
      * \brief Set flow graph configuratiob
      */
-    void set_configuration(std::shared_ptr<ConfigurationInterface> configuration);
+    void set_configuration(const std::shared_ptr<ConfigurationInterface>& configuration);
 
     bool connected() const
     {

src/tests/unit-tests/signal-processing-blocks/acquisition/gps_l1_ca_pcps_acquisition_test.cc

@@ -83,7 +83,7 @@ class GpsL1CaPcpsAcquisitionTest_msg_rx : public gr::block
 {
 private:
     friend GpsL1CaPcpsAcquisitionTest_msg_rx_sptr GpsL1CaPcpsAcquisitionTest_msg_rx_make();
-    void msg_handler_events(pmt::pmt_t msg);
+    void msg_handler_events(const pmt::pmt_t &msg);
     GpsL1CaPcpsAcquisitionTest_msg_rx();
 
 public:
@@ -98,7 +98,7 @@ GpsL1CaPcpsAcquisitionTest_msg_rx_sptr GpsL1CaPcpsAcquisitionTest_msg_rx_make()
 }
 
 
-void GpsL1CaPcpsAcquisitionTest_msg_rx::msg_handler_events(pmt::pmt_t msg)
+void GpsL1CaPcpsAcquisitionTest_msg_rx::msg_handler_events(const pmt::pmt_t &msg)
 {
     try
         {

src/tests/unit-tests/signal-processing-blocks/libs/acquisition_msg_rx.cc

@@ -44,7 +44,7 @@ Acquisition_msg_rx_sptr Acquisition_msg_rx_make()
 }
 
 
-void Acquisition_msg_rx::msg_handler_events(pmt::pmt_t msg)
+void Acquisition_msg_rx::msg_handler_events(const pmt::pmt_t& msg)
 {
     try
         {

src/tests/unit-tests/signal-processing-blocks/libs/acquisition_msg_rx.h

@@ -49,7 +49,7 @@ class Acquisition_msg_rx : public gr::block
 {
 private:
     friend Acquisition_msg_rx_sptr Acquisition_msg_rx_make();
-    void msg_handler_events(pmt::pmt_t msg);
+    void msg_handler_events(const pmt::pmt_t& msg);
     Acquisition_msg_rx();
 
 public:

src/utils/front-end-cal/main.cc

@@ -116,7 +116,7 @@ class FrontEndCal_msg_rx : public gr::block
 {
 private:
     friend FrontEndCal_msg_rx_sptr FrontEndCal_msg_rx_make();
-    void msg_handler_events(pmt::pmt_t msg);
+    void msg_handler_events(const pmt::pmt_t& msg);
     FrontEndCal_msg_rx();
 
 public:
@@ -130,7 +130,7 @@ FrontEndCal_msg_rx_sptr FrontEndCal_msg_rx_make()
 }
 
 
-void FrontEndCal_msg_rx::msg_handler_events(pmt::pmt_t msg)
+void FrontEndCal_msg_rx::msg_handler_events(const pmt::pmt_t& msg)
 {
     try
         {