1
0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2025-07-04 19:12:57 +00:00

877 Commits

Author SHA1 Message Date
Carles Fernandez
32e7dc03ae
Fix typos detected by codespell 2025-02-10 13:20:14 +01:00
Carles Fernandez
b9c834acba
Revert unnecessary moves 2025-01-24 00:41:06 +01:00
Carles Fernandez
bd0d19a24b
Fix low-impact performance inefficiency defects detected by Coverity Scan 2024.6
Reduce defect noise so other defects are easier spotted
2025-01-23 22:32:35 +01:00
joebre
b82332cd33 clang-tiday fix
Signed-off-by: joebre <joel.brenner@saphyrion.ch>
2025-01-22 15:25:17 +01:00
joebre
4b2e5661cf clang-formt
Signed-off-by: joebre <joel.brenner@saphyrion.ch>
2025-01-22 15:25:17 +01:00
joebre
acae99cb5c gps almanac decoding
Signed-off-by: joebre <joel.brenner@saphyrion.ch>
2025-01-22 15:25:17 +01:00
Carles Fernandez
6757adf8d5
Safer copy constructor and copy assignment operator for Gnss_Satellite
Fix clang-tidy bugprone-exception-escape warnings
2024-12-29 22:38:55 +01:00
Carles Fernandez
700d4403d5
Transition to clang-format 19 2024-12-26 11:18:41 +01:00
Carles Fernandez
4c07b71c37
Storage-class specifier should be at the beginning of the declaration 2024-10-07 17:40:16 +02:00
Carles Fernandez
d74bceee6e
Make clang-tidy job happy 2024-09-25 21:17:45 +02:00
Carles Fernandez
f91f37261d
Fix merging conflict 2024-09-25 20:49:44 +02:00
Carles Fernandez
12a095920f
Fix merge conflict 2024-09-25 20:34:26 +02:00
Carles Fernandez
98705b3ff7
Merge branch 'next' of github.com:carlesfernandez/gnss-sdr into ism 2024-09-25 20:12:45 +02:00
Carles Fernandez
d0a6264754
Make clang-tidy CI job happy 2024-09-25 20:08:02 +02:00
Carles Fernandez
311b0ea6f2
Improve ISM handling and add PRN applicability check 2024-09-21 13:12:48 +02:00
Carles Fernandez
abc07e414b
Merging next, solving conflicts (#28)
* Decouple the FPGA DMA signal source from the AD9361 FPGA signal source.

* Add the MAX2771_EVKIT FPGA signal source and the ENABLE_FPGA_MAX2771_EVKIT flag to enable it.

* Adjust cross-compilation flags to properly support FPGA signal sources

* fix signal source names for consistency

* Detect if the spidev driver is installed when the ENABLE_MAX2771 flag is set. Detect if the DMA proxy driver is installed when the ENABLE_DMA_PROXY flag is set. Check if ENABLE_FPGA is set when either ENABLE_MAX2771 or ENABLE_DMA_PROXY is set.

* fix FPGA signal source names for consistency

* Fix FPGA-related CMakefile flags

* make cpplint happy

* make cpplint happy

* make cmakelint happy

* make clang-format happy

* Replaced the AD9361 FPGA signal source with the ADRV9361_Z7035 FPGA and the FMCOMMS5 FPGA signal sources.

* Bump local version of GoogleTest to 1.15.2 and Protocol Buffers to 27.3

* Avoid code duplication in CMake modules

* Update clang-tidy job

* Clang Tidy fixes

* Improve efficiency of Concurrent_Map and Concurrent_Queue classes

* Fix segmentation fault if the SignalSource implementation is not available

* Moved decimation factor count variable to the class

* Avoid possible runtime error when PVT.enable_rx_clock_correction=true

* Fix formatting

* Fix clang-tidy job

* Capitalize FPGA in class implementation names

* Capitalize acronyms in FPGA-related class names

* Instantiate sources only once

* Update changelog

* Bump version of google benchmark to 1.9.0

* Fix CMakeLists header file list in signal source libs

Header file paths were being appended to the source files list.

This is not that important since, in general, you don't need to add the header files to the cmake target.

* Added ION GNSS SDR Metadata Standard signal source

* Only specify outputs for the requested streams

* Fixed block iteration withing a file

The `File` object only holds a shallow reference to its `Lane` (without the list of blocks). So we must retrieve the full reference manually.

* Treat data file paths as relative to the metadata file

The data file paths are actually not native paths but URLs, this covers most cases but not all of them.

* Fixed decoding errors and refactored each class into its own file

* Fixed sample count error & refactored

* Bufferef IO & propagate configuration inside ION source

* Reset sample value before writing new one

Sample values are ORed into the output buffer because they may need a few read/write operations depending on alignment.
So, if we don't set the value to 0 before doing this, all samples quickly become 0xFF after a few cycles of the output buffer.

* Simpler handling of simpler bit formats

If a sample is the same size as a word, it is much easier to read.

* Less callback shenanigans

* Fix wrong buffer size

* Fixed conditional compilation issues

And added a comment

* Linting fixes

* Fixed arithmetic operations on pointers

* Fix formatting

* Use lock_guard instead of unique_lock

* Create a CMake target for the ION dependency for consistency

* Improve formatting, add missing include

* Fixes for C++ standards older than 20. Avoid C++20-specific lambda templates

* Update changelog

* Add Victor to the list of authors

* Fix CMake error

* Fix building error

* Fix building

* Add -DENABLE_ION=ON to CI jobs

* Fix CMake lists

* Catch all exceptions

* Fix building for -DENABLE_PLUTOSDR=ON

* Removed unused member fields and function parameters

* Use std::ifstream instead of FILE for reading sample data

* Fixed includes and code style

* Simplified disconnect() function

We can disconnect the sources directly instead of disconnecting each of their outputs.

* Implemented range check in `IONGSMSSignalSource::get_right_block(int)`

* Moved ION GSMS file source to `gnuradio_blocks/` directory

Also fixed some header guards.

* Fixed ION GNSS Metadata Standard dependency version

* Simplified by removing a very shallow class

`ion_gnss_metadata_handler` was only reading the metadata file, which can easily be done in `ion_gsms_signal_source`.

* Added valves to properly handle end of samples

* Cleaner exit if the data file is not found

* Fix uninitialized warning

* Remove unused configuration parameter. Uniformize guard names

* Fix for CMake < 3.14

* fix configuration options for the FPGA-based AD9361-based boards

* Put the global function into an anonymous namespace

Use emplace_back instead of push_back

* Make private member metadata_ a std::shared_pointer

* Simplify code

* Remove ION source from CI

* Apply clang-tidy fixes

* Initialize the receiver local oscillator frequency to GPS_L5_FREQ_HZ by default in the ADRV9361Z7035 FPGA signal source and remove unnecessary include files.

* Sort out building flags and improve their reporting

* Allow building Ad936x_Custom_Signal_Source when gnuradio-iio is not available

* Bump local version of Protocol Buffers to v28.0

* Update AArch64 features to Linux 6.10.6

* Update AArch64 features to Linux 6.10.6

* Fix: Windows does not define __ARM_NEON

* Improve detection of the dma_proxy module and the spidev driver

* Add missing include (fixes building with modern GCC)

* Adapted udp_port to multiple ports

* Fixed typo

* Fixed clang format

* Update changelog

* Add Xavier Guerrero to the authors list

* Update changelog

* Bump local version of Protocol Buffers to 28.1

* Add install and uninstall targets to nav_msg_listener

* Add Cesare to the authors list

* Add OSNMA to changelog

* Leave OSNMA files in the same folder for consistency

* Fix conflict

---------

Co-authored-by: Marc Majoral <majoralmarc@gmail.com>
Co-authored-by: cesaaargm <cesare.martinez@proton.me>
Co-authored-by: Xavier Guerrero-Pau <xguerrero@cttc.es>
Co-authored-by: Victor Castillo <victorcastilloaguero@gmail.com>
2024-09-21 11:40:17 +02:00
Carles Fernandez
bc800dea28
Improve CRC computation of ISM 2024-09-21 10:22:32 +02:00
Carles Fernandez
e23d171b22
Fix formatting 2024-09-21 08:42:59 +02:00
Carles Fernandez
f6f58fd45e
Log ISM data 2024-09-21 07:39:24 +02:00
Carles Fernandez
de6f991811
Improve CRC computation of ISM 2024-09-20 18:54:18 +02:00
Carles Fernandez
db78d104bf
Merge branch 'ism' of github.com:carlesfernandez/gnss-sdr into ism 2024-09-20 17:06:22 +02:00
Carles Fernandez
660770f9fb
Merge branch 'next' of github.com:carlesfernandez/gnss-sdr into ism 2024-09-20 17:05:03 +02:00
Carles Fernandez
583ae6df0d
Fix CRC computation in ISM 2024-09-20 14:50:31 +02:00
Carles Fernandez
557a7f7265
Add work on ISM 2024-08-28 11:13:54 +02:00
cesaaargm
2e867f2dac [TAS-240][FEAT] Implement TESLA Chain Renewal and Revocation I
* Implemented a new chain renewal mechanism for OSNMA data structure updates and key management.
* Added related flags and data fields.
* tested successfully with test vectors.
2024-08-14 13:14:23 +02:00
cesaaargm
794bd61419 [TAS-249][Bug][Tag] new NavDataManager causes less tags to be verified
[TAS-234][Feature] Dummy tags verification

* Fixed the navData retrieval which caused many tags to be skipped
* Dummy tags verification added.
* Replaced direct field access with getters/setters for OSNMA navigation data.
2024-08-11 16:41:54 +02:00
Carles Fernandez
5a634f7332
More fixes (#25)
* Clang Tidy fixes

* Fix some potential defects and be more consistent in class name. Improve const correctness

* Fix formatting

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-11 12:44:18 +02:00
Carles Fernandez
79da7787ff
Move files (#24)
* Bump local version of GoogleTest to 1.15.2 and Protocol Buffers to 27.3

* Avoid code duplication in CMake modules

* Update clang-tidy job

* Clang Tidy fixes

* Improve efficiency of Concurrent_Map and Concurrent_Queue classes

* Fix segmentation fault if the SignalSource implementation is not available

* Moved decimation factor count variable to the class

* Avoid possible runtime error when PVT.enable_rx_clock_correction=true

* Fix formatting

* Fix clang-tidy job

* Move receiver-related classes to src/core/libs

* Uniformize cmake module names

* Fix formatting

* Make clang-tidy happy

* Fix crypto benchmarks

* Fixes for old systems

* Instantiate sources only once

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
Co-authored-by: Xavier Guerrero-Pau <xguerrero@cttc.es>
2024-08-10 11:31:15 +02:00
Carles Fernandez
98f1cdfb6b
More minor fixes (#23)
* Clang Tidy fixes

* Fix defects detected by Coverity Scan

* Fix for OpenSSL 1.0

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-08 09:33:48 +02:00
Carles Fernandez
5a6d19be70
Fix some defects detected by Coverity Scan (#22)
* Clang Tidy fixes

* Fix defects detected by Coverity Scan

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-07 09:13:13 +02:00
Carles Fernandez
7367b56725
Improve test (#21)
* Clang Tidy fixes

* Improve GnssCryptoTest.VerifyPublicKeyStorage test

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-06 12:28:01 +02:00
Carles Fernandez
a1ef563988
Fix for OpenSSL 1.0 (#20)
* Clang Tidy fixes

* Fix for OpenSSL 1.0

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-05 13:06:28 +02:00
Carles Fernandez
8a45df29a8
Some API improvements and a bug fix (#18)
* Clang Tidy fixes

* Fix reading of .crt files with GnuTLS

* Hide d_crypto pointer from public API

* Read public key type also from .pem files

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-05 10:29:01 +02:00
Carles Fernandez
3457b8ed3b
Get time zone offset in a more standard way (#17)
* Clang Tidy fixes

* Get time zone offset in a more standard way

Account for leap seconds
Use GNSS-SDR.osnma_mode=strict to check for local time

* Fix for C++20

* Initialize tm in a more portable way

* Remove unnecessary data members in osnma_msg_receiver

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-03 19:58:34 +02:00
Carles Fernandez
6beb92278f
Read type of public key (#16)
* Clang Tidy fixes

* Improve reading public key type

* Update osnma_nav_data_manager.cc

hotfix

---------

Co-authored-by: cesaaargm <cesare.martinez@proton.me>
2024-08-02 09:38:37 +02:00
cesaaargm
960e76e3a0 Clang Tidy fixes 2024-08-01 19:16:47 +02:00
cesaaargm
a47cf1187c [TAS-255] [BUG] Assure time synch. is properly done
if d_flag_debug=false, now system clock is used to for the receiver synchronisation. It uses the UTC time and the GST epoch start time (adjusted for local time zone difference) to create a local estimation of GST, then compares with GST_SIS (coming from NavData Words 5 and 6)
2024-08-01 11:52:28 +02:00
cesaaargm
02c5d26dcc [TAS-250] (x3) [FEAT] Implement PK renewal and revocation. Bugfix for DS length computation.
* it was based on the HF field, which is not correct. It was discovered when the PK was P521 instead of P256 then the Padding size check was failing due to this.
* The solution is temporary:
** GNSS_Crypto: when reading the key, the type is inferred (only for OSSL for the moment)
** when PK comes through the satellites, the public key type is taken from the NPKT field.
2024-07-30 18:09:07 +02:00
Carles Fernandez
07cbf2c01f
Fixes for GnuTLS and OpenSSL < 3 (#14)
* Fix set_public_key when using GnuTLS

* Fix for OpenSSL 1.1.1

* Fix formatting

* Fix formatting

* Fix ECDSA-P521 signature verification when using GnuTLS

* Improve finding of the GMP library in Debian-based systems

* Improve finding of the GMP library in Debian-based systems

* Keep GMP usage private
2024-07-30 18:00:41 +02:00
cesaaargm
fc1541ef10 [TAS-250] [FEAT] Implement PK renewal and revocation. 2024-07-29 12:18:08 +02:00
cesaaargm
5675b996e8 [TAS-251] set_public_key accepts compressed ECDSA PK. Make Crypto tests pass again (OSSL3 and OSSL<3)
* both P256 and P521 curves. Tested successfully.
2024-07-29 12:16:55 +02:00
cesaaargm
a4cfe51515 [TAS-248] [BUG][Kroot] Kroot and PK available, but until DSM-Kroot arrived no MACK processing
* reverted commit [TAS-247][FEAT][Kroot] enable hotstart with last known Kroot
* DSM-KROOT loaded during startup
* if new DSM verified => stored
* this improves TTFAF from 4 min to 1 minute.
2024-07-27 18:25:20 +02:00
cesaaargm
06e0c4b63a [TAS-247][FEAT][Kroot] enable hotstart with last known Kroot
* Kroot is now saved into binary file if successfuly verified.
* on startup, file is checked first.
* This should enable a much quicker TTFAF
2024-07-26 18:03:21 +02:00
cesaaargm
e0506eaf9b Consider CI/CD comments (x2) 2024-07-25 19:03:57 +02:00
cesaaargm
95aea155f0 Merge branch 'carlesfernandez-osnma-cesare-fix10' into osnma-cesare 2024-07-25 15:40:57 +02:00
cesaaargm
84b16cd54d Merge branch 'osnma-cesare-fix10' of https://github.com/carlesfernandez/gnss-sdr into carlesfernandez-osnma-cesare-fix10 2024-07-25 14:48:29 +02:00
cesaaargm
8566eca92f [TAS-238][FEAT] Implement Tag accumulation
* New class: osnma_nav_data_manager => manages navigation data coming to osnma
* navigation data is grouped now avoiding duplication => a NavData entry has now TOW_start and TOW_end
* tag accumulation: now, navigation data has verified_bits field, which shows how many tags have verified that data. unless L_T_min achieved, validation is not considered successful
2024-07-25 14:08:34 +02:00
Carles Fernandez
8ff339671b
Code cleaning 2024-07-24 20:39:40 +02:00
Carles Fernandez
49eb854b16
Fix formatting 2024-07-23 16:51:59 +02:00
Carles Fernandez
39f94dcbe6
Code cleaning 2024-07-23 12:15:43 +02:00