1
0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-23 10:07:19 +00:00
Commit Graph

9462 Commits

Author SHA1 Message Date
Jeremy Ruston
b95723a022
Fix syncer to handler errors properly (#4373)
* First commit

* Add throttling of saves

Now we refuse to save a tiddler more often than once per second.

* Wait for a timeout before trying again after an error

* Modest optimisations of isDirty() method

* Synchronise system tiddlers and deletions from the server

Fixes two long-standing issues:

* Changes to system tiddlers are not synchronised from the server to the browser
* Deletions of tiddlers on the server are not propagated to browser clients

* Make sure we update the dirty status even if there isn't a task to perform

* Replace save-wiki button with popup sync menu

* Remove the "Server" control panel tab

We don't need it with the enhanced sync dropdown

* Add indentation to the save-wiki button

* Fix spacing in dropdown menu items

* Switch between cloud icons according to dirty status

* Add a menu item to copy syncer logs to the clipboard

* Improve animated icon

* Remove indentation from save-wiki button

@pmario the annoying thing is that using `\trim whitespace` trims significant whitespace too, so it means we have to use <$text text=" "/> when we need a space that won't be trimmed. For the moment, I've removed the indentation but will keep thinking about it.

* Further icon, UI and copy text tweaks

Move the icons and styles from the core into the TiddlyWeb plugin

* Clean up PR diff

* Tweak animation durations

* Break the actions from the syncer dropdown into separate tiddlers

@pmario I think this makes things a bit easier to follow

* Refactor syncadaptor creation and logging

The goal is for the syncadaptor to be able to log to the same logger as the syncer, so that the "copy syncer logs to clipboard" data is more useful.

* Don't transition the dirty indicator container colour, just the SVG's colour

* Only trigger a sync for changes to tiddlers we're interested in

Otherwise it is triggered by the creation of the alert tiddlers used to display errors.

* Restore deleting local tiddlers removed from the server

(I had commented it out for some testing and accidentally commited it).

* Guard against missing adaptor info

* We still need to trigger a timeout when there was no task to process

* Avoid repeatedly polling for changes

Instead we only trigger a timeout call at if there is a pending task (ie a tiddler that has changed but isn't yet old enough to save).

* Lazy loading: include skinny versions of lazily loaded tiddlers in the index.html

* Introduce _is_skinny field for indicating that a tiddler is subject to lazy loading

* Remove savetrail plugin from prerelease

It doesn't yet work with the new syncer

* Make the savetrail plugin work again

* Clear outstanding alerts when synchronisation is restored

* Logger: only remove alerts from the same component

Missed off 9f5c0de07

* Make the saving throttle interval configurable (#4385)

After switching Bob to use the core syncer the throttle interval makes saving feel very sluggish compared to the message queue setup that I had before.
The editing lock that I use to prevent conflicts with multiple users doesn't go away until the save is completed, and with the 1 second delay it means that if you edit a tiddler and save it than you have to wait one second before you can edit it again.

* Tweaks to appearance of alerts

* Exclude temp tiddlers from offline snapshots

Otherwise alerts will persist

* Tweak appearance of status line in dropdown

* Update release note

* Web server: Don't include full path in error messages

Fixes #3724

* In change event handler check for deletions

* Disable the official plugin library when the tiddlyweb plugin is loaded

* Hide error details from browser for /files/ route

See https://github.com/Jermolene/TiddlyWiki5/issues/3724#issuecomment-565702492 -- thanks @pmario

* Revert all the changes to the relationship between the syncer and the syncadaptor

Previously we had some major rearrangements to make it possible for the syncadaptor to route it's logging to the logger used by the syncer. The motivation is so that the "copy logs to clipboard" button is more useful.

On reflection, changing the interface this drastically is undesirable from a backwards compatibility perspective, so I'm going to investigate other ways to achieve the logger sharing

* Make the tiddlyweb adaptor use the syncer's logger

So that both are availavble when copying the syncer logs to the clipboard

* Update release note

* Support setting port=0 to get an OS assigned port

Quite useful

* Update code comment

* UI: Use "Get latest changes from server" instead of "Refresh"

* Add getUpdatedTiddlers() method to syncadaptor API

See https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-573579495

* Refactor revision handling within the syncer

Thanks @pmario

* Fix typo in tiddlywebadaptor

* Improve presentation of errors

See https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-573695267

* Add docs for getTiddlerRevision()

* Remove unused error animation

* Update comment for GET /recipes/default/tiddlers/tiddlers.json

* Optimise SVG cloud image

* Add optional list of allowed filters for get all tiddlers route

An attempt to address @Arlen22's concern here:

https://github.com/Jermolene/TiddlyWiki5/pull/4373#pullrequestreview-342146190

* Fix network error alert text translatability

* Fix error code and logging for GET /recipes/default/tiddlers/tiddlers.json

Thanks @Arlen22

* Flip GET /recipes/default/tiddlers/tiddlers.json allowed filter handling to be secure by default

* Validate updates received from getUpdatedTiddlers()

* Add syncer method to force loading of a tiddler from the server

* Remove the release note update to remove the merge conflict

* Fix crash when there's no config section in the tiddlywiki.info file

* Use config tiddler title to check filter query (merge into fix-syncer) (#4478)

* Use config tiddler title to check filter query

* Create config-tiddlers-filter.tid

* Add config switch to enable all filters on GET /recipes/default/tiddlers/tiddlers.json

And update docs

* Fix bug when deleting a tiddler with a shadow

Reported by @kookma at https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-604027528

Co-authored-by: jed <inmysocks@fastmail.com>
Co-authored-by: Arlen22 <arlenbee@gmail.com>
2020-03-30 15:24:05 +01:00
Jeremy Ruston
15b8545d72 Update release note 2020-03-30 14:30:09 +01:00
Jeremy Ruston
9ae2c15638 Merge branch 'tiddlywiki-com' 2020-03-30 14:29:55 +01:00
Jeremy Ruston
091bcfce7d Fix the datauri macro to work with _canonical_uri tiddlers 2020-03-30 10:55:37 +01:00
Joshua Fontany
6f4daa70e1
GruvBoxDark palette contrast tweaks (#4522) 2020-03-29 13:44:09 +01:00
Rob Hoelz
ae04a425c0
Add backlinks indexer (#4421)
* Add tests for backlinks

* Add backlinks indexer

* Use backlinks indexer in getTiddlerBacklinks if available

* Extract link extraction into its own method

This way we can provide an arbitrary parse tree, rather than just a
title, which will allow us to compare lists of outgoing links between
versions of a single tiddler

* Use new extractLinks method in backlinks indexer

...rather than copy-pasting the implementation

* Remove ES6-isms

TiddlyWiki needs to work with browsers that only support ES5
2020-03-26 13:15:02 +00:00
Jeremy Ruston
2d9a9703cb Menubar: Fix positioning of toprightbar when narrow
Fixes #4477
2020-03-24 10:35:07 +00:00
Simon Huber
4232b402ab
Update Vanilla.tid (#4515) 2020-03-20 18:31:57 +00:00
Simon Huber
10ab83940a
Update Nord Palette for better readability (#4517) 2020-03-20 12:47:48 +00:00
Jeremy Ruston
6928842bbf Update docs for disabling drag and drop 2020-03-20 11:02:14 +00:00
Jeremy Ruston
cb52d709c2 Improve ability to disable drag and drop
Now we disable the draggable list macros too.
2020-03-20 10:46:17 +00:00
Cameron Fischer
561662782e
Fixes issue with #4504 and importvariable copying (#4518)
* Fixes issue with #4504 and importvariable copying

ImportVariables widget was using $tw.utils.extend to copy the
variables from temporary set widgets into itself. However,
$tw.utils.extend does NOT behave like Object.assign. It not only
copies all self-owned variables over, but also all variables
in that object's prototype chain. This led to some redundant copying,
and a problem where some variables might show up more than once
(like transclusion).

Fixed now. importvariables widget does its own copying, since it
can't rely on $tw.utils.extend to do the right job, and it can't
count on Object.assign to be there.

* Added test to prevent reversion of #4504

* Slight corrections to new importvariables test
2020-03-19 20:32:51 +00:00
Jeremy Ruston
c16c2fe5e6 Docs: Clarify Node.js docs 2020-03-18 11:57:58 +00:00
Bram Chen
33fb4f5c0d
Fix the index names of chinese translations for Gitea saver in ControlPanel.multids (#4506) 2020-03-16 09:14:15 +00:00
Simon Huber
c6b109fbde
Update GruvBoxDark.tid (#4510)
better readability, was wrong the first time
2020-03-16 09:12:35 +00:00
Jeremy Ruston
8f12717935 Menu bar: Fix search result visibility
Fixes #4509
2020-03-16 09:11:08 +00:00
Jeremy Ruston
bc687e5783 Add a hidden setting for disabling the page dropzone 2020-03-15 14:46:33 +00:00
Jeremy Ruston
a6f6db40d9 Revert "Fix test for needing to update text editor DOM"
This reverts commit a65ec87c53.
2020-03-15 14:23:10 +00:00
Simon Huber
e67485ec54
Highlight Plugin: Update readme to reflect version change (#4503) 2020-03-14 17:16:38 +00:00
Jeremy Ruston
fa48a592da Menubar: Fix links in sidebar "open" tab
Fixes @BurningTreeC's report 061a2c6c94 (commitcomment-37826117)
2020-03-14 17:03:40 +00:00
Simon Huber
f3ac255855
Update GruvBoxDark.tid (#4501) 2020-03-14 13:10:39 +00:00
Simon Huber
f051e0d790
Update highlight.js to latest v9.18.1 (#4502)
* update highlight.pack.js to latest v9.18.1

* Update readme.tid
2020-03-14 13:06:50 +00:00
Jeremy Ruston
061a2c6c94 Menubar: Add an optional dropdown for the sidebar tabs 2020-03-14 12:55:11 +00:00
Matthias Bilger
62f8c9353e
Use CamelCase for Gitea (#4496) 2020-03-13 17:36:05 +00:00
Jeremy Ruston
ff7fab6175 Menubar: Move behind modals in z-order
Fixed fix for #4499
2020-03-13 09:52:24 +00:00
Bram Chen
0644716f4b
Add chinese translations for description of Gitea saver (#4498) 2020-03-13 09:41:43 +00:00
Jeremy Ruston
1dc517b151 Menubar: Move behind modals in z-order
Fixes #4499
2020-03-13 09:35:37 +00:00
saqimtiaz
ca6dd93214
Add support for a custom class to modal wrapper (#4490)
* Add support for a custom class to modal wrapper

As per https://github.com/Jermolene/TiddlyWiki5/issues/4485 add support for a custom class to modal wrapper, by means of a field in the modal tiddler. The class is added to the modal wrapper in addition to the default class, allowing for custom styling via css of any part of the modal.

* Remove redundant check for tiddler.
2020-03-12 16:58:14 +00:00
Simon Huber
195b3b0209
Add "Gruvbox Dark" color palette (#4494)
* Add "Gruvbox Dark" color palette

this adds the "gruvbox dark" color palette (https://github.com/morhetz/gruvbox) which is also available for highlight.js and codemirror

* add "credits" field

* change "credits" field to "license" field
2020-03-12 15:54:23 +00:00
Matthias Bilger
52a9f928ae
Added gitea saver (#4491)
* added gitea saver

* create nonexistent file
2020-03-12 15:53:55 +00:00
Matthias Bilger
d704507069
Signing the CLA (#4492) 2020-03-12 15:42:15 +00:00
Simon Huber
22e6b20f50
Better readability for "Community" Tiddler with various ... (#4493)
... color palettes
2020-03-12 13:34:59 +00:00
Simon Huber
3d16745b4b
Add german descriptions for menubar-background... (#4483)
* add german descriptions for menubar-background...

* Update PaletteColours.multids

* Update PaletteColours.multids
2020-03-11 17:40:22 +00:00
twMat
2ad8d1790b
Update LinkWidget.tid (#4489) 2020-03-11 17:37:53 +00:00
Jeremy Ruston
cab9fd11dc Clarify docs on the path-prefix subcommand of the listen command 2020-03-11 17:19:21 +00:00
Jeremy Ruston
9b48a1c829 Introducing "Dynannotate" plugin for overlaying annotations 2020-03-11 16:55:19 +00:00
Bram Chen
592922d399
Add chinese translations for color descriptions for menubar-background and menubar-foreground (#4488) 2020-03-10 10:41:42 +00:00
JesseWeinstein
d950591051
Mention importing process more explicitly (#3666)
* Mention importing process more explicitly

* Explicitly mention "images"

So this page shows up in a search for "images".

* Apply PR suggestions
2020-03-09 21:34:23 +00:00
Simon Huber
0f7e365450
Add color descriptions for menubar-background and ... (#4481)
menubar-foreground to PaletteColours.multids
2020-03-09 21:08:48 +00:00
Simon Huber
8b5f38c53e
Add menubar-background and menubar-foreground to Nord palette (#4482)
Nord palette
2020-03-09 21:08:22 +00:00
saqimtiaz
8cd1dc36c1
Fix suspected typo that impacts refresh handling (#4464) 2020-03-09 21:07:34 +00:00
Jeremy Ruston
a22438589e Remove unsafe externalimages build target from server edition
See #4484
2020-03-09 21:05:50 +00:00
Jeremy Ruston
ae9ce4f01c ViewTemplate: Add tc-tiddler-overridden-shadow class 2020-03-09 20:31:42 +00:00
Jeremy Ruston
665b63ec38 Fix lack of refresh when button widget actions attribute changes 2020-03-08 17:11:21 +00:00
Jeremy Ruston
a65ec87c53 Fix test for needing to update text editor DOM
Checking the active element is clumsy, and interferes with debugging. Checking the content is clearer, and avoids the Firefox bug.

Fixes #4472
2020-03-07 14:00:46 +00:00
Jeremy Ruston
6091b01386 Add hidden setting for default tiddler icon 2020-03-06 14:52:37 +00:00
Jeremy Ruston
24d2804799 Add action-popup widget
Fixes #4185
2020-03-03 12:03:32 +00:00
scott willeke
3fd301a5d2
Markdown plugin: Description notes remarkable instead of markdown-js (#4422) 2020-03-02 09:29:16 +00:00
scott willeke
a942b161ad
Signing the CLA (#4440) 2020-03-02 09:27:55 +00:00
Jeremy Ruston
6cdffc4eae Fix broken filters introduced in b179a6011
The mistake arose because browser local storage was enabled
2020-02-29 15:56:22 +00:00