For five minutes I stared at the following code...
if(value != null && typeof value === "object") {
Object.freeze(value);
}
... and at the error message that led me to this code: `Object.freeze called on non-object`
And then I remembered that js treads null as object (http://www.ecma-international.org/ecma-262/5.1/#sec-11.4.3). This means the `typeof === "object"` will not discover null and freeze will throw an error...
So `value != null` will also work when value is undefined.
A hard to find bug ;)
The URL (freedombits.org) is no longer hosting this example. It no
longer provides a good example as there is no TiddlyWiki linked anymore.
With much regret it needs to be removed till the original author can fix
the problem.
For some reason this is causing the focus to be repeatedly set to
the title field when editing a tiddler's text. Let's revert it for
now.
See Issue #1527.
This reverts commit fdc635007b.
The previous fix changed the scrolling behaviour such that it only
scrolled to the top of a tiddler if the tiddler was entirely offscreen.
It wasn’t entirely satisfactory because scrolling was prevented even if
only a few pixels of a tiddler are in view. This commit ensures that
the scroll does occur if less than 50 pixels of the target is in view
With this enhancement, clicking on a tiddler in the story view will
navigate to that tiddler. This is needed for eg the stacked storyview,
where we want to be able to click on tiddlers to bring them to the
front of the stack.
There are some problems though - as things stand, clicking on a tiddler
in classic storyview will scroll to the top of that tiddler.
Layout bugs with position: sticky in Firefox mean that we probably
shouldn’t have sticky titles as the default. Rather than reverting to
putting them in a separate theme, it is proposed to expose the sticky
titles setting in Vanilla theme tweaks.
Previously the shadow was to the bottom right. When tiddlers overlap
(as with the stacked storyview) it makes them “pop” more if the shadow
extends round all sides of the tiddler.
Firefox bugs with position:sticky mean that we probably shouldn’t have
sticky titles turned on by default.
Previously, sticky titles were packaged into a pluggable theme. Now, I
think it may make more sense to make the sticky titles status be a
theme tweak for the Vanilla theme.
By turning the tiddler frame into a link it is now possible to click on
a tiddler to navigate to it. This is needed for the new
stacked-storyview, but it also useful in other storyviews.
Note that there are currently some issues. For example, in classic
storyview, clicking on a tiddler will scroll to the top of it, which
isn’t helpful if you’ve scrolled halfway down a long tiddler.
