1
0
mirror of https://github.com/SuperBFG7/ympd synced 2024-12-23 17:40:26 +00:00
Commit Graph

132 Commits

Author SHA1 Message Date
Virgil Dupras
698f573a65 Fix broken add track action
Fix the bug I've introduced in my PR #78, breaking the add
track/playlist action. We have to decode URIs before sending them back
to our socket!

fixes #80
2015-07-13 14:31:56 -04:00
Virgil Dupras
fe44fca184 Fix browsing for non-ascii entity URI under Safari
Previously, browsing entities with non-ascii characters in their URI
under Safari wouldn't work. Directories would be empty, songs wouldn't
be added. I haven't tried it, but this behavior seems to be common to
Webkit-based browsers, so Chrome would be affected too.

This turned out to be because Safari normalizes all unicode strings to
NFC, breaking the link with MPD-spewed URIs, which are in NFD.

An obvious fix would have been to normalize all URIs to NFD, but
unfortunately, Safari doesn't have `str.normalize()`. Adding
normalization capabilities to our JS side would have involved
introductiing libraries such as `unorm`, which is rather big.

We could have done it on the C side, but it involves introducing `icu`,
which is far from trivial too.

After much fussing around, I stumbled on a simple solution: URI-encode
our URI when creating our browser table row. This magically prevents
Safari from trying to mess with our unicode form before we get the
chance to send it back to our server.
2015-06-20 22:39:42 -04:00
Andy
51c371bbc3 Merge pull request #73 from jpleau/fix_init
fix webport using the wrong variable in init scripts
2015-05-03 02:20:04 +02:00
Jason Pleau
c7f19755bd fix webport using the wrong variable in init scripts 2015-05-01 20:57:58 -04:00
Andrew Karpow
770c32a370 replaced deprecated drone.yml with travis-ci 2015-05-02 01:49:48 +02:00
Andy
8c916e2b74 Merge pull request #72 from jpleau/various_patches
various patches: manpage, remove external js, init scripts
2015-05-02 01:11:05 +02:00
Jason Pleau
5abfdfda7b update init script and systemd service file
init script: depend on $remote_fs instead of $local_fs. Reason: /usr can
be mounted a remote filesystem. Also depend on mpd (instead of $mpd,
which doesn't seem to exist.. at least on my system)

Also provide a default config (which should be installed as
/etc/default/ympd)

This commit makes the systemd unit file as well as the init script load
values from this configuration file so the user can change ympd settings
easily when running it as a service.
2015-05-01 17:14:21 -04:00
Jason Pleau
3ef53f3cc2 webpage: remove respond.js
Calling outside resources is a breach of privacy, and prevents the page
from loading correctly if offline.
2015-05-01 17:06:57 -04:00
Jason Pleau
1035264d66 manpage: set section to 1 and update version 2015-05-01 17:06:09 -04:00
Andrew Karpow
ade4ee3808 apply mg_set listening_port only once, fixes #71 2015-05-01 21:05:15 +02:00
Andrew Karpow
caddebcec0 fixed memleak in mpd_set_password 2015-04-25 00:39:16 +02:00
Andrew Karpow
4ba3e0b70f removed %m formatstring, works now with openbsd, fixes #68 2015-04-25 00:35:01 +02:00
Andrew Karpow
3701a8510b add libmpdclient header location to gcc-search path, fixes openbsd builds 2015-04-24 23:38:39 +02:00
Andy
2e350f4a65 Merge pull request #67 from jpleau/update_mongoos_56
Update mongoos 56
2015-04-24 21:41:31 +02:00
Jason Pleau
19c6d7eb88 replace mg_iterate_over_connections with a loop with mg_next 2015-04-20 23:11:03 -04:00
Jason Pleau
7061015486 update mongoose to 5.6 2015-04-20 23:05:23 -04:00
Andy
3df5b36b97 Merge pull request #56 from warhog/master
Added ability to add streams
2015-03-19 23:08:15 +01:00
warhog
4d4ff2bdc2 changed order of menu entries 2015-03-06 12:41:26 +01:00
warhog
1c4e89def8 added ability to add streams 2015-03-06 12:40:14 +01:00
Andy
ca40c44dd5 Merge pull request #52 from ajs124/master
Add crossfade support. Not sure about the icon/glyph though
2015-03-03 21:50:49 +01:00
Andy
1268cab3b3 Merge pull request #40 from iwanders/master
Change websocket URL to allow easy incorporation of different backends.
2015-03-03 21:49:46 +01:00
ajs124
3eb12e6ecd Add crossfade support. Not sure about the icon/glyph though 2015-02-17 15:45:26 +01:00
Andrew Karpow
e6e93a08c7 release build now installs assets to prefix
if build with dynamic assets
2014-11-11 21:13:11 +01:00
Ivor Wanders
a5a4ac9461 Changes URL used for the websocket.
This change allows easier implementation of different backends because the websocket URL isn't identical to the webpage URL. This does not affect the functionality of the default C backend.
2014-11-03 20:01:05 +01:00
Andy
aeaac3ecc3 Merge pull request #38 from jpleau/jquery
add jquery source file
2014-11-03 19:07:33 +01:00
Andy
b9411a7134 Merge pull request #26 from KAMiKAZOW/patch-1
Create ympd.spec
2014-11-03 03:22:05 +01:00
Andy
9728aae69c Merge pull request #37 from jpleau/fix_mpd_port_argument
ympd.c: add a break statement for the mpd port argument
2014-11-02 13:13:04 +01:00
Jason Pleau
07b6ac7473 add jquery source file
This is to comply with the Debian Free Software Guidelines:
https://www.debian.org/social_contract#guidelines

ympd can still use the minified file, however we need the source files
to be included in the source package.
2014-10-29 18:25:07 -04:00
Jason Pleau
59d971dc1b ympd.c: add a break statement for the mpd port argument
Otherwise, passing -p tried to also bind the http server to MPD's port
(which was already in use by MPD...)
2014-10-28 22:48:08 -04:00
KAMiKAZOW
d4f45558e9 Rename ympd.spec to contrib/ympd.spec 2014-10-29 03:08:59 +01:00
Andy
8b29371e4e Merge pull request #36 from jpleau/init_script
init.debian: correct typo in shebang and adjust default webport
2014-10-29 02:38:04 +01:00
Jason Pleau
d8610584d4 init.debian: correct typo in shebang and adjust default webport
The default webport in the systemd unit is 8080, but the one in the init
script was 80.
2014-10-28 20:11:38 -04:00
Andrew Karpow
dc15e3b0d7 add WITH_DYNAMIC_SERVING for theme developing 2014-10-27 22:12:10 +01:00
Andrew Karpow
2b5a4c6fa0 added mkdata.pl generator for cross-compiling, fixes #31 2014-10-19 22:58:03 +02:00
Andrew Karpow
912140c96c prepare for 1.2.3 release 2014-10-19 20:29:30 +02:00
Andrew Karpow
60d2392022 set mpd timeout only after connect, fixes #32 2014-10-19 20:27:11 +02:00
Andrew Karpow
aa60cb8991 upgraded to mongoose 5.4, introducing ipv6 support 2014-10-19 19:52:23 +02:00
Andrew Karpow
87fdd34f87 make mkdata more portable, fixes #35 2014-10-19 16:45:49 +02:00
Andrew Karpow
5fd723c1db fixed CMake warning CMP0026 2014-10-19 16:35:16 +02:00
KAMiKAZOW
8b77500850 Create ympd.spec
Spec file to create RPM packages. Works under Fedora 19 and 20:
https://build.opensuse.org/package/show/home:KAMiKAZOW:Fedora/ympd
2014-07-30 06:34:54 +02:00
Andy
a98d760ddd Merge pull request #19 from ajs124/master
remove webkit prefix from notifications
2014-05-24 15:25:47 +02:00
ajs124
9f001aa264 change notification cookie from session to "permanent" 2014-05-24 03:12:51 +02:00
ajs124
0730673851 remove webkit prefix from Notifications, now working with firefox!
+ probably fix bug with undefined artist or album
2014-05-24 02:57:30 +02:00
Andrew Karpow
a70d87f7c7 bumped version to 1.2.2 2014-05-09 14:10:14 +02:00
Andy
1e3dea473c Merge pull request #14 from phmongeau/master
make service environment file optional
2014-04-23 17:31:05 +02:00
Philippe Mongeau
5659a1a86d make service environment file optional 2014-04-23 10:47:25 -04:00
Andrew Karpow
25d54f68d6 drop privliges after port binding, fixes #12 2014-04-23 12:22:31 +02:00
Andy
fd140e210e Merge pull request #13 from kingcody/hotfix/prev-next-swap
fix prev and next buttons
2014-04-23 12:03:17 +02:00
Cody Mize
11e3dbefb0 fix prev and next buttons; was swapped 2014-04-23 03:13:07 -04:00
Andy
acc5855e17 Merge pull request #11 from Nighoo/typo-1
fix some typos
2014-04-15 20:59:50 +02:00