mirrors/janet
1
0
Fork 0
mirror of https://github.com/janet-lang/janet synced 2024-11-25 09:47:17 +00:00
Code Issues 1 Releases Wiki Activity

Merge pull request #378 from andrewchambers/tweak

Browse Source 
Tweak comment, remove extra include.
This commit is contained in:
Calvin Rose 2020-05-07 10:33:19 -04:00 committed by GitHub
commit 95c669389b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/io.c
View File

@ -33,7 +33,6 @@
#include <fcntl.h> #include <fcntl.h>
#include <sys/wait.h> #include <sys/wait.h>
#include <unistd.h> #include <unistd.h>
#include <fcntl.h>
#endif #endif
static int cfun_io_gc(void *p, size_t len); static int cfun_io_gc(void *p, size_t len);
@ -143,10 +142,9 @@ static Janet cfun_io_temp(int32_t argc, Janet *argv) {
#ifndef JANET_WINDOWS #ifndef JANET_WINDOWS
/* It seems highly unlikely a typical janet user wants a tempfile to be inherited and /* It seems highly unlikely a typical janet user wants a tempfile to be inherited and
libc tmpfile does NOT set O_CLOEXEC by default, libc tmpfile does NOT set O_CLOEXEC by default.
Even though setting this flag after a delay is racy in threaded programs, For threaded programs we should use mkostemp
It helps in single threaded ones. The fix for threaded programs would be to use mkostemp
which is coming to POSIX at a later time. */ which is coming to POSIX at a later time. */
if (fcntl(fileno(tmp), F_SETFD, FD_CLOEXEC) != 0) { if (fcntl(fileno(tmp), F_SETFD, FD_CLOEXEC) != 0) {
fclose(tmp); fclose(tmp);