1
0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2024-12-16 13:10:35 +00:00
Commit Graph

8552 Commits

Author SHA1 Message Date
Carles Fernandez
73a728b3f6
Merge branch 'feature/signal_source_interface' of https://github.com/jwmelto/gnss-sdr into jwmelto-feature/signal_source_interface 2021-02-18 09:03:03 +01:00
Carles Fernandez
9403560427
Return back init() to connect() 2021-02-17 22:13:20 +01:00
Carles Fernandez
03e53477c7
Apply some mostly cosmetic changes
This is not so cosmetic: Moved init() chores from connect() to the constructor for consistency with other implementations. Not relevant here since files are not processed in real-time, but is it common practice in other blocks to set everything needed (and get all the resources) in the constructor, before connect()

Moved the constructor code to the top of the file, also for consistency with other files. This is an opinionated practice, I know, since one could expect the same order than in the header file.

Improved comment formatting for Doxygen

Added and removed some blank lines to match the style of other files (two blank lines within method implementations, no two consecutive blank lines inside the method. Again opinionated, but for the sake of consistency.

Included the <tuple> library (include what you use)
2021-02-17 22:07:22 +01:00
Jim Melton
704b99e633
another MacOS property ambiguity ... ARRRGGGHHH 2021-02-17 13:40:04 -07:00
Jim Melton
c221fd1c87
update copyright and move risky initializer into ctor body 2021-02-17 12:54:10 -07:00
Carles Fernandez
6d41fc8fb2
Fix Multichannel_File_Signal_Source
The constructor was not getting right the SignalSource.RF_channels value (role was moved before, so it was unusable)
2021-02-17 13:50:45 +01:00
Carles Fernandez
f703990a09
Fix building when using C++11
Update changelog
2021-02-17 09:43:05 +01:00
Carles Fernandez
0f735814df
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next 2021-02-16 18:34:31 +01:00
Javier Arribas
8ba3cfa86f Send monitor ephemeris even in the case that it is not enabled the RINEX writter 2021-02-16 17:54:38 +01:00
Carles Fernandez
a7699c2050
Fix file headers 2021-02-16 17:15:48 +01:00
Carles Fernandez
3b3beb099a
Fix clang-tidy job, update headers 2021-02-16 17:00:22 +01:00
Carles Fernandez
9bfa748620
Update changelog 2021-02-16 16:46:42 +01:00
Carles Fernandez
de4dfd410c
Merge branch 'mmajoral-buffer_monitor' into next 2021-02-16 16:43:35 +01:00
Carles Fernandez
19c03edf1f
Update file header 2021-02-16 16:42:10 +01:00
Carles Fernandez
060e276414
Merge branch 'buffer_monitor' of https://github.com/mmajoral/gnss-sdr into mmajoral-buffer_monitor 2021-02-16 16:11:15 +01:00
Carles Fernandez
52ff85b004
Merge branch 'next' of https://github.com/gnss-sdr/gnss-sdr into next 2021-02-16 16:03:14 +01:00
Jim Melton
ec7b4cc537
clang-tidy : change '1u' to '1U' 2021-02-16 00:34:49 -07:00
Jim Melton
e5bcf4700c
penultimate clang-tidy/clang-format complaint 2021-02-15 23:01:56 -07:00
Jim Melton
a8959bdd87
more clang-tidy cleanup/suppression 2021-02-15 22:56:30 -07:00
Jim Melton
c67f23c913
fix clang-tidy complaints
some of these are ridiculous and so have been silenced. I'm a huge fan
of static code analysis but I have a hard time believing that writing
"0U" is a qualitative improvement over "0u".
2021-02-15 21:30:50 -07:00
Jim Melton
35f07b76a0
the Mac compiler is really annoying (and not that arguably correct...) 2021-02-15 18:37:38 -07:00
Jim Melton
957a13e6ef
fix MacOS ambiguity error 2021-02-15 17:51:42 -07:00
Jim Melton
3b728d9c26
fix cast error 2021-02-15 17:15:38 -07:00
Jim Melton
ece5effa2d
penultimate clang-format fix 2021-02-15 16:34:16 -07:00
Jim Melton
bba9edd68c
change invalid block implementation from FATAL to ERROR
I'm not sure that there is any value in continuing with a bad configuration
but be careful about changing the semantics of existing code. You never know
what else may depend upon it.
2021-02-15 16:31:35 -07:00
Jim Melton
6e04a42c8a
clang-format
This was much worse than I thought. I had run clang-format at some point, but
apparently I subsequently made some non-compliant changes in pretty much every
file I touched.
2021-02-15 15:34:48 -07:00
Jim Melton
3bf2deb2ae
fixed failing unit test
I don't know how this didn't run before submitting the PR. CI tests are great!

The file-based signal sources were modified to not throw an exception on creation
but rather when connect() is called. The unit test was checking for an exception
upon construction.
2021-02-15 15:33:16 -07:00
Marc Majoral
440e8f1b3c log FPGA buffer overflow with severity level ERROR + add some comments. 2021-02-15 22:27:03 +01:00
Jim Melton
fb6fef74e3
fix clang-tidy CI issues 2021-02-15 14:13:54 -07:00
Jim Melton
4a88479972
reverted LOG4CPP work-around
The existing CMake logic is broken-ish; or rather log4cpp is broken-ish, and
this inhibits the use of C++17 std::filesystem.

All of the static libraries created are brittle; consider changing from
STATIC to OBJECT in the future?
2021-02-15 14:04:54 -07:00
Jim Melton
41c7a7ad7d
fix whitespace 2021-02-15 13:46:12 -07:00
Marc Majoral
b279c3bcbd replace exception by receiver stop command 2021-02-15 21:44:05 +01:00
Jim Melton
75483e1d2d
refactor two_bit_packed_file_signal_source
(signed for DCO)
2021-02-15 13:15:50 -07:00
Jim Melton
353680bc99 add 2bit_cpx file source 2021-02-15 11:47:13 -07:00
Jim Melton
4399aa5d10 next round of abstraction. Add nsr_file_signal_source 2021-02-15 11:47:13 -07:00
Jim Melton
c8ecc907c9 save before checkin 2021-02-15 11:47:13 -07:00
Jim Melton
1854cec106 first subclass of file_source_base
Refactored the base implementation to add appropriate virtual hooks so subclasses
can easily extend without duplicating a lot of code.
2021-02-15 11:47:13 -07:00
Jim Melton
6d4ddc16e7 eliminate compile warning
Note this commit introduces a more appropriate pattern for exception
handling within loops, but did not change all occurrences.
2021-02-15 11:47:13 -07:00
Jim Melton
a3c9dd4325 remove commented code 2021-02-15 11:47:13 -07:00
Jim Melton
4282386a30 simplify get_right_block() 2021-02-15 11:47:13 -07:00
Jim Melton
e0eb4bd769 initial implementation of common file source base class
Only the file_signal_source uses it at this time; changing multi-channel
to use it can be done with a little work
2021-02-15 11:47:13 -07:00
Jim Melton
78362e7cba add signal_source_interface
also adds a base implementation that most signal sources should inherit from.
The gen_signal_source is inexplicably different (probably as a test fixture,
commonality was not valued).

Only the file_signal_source has been tested; all the sources are modified in the same
way, but we all know the only proof of correctness is testing.

The block factory was simplified a bit. Handling for legacy config files was pulled out
of the flowgraph; now when the "0" instance of a component (Foo0) is created, if there is
no config for it, then the legacy version (Foo) will be tried. This is different from
passing -1 for the item number (which is still supported). Theoretically, all existing
config files should still work.
2021-02-15 11:47:13 -07:00
Jim Melton
8407acb7a7 WIP: initial commit for collaboration 2021-02-15 11:47:13 -07:00
Javier Arribas
39031b24ac Completing UDP GPS and Galileo ephemeris server 2021-02-15 15:58:38 +01:00
Marc Majoral
c0e4b2aee5 dump the buffer monitor results to a file 2021-02-15 11:53:16 +01:00
Javier Arribas
1721431010 Adding GPS and Galileo protobuf serdes 2021-02-15 10:56:30 +01:00
Marc Majoral
d8c41a7171 removed whitespace 2021-02-14 13:40:52 +01:00
Marc Majoral
a3d2763970 removed header file 2021-02-13 17:29:30 +01:00
Marc Majoral
03e8f97d2e real-time FPGA receiver buffer monitoring 2021-02-13 17:10:43 +01:00
Carles Fernandez
f3ae29e8bf
Document C++20 as the currect C++ standard 2021-02-13 12:53:17 +01:00