Jim Melton
35f07b76a0
the Mac compiler is really annoying (and not that arguably correct...)
2021-02-15 18:37:38 -07:00
Jim Melton
957a13e6ef
fix MacOS ambiguity error
2021-02-15 17:51:42 -07:00
Jim Melton
3b728d9c26
fix cast error
2021-02-15 17:15:38 -07:00
Jim Melton
ece5effa2d
penultimate clang-format fix
2021-02-15 16:34:16 -07:00
Jim Melton
bba9edd68c
change invalid block implementation from FATAL to ERROR
...
I'm not sure that there is any value in continuing with a bad configuration
but be careful about changing the semantics of existing code. You never know
what else may depend upon it.
2021-02-15 16:31:35 -07:00
Jim Melton
6e04a42c8a
clang-format
...
This was much worse than I thought. I had run clang-format at some point, but
apparently I subsequently made some non-compliant changes in pretty much every
file I touched.
2021-02-15 15:34:48 -07:00
Jim Melton
3bf2deb2ae
fixed failing unit test
...
I don't know how this didn't run before submitting the PR. CI tests are great!
The file-based signal sources were modified to not throw an exception on creation
but rather when connect() is called. The unit test was checking for an exception
upon construction.
2021-02-15 15:33:16 -07:00
Jim Melton
fb6fef74e3
fix clang-tidy CI issues
2021-02-15 14:13:54 -07:00
Jim Melton
41c7a7ad7d
fix whitespace
2021-02-15 13:46:12 -07:00
Jim Melton
75483e1d2d
refactor two_bit_packed_file_signal_source
...
(signed for DCO)
2021-02-15 13:15:50 -07:00
Jim Melton
353680bc99
add 2bit_cpx file source
2021-02-15 11:47:13 -07:00
Jim Melton
4399aa5d10
next round of abstraction. Add nsr_file_signal_source
2021-02-15 11:47:13 -07:00
Jim Melton
c8ecc907c9
save before checkin
2021-02-15 11:47:13 -07:00
Jim Melton
1854cec106
first subclass of file_source_base
...
Refactored the base implementation to add appropriate virtual hooks so subclasses
can easily extend without duplicating a lot of code.
2021-02-15 11:47:13 -07:00
Jim Melton
6d4ddc16e7
eliminate compile warning
...
Note this commit introduces a more appropriate pattern for exception
handling within loops, but did not change all occurrences.
2021-02-15 11:47:13 -07:00
Jim Melton
a3c9dd4325
remove commented code
2021-02-15 11:47:13 -07:00
Jim Melton
4282386a30
simplify get_right_block()
2021-02-15 11:47:13 -07:00
Jim Melton
e0eb4bd769
initial implementation of common file source base class
...
Only the file_signal_source uses it at this time; changing multi-channel
to use it can be done with a little work
2021-02-15 11:47:13 -07:00
Jim Melton
78362e7cba
add signal_source_interface
...
also adds a base implementation that most signal sources should inherit from.
The gen_signal_source is inexplicably different (probably as a test fixture,
commonality was not valued).
Only the file_signal_source has been tested; all the sources are modified in the same
way, but we all know the only proof of correctness is testing.
The block factory was simplified a bit. Handling for legacy config files was pulled out
of the flowgraph; now when the "0" instance of a component (Foo0) is created, if there is
no config for it, then the legacy version (Foo) will be tried. This is different from
passing -1 for the item number (which is still supported). Theoretically, all existing
config files should still work.
2021-02-15 11:47:13 -07:00
Jim Melton
8407acb7a7
WIP: initial commit for collaboration
2021-02-15 11:47:13 -07:00
Carles Fernandez
10fc0eb62e
Fix -Wsign-compare warning
2021-02-11 13:45:55 +01:00
Carles Fernandez
16dd5ec241
Apply clang-tidy check: readability-string-compare
2021-02-11 13:37:32 +01:00
Marc Majoral
915c2859f2
Use the Galileo E1 FPGA tracking multicorrelators for the GPS L1 C/A channels if not enough GPS L1 C/A tracking multicorrelators are present in the FPGA. This selection is done automatically only if the GPS L1 C/A channels are assigned to the GPS L1 C/A FPGA tracking multicorrelators (this may not be the case when testing).
...
+ renamed the device name variables.
2021-02-10 18:43:11 +01:00
Carles Fernandez
ba89685ce6
Remove wrong error message
2021-02-09 11:34:07 +01:00
Carles Fernandez
2a82c27954
Fix linking for std::filesystem in GCC 8
2021-01-31 14:13:25 +01:00
Carles Fernandez
3c17f0a9a7
Fix defect detected by Coverity Scan (uninitialized scalar variables)
2021-01-29 14:01:21 +01:00
Carles Fernandez
c7887a03e5
Fix defects detected by Coverity Scan
2021-01-28 20:14:00 +01:00
Carles Fernandez
bd87e4e9b7
Fix warning -Wstringop-truncation raised by GCC 11
2021-01-28 14:09:33 +01:00
Carles Fernandez
c5916d05c3
Fix warning Wstringop-overread raised by GCC 11
2021-01-28 13:56:30 +01:00
Carles Fernandez
5d42f1e14c
Extend segfault fix when RINEX output is disabled for other signals than GPS L1
2021-01-27 12:47:13 +01:00
Stefan van der Linden
a07217d34f
Fixed segfault when rinex output is disabled
2021-01-27 11:12:45 +01:00
Carles Fernandez
d249a7efcf
Avoid segmentation faults if the SignalConditioner is not well defined in the configuration
2021-01-26 23:11:06 +01:00
Carles Fernandez
24041058a6
Improve reported output in case of configuration error
2021-01-26 16:11:41 +01:00
Carles Fernandez
720215af30
Avoid segmentation fault if the item_type for the signal source is mismatched with the input item size of the Signal Conditioner
2021-01-26 15:20:37 +01:00
Carles Fernandez
862bdeea5c
Avoid segmentation fault if the Tracking item_type is not defined for the given implementation
2021-01-26 14:01:28 +01:00
Carles Fernandez
7f23b6d88b
Use C++ cast insted of C-style cast
2021-01-26 11:58:46 +01:00
Carles Fernandez
d738d893c6
Apply clang-format
2021-01-26 00:14:50 +01:00
Carles Fernandez
950111d0fe
Avoid warning when building googletest with CMake >= 3.19
2021-01-25 22:19:18 +01:00
Carles Fernandez
ecf20d38d6
Merge branch 'clang-tidy-fgpa' into next
2021-01-25 22:17:08 +01:00
Carles Fernandez
d6d1fff743
Apply clang-tidy fixes when -DENABLE_FPGA=ON
2021-01-25 22:07:59 +01:00
Carles Fernandez
ed5975d968
Merge branch 'coverity-fix' into improve-flowgraph
2021-01-25 13:37:05 +01:00
Carles Fernandez
2f627581ef
Fix error handling issues detected by Coverity Scan 2020.09
2021-01-25 13:35:47 +01:00
Carles Fernandez
cd1c9e46ba
Add some basic configuration checks
...
Avoid some segmentation faults caused by ill-formatted configuration files
2021-01-25 00:49:36 +01:00
Carles Fernandez
a21c60ecb2
Improve error handling when the flow graph fails to start
...
Avoid segmentation faults due to some common inconsistencies in the configuration file
E.g.: non-existing names for blocks implementation, some mismatched input/output item sizes
Provide hints to the user on how to fix the configuration in case of failure when starting the flow graph
2021-01-24 01:49:16 +01:00
Carles Fernandez
268fc1215c
Refactor private implementation of flowgraph connection and disconnection
2021-01-22 17:32:37 +01:00
Carles Fernandez
3773f3c71a
Do not apply clang-tidy fixes to protobuf-generated headers
2021-01-18 16:00:33 +01:00
Carles Fernandez
1287e8fe79
Improve handling of the filesystem library
2021-01-16 14:37:19 +01:00
Carles Fernandez
0e9046c956
Raise an error if GPSTK is to be built but the patch command is not found
2021-01-16 10:51:38 +01:00
Carles Fernandez
11f13ebcab
Fix building in modern environments
2021-01-15 15:03:36 +01:00
Carles Fernandez
4fea48f603
Improve handling of change in GNU Radio 3.9 FFT API
...
Fix compilation of some optional blocks when linking against GR 3.9
Fix warning -Wembedded-directive: embedding a directive within macro arguments has undefined behavior
2021-01-15 13:39:26 +01:00
