mirrors/gnss-sdr
1
0
Fork 0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2026-08-22 18:18:54 +00:00
Code Issues Releases Wiki Activity

Fix defects detected by Coverity Scan

Browse Source 
Fix uninitialized pointer field in base_pcps_acquisition.cc
Remove unnecessary object copies in rinex_printer.cc
Remove structurally dead code in labsat23_source.cc
This commit is contained in:
Carles Fernandez
2025-11-12 12:18:04 +01:00
committed by Carles Fernandez
parent 6dadfe9307
commit 3872eb2159
4 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/algorithms/PVT/libs/rinex_printer.cc
+5 -5
View File
@@ -3582,7 +3582,7 @@ void Rinex_Printer::update_nav_header(std::fstream& out, const Beidou_Dnav_Utc_M
void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Gps_Ephemeris>& eph_map) const
{
std::string line;
const auto sys_char = satelliteSystem.at("GPS");
const auto & sys_char = satelliteSystem.at("GPS");
for (const auto& gps_ephemeris_iter : eph_map)
{
@@ -3802,7 +3802,7 @@ void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Gps
void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Gps_CNAV_Ephemeris>& eph_map)
{
const auto sys_char = satelliteSystem.at("GPS");
const auto & sys_char = satelliteSystem.at("GPS");
for (const auto& gps_ephemeris_iter : eph_map)
{
@@ -3864,7 +3864,7 @@ void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Gps
void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Galileo_Ephemeris>& eph_map) const
{
const auto sys_char = satelliteSystem.at("Galileo");
const auto & sys_char = satelliteSystem.at("Galileo");
for (const auto& galileo_ephemeris_iter : eph_map)
{
@@ -3950,7 +3950,7 @@ void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Gal
void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Glonass_Gnav_Ephemeris>& eph_map) const
{
std::string line;
const auto sys_char = satelliteSystem.at("GLONASS");
const auto & sys_char = satelliteSystem.at("GLONASS");
for (const auto& glonass_gnav_ephemeris_iter : eph_map)
{
@@ -4099,7 +4099,7 @@ void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Gal
void Rinex_Printer::log_rinex_nav(std::fstream& out, const std::map<int32_t, Beidou_Dnav_Ephemeris>& eph_map) const
{
const auto sys_char = satelliteSystem.at("Beidou");
const auto & sys_char = satelliteSystem.at("Beidou");
for (const auto& bds_ephemeris_iter : eph_map)
{
src/algorithms/acquisition/adapters/base_pcps_acquisition.cc
+1
View File
@@ -77,6 +77,7 @@ BasePcpsAcquisition::BasePcpsAcquisition(
double opt_freq,
double code_length_chips,
uint32_t ms_per_code) : acq_parameters_(get_acq_conf(configuration, role, chip_rate, opt_freq, ms_per_code)),
gnss_synchro_(nullptr),
role_(role),
vector_length_(std::floor(acq_parameters_.sampled_ms * acq_parameters_.samples_per_ms) * (acq_parameters_.bit_transition_flag ? 2.0 : 1.0)),
code_length_(static_cast<unsigned int>(std::floor(static_cast<double>(acq_parameters_.resampled_fs) / (chip_rate / code_length_chips)))),
src/algorithms/acquisition/adapters/galileo_e1_pcps_ambiguous_acquisition.cc
+2 -1
View File
@@ -34,7 +34,8 @@ GalileoE1PcpsAmbiguousAcquisition::GalileoE1PcpsAmbiguousAcquisition(
GALILEO_E1_B_CODE_LENGTH_CHIPS,
GALILEO_E1_CODE_PERIOD_MS),
acquire_pilot_(configuration->property(role + ".acquire_pilot", false)),
cboc_(configuration->property(role + ".cboc", false))
cboc_(configuration->property(role + ".cboc", false)),
gnss_synchro_(nullptr)
{
}
src/algorithms/signal_source/gnuradio_blocks/labsat23_source.cc
+3 -6
View File
@@ -1287,17 +1287,14 @@ int labsat23_source::general_work(int noutput_items,
if (!d_is_ls3w && !d_is_ls4)
{
return parse_ls23_data(noutput_items, out);
return parse_ls23_data(noutput_items, std::move(out));
}
else if (d_is_ls3w) // Labsat 3 Wideband
{
return parse_ls3w_data(noutput_items, out);
return parse_ls3w_data(noutput_items, std::move(out));
}
else // Labsat 4
{
return parse_ls4_data(noutput_items, out);
return parse_ls4_data(noutput_items, std::move(out));
}
std::cout << "Warning!!\n";
return 0;
}