mirrors/gnss-sdr
1
0
Fork 0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2025-10-31 15:23:04 +00:00
Code Issues Releases Wiki Activity

Apply and add clang-tidy ckecks readability-make-member-function-const and readability-qualified-auto

Browse Source
This commit is contained in:
Carles Fernandez
2020-12-30 21:49:29 +01:00
parent 7308745f05
commit 21352a80d1
54 changed files with 187 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/algorithms/libs/gnss_sdr_create_directory.cc
View File

@@ -43,7 +43,7 @@ namespace errorlib = boost::system;
bool gnss_sdr_create_directory(const std::string& foldername)
{
std::string new_folder;
for (auto& folder : fs::path(foldername))
for (const auto& folder : fs::path(foldername))
{
new_folder += folder.string();
errorlib::error_code ec;

4
src/algorithms/libs/rtklib/rtklib_preceph.cc
View File

@@ -304,8 +304,8 @@ void readsp3b(FILE *fp, char type, int *sats __attribute__((unused)), int ns, co
/* compare precise ephemeris -------------------------------------------------*/
int cmppeph(const void *p1, const void *p2)
{
auto *q1 = static_cast<const peph_t *>(p1);
auto *q2 = static_cast<const peph_t *>(p2);
const auto *q1 = static_cast<const peph_t *>(p1);
const auto *q2 = static_cast<const peph_t *>(p2);
double tt = timediff(q1->time, q2->time);
return tt < -1e-9 ? -1 : (tt > 1e-9 ? 1 : q1->index - q2->index);
}

16
src/algorithms/libs/rtklib/rtklib_rtkcmn.cc
View File

@@ -3309,8 +3309,8 @@ int geterp(const erp_t *erp, gtime_t time, double *erpv)
/* compare ephemeris ---------------------------------------------------------*/
int cmpeph(const void *p1, const void *p2)
{
auto *q1 = static_cast<const eph_t *>(p1);
auto *q2 = static_cast<const eph_t *>(p2);
const auto *q1 = static_cast<const eph_t *>(p1);
const auto *q2 = static_cast<const eph_t *>(p2);
return q1->ttr.time != q2->ttr.time ? static_cast<int>(q1->ttr.time - q2->ttr.time) : (q1->toe.time != q2->toe.time ? static_cast<int>(q1->toe.time - q2->toe.time) : q1->sat - q2->sat);
}
@@ -3359,8 +3359,8 @@ void uniqeph(nav_t *nav)
/* compare glonass ephemeris -------------------------------------------------*/
int cmpgeph(const void *p1, const void *p2)
{
auto *q1 = static_cast<const geph_t *>(p1);
auto *q2 = static_cast<const geph_t *>(p2);
const auto *q1 = static_cast<const geph_t *>(p1);
const auto *q2 = static_cast<const geph_t *>(p2);
return q1->tof.time != q2->tof.time ? static_cast<int>(q1->tof.time - q2->tof.time) : (q1->toe.time != q2->toe.time ? static_cast<int>(q1->toe.time - q2->toe.time) : q1->sat - q2->sat);
}
@@ -3410,8 +3410,8 @@ void uniqgeph(nav_t *nav)
/* compare sbas ephemeris ----------------------------------------------------*/
int cmpseph(const void *p1, const void *p2)
{
auto *q1 = static_cast<const seph_t *>(p1);
auto *q2 = static_cast<const seph_t *>(p2);
const auto *q1 = static_cast<const seph_t *>(p1);
const auto *q2 = static_cast<const seph_t *>(p2);
return q1->tof.time != q2->tof.time ? static_cast<int>(q1->tof.time - q2->tof.time) : (q1->t0.time != q2->t0.time ? static_cast<int>(q1->t0.time - q2->t0.time) : q1->sat - q2->sat);
}
@@ -3488,8 +3488,8 @@ void uniqnav(nav_t *nav)
/* compare observation data -------------------------------------------------*/
int cmpobs(const void *p1, const void *p2)
{
auto *q1 = static_cast<const obsd_t *>(p1);
auto *q2 = static_cast<const obsd_t *>(p2);
const auto *q1 = static_cast<const obsd_t *>(p1);
const auto *q2 = static_cast<const obsd_t *>(p2);
double tt = timediff(q1->time, q2->time);
if (fabs(tt) > DTTOL)
{

4
src/algorithms/libs/rtklib/rtklib_sbas.cc
View File

@@ -730,8 +730,8 @@ void readmsgs(const char *file, int sel, gtime_t ts, gtime_t te,
/* compare sbas messages -----------------------------------------------------*/
int cmpmsgs(const void *p1, const void *p2)
{
auto *q1 = static_cast<const sbsmsg_t *>(p1);
auto *q2 = static_cast<const sbsmsg_t *>(p2);
const auto *q1 = static_cast<const sbsmsg_t *>(p1);
const auto *q2 = static_cast<const sbsmsg_t *>(p2);
return q1->week != q2->week ? q1->week - q2->week : (q1->tow < q2->tow ? -1 : (q1->tow > q2->tow ? 1 : q1->prn - q2->prn));
}

8
src/algorithms/libs/rtklib/rtklib_solution.cc
View File

@@ -982,8 +982,8 @@ int readsoldata(FILE *fp, gtime_t ts, gtime_t te, double tint, int qflag,
/* compare solution data -----------------------------------------------------*/
int cmpsol(const void *p1, const void *p2)
{
auto *q1 = static_cast<const sol_t *>(p1);
auto *q2 = static_cast<const sol_t *>(p2);
const auto *q1 = static_cast<const sol_t *>(p1);
const auto *q2 = static_cast<const sol_t *>(p2);
double tt = timediff(q1->time, q2->time);
return tt < -0.0 ? -1 : (tt > 0.0 ? 1 : 0);
}
@@ -1211,8 +1211,8 @@ void freesolstatbuf(solstatbuf_t *solstatbuf)
/* compare solution status ---------------------------------------------------*/
int cmpsolstat(const void *p1, const void *p2)
{
auto *q1 = static_cast<const solstat_t *>(p1);
auto *q2 = static_cast<const solstat_t *>(p2);
const auto *q1 = static_cast<const solstat_t *>(p1);
const auto *q2 = static_cast<const solstat_t *>(p2);
double tt = timediff(q1->time, q2->time);
return tt < -0.0 ? -1 : (tt > 0.0 ? 1 : 0);
}