Fix performance inefficiencies detected by Coverity Scan

src/algorithms/acquisition/adapters/beidou_b1i_pcps_acquisition.h

@@ -30,6 +30,7 @@
 #include <cstdint>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */

src/algorithms/acquisition/adapters/beidou_b3i_pcps_acquisition.h

@@ -29,6 +29,7 @@
 #include <cstdint>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -95,7 +96,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_8ms_ambiguous_acquisition.h

@@ -24,6 +24,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -92,7 +93,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_ambiguous_acquisition.h

@@ -27,6 +27,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -95,7 +96,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_ambiguous_acquisition_fpga.h

@@ -25,6 +25,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -121,7 +122,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_fpga_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_cccwsr_ambiguous_acquisition.h

@@ -24,6 +24,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -93,7 +94,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_quicksync_ambiguous_acquisition.h

@@ -24,6 +24,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -93,9 +94,10 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
+
     /*!
      * \brief Set statistics threshold of PCPS algorithm
      */

src/algorithms/acquisition/adapters/galileo_e1_pcps_tong_ambiguous_acquisition.h

@@ -24,6 +24,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -93,9 +94,10 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
+
     /*!
      * \brief Set statistics threshold of TONG algorithm
      */

src/algorithms/acquisition/adapters/galileo_e5a_noncoherent_iq_acquisition_caf.h

@@ -29,6 +29,7 @@
 #include "gnss_synchro.h"
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -93,7 +94,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e5a_pcps_acquisition.h

@@ -25,6 +25,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -86,7 +87,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e5a_pcps_acquisition_fpga.h

@@ -25,6 +25,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -121,7 +122,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_fpga_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e5b_pcps_acquisition.h

@@ -26,6 +26,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -117,7 +118,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e5b_pcps_acquisition_fpga.h

@@ -26,6 +26,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -120,7 +121,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_fpga_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/galileo_e6_pcps_acquisition.h

@@ -27,6 +27,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -95,7 +96,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/glonass_l1_ca_pcps_acquisition.h

@@ -29,6 +29,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -97,7 +98,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/glonass_l2_ca_pcps_acquisition.h

@@ -28,6 +28,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -96,7 +97,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_acquisition.h

@@ -31,6 +31,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * Classes for GNSS signal acquisition
@@ -101,7 +102,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_acquisition_fine_doppler.h

@@ -25,6 +25,7 @@
 #include "pcps_acquisition_fine_doppler_cc.h"
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -95,7 +96,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_acquisition_fpga.h

@@ -28,6 +28,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -122,7 +123,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_fpga_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_assisted_acquisition.h

@@ -25,6 +25,7 @@
 #include "pcps_assisted_acquisition_cc.h"
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -94,7 +95,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_opencl_acquisition.h

@@ -24,6 +24,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -92,7 +93,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_quicksync_acquisition.h

@@ -26,6 +26,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -95,7 +96,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_tong_acquisition.h

@@ -25,6 +25,7 @@
 #include <gnuradio/blocks/stream_to_vector.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -93,7 +94,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_cc_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l2_m_pcps_acquisition.h

@@ -28,6 +28,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -97,7 +98,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l2_m_pcps_acquisition_fpga.h

@@ -29,6 +29,7 @@
 #include <cstddef>  // for size_t
 #include <memory>   // for weak_ptr
 #include <string>   // for string
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -97,7 +98,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_fpga_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l5i_pcps_acquisition.h

@@ -28,6 +28,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 
 /** \addtogroup Acquisition
  * \{ */
@@ -96,7 +97,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_->set_channel_fsm(channel_fsm_);
     }
 

src/algorithms/acquisition/adapters/gps_l5i_pcps_acquisition_fpga.h

@@ -28,6 +28,7 @@
 #include <volk_gnsssdr/volk_gnsssdr_alloc.h>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 /** \addtogroup Acquisition
@@ -124,7 +125,7 @@ public:
      */
     inline void set_channel_fsm(std::weak_ptr<ChannelFsm> channel_fsm) override
     {
-        channel_fsm_ = channel_fsm;
+        channel_fsm_ = std::move(channel_fsm);
         acquisition_fpga_->set_channel_fsm(channel_fsm_);
     }