1
0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-10-30 22:56:17 +00:00
Commit Graph

55 Commits

Author SHA1 Message Date
FlashSystems
e9405ac810
Fix for Bug #6618 (#6628)
* Fix for Bug #6618

This Commit fixes Bug #6618. It is a little bit more complicated than
using one tiddler to store the new value for a field. Because the
following can happen:

* The user types "not-a-date" into the field value of a simple text field.
* The user now selects a field name that uses a HTML5 date editor. The
  Editor will show no date because the value cannot be parsed.
* The user saves the tiddler by clicking the checkmark.

Now the date-field contains the value "not-a-date" but the user was not
aware that this will be added. The edit control showed no date (because
the value was invalid) and the user assumed the field was empty and
won't be added to the tiddler.

To prevent this, every kind of field editor gets its own storage tiddler.
Its name is derived from the SHA256-hash of the name of the tiddler that
is returned by the Field Editor Cascade. That way every editor in the
cascade is only seeing its input. As long as the default setup (with one
default editor) is used, everything works like in 5.2.1.

This commit also fixes the bug that the after adding a field the
field-type input box was not focused again.

* Update Documentation for Field Editor Cascade

The fix for bug #6618 makes the handling of the tiddler backing the edit
operation much more complicated. See previous commit "Fix for Bug #6618"
for more details.
2022-05-14 13:30:04 +01:00
Cameron Fischer
5d69fe7bef
Trim Saga: Making existing trim tiddlers consistent (#6272)
* adding trim: AdvancedSearch Standard

* adding trim: tiddlers that had SOME trim already

* making all existing trim tiddlers consistent

* Forgot to properly indent this widget

* I don't THINK that space was important...

but I'm putting it back in

* Forgot one whitespace trim
2022-03-26 15:18:42 +00:00
FlashSystems
b529e69289
Add a cascade for rendering fields within the Edit Template (#6511)
* Allow the rendering of fields to be extended

This commit extends the `$:/core/ui/EditTemplate/fields` tiddler to
use a new cascade (Field Editor Cascade) to allow customizing the
rendering of the field editor.
It provides a default element for the cascade that displays the standard
EditTextWidget as a fallback. That way, the implementation is completely
backwards compatible. The `currentTiddler` and `currentField` variables
are available in the transcluded tiddler. This has the additional
benefit, that not only the `EditTextWidget` can be used. The user can
use a dropdown-list or even something completely crazy. As long as it
can be put into a tiddler that updates the field, it will be fine.

* Make `select` Tags in Fields look like the rest

This patch updates the CSS to make `tc-edit-texteditor` usable on
`select`-tags as well.

I'm not sure what `-webkit-appearance: none;` is for, but it hides the
DropDown-arrow in Chrome and makes the select-tag hard to discover. I've
changed the css to only apply it to the input tag. Maybe it can be
removed altogether.

* Add documentation for the Field Editor Cascade
2022-03-17 17:06:24 +00:00
Mario Pietsch
85835ebe42
fix 5424 add button is in new line (#5425) 2021-03-26 09:32:12 +00:00
Simon Huber
da66323dc5
Remove 2em of whitespace from EditTemplate when there are no visible fields (#5063)
* Remove 2em of whitespace from EditTemplate when there are no visible fields

* Update base.tid

* Update fields.tid

* Update fields.tid

* Update base.tid
2020-11-18 18:02:40 +00:00
Simon Huber
43061e64a6
Fix #5039 - Tag input, Type input and Fields inputs don't delete their state tiddlers on tiddler-cancel/delete (#5049)
* Update EditTemplate.tid

* Update EditTemplate.tid

* Update EditTemplate.tid

* Update tag-picker.tid

* Update tag-picker.tid

* Update type.tid

* Update fields.tid

* Update cancel.tid

* Update delete.tid

* Update type.tid

* Update ViewTemplate.tid
2020-11-16 16:54:29 +00:00
Simon Huber
a2b2e117e3
Delete all state tiddlers after adding a new field (#5045) 2020-11-15 15:49:43 +00:00
Simon Huber
458460354e
Add delete-field keyboard shortcut (#4978)
* Add delete-field keyboard-widget

* Update shortcuts.multids

* Update ShortcutInfo.multids

* Update fields.tid

* Update shortcuts.multids
2020-11-06 16:27:41 +00:00
Simon Huber
4a6aa865b3
Make Escape in keyboard-driven-inputs behave like in AdvancedSearch/Filter (#4961)
* Create focus-editor.js

* Update search.tid

* Update link-dropdown.tid

* Update search.tid

* Update Standard.tid

* Update Shadows.tid

* Update System.tid

* Update fields.tid

* Update tag-picker.tid

* Update Filter.tid

* Update clear.tid

* Update link-dropdown.tid

* Delete focus-editor.js
2020-11-02 19:08:24 +00:00
Simon Huber
b8fa6f0f0a
Fix keyboard-driven fieldname dropdown (#4930)
I've accidentally overwritten the correct file when adding the tc-small-gap classes ... SORRY!
2020-10-28 17:16:20 +00:00
Simon Huber
e71bf27dae
Replace various   with tc-small-gap classes (#4926)
* replace   by span.tc-small-gap-right

* replace  

* replace  

* replace  

* replace  

* replace  

* replace  

* replace  
2020-10-28 13:13:55 +00:00
Simon Huber
12be7ac7e9
Add ability to navigate fieldname-dropdown by keyboard (#4921)
* make fields EditTemplate navigatable by keyboard

* Add configuration tiddler for fieldname-dropdown filters

* Update base.tid
2020-10-28 11:59:36 +00:00
Simon Huber
84b6a85293
Fix css selector for edit template new field (#4783) 2020-07-31 14:49:09 +01:00
Simon Huber
17a36726fa
Fields EditTemplate: Correct positioning of dropdown (#4687)
* Add wrapper div to fields EditTemplate

* Add classes

* remove obsolete span

* Update base.tid
2020-06-11 12:18:31 +01:00
Simon Huber
e59f606566
Cancel popups when clicking within an editor (#4658)
* Add cancelPopups attribute to edit widget

* Add cancelPopups attribute to factory.js

* Cancel popups in editor/simple.js

* Cancel popups on focus in engines/framed.js

* Cancel popups on focus in CodeMirror engine

* Add cancelPopups="yes" to tag-picker

* Add cancelPopups="yes" to sidebar search

* Add cancelPopups="yes" to editor

* Add cancelPopups="yes" to fields EditTemplate

* Update body.tid

* Add cancelPopups="yes" to title EditTemplate

* Add cancelPopups="yes" to type EditTemplate

* Update EditTextWidget.tid

* Update EditWidget.tid

* Add cancelPopups="yes" to menubar plugin search

* Update tag-picker.tid

* Update tags.tid
2020-06-11 11:41:35 +01:00
Simon Huber
18151cc193
Make "type" input look consistent with "fields" input (#4358)
* add class tc-edit-texteditor to type field, trim ...

... whitespace, make look consistent

* define width 20% for type input field

* add second nbsp; for consistency with type input
2020-01-30 15:39:38 +00:00
Simon Huber
1cf2d0799d Fix field-name input (#4322) 2019-10-14 14:54:47 +01:00
Simon Huber
3c365a2567 EditTemplate optimizations (#4104)
#4093 and #4100 are bundled in this PR

* qualified state-tiddlers for the tags input and fieldname + fieldvalue inputs
* newTagName, newFieldNameTiddler and newFieldValueTiddler variables defined in EditTemplate (all qualified through `qualify` macro)
* save-tiddler-actions macro in the EditTemplate (reused by the save-tiddler button)
* enter (configurable) in the fieldvalue field adds the field and sets focus to the next fieldname input

Edit:

* storyview="pop" for fields list
2019-10-14 14:31:57 +01:00
Simon Huber
45def4def4 Fix focus in fields editTemplate (#4321)
the focus was set to the wrong field
2019-10-14 13:57:45 +01:00
Simon Huber
bfa3ddd077 Add two missing tooltips: add-tag button and add-field button (#4306)
* add tooltip to field add button

* Update EditTemplate.multids

* Update EditTemplate.multids

* add tooltip to tag-picker add button
2019-10-12 14:10:06 +01:00
Simon Huber
66b68f4a58 Allow configuration of default focus field of new tiddlers (#4238)
* add editFocus attribute to edit widget

* add focus condition to title editTemplate

* add focus condition to body-editor editTemplate

* add focus attribute to type editTemplate

* add focus attribute to fields editTemplate

* add focus attribute to tag-picker

* add $:/config/AutoFocus tiddler

... default focus is title

* Update Basics.tid

* Update ControlPanel.multids

* Create minifocusswitcher.tid

* Update minifocusswitcher.tid

* Update Basics.tid

* Update body-editor.tid
2019-10-12 12:04:10 +01:00
Simon Huber
00fb4190f2 Fix whitespace around fields inputs (II) (#4240) 2019-09-09 14:17:32 +01:00
Simon Huber
1873785ef6 Fix whitespace around field inputs (#4227) 2019-09-02 18:07:45 +01:00
Simon Huber
4ef9ccbab9 Fix bug with wikitext in fieldnames #4218 2019-08-30 10:44:23 +01:00
Simon Huber
62a7fa4203 Pop storyview for fields list in EditTemplate (#4148) 2019-08-02 15:05:30 +01:00
Simon Huber
638eb53429 Add tabindex attributes to edit templates (#3758)
* add tabindex attribute to editor-body edit-template

* add tabindex attr to fields edit-template

* add tabIndex variable to tags edit-template

* add tabindex attr to title edit-template

* add tabindex attr to type edit-template

* add tabindex attr to canonical-uri input

* add tabindex attr (as variable tabIndex) to tag-picker macro
2019-03-02 19:04:27 +01:00
Jermolene
a83cd3f984 Change logic of tv-hide-missing-links to tv-show-missing-links
See https://github.com/Jermolene/TiddlyWiki5/pull/3530#issuecomment-441368922
2018-11-24 15:53:39 +00:00
BurningTreeC
3f91d5b3a1 Add tv-override-missing-links to fix links to missing tiddlers (#3530)
* add tv-override-missing-links variable

this lets us set `tv-override-missing-links` true so that we can fix edge cases like the `Filter` dropdown in the `Advanced Search` when `enable missing links` is unchecked in the `Settings` tab of the Control Panel

* add tv-override-missing-links to filter dropdown

* add tv-override-missing-links to type dropdown

* add tv-override-missing-links to fieldname dropd

* add tv-override-missing-links to TagManager(icons)

* undo tv-override-missing-links TagManager

not needed here

* Update link.js

* Update dropdown.tid

* Update fields.tid

* Update type.tid

* Update dropdown.tid

* Update link.js

* simplify all together

* add tv-hide-missing-links to pagetemplate

* do we need to refresh here...

... if the variable gets set on top of the pagetemplate?
2018-11-24 13:36:48 +00:00
Tobias Beer
f26bcb273b Fix new field value handling in edit template (#3048)
prevents variables in the value from being replaced when adding a new field
2018-04-24 22:03:59 +01:00
Tobias Beer
d038e0bc1b Filter titles in new fieldname popup by entered string (#2585) 2016-10-08 12:18:19 +01:00
Jermolene
31ebbb2d7d Add translatable strings for type dropdown 2015-07-01 15:58:49 +01:00
Jeremy Ruston
062aa03c5a Merge pull request #1849 from Infurnoape/master
Update fields.tid
2015-07-01 15:40:25 +01:00
Andrew J Harrison
7ad15bc248 Update fields.tid
Add a new field drop down
2015-06-29 10:45:41 -07:00
Jermolene
3e1b84064a Improved fix for illegal field name problem
Better fix for the problem identified in 9b4b9d4
2015-05-18 22:16:04 +01:00
Jermolene
5a6249894d Fix problem with field names containing special characters
The characters `> / ' " =` were causing problems.

Thanks @ericshulman
2015-05-18 19:29:10 +01:00
Jermolene
f3ed9bf7e4 Fix problem with double quotes in new field value
Fixes #1634
2015-04-03 09:06:57 +01:00
Jermolene
2689e2861b Revert to using fieldmangler for adding fields
In 5.1.5 we switched to using `<$action-setfield>` instead of
`<$fieldmangler>`. The problem was that in the process we lost the
validation of field names, making it possible to create fields with
illegal names

Fixes #1186
2014-12-04 09:39:14 +00:00
Jermolene
09a3f94d79 Accessibility fixes
Fixes for accessibility issues raised here:

https://groups.google.com/d/topic/tiddlywiki/C6lSabtpdEI/discussion
2014-11-07 21:15:21 +00:00
Jermolene
92f69d44bf Use action-deletefield widget in edit template fields editor
On the way to deprecating the field mangler widget
2014-11-06 18:32:11 +00:00
Jermolene
da1f9f7d22 Add input box for new field value to edit template 2014-11-06 18:24:33 +00:00
Jermolene
2f69ea362c Rename "tw-*" messages to "tm-*" 2014-08-28 21:43:44 +01:00
Jermolene
1814d502a4 Convert more "tw-*" classes to "tc-*" 2014-08-28 18:47:21 +01:00
Jermolene
d0cbd34bf9 Rename "btn-invisible" class to "tc-btn-invisible"
Part of #764
2014-08-28 17:28:32 +01:00
Jermolene
be8c753f28 Fix formatting of edit fields 2014-08-10 09:13:56 +01:00
Jermolene
d357e1706c Allow visible edit fields to be configured
Create a tiddler “$:/config/EditTemplateFields/Visibility/fieldname”
with the text “hide” to hide a particular field
2014-08-01 17:03:53 +01:00
nameanyone
157ca0c8aa Rename $:/temp/NewFieldName to $:/temp/newfieldname
As per "Naming of System Tiddlers"
2014-05-15 22:54:46 -07:00
Jermolene
f08c4aa525 Arrange fields alphabetically in the edit template 2014-04-09 11:31:27 +01:00
Jermolene
597b8ca4b1 Ensure fieldnames are not wikified
`__proto__` was being wikified into underlined text
2014-04-06 22:49:59 +01:00
Jermolene
b7f674c51a First pass at refactoring filter execution
This is the beginning of addressing #523.
2014-04-03 20:49:16 +01:00
Jermolene
4ee277f41b Fix some missing translateables 2014-02-21 14:27:49 +00:00