1
0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-06-29 08:43:14 +00:00
Commit Graph

703 Commits

Author SHA1 Message Date
Jeremy Ruston
9d9b00bdb5 Merge branch 'master' into single-tiddler-mode 2020-04-02 11:45:01 +01:00
Jeremy Ruston
b95723a022
Fix syncer to handler errors properly (#4373)
* First commit

* Add throttling of saves

Now we refuse to save a tiddler more often than once per second.

* Wait for a timeout before trying again after an error

* Modest optimisations of isDirty() method

* Synchronise system tiddlers and deletions from the server

Fixes two long-standing issues:

* Changes to system tiddlers are not synchronised from the server to the browser
* Deletions of tiddlers on the server are not propagated to browser clients

* Make sure we update the dirty status even if there isn't a task to perform

* Replace save-wiki button with popup sync menu

* Remove the "Server" control panel tab

We don't need it with the enhanced sync dropdown

* Add indentation to the save-wiki button

* Fix spacing in dropdown menu items

* Switch between cloud icons according to dirty status

* Add a menu item to copy syncer logs to the clipboard

* Improve animated icon

* Remove indentation from save-wiki button

@pmario the annoying thing is that using `\trim whitespace` trims significant whitespace too, so it means we have to use <$text text=" "/> when we need a space that won't be trimmed. For the moment, I've removed the indentation but will keep thinking about it.

* Further icon, UI and copy text tweaks

Move the icons and styles from the core into the TiddlyWeb plugin

* Clean up PR diff

* Tweak animation durations

* Break the actions from the syncer dropdown into separate tiddlers

@pmario I think this makes things a bit easier to follow

* Refactor syncadaptor creation and logging

The goal is for the syncadaptor to be able to log to the same logger as the syncer, so that the "copy syncer logs to clipboard" data is more useful.

* Don't transition the dirty indicator container colour, just the SVG's colour

* Only trigger a sync for changes to tiddlers we're interested in

Otherwise it is triggered by the creation of the alert tiddlers used to display errors.

* Restore deleting local tiddlers removed from the server

(I had commented it out for some testing and accidentally commited it).

* Guard against missing adaptor info

* We still need to trigger a timeout when there was no task to process

* Avoid repeatedly polling for changes

Instead we only trigger a timeout call at if there is a pending task (ie a tiddler that has changed but isn't yet old enough to save).

* Lazy loading: include skinny versions of lazily loaded tiddlers in the index.html

* Introduce _is_skinny field for indicating that a tiddler is subject to lazy loading

* Remove savetrail plugin from prerelease

It doesn't yet work with the new syncer

* Make the savetrail plugin work again

* Clear outstanding alerts when synchronisation is restored

* Logger: only remove alerts from the same component

Missed off 9f5c0de07

* Make the saving throttle interval configurable (#4385)

After switching Bob to use the core syncer the throttle interval makes saving feel very sluggish compared to the message queue setup that I had before.
The editing lock that I use to prevent conflicts with multiple users doesn't go away until the save is completed, and with the 1 second delay it means that if you edit a tiddler and save it than you have to wait one second before you can edit it again.

* Tweaks to appearance of alerts

* Exclude temp tiddlers from offline snapshots

Otherwise alerts will persist

* Tweak appearance of status line in dropdown

* Update release note

* Web server: Don't include full path in error messages

Fixes #3724

* In change event handler check for deletions

* Disable the official plugin library when the tiddlyweb plugin is loaded

* Hide error details from browser for /files/ route

See https://github.com/Jermolene/TiddlyWiki5/issues/3724#issuecomment-565702492 -- thanks @pmario

* Revert all the changes to the relationship between the syncer and the syncadaptor

Previously we had some major rearrangements to make it possible for the syncadaptor to route it's logging to the logger used by the syncer. The motivation is so that the "copy logs to clipboard" button is more useful.

On reflection, changing the interface this drastically is undesirable from a backwards compatibility perspective, so I'm going to investigate other ways to achieve the logger sharing

* Make the tiddlyweb adaptor use the syncer's logger

So that both are availavble when copying the syncer logs to the clipboard

* Update release note

* Support setting port=0 to get an OS assigned port

Quite useful

* Update code comment

* UI: Use "Get latest changes from server" instead of "Refresh"

* Add getUpdatedTiddlers() method to syncadaptor API

See https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-573579495

* Refactor revision handling within the syncer

Thanks @pmario

* Fix typo in tiddlywebadaptor

* Improve presentation of errors

See https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-573695267

* Add docs for getTiddlerRevision()

* Remove unused error animation

* Update comment for GET /recipes/default/tiddlers/tiddlers.json

* Optimise SVG cloud image

* Add optional list of allowed filters for get all tiddlers route

An attempt to address @Arlen22's concern here:

https://github.com/Jermolene/TiddlyWiki5/pull/4373#pullrequestreview-342146190

* Fix network error alert text translatability

* Fix error code and logging for GET /recipes/default/tiddlers/tiddlers.json

Thanks @Arlen22

* Flip GET /recipes/default/tiddlers/tiddlers.json allowed filter handling to be secure by default

* Validate updates received from getUpdatedTiddlers()

* Add syncer method to force loading of a tiddler from the server

* Remove the release note update to remove the merge conflict

* Fix crash when there's no config section in the tiddlywiki.info file

* Use config tiddler title to check filter query (merge into fix-syncer) (#4478)

* Use config tiddler title to check filter query

* Create config-tiddlers-filter.tid

* Add config switch to enable all filters on GET /recipes/default/tiddlers/tiddlers.json

And update docs

* Fix bug when deleting a tiddler with a shadow

Reported by @kookma at https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-604027528

Co-authored-by: jed <inmysocks@fastmail.com>
Co-authored-by: Arlen22 <arlenbee@gmail.com>
2020-03-30 15:24:05 +01:00
Jeremy Ruston
cb52d709c2 Improve ability to disable drag and drop
Now we disable the draggable list macros too.
2020-03-20 10:46:17 +00:00
Jeremy Ruston
bc687e5783 Add a hidden setting for disabling the page dropzone 2020-03-15 14:46:33 +00:00
Matthias Bilger
62f8c9353e
Use CamelCase for Gitea (#4496) 2020-03-13 17:36:05 +00:00
Matthias Bilger
52a9f928ae
Added gitea saver (#4491)
* added gitea saver

* create nonexistent file
2020-03-12 15:53:55 +00:00
Jeremy Ruston
ae9ce4f01c ViewTemplate: Add tc-tiddler-overridden-shadow class 2020-03-09 20:31:42 +00:00
Jeremy Ruston
6091b01386 Add hidden setting for default tiddler icon 2020-03-06 14:52:37 +00:00
Jeremy Ruston
6cdffc4eae Fix broken filters introduced in b179a6011
The mistake arose because browser local storage was enabled
2020-02-29 15:56:22 +00:00
Jeremy Ruston
b179a60111 Tweak some system buttons to look better in the new menu bar
The reveal widget leaves behind an unnecessary span, which breaks the CSS used to target the button.
2020-02-28 14:34:06 +00:00
Lee Sheng Long
96eca32b11
Add download button/link to binary tiddler warning banners in view and edit mode (#4423) 2020-01-31 09:13:28 +00:00
Simon Huber
5d0e4732b2
Add "none" as an option in the icon dropdown in tag manager (#4361)
* add no-icon option to tagmanager and add ...

... whitespace trims

* Update Misc.multids
2020-01-30 15:52:33 +00:00
Simon Huber
18151cc193
Make "type" input look consistent with "fields" input (#4358)
* add class tc-edit-texteditor to type field, trim ...

... whitespace, make look consistent

* define width 20% for type input field

* add second nbsp; for consistency with type input
2020-01-30 15:39:38 +00:00
Jeremy Ruston
f256b7791d Merge branch 'master' into single-tiddler-mode 2020-01-17 13:06:07 +00:00
Jeremy Ruston
66fc63ed7f Revert "Merge branch 'master' into single-tiddler-mode"
This reverts commit f703330962.
2020-01-17 13:01:39 +00:00
Jeremy Ruston
f703330962 Merge branch 'master' into single-tiddler-mode 2020-01-17 12:54:51 +00:00
Jeremy Ruston
7795ed9230 Fix stamp dropdown not transcluding caption field 2020-01-15 20:29:13 +00:00
Simon Huber
f59d044a8c Replace "&times" with close-button in keyboard-shortcuts (#4406)
this PR replaces the `&times` in the keyboard-shortcuts dropdown with the `$:/core/images/close-button`
2020-01-05 13:13:39 +00:00
Jeremy Ruston
e3835c64da Restore whitespace for page control buttons
Even with whitespace trim, we need a single space between the icon and text
2020-01-04 16:44:33 +00:00
Simon Huber
75ba862a7e Fix "remove" tooltip in keyboard shortcuts (#4405)
this PR just fixes the tooltip of the small "remove" button in the keyboard-shortcut dropdown
2020-01-04 11:25:43 +00:00
Jeremy Ruston
5a5c967a39 Add support for $:/tags/Macro/View macros that are only visible within view templates 2020-01-03 10:40:11 +00:00
Jeremy Ruston
144ec28552 Update class settings in edit template to match view template
@pmario this adds the tc-tagged- classes to the edit template, do you think that's useful?
2019-12-17 12:01:59 +00:00
Mario Pietsch
2deed528bc Remove &nbsp from tag pill in edit mode (#4366)
* remove &nbsp from tag pill in edit mode

PR: fix missing space between edittemplate tags #3585 introduced an unbreakable space ...

The `&nbsp` isn't needed and **causes problems**, if users copy&paste the tag text, because the "new" tag in the text input field now contains an space in front of the tag. This space invalidates the tag, so it doesn't function anymore. 

see [comment in GG](https://groups.google.com/d/msg/tiddlywiki/RQEyqPQIZSM/uaU7lgJJAAAJ) .. I also had a problem like this some time ago, which costed me several hours of debugging.

* Update base.tid

* Update tag.tid
2019-11-07 12:39:14 +00:00
Simon Huber
1cf2d0799d Fix field-name input (#4322) 2019-10-14 14:54:47 +01:00
Simon Huber
3c365a2567 EditTemplate optimizations (#4104)
#4093 and #4100 are bundled in this PR

* qualified state-tiddlers for the tags input and fieldname + fieldvalue inputs
* newTagName, newFieldNameTiddler and newFieldValueTiddler variables defined in EditTemplate (all qualified through `qualify` macro)
* save-tiddler-actions macro in the EditTemplate (reused by the save-tiddler button)
* enter (configurable) in the fieldvalue field adds the field and sets focus to the next fieldname input

Edit:

* storyview="pop" for fields list
2019-10-14 14:31:57 +01:00
Simon Huber
45def4def4 Fix focus in fields editTemplate (#4321)
the focus was set to the wrong field
2019-10-14 13:57:45 +01:00
Simon Huber
7af24d217a Make tags in controlpanel animate (#4320) 2019-10-14 13:57:28 +01:00
Jeremy Ruston
73bb27fd77 Tweak autofocus text in control panel
Also made the trailing punctuation more consistent
2019-10-14 13:19:08 +01:00
Simon Huber
daa24a52bd Add default new-tiddler and new-journal tags mechanism and... (#4314)
* Update Basics.tid

* Update ControlPanel.multids

* Update NewJournal.multids

* Create NewJournalTags.tid

* Update new-tiddler.tid

* Update new-image.tid

* Update new-journal.tid

* Update new-here.tid

* Update new-journal-here.tid
2019-10-13 16:53:52 +01:00
Simon Huber
89728d8a9a Make tag-picker add-tag button more consistent II (#4313)
* Update tag-picker.tid

* Update tags.tid

* Update tag-picker.tid
2019-10-13 16:53:40 +01:00
Simon Huber
4cf96e7339 Revert "Fix: make tag-picker "add-tag" button more consistent (#4199)" (#4311)
This reverts commit 74172b35ce.
2019-10-13 10:19:44 +01:00
Simon Huber
f0779b58ac Revert "Add default new tiddler tags mechanism and interface (#4307)" (#4312)
This reverts commit 007fc8239b.
2019-10-13 10:19:07 +01:00
Simon Huber
007fc8239b Add default new tiddler tags mechanism and interface (#4307)
* Update ControlPanel.multids

* Update Basics.tid

* Update new-tiddler.tid

* Update new-journal.tid

* Update new-image.tid

* Update new-here.tid

* Update new-journal-here.tid

* Update new-tiddler.tid

* Update new-image.tid

* Update new-journal.tid

* Update new-tiddler.tid

* Update new-image.tid

* Update new-here.tid

* Update new-journal-here.tid

* Update Basics.tid

* Update Basics.tid
2019-10-12 16:30:59 +01:00
Simon Huber
ea6113b255 Fix CamelCase AutoFocus in ControlPanel (#4308)
* from AutoFocus to ~AutoFocus

* Update minifocusswitcher.tid

* Update Basics.tid

* Update body-editor.tid
2019-10-12 15:10:24 +01:00
Simon Huber
bfa3ddd077 Add two missing tooltips: add-tag button and add-field button (#4306)
* add tooltip to field add button

* Update EditTemplate.multids

* Update EditTemplate.multids

* add tooltip to tag-picker add button
2019-10-12 14:10:06 +01:00
Simon Huber
66b68f4a58 Allow configuration of default focus field of new tiddlers (#4238)
* add editFocus attribute to edit widget

* add focus condition to title editTemplate

* add focus condition to body-editor editTemplate

* add focus attribute to type editTemplate

* add focus attribute to fields editTemplate

* add focus attribute to tag-picker

* add $:/config/AutoFocus tiddler

... default focus is title

* Update Basics.tid

* Update ControlPanel.multids

* Create minifocusswitcher.tid

* Update minifocusswitcher.tid

* Update Basics.tid

* Update body-editor.tid
2019-10-12 12:04:10 +01:00
Simon Huber
74172b35ce Fix: make tag-picker "add-tag" button more consistent (#4199)
* make tag-picker add-button compliant with enter-actions

... the `$actions$` way throws a filter syntax error in some cases, the `<<add-tag-actions>>` way is more solid

* Update tags.tid

remove tag-picker-actions
2019-10-12 10:01:27 +01:00
Simon Huber
9ed45cfaad Add whitespace trim to SideBarSegments search (#4302) 2019-10-12 09:24:05 +01:00
Jeremy Ruston
e9211b0eee Allow sidebar tabs to be independently targeted via CSS 2019-10-11 10:57:29 +01:00
Simon Huber
8efd0ace34 Missing whitespace trim in PageControls (#4293)
* add whitespace trim to advanced search button

* add whitespace trim to new tiddler

* add whitespace trim to new journal

* add whitespace trim to new image

* add whitespace trim to control panel button

* add whitespace trim to tiddler manager button

* add whitespace trim to language button

* add whitespace trim to palette button

* add whitespace trim to theme button

* add whitespace trim to storyview button

* add whitespace trim to timestamp button

* add whitespace trim to encryption button

* add whitespace trim to tag-manager button
2019-10-07 15:13:55 +01:00
Jeremy Ruston
89716bb81d Add class identifying the tiddler body editor
See https://groups.google.com/d/msgid/tiddlywiki/13fb3572-4259-46c3-9cc7-6ed85b636177%40googlegroups.com
2019-10-06 14:58:45 +01:00
Jeremy Ruston
0e771e2419 Fix currentTiddler in pagecontrol buttons
Bug introduced in 8db893b9c9

Fixes #4283
2019-10-03 12:13:29 +01:00
Jeremy Ruston
55e3b8d66d Plugin improvements
* Improve docs
* Improve styling of subplugins
2019-09-28 11:49:09 +01:00
Jeremy Ruston
ded9d4074c Plugin library chooser improvements
* Make "Also requires:" translatable
* Clearer styling for sub-plugins
* Documentation tweaks
2019-09-28 10:06:18 +01:00
Jeremy Ruston
93e01435d1 Dynamic plugins: Change "contains JavaScript" to "requires reload"
We might in the future offer support for certain types of JS module to be hot loaded.
2019-09-27 16:47:55 +01:00
Jeremy Ruston
e752ba7c6a Use the dependents and parent-plugin fields to automatically install dependencies 2019-09-25 21:57:22 +01:00
Jeremy Ruston
92340d81cc Introduce "parent-plugin" field to control how plugins are displayed in the chooser
"Sub-plugins" are displayed within the dropdown of their parent plugin.

This is a more elaborate version of #4109. It doesn't address dependent plugins (yet), this is just about grouping addon plugins under their parent.
2019-09-25 16:16:28 +01:00
Jeremy Ruston
db2ed63e54 Fix formatting of plugin listing in control panel
And make some minor tweaks across the plugin chooser too
2019-09-20 14:30:52 +01:00
Jeremy Ruston
d91fcd990e Improve appearance of plugin chooser 2019-09-19 13:20:07 +01:00
Jeremy Ruston
1c23059204
Dynamic loading/unloading of plugins (#4259)
* First pass at dynamic loading/unloading

* Show warning for changes to plugins containing JS modules

* Use $:/config/RegisterPluginType/* for configuring whether a plugin type is automatically registered

Where "registered" means "the constituent shadows are loaded".

* Fix the info plugin

The previous mechanism re-read all plugin info during startup

* Don't prettify JSON in the plugin library

* Indicate in plugin library whether a plugin requires reloading

* Display the highlighted plugin name in the plugin chooser

And if there's no name field fall back to the part of the title after the final slash.
2019-09-16 12:15:39 +01:00