jeremy@jermolene.com
b426724f35
Fix macrocall refresh issue
...
It turns out that this.transcludeTitle is always truthy, even if we are transcluding a variable
Fixes #7001
2022-10-20 15:08:05 +01:00
jeremy@jermolene.com
3a4589dc79
Transcluding functions: fix missing parameters passed as undefined
...
Thanks @btheado – see https://github.com/Jermolene/TiddlyWiki5/pull/6666#issuecomment-1276187372
2022-10-12 17:15:39 +01:00
jeremy@jermolene.com
e3d13696c8
Remove implementation of $:/globals/
...
Performance with this implementation is inherently poor because of the need to perform a wiki lookup for each child widget created.
2022-09-24 12:56:06 +01:00
jeremy@jermolene.com
8f9d5cabaa
Missing tests for parameters widget
2022-09-16 16:07:32 +01:00
jeremy@jermolene.com
e3697e29bb
When transcluding functions, pass an empty item list to the filter, and just return the first item
2022-09-09 10:22:06 +01:00
jeremy@jermolene.com
11e0c66a4c
Transcluded functions should operate on the entire store
2022-09-03 20:11:45 +01:00
jeremy@jermolene.com
a439cb58be
Fix caching of parse variables/macros/procedures
2022-09-03 20:11:23 +01:00
jeremy@jermolene.com
9317804464
FIx transcluding of functions
...
This first implementation concatenates the results of the filter (with no separator) and then wikifies the result.
The test in this commit is quite interesting...
2022-08-04 09:28:56 +01:00
jeremy@jermolene.com
30f7b37cba
Make use of type attribute consistent
2022-07-18 19:44:37 +01:00
jeremy@jermolene.com
defe3e42e6
Adjust naming of transclusion metaparameter
2022-06-05 16:10:41 +01:00
jeremy@jermolene.com
7680280d87
Fix typo
2022-06-05 15:59:03 +01:00
jeremy@jermolene.com
542df63ccf
Simplify metaparameters implementation
2022-06-03 11:21:32 +01:00
jeremy@jermolene.com
c42df2233a
Make slot fill data available to transclusions
...
Allows transcluded content to dynamically process <$fill> widgets within the calling transclusion
2022-06-03 08:53:51 +01:00
jeremy@jermolene.com
613f4af20f
Fix refreshing of global variables
...
Global variables access within attributes will automatically trigger a refresh if the attribute text changes, but that wasn't happening for transclusions.
2022-05-31 09:19:01 +01:00
jeremy@jermolene.com
006ae6e759
Refactor $parameters widget
...
The objective is to add a $depth attribute so that it is possible to reach up to retrieve the parameters of ancestor transclusions. However, doing so requires changing the encoding of parameter names so that it is not possible for a user parameter to clash with an attribute like $depth. So now we have to double up dollars on any attribute names seen by the parameters widget, just like with the transclude widget itself.
2022-05-31 09:03:20 +01:00
jeremy@jermolene.com
22e7ec2381
Procedures and widgets inherit whitespace trim setting from their definition
2022-05-23 15:30:33 +01:00
jeremy@jermolene.com
ec1ec8ccd8
Fix invocation of JS macros
2022-05-21 16:31:34 +01:00
jeremy@jermolene.com
bbd9e2f243
Rename <$value> widget to <$fill>
2022-05-13 09:18:25 +01:00
jeremy@jermolene.com
36cf50aa96
Use \widget for custom widget definitions, and remove need for angle brackets
...
Need to do some refactoring of all those isFunctionDefinition/isProcedureDefinition/isWidgetDefinition flags into a single property
2022-05-13 08:49:53 +01:00
jeremy@jermolene.com
904e30a0e2
Detect recursion by tracking widget tree depth
...
The old recursion marker approach was very slow, and didn't catch test cases like editions/test/tiddlers/tests/data/transclude/Recursion.tid
2022-05-12 16:26:33 +01:00
jeremy@jermolene.com
774459fa73
Transclude: replace paramNames/paramValues with more robust JSON payload
...
More details at https://github.com/Jermolene/TiddlyWiki5/pull/6666#issuecomment-1123719153
2022-05-11 13:51:11 +01:00
jeremy@jermolene.com
0b11b499c2
Better backwards compatibility for legacy recursion marker
...
Fixes the problem with tag dropdowns @btheado
2022-05-10 10:21:56 +01:00
jeremy@jermolene.com
e092113f9f
Switch to using \procedure to define new-style macros, and \function for custom filter operator functions
...
I now need to update the OP!
2022-05-09 18:00:09 +01:00
jeremy@jermolene.com
64448ae774
Make the macrocall widget delegate to the transclude widget
2022-05-08 20:48:33 +01:00
jeremy@jermolene.com
e9630328f1
Extend transclude widget to work with old-style macros and use it for the macrocall shortcut syntax
2022-05-08 15:59:20 +01:00
jeremy@jermolene.com
9be05f6f38
Use consistent parse tree node property for params
2022-05-07 13:22:53 +01:00
jeremy@jermolene.com
a9938a6c67
Improve recursion detection
...
While retaining backwards compatibility
2022-05-06 15:00:10 +01:00
jeremy@jermolene.com
f307f00e32
Fixes to enable the transclude widget itself to be overridden
...
There are two big changes here:
Replace the previous "ts-wrapper" mechanism, which we had been using to redefine custom widgets inside their definitions to prevent recursive calls. Now we've got the genesis widget we can instead control recursion through a new "$remappable" attribute that allows the custom widget mechanism to be skipped.
We also extend the slot widget to allow a depth to be specified; it then reaches up by the indicated number of transclusion widgets to find the one from which it should retrieve the slot value.
2022-05-05 08:20:14 +01:00
jeremy@jermolene.com
e99137f4cc
Cache parse trees when transcluding variables
2022-05-03 17:59:45 +01:00
jeremy@jermolene.com
e1df50d981
Fix parameter handling
2022-05-03 12:54:29 +01:00
jeremy@jermolene.com
3000d3339c
Remove extraneous code
2022-05-03 08:11:00 +01:00
jeremy@jermolene.com
a10106a4a6
Fix crash when transcluding an undefined variable
...
Thanks @pmario
See https://github.com/Jermolene/TiddlyWiki5/pull/6666#issuecomment-1114692359
2022-05-02 11:15:18 +01:00
jeremy@jermolene.com
bbc6661192
Remove erroneous "tag" property
2022-05-02 09:26:18 +01:00
jeremy@jermolene.com
c9bd1b5274
Add wikitext shortcut for new-style function definitions
2022-04-30 12:44:26 +01:00
jeremy@jermolene.com
aac2d6ccb0
Refactor ubertransclude functionality into transclude widget
2022-04-30 09:54:55 +01:00
jeremy@jermolene.com
c4991fff9e
Refactor transclude widget before uberfying it
2022-04-30 09:30:25 +01:00
jeremy@jermolene.com
753bf8fe62
Revert "Revert "Transclude widget: refresh selectively when needed ( #5736 )""
...
This reverts commit 4f9dd50382
2021-06-02 21:45:06 +01:00
jeremy@jermolene.com
4f9dd50382
Revert "Transclude widget: refresh selectively when needed ( #5736 )"
...
This reverts commit 2e695801b1
2021-06-02 19:14:05 +01:00
Saq Imtiaz
2e695801b1
Transclude widget: refresh selectively when needed ( #5736 )
...
* Transclude widget: only refresh when transcluded text reference has changed, includes tests
* Refactor wiki.parseTextReference so it is re-usable for getting the parser info
* Re-arrange methods in wiki.js to improve diff readability
2021-06-02 13:58:30 +01:00
Joe Bordes
82ec63e711
style(App) eliminate whitespace at the end of code lines ( #5735 )
2021-05-30 19:20:17 +01:00
jeremy@jermolene.com
28521d82f3
Revert "Extend transclude widget to optionally set variables"
...
Actually a partial reversion, because we're keeping the minor refactoring of makeChildWidget() in widget.js
This reverts commit 80ee5adb14
2021-04-02 09:47:38 +01:00
jeremy@jermolene.com
7f202f35b4
Minor refactoring for clarity
...
See 9af68297cd (r48540814)
2021-03-22 09:50:54 +00:00
jeremy@jermolene.com
9af68297cd
Fix transclusion refreshing
...
Missed off 80ee5adb14
2021-03-19 16:14:15 +00:00
jeremy@jermolene.com
80ee5adb14
Extend transclude widget to optionally set variables
...
Partially fixes #5199
2021-03-19 15:37:59 +00:00
saqimtiaz
5aa4e4cb68
Initial support for switching page templates ( #4979 )
...
* Add support for switching page templates
* Revert "Add support for switching page templates"
This reverts commit dbf7682d47
2020-11-07 09:51:01 +00:00
Myeongjin
6388f859d1
Add localisable strings for error ( #2447 )
...
* Add localisable strings for error
* Update tiddler Transclusion Basic Usage in fr-FR
2016-05-17 21:58:47 +01:00
Myeongjin
8afc1e9354
Add localisable strings ( #2438 )
...
* Add localisable string for recursive transclusion error
* Add localisable string for count
* Add localisable strings for syncer
2016-05-12 08:44:28 -06:00
Jermolene
61af1f9379
Add error formatting for transclusion recursion errors
2014-09-24 11:50:38 +02:00
Jermolene
7953b95d13
Include subtiddler in transclusion recursion detection
2014-08-07 15:43:48 +01:00
Jermolene
f793816dfa
Add subtiddler support to the transclude widget
...
Useful to be able to reach into plugins. It will enable us to do things
like extract readmes from themes that are not active.
2014-07-17 18:41:20 +01:00
