Fixes#4082
This version removes selective updating of the tag index, instead completely clearing the index on each update. I'm investigating restoring that optimisation.
The test rig previously used a simplified implementation of shadow tiddlers which broke with the new indexing engine. There was also a problem that made that even if indexers were disabled they were still initialised.
This PR fixes both problems, in preparation for fixing #4082
See discussion at https://groups.google.com/d/msgid/tiddlywiki/526754d5-8786-49cd-aaa1-c77311670116%40googlegroups.com:
The history here is that in v5.1.14 we added an "actions" attribute to the checkbox widget that specified an action string to be specified whenever the state of the checkbox changed. The same action string is executed regardless of whether the checkbox was checked or unchecked.
Then in v5.1.16 we merged https://github.com/Jermolene/TiddlyWiki5/pull/3182 which added the "uncheckactions" attribute. The difference between the two is that the uncheckactions are only executed if the checkbox is unchecked. The main "actions" attribute is executed before any actions in "uncheckactions", which makes it possible to arrange things so that the "actions" attribute sets things to the checked state while the "uncheckactions" attribute overwrites those changes to set things to the unchecked state.
In retrospect, it would have made more sense to have also added a "checkactions" attribute that was executed only if the checkbox was checked. I'll investigate adding it for v5.1.20.
Regarding the bulleted tag pills; they should probably also be removed in place of text but I see value in keeping them for the sake of being able to easily peek at what they tag. We should probably have a section under Ctrlpanel>Settings where any startupaction-tiddlers are listed but since we don't yet, then the mentioned tag pills could perhaps remain.... except for the one in the PR.
Include = before each number in the Mathematics Operators examples,
so that people get used to seeing that in math examples where dupes
are likely.
Only the Mathematics Operators tiddler really needed to be changed;
the example tiddlers for individual operators were already using =.
Fixes#3979.
* First pass at modular wiki indexes
An exploratory experiment
* Fix tests
* Faster checking for existence of index methods
We don't really need to check the type
* Use the index for the has operator
* Fix typo
* Move iterator index methods into indexer modules
Now boot.js doesn't know the core indexers
* Fix up the other iterator index functions
* Fix crash with missing index branch
* Limit the field indexer to values less than 128 characters
* Fallback to the old manual scan if the index method returns null
* Sadly, we can no longe re-use the field indexer to accelerate the `has` operator, because the index now omits tiddlers that have field values longer than the limit
Still need to make the index configuration exposed somehow
* Rearrange tests so that we can test with and without indexers
We also need to expose the list of enabled indexers as a config option
* Test the field indexer with different length fields
So that we test the indexed and non-indexed codepaths
* Update TiddlyWiki5 Squared by Iannis Zannos.tid
Link no longer works. Changed it to the github page.
* Update TiddlyWiki5 Squared by Iannis Zannos.tid
Fixed URL linking to the "ur" field
Changed line
`<<toc-selective-expandable "TableOfContents" "sort{fuzzy}">>`
to
`<<toc-selective-expandable "TableOfContents" "sort{!!fuzzy}">>`
Tested that this is the correct code.
* Add uniquetitle macro
This macro is a wrapper on the $tw.wiki.generateNewTitle function to return a unique name, it has been requested multiple times in the forums.
* Add documentation tiddler for uniquetitle macro
* Add uniquetitle macro examples
* Change name from uniquetitle to unusedtitle for clarity
The title isn't unique, just not currently used in the wiki.
* Update uniquetitle to unusedtitle
* Change uniquetitle to unusedtitle
* Fix a typo
There are other ways we could add maths to TW5 (including @EvanBalster's awesome https://github.com/EvanBalster/TiddlyWikiFormula) but the approach here has the merit of simplicity because it reuses the existing filter evaluation mechanism. That means that it's not ordinary "2+2" maths, it's a unique list processing language...
Docs to come
Fixes#254
* Update CountWidget.tid
Just a simple example added.
* Update CountWidget.tid
Made a slight addition to conform with the same style used in the Examples section of the $text widget: TextWidget.tid
* Update CountWidget.tid
Modified to use the Documentation display macro:
`<<wikitext-example-without-html>>`
From the readme:
This plugin enables TiddlyWiki to embed a modified copy of itself (an "innerwiki"). The primary motivation is to be able to produce screenshot illustrations that are automatically up-to-date with the appearance of TiddlyWiki as it changes over time, or to produce the same screenshot in different languages
It turns out that we don't need to disable any scroll anchoring done by the browser as our implementation of scroll anchoring will adapt itself.
Also removing an unneeded paragraph tag from the view template.
* Fix search method for search tokens spread across fields
Addresses GH #3636, which reports that if you're searching for "test
body", and "test" only appears in the title field, and "body" only appears
in the text field, 5.1.18's search method won't yield that tiddler as a
result, which appears to be a regression from the 5.1.17 behavior
* Add test for searching for multiple tokens across fields
Verifies GH #3636:
> If I create a tiddler in the empty edition with the title "Test tiddler" and content "Body content", searching the wiki for "test body" yields no results under either "title matches" or "all matches". Searching for either word individually turns up "Test tiddler", and repeating this in an empty wiki I created from the 5.1.17 tag causes "Test tiddler" to show up under "all matches".
* Promote Gitter Chat in the Readme
I'm not sure if it's ok to use inline styles for a small addition like this... also, feel free to change the colors :-)
* Added link to Gitter in 'Forums' tiddler and transcluded it in the readme as per @Jermolene comments
* Fixed transclusion and built readme
* Modified Readme so the 'forums' section is transclued with lower heading levels
* add link to "How to" keyboard shortcuts + styles
* add "How to create keyboard shortcuts"
* Update How to create keyboard shortcuts.tid
* Update How to create keyboard shortcuts.tid
* Update How to create keyboard shortcuts.tid
* Documentation of Using Excise text
Documentation on the Excise text function.
I propose that the Excise text drop down ( the tiddler: $:/language/Buttons/Excise/Caption/Tag) links to this doc. I don't have permission to (or don't know how to) edit that tiddler in github.
I propose the following text for the drop-down tiddler:
Tag new tiddler with the title of this tiddler (If the title is changed you have to [[save and re-edit|Using Excise]] to use the new title as tag).
see the issue:
https://github.com/Jermolene/TiddlyWiki5/issues/2531
* Update Using Excise.tid
changed headings in response to discussion
* Doc for editor toolbar buttons (wikitext)
Documentation for buttons special to the editor toolbar (wikitext)
* Update Using Excise.tid
placed it under the new [[Editor toolbar]]
* Update Using Stamp.tid
placed it under the new [[Editor toolbar]] tiddler
* Update WikiText.tid
added reference to [[Editor toolbar]]
* Update Formatting text in TiddlyWiki.tid
added reference to the [[Editor toolbar]]
* Update WikiText.tid
* Update Editor toolbar.tid
* Update Editor toolbar.tid
* Update Editor toolbar.tid
* Update Editor toolbar.tid
typo
uthor: G0erman <goerman.rafi@gmail.com
Date: Fri Nov 23 17:21:43 2018 -0500
Add a line in the end
commit 3cdd78116965f38147f55897adfcef493befe5d0
Author: G0erman <goerman.rafi@gmail.com>
Date: Fri Nov 23 17:15:47 2018 -0500
Recover file accidentally deleted
commit c4536e9182cd90a5d4e6e694ac6fc930ea75ddb5
Author: G0erman <goerman.rafi@gmail.com>
Date: Fri Nov 23 17:12:25 2018 -0500
Translate instructions about install plugin in node server.
commit 0622d03beb
Author: Jeremy Ruston <jeremy@jermolene.com>
Date: Wed Nov 21 12:10:35 2018 +0000
Update release note contributors list
commit 9d0083d8dc
Merge: 8134f8de22541b9b09
Author: Jeremy Ruston <jeremy@jermolene.com>
Date: Wed Nov 21 11:53:43 2018 +0000
Merge branch 'master' of https://Jermolene@github.com/Jermolene/TiddlyWiki5.git
commit 8134f8de28
Author: Jeremy Ruston <jeremy@jermolene.com>
Date: Wed Nov 21 11:53:26 2018 +0000
Update release note
commit 2541b9b090
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Wed Nov 21 12:32:22 2018 +0100
Pagescroller - get scroll pos in src window (#3561)
commit d55a498fca
Author: Bimba Laszlo <bimbalaszlo@gmail.com>
Date: Wed Nov 21 12:26:00 2018 +0100
Docs: Clarify TextWidget with example (#3564)
commit ce7becd64f
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Wed Nov 21 12:24:50 2018 +0100
KeyboardShortcut docs (#3496)
* add SystemTag $:/tags/KeyboardShortcut
* add Keyboard Shortcut Descriptor
* Update KeyboardShortcuts.tid
* Update KeyboardShortcutDescriptor.tid
* Update and rename SystemTag_$__tags_KeyboardShortcut.tid to SystemTag_ $__tags_KeyboardShortcut.tid
* Create KeyboardShortcutTiddler.tid
* Update KeyboardShortcutTiddler.tid
* Update KeyboardShortcutTiddler.tid
* Update KeyboardShortcuts.tid
* Update KeyboardShortcuts.tid
commit 09330968cc
Author: Jeremy Ruston <jeremy@jermolene.com>
Date: Tue Nov 20 13:29:44 2018 +0000
New "else" prefix for filters (#3558)
* Experimental "else" prefix for filters
See #3557
* Docs updates for "else" filter runs
commit 02f26d94a1
Author: Jermolene <jeremy@jermolene.com>
Date: Tue Nov 20 13:29:01 2018 +0000
Releaase note update
commit 7729649f0e
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Tue Nov 20 12:50:12 2018 +0100
Fix bad function declaration in wiki.js (#3559)
fix for #3555 - inner function declaration should be on top of its "host" function
error originally appeared on firefox v38.0.5
commit 430be4ec30
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Tue Nov 20 12:43:15 2018 +0100
Fix list-tagged-draggable for quotes !! and ## (#3442)
* fix list-tagged-draggable for quotes !! and ##
* Update list.tid
* Update list.tid
* Update list.tid
commit b009a60b69
Author: Jermolene <jeremy@jermolene.com>
Date: Tue Nov 20 11:30:06 2018 +0000
Update release note
Not quite up to date, got as far as 31 Oct.
commit 8832409666
Author: Jermolene <jeremy@jermolene.com>
Date: Tue Nov 20 11:29:36 2018 +0000
Docs typo
commit 6d67dc8eb8
Author: Bimba Laszlo <bimbalaszlo@gmail.com>
Date: Tue Nov 20 11:06:12 2018 +0100
Clarify drag-n-drop behaviour again (#3434)
* Clarify drag-n-drop behaviour again
Just found the real reason of drag-n-drop issue mentioned in
b89e8d1635.
* Trying to formulate correctly
commit f4ca295086
Author: Bimba Laszlo <bimbalaszlo@gmail.com>
Date: Mon Nov 19 22:01:56 2018 +0100
Docs: Remove broken `is` operator example (#3556)
In 737e9ae4cb the multiple suboperator
functionality was banned, but an example is remained in the docs.
commit b629b1412d
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Mon Nov 19 21:56:59 2018 +0100
Fix CodeMirror on fake dom (#3547)
* fix for #3547
see https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty
because of "strict mode" - the `parentNode` property may not be writable and causes an error in `fakedom.js` (appendChild)
to reproduce: install CodeMirror, install "Tools for exploring internals of TW", open a heavy Tiddler like the Control-Panel in edit-mode, toggle preview on, switch to "parse tree" or "widget tree"
* check for tw fakedom
commit eea034c32d
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Mon Nov 19 18:59:04 2018 +0100
Docs: add state* documentation to button and reveal widgets (#3553)
* docs: add state* attributes to reveal widget
* docs: add state* attributes to button widget
commit f373d8f2bf
Author: Adrian Morosanu <morosanuae@yahoo.com>
Date: Mon Nov 19 12:50:09 2018 +0200
Tree macro - fix for double quotes (and other special characters) (#3552)
* Added fixes for special characters (e.g. double quotes) (including @BurningTreeC and @Jermolene suggestions)
* Removed a lot of redundant code
* Set a default value for "tree" macro prefix parameter ($:/)
commit 4f78d3d81b
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Mon Nov 19 10:35:06 2018 +0100
Fix untagged-pill popup position (#3550)
this corrects the popup-position of the untagged-pill in the tag-manager, showing on top of the Tiddler, not below the pill
commit 72679d2041
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Sun Nov 18 21:58:03 2018 +0100
Fix bad characters in the TagManager (#3549)
now the tag manager needs some fixes for breaking titles, too
- the `<<__variable__>>` syntax needs to be used
- the `tag-pills` don't use the tag-pill macro, but `{{||$:/core/ui/TagTemplate}}` directly
- some already sufficiently qualified states in the `iconEditor` macro are reduced to not use the `qualify` macro
commit 33ba69e852
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Sun Nov 18 21:57:04 2018 +0100
Modals: Display in source-window (#3539)
* Make modals display in source Window
this makes modals display within the window where they got opened, with the parameter `rootwindow` that, if `yes` or `true`, shows the modal always in the root TW window (`<$action-sendmessage $message="tm-modal" $param="mymodal" rootwindow="yes|true"/>`)
* pass the full event to $tw.modal.display
we need the event there to find `srcDocument` and `srcWindow`
* pass event in options object
* update modal.js to use options.event
* add docs for rootwindow tm-modal attribute
commit 3aae643e14
Author: Jermolene <jeremy@jermolene.com>
Date: Sun Nov 18 19:31:53 2018 +0000
Reveal widget with lazily loaded state tiddlers
Fixes#3476
commit e983936c30
Author: Lioric <7177570+Lioric@users.noreply.github.com>
Date: Sun Nov 18 14:19:10 2018 -0500
Signing the CLA (#3477)
commit 849844be12
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Sun Nov 18 20:16:46 2018 +0100
Add stateTitle stateField stateIndex attributes (#3529)
* make triggerPopup optionally set state directly
* update button widget for new state attributes
* update reveal widget for new state attributes
* fix errors in button widget
commit 2b6514ddc2
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Sun Nov 18 11:54:12 2018 +0100
Use new state* attributes for reveal and button widgets (#3531)
* toc macros: use stateTitle and setTitle
* tree macros: use stateTitle and setTitle
* TagManager: use popupTitle, stateTitle setTitle
* body viewtemplate: use stateTitle for folded-state
* import-listings: use stateTitle and setTitle
commit ddc76622f2
Author: BurningTreeC <hypnotizedkangaroo@gmail.com>
Date: Sun Nov 18 11:44:19 2018 +0100
Remove sourceMappingUrl from hammer.js (#3535)
commit 882cad1a0d
Author: Bram Chen <bram.chen@gmail.com>
Date: Sat Nov 17 21:48:31 2018 +0800
Add chinese translations for Title/References (#3545)
* Make modals display in source Window
this makes modals display within the window where they got opened, with the parameter `rootwindow` that, if `yes` or `true`, shows the modal always in the root TW window (`<$action-sendmessage $message="tm-modal" $param="mymodal" rootwindow="yes|true"/>`)
* pass the full event to $tw.modal.display
we need the event there to find `srcDocument` and `srcWindow`
* pass event in options object
* update modal.js to use options.event
* add docs for rootwindow tm-modal attribute
To avoid clashing with tiddlers called "login-basic" :)
We also need to revise the rout for /status for the same reason, but there are backward compatibility issues there
* Added better handling for sortByList manual placements
If manual placement specifications show up in an inconvenient order,
sortByList, will go to the trouble of processing them in that order.
* Added tests to confirm solution to (#3296)
...That custom tag ordering will not choke when tiddlers get sorted after their dependencies have been placed around them
* Corrected list-after bug when referencing external titles
* Using more error-proof $tw.utils.hop in sortByList
* minor indentation correction in test-tags.js
* Explore externalising TiddlyWiki's JS core into a separate file
* Fix missing newline after copyright notice
* Add an error alert if tiddlywiki.js can't be loaded
* Update Macro Definitions in WikiText.tid
*The table is intended as an overview.
*The "Parameters as Variables" example is more clean cut than previously.
Please note that the text lacks an example of direct `<<variable>>` invocation (because I'm not even sure I categorize or name this properly). Also my changes may contain factual errors or faulty lingo - please check!
* Update Macro Definitions in WikiText.tid
* Clarify the drag-n-drop behaviour
In my case I misunderstood it: I thought that I need to select the text and
drag the selection, because drag-n-drop did not work by default.
* Fix grammar
A few minor improvements that I propose are merged directly.
But, @pmario , we also need a clarifying example showing how to target a tiddler using *multiple* tags. So, under the examples there ought to be something like this:... BUT I fail to get this to work (syntax?):
```
[data-tags*="[[How to apply custom styles]] example-test"] {
outline: 2px solid green;
}
```
Further, the text states that
`Important: Tiddler tags are not sorted, so the order in the rendered output may be different!`
...but I'm not sure what this means. Does it mean:
```
Important: A tiddlers tags are displayed alphabetically but rendered styles may come out in a different order. As per standard CSS behaviour, styles rendered later override styles rendered earlier.
```
* Module-ize server routes and add static file support (#2510)
* Refactor server routes to modules
New module type: serverroute
Caveats: Loading order is not deterministic but this would only matter
if two route modules attempted to use the same path regexp (that would
be silly).
* Add static assets plugin
This plugin allows the node server to fetch static assets in the /assets
directory. I felt that this was a feature that goes above the core
functionality. That is why I added it as a plugin. with the modular
route extensions this was a breeze.
* Add serverroute description to ModuleTypes
* Coding standards tweaks
* Fix filename typo
* Move support for attachments from a plugin into the core
* Missing "else"
* Refactor server handling
* Introduce a new named parameter scheme for commands
* Move the SimpleServer class into it's own module
* Deprecate the --server command because of the unwieldy syntax
* Add a new --listen command using the new syntax
For example:
tiddlywiki mywiki --listen host:0.0.0.0 port:8090
* Add check for unknown parameters
* Add support for multiple basic authentication credentials in a CSV file
Beware: Passwords are stored in plain text. If that's a problem, use an authenticating proxy and the trusted header authentication approach.
* Refactor module locations
* Rename "serverroute" module type to "route"
* Remove support for verifying optional named command parameters
The idea was to be able to flag unknown parameter names, but requiring a command to pre-specify all the parameter names makes it harder for (say) the listen command to be extensible so that plugins can add new optional parameters that they handle. (This is particularly in the context of work in progress to encapsulate authenticators into their own modules).
* Refactor the two authenticators into separate modules and add support for authorization
* Correct mistaken path.join vs. path.resolve
See https://stackoverflow.com/a/39836259
* Docs for the named command parameters
I'd be grateful if anyone with sufficient Windows experience could confirm that the note about double quotes in "NamedCommandParameters" is correct.
* Be consistent about lower case parameter names
* Do the right thing when we have a username but no password
With a username parameter but no password parameter we'll attribute edits to that username, but not require authentication.
* Remove obsolete code
* Add support for requiring authentication without restricting the username
* Refactor authorization checks
* Return read_only status in /status response
* Fix two code typos
* Add basic support for detecting readonly status and avoiding write errors
We now have syncadaptors returning readonly status and avoid attempting to write to the server if it's going to fail
* Add readonly-styles
We hide editing-related buttons in read only mode
I've made this part of the tiddlyweb plugin but I think a case could be made for putting it into the core.
* Add custom request header as CSRF mitigation
By default we require the header X-Requested-With to be set to TiddlyWiki. Can be overriden by setting csrfdisable to "yes"
See https://www.owasp.org/index.php/Cross-Site_Request_Forgery_(CSRF)_Prevention_Cheat_Sheet#Protecting_REST_Services:_Use_of_Custom_Request_Headers
* Add support for HTTPS
* First pass at a route for serving rendered tiddlers
cc @Drakor
* Tweaks to the single tiddler static view
Adding a simple sidebar
* Switch to "dash" separated parameter names
* Typo
* Docs: Update ServerCommand and ListenCommand
* First pass at docs for the new web server stuff
Writing the docs is turning out to be quite an undertaking, much harder than writing the code!
* Get rid of extraneous paragraphs in static renderings
* Rejig anonymous user handling
Now we can support wikis that are read-only for anonymous access, but allow a user to login for read/write access.
* More docs
Slowly getting there...
* Static tiddler rendering: Fix HTML content in page title
* Docs updates
* Fix server command parameter names
Missed off 30ce7ea
* Docs: Missing quotes
* Avoid inadvertent dependency on Node.js > v9.6.0
The listenOptions parameter of the plain HTTP version of CreateServer was only introduced in v9.6.0
cc @Drakor @pmario
* Typo
* Refactored the is operator for simplicity and efficiency.
* Improve `is` filter documentation.
* Update is.js
* extracted `subops.length` to `num_of_subops`
* renamed `subop` to `operator` for clarity/differentiation from `subops`
* refactored to avoid using a `Set` object.
* Update is.js
