mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-27 03:57:21 +00:00
Code Issues Releases Wiki Activity

tw5.com : Fix typo in contributing.tid (#6216)

Browse Source 
* tw5.com : Fix typo in contributing.tid

* tw5.com : update modified field of Contributing.tid

When editing a tiddler outside TW itself, this doesn't change automatically the modified field.
This commit is contained in:
eiro10 2021-11-15 22:16:36 +01:00 committed by GitHub
parent 3ff165402c
commit ce99c0aa0f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
editions/tw5.com/tiddlers/community/Contributing.tid
View File

@ -1,5 +1,5 @@
created: 20131101111400000
modified: 20210402095728684
modified: 20211115092001000
tags: Community
title: Contributing
type: text/vnd.tiddlywiki
@ -45,7 +45,7 @@ PR titles may also include a short prefix to indicate the subsystem to which the
! Commenting on Pull Requests
One of the principles of open source is that many pairs of eyes on the code can improve quality. So, we welcome comments and critiques of pending PRs. [[Conventional Comments|https://conventionalcomments.org]] has some techcniques to help make comments as constructive and actionable as possible. Notably, they recommend prefixing a comment with a label to clarify the intention:
One of the principles of open source is that many pairs of eyes on the code can improve quality. So, we welcome comments and critiques of pending PRs. [[Conventional Comments|https://conventionalcomments.org]] has some techniques to help make comments as constructive and actionable as possible. Notably, they recommend prefixing a comment with a label to clarify the intention:
|praise |Praises highlight something positive. Try to leave at least one of these comments per review. Do not leave false praise (which can actually be damaging). Do look for something to sincerely praise |
|nitpick |Nitpicks are small, trivial, but necessary changes. Distinguishing nitpick comments significantly helps direct the reader's attention to comments requiring more involvement |