From ce99c0aa0f5a2111021f2efe86867f208e9729d9 Mon Sep 17 00:00:00 2001 From: eiro10 Date: Mon, 15 Nov 2021 22:16:36 +0100 Subject: [PATCH] tw5.com : Fix typo in contributing.tid (#6216) * tw5.com : Fix typo in contributing.tid * tw5.com : update modified field of Contributing.tid When editing a tiddler outside TW itself, this doesn't change automatically the modified field. --- editions/tw5.com/tiddlers/community/Contributing.tid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/editions/tw5.com/tiddlers/community/Contributing.tid b/editions/tw5.com/tiddlers/community/Contributing.tid index 05da11caa..e5e23c624 100644 --- a/editions/tw5.com/tiddlers/community/Contributing.tid +++ b/editions/tw5.com/tiddlers/community/Contributing.tid @@ -1,5 +1,5 @@ created: 20131101111400000 -modified: 20210402095728684 +modified: 20211115092001000 tags: Community title: Contributing type: text/vnd.tiddlywiki @@ -45,7 +45,7 @@ PR titles may also include a short prefix to indicate the subsystem to which the ! Commenting on Pull Requests -One of the principles of open source is that many pairs of eyes on the code can improve quality. So, we welcome comments and critiques of pending PRs. [[Conventional Comments|https://conventionalcomments.org]] has some techcniques to help make comments as constructive and actionable as possible. Notably, they recommend prefixing a comment with a label to clarify the intention: +One of the principles of open source is that many pairs of eyes on the code can improve quality. So, we welcome comments and critiques of pending PRs. [[Conventional Comments|https://conventionalcomments.org]] has some techniques to help make comments as constructive and actionable as possible. Notably, they recommend prefixing a comment with a label to clarify the intention: |praise |Praises highlight something positive. Try to leave at least one of these comments per review. Do not leave false praise (which can actually be damaging). Do look for something to sincerely praise | |nitpick |Nitpicks are small, trivial, but necessary changes. Distinguishing nitpick comments significantly helps direct the reader's attention to comments requiring more involvement |