mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-12-27 18:40:28 +00:00
Code Issues Releases Wiki Activity

Fix crash in GitHub saver (#3905)

Browse Source 
If the path was not specified, RSOD error occurred when we wanted to
download the wiki:

  Uncaught TypeError: Cannot read property 'substring' of undefined
This commit is contained in:
Bimba Laszlo 2019-04-11 09:21:55 +02:00 committed by Jeremy Ruston
parent 61d87875ff
commit 9b72eabd1a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/modules/savers/github.js
View File

@ -34,6 +34,10 @@ GitHubSaver.prototype.save = function(text,method,callback) {
"Content-Type": "application/json;charset=UTF-8",
"Authorization": "Basic " + window.btoa(username + ":" + password)
};
// Bail if we don't have everything we need
if(!username || !password || !repo || !path || !filename) {
return false;
}
// Make sure the path start and ends with a slash
if(path.substring(0,1) !== "/") {
path = "/" + path;
@ -43,10 +47,6 @@ GitHubSaver.prototype.save = function(text,method,callback) {
}
// Compose the base URI
var uri = "https://api.github.com/repos/" + repo + "/contents" + path;
// Bail if we don't have everything we need
if(!username || !password || !repo || !path || !filename) {
return false;
}
// Perform a get request to get the details (inc shas) of files in the same path as our file
$tw.utils.httpRequest({
url: uri,