From 9b72eabd1ae6260f7e07e35c3072b65149cb919c Mon Sep 17 00:00:00 2001 From: Bimba Laszlo Date: Thu, 11 Apr 2019 09:21:55 +0200 Subject: [PATCH] Fix crash in GitHub saver (#3905) If the path was not specified, RSOD error occurred when we wanted to download the wiki: Uncaught TypeError: Cannot read property 'substring' of undefined --- core/modules/savers/github.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/modules/savers/github.js b/core/modules/savers/github.js index 642ffd75d..cad1b99f1 100644 --- a/core/modules/savers/github.js +++ b/core/modules/savers/github.js @@ -34,6 +34,10 @@ GitHubSaver.prototype.save = function(text,method,callback) { "Content-Type": "application/json;charset=UTF-8", "Authorization": "Basic " + window.btoa(username + ":" + password) }; + // Bail if we don't have everything we need + if(!username || !password || !repo || !path || !filename) { + return false; + } // Make sure the path start and ends with a slash if(path.substring(0,1) !== "/") { path = "/" + path; @@ -43,10 +47,6 @@ GitHubSaver.prototype.save = function(text,method,callback) { } // Compose the base URI var uri = "https://api.github.com/repos/" + repo + "/contents" + path; - // Bail if we don't have everything we need - if(!username || !password || !repo || !path || !filename) { - return false; - } // Perform a get request to get the details (inc shas) of files in the same path as our file $tw.utils.httpRequest({ url: uri,