mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-27 03:57:21 +00:00
Code Issues Releases Wiki Activity

Fix server error when saving a new tiddler created by following a tiddler link (#4770)

Browse Source 
* Initialize draft tiddler with empty text

Otherwise, when the tiddler has a meta file,
$tw.utils.saveTiddlerToFile will call fs.writeFile with the content
to write as `undefined`. Depending on the version of Node, this
results in the string "undefined" getting saved or a TypeError.

* Remove what seems to be a leftover debug log
This commit is contained in:
ento 2020-08-27 06:45:34 -08:00 committed by GitHub
parent aa08210e44
commit 259b45065a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/modules/widgets/navigator.js
View File

@ -273,7 +273,9 @@ NavigatorWidget.prototype.makeDraftTiddler = function(targetTitle) {
var tiddler = this.wiki.getTiddler(targetTitle); var tiddler = this.wiki.getTiddler(targetTitle);
// Save the initial value of the draft tiddler // Save the initial value of the draft tiddler
draftTitle = this.generateDraftTitle(targetTitle); draftTitle = this.generateDraftTitle(targetTitle);
var draftTiddler = new $tw.Tiddler( var draftTiddler = new $tw.Tiddler({
text: "",
},
tiddler, tiddler,
{ {
title: draftTitle, title: draftTitle,
@ -325,7 +327,6 @@ NavigatorWidget.prototype.handleSaveTiddlerEvent = function(event) {
// If enabled, relink references to renamed tiddler // If enabled, relink references to renamed tiddler
var shouldRelink = this.getAttribute("relinkOnRename","no").toLowerCase().trim() === "yes"; var shouldRelink = this.getAttribute("relinkOnRename","no").toLowerCase().trim() === "yes";
if(isRename && shouldRelink && this.wiki.tiddlerExists(draftOf)) { if(isRename && shouldRelink && this.wiki.tiddlerExists(draftOf)) {
console.log("Relinking '" + draftOf + "' to '" + draftTitle + "'");
this.wiki.relinkTiddler(draftOf,draftTitle); this.wiki.relinkTiddler(draftOf,draftTitle);
} }
// Remove the draft tiddler // Remove the draft tiddler