From 259b45065a0f6088036c228ae554fc4f7b0431fe Mon Sep 17 00:00:00 2001 From: ento Date: Thu, 27 Aug 2020 06:45:34 -0800 Subject: [PATCH] Fix server error when saving a new tiddler created by following a tiddler link (#4770) * Initialize draft tiddler with empty text Otherwise, when the tiddler has a meta file, $tw.utils.saveTiddlerToFile will call fs.writeFile with the content to write as `undefined`. Depending on the version of Node, this results in the string "undefined" getting saved or a TypeError. * Remove what seems to be a leftover debug log --- core/modules/widgets/navigator.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/modules/widgets/navigator.js b/core/modules/widgets/navigator.js index df7e2475b..d61432b60 100755 --- a/core/modules/widgets/navigator.js +++ b/core/modules/widgets/navigator.js @@ -273,7 +273,9 @@ NavigatorWidget.prototype.makeDraftTiddler = function(targetTitle) { var tiddler = this.wiki.getTiddler(targetTitle); // Save the initial value of the draft tiddler draftTitle = this.generateDraftTitle(targetTitle); - var draftTiddler = new $tw.Tiddler( + var draftTiddler = new $tw.Tiddler({ + text: "", + }, tiddler, { title: draftTitle, @@ -325,7 +327,6 @@ NavigatorWidget.prototype.handleSaveTiddlerEvent = function(event) { // If enabled, relink references to renamed tiddler var shouldRelink = this.getAttribute("relinkOnRename","no").toLowerCase().trim() === "yes"; if(isRename && shouldRelink && this.wiki.tiddlerExists(draftOf)) { -console.log("Relinking '" + draftOf + "' to '" + draftTitle + "'"); this.wiki.relinkTiddler(draftOf,draftTitle); } // Remove the draft tiddler