4 How to get your PR merged

opusforlife2 edited this page 2022-10-01 02:05:55 +00:00

1. Create your PR
2. Wait for a maintainer review
3. Do the requested changes, and answer any questions raised by the reviewer(s)
4. Rebase on dev if necessary:

$ git checkout dev
$ git pull
$ git checkout <the_branch_im_working_in>
$ git rebase dev
$ # The rebase might consist of several commits, so you might have to do this several times after resolving a collision:
$ git rebase --continue
$ # Check if everything works, and no tests fail.
$ git push --force
$ # WARNING: it will push your local changes and erase the difference. It is needed after a rebase.

For more information, see https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md#code-contribution.

The primary docs are found on the project's website