Abanoub Sameh
5532666ad5
Long press on player share button to copy url to clipboard
2021-06-08 14:23:33 +02:00
Robin
3b0045917c
Increase buffer for playback after rebuffer
2021-06-07 09:25:49 +02:00
Stypox
a102fc9cad
Use constraint layout for play queue item
...
Also remove invalid ic_selected attribute
2021-06-07 08:07:27 +02:00
Douile
d921e2e61b
Hide queue duration when displaying segment panel
...
Fixes #6441
2021-06-07 02:10:44 +01:00
TobiGr
98fdbec442
Fix playback speed not being updated in PlayQueuAcitvity
...
Fixes #6419
2021-06-05 12:24:59 +02:00
Zhiheng Xu
2e161a1f45
Change shuffle() guard to check for size <= 2
...
After testing the app, I realized that shuffling a queue with size 2
does nothing
2021-05-24 12:20:19 -04:00
Zhiheng Xu
5ab6e84044
Remove redundant clearing of list
2021-05-24 12:20:19 -04:00
Zhiheng Xu
e1a6347c4e
Refactor shuffle and update documentation
...
- Add early return for invalid sizes to shuffle
- Rename variables to be more descriptive
- Refactor moving list element, removing unnecessary operations
- Unwrap if clause for adding to history because the condition is
guaranteed by the guard clause
- Inline the value 0 for the ReorderEvent
- Update documentation to reflect new changes
2021-05-24 12:20:19 -04:00
Eric Xu
92a67bb8cb
Rearrange fields
...
Final fields should be arranged first
2021-05-24 12:20:19 -04:00
Eric Xu
e8eeac6735
Resolve TODO in indexOf(...)
...
PlayQueueItem overrides equals and hashCode, so using indexOf is
perfectly fine.
2021-05-24 12:20:19 -04:00
Eric Xu
775fbc9a75
Rewrite setIndex(int) to pass unit tests
...
Original did not cover the case of when streams is empty and
documentation does not specify any input restrictions.
There's an ambiguity with broadcasting an event between the
documentation and the actual code (see TODO).
2021-05-24 12:20:19 -04:00
Eric Xu
8efe2859b8
Refactor assignments to field declaration
...
Assignments that don't require the constructor can be moved out.
2021-05-24 12:20:19 -04:00
Eric Xu
441c68ead2
Add hashCode() to match equals(other)
2021-05-24 12:20:19 -04:00
Eric Xu
4cd1f201f5
Refactor streams to initialize with values
2021-05-24 12:20:19 -04:00
Eric Xu
013c59f904
Refactor ArrayList fields to List
2021-05-24 12:20:19 -04:00
Eric Xu
57474e2dab
Refactor and optimize equals
...
- Remove multiple casts of obj
- Simply use object equals on the streams because PlayQueueItem’s
equals already compares urls
2021-05-24 12:20:19 -04:00
TobiGr
87d2f33e55
Add support for PeerTube HLS streams
2021-05-23 11:53:35 +02:00
Robin
95f61542b5
TEST: Downgrade ExoPlayer to 2.12
2021-05-14 14:47:53 +02:00
Robin
98ccd577d6
Fixed checkstyle
2021-05-14 12:15:48 +02:00
Robin
1d43a2362c
Add debug option to disable media tunneling
2021-05-14 12:05:52 +02:00
litetex
31ea44ccf1
Fixed player not automatically playing ( #6266 )
...
* Fixed player not automatically playing
Should also fix https://github.com/TeamNewPipe/NewPipe/issues/6179
* Added comment
2021-05-12 10:20:39 +02:00
Robin
c85b97a484
Fix: fragmentSize is below the minimum ( #6238 )
...
noticed logs " CacheDataSink: fragmentSize is below the minimum recommended value of 2097152. This may cause poor cache performance.
this fixes the issue by using ExoPlayers MIN_RECOMMENDED_FRAGMENT_SIZE. Unfortunately that field is private:
aeb306a164/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSink.java (L123)
2021-05-04 19:08:25 +02:00
TobiGr
b54c2b7f57
Fix invisible buffering / loading indicator in player
2021-04-25 11:36:00 +02:00
Tom
3fcd580491
Add queue time ( #6023 )
...
* Add queue time
2021-04-08 10:41:41 +02:00
krlvm
e484339cca
Merge branch 'dev' into daynight
2021-04-03 00:08:26 +03:00
Fynn Godau
c9766d25ef
Rename related streams to related items
2021-03-31 22:33:22 +02:00
Robin
4a9d21062a
Disabled tunneling on Hi3798MV200
2021-03-31 16:38:50 +02:00
Stypox
5739caaa5a
Merge pull request #5856 from Redirion/exo213
...
Update to ExoPlayer 2.13.2
2021-03-31 14:29:16 +02:00
wangear
73cfa5499d
Fix overlapping fonts and crash on tapping anywhere on video after long-pressing 'Popup' button ( #5813 )
...
* Overlapping fonts #5096
issue : #5096
* Overlapping fonts #5096
issue : #5096
changed :
- If additional textView is overlapped, only title view shows.
* Overlapping fonts #5096
issue : #5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.
* Overlapping fonts #5096
issue : #5096
changed :
- remove unusable variable
* Crash on tapping anywhere on video after long-pressing 'Popup' button #5804
issue : #5804
changed :
- checked null
- fixed NullPointerException.
2021-03-31 10:10:14 +02:00
Robin
83d16932a4
Update to ExoPlayer 2.13.2
2021-03-31 10:05:44 +02:00
Tom
84de865daf
Allow the user to pause while a video is buffering ( #5929 )
...
Fix pause while buffering
Use getPlayWhenReady wrapper everywhere playWhenReady is checked
Remove duplicate `playPause()` code
2021-03-29 18:00:00 +02:00
krlvm
80d1c5b9f5
Fix Repeat Button color in Player
2021-03-28 22:04:54 +03:00
krlvm
0afdac5683
Fix Light Player Popups in Dark Theme, make Player Controls Overlay always Dark
2021-03-28 18:48:51 +03:00
krlvm
fd14c8cdce
Fix Dark elements in Light Theme
2021-03-27 17:46:05 +03:00
Stypox
86381696f4
Merge pull request #5457 from Redirion/exo123
...
Update to ExoPlayer 2.12.3
2021-03-18 18:59:56 +01:00
Stypox
feb65cf8f3
Merge pull request #5792 from TeamNewPipe/resize_mode
...
Fix last resize mode not being restored correctly
2021-03-17 09:07:44 +01:00
TobiGr
71d3227791
Fix bottom controls being out of the screen
...
This was caused by too large end screen thumbnails enlarging the whole palyer. Fixed by scaling the thumbnail.
Ensure that the player does not use the whole screen height in detail fragment to keep the additional content like title, comments, etc. available.
2021-03-14 17:52:15 +01:00
TobiGr
86fa629591
Fix last resize mode not being restored correctly
...
I think the settings key "last_resize_mode" is ambiguous. While it is used to get the recently used resize mode, someone thought while working on the resize mode switcher, that the old (to be replaced) resize mode should be stored.
Fixes #5613
2021-03-08 09:46:33 +01:00
Stypox
8978187c64
Improve code style and fix some warnings
...
Removed a textTrack null check on a now- NonNull method
Added a error type switch case (TIMEOUT)
2021-02-16 16:54:44 +01:00
Robin
eba0b07782
Update to ExoPlayer 2.12.3
2021-02-16 16:42:51 +01:00
karol
156d7139fa
removed resizig text from popup player, as requested in #5514
2021-02-11 11:20:27 +01:00
Stypox
fdb0f01b38
Add Objects.requireNotNull to warning which is surely not null
2021-01-28 14:35:47 +01:00
Stypox
376cba696e
Remove useless getString for default setting value
2021-01-28 14:35:00 +01:00
Stypox
cade272501
Use PlayerHelper.retrieveResizeModeFromPrefs in Player
2021-01-28 14:33:50 +01:00
Stypox
4f828fbe00
Fix always minimizing to popup player
2021-01-28 14:33:12 +01:00
Stypox
e327f7ba2c
Fix popup closing x button animation
2021-01-19 09:34:21 +01:00
XiangRongLin
23b5cd5b72
Merge pull request #5442 from Stypox/fix-close-popup
...
Prevent IllegalArgumentException when closing popup
2021-01-18 09:39:02 +01:00
Stypox
d4a33603ab
Prevent IllegalArgumentException when closing popup
2021-01-18 08:27:49 +01:00
Stypox
4c3ba0fe3d
Add icons to VideoDetailFragment tab layout for better accessibility
2021-01-17 15:34:24 +01:00
Isira Seneviratne
fe92abde0e
Use view binding in VideoDetailFragment.
2021-01-17 09:57:40 +05:30
TiA4f8R
79e98db3bd
Apply the requested changes and little improvements
...
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
Apply the requested changes and do little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
2021-01-16 13:23:42 +01:00
Isira Seneviratne
920e560b4b
Convert AnimationUtils functions to extension functions.
2021-01-16 14:49:37 +05:30
vkay94
37aa41afae
Add stream segments to player
2021-01-14 21:58:19 +01:00
Stypox
059bb7622d
Merge and rename into PlayQueueActivity
2021-01-14 10:25:48 +01:00
Stypox
cece83328a
Fix wrong speed indicator in queue activity
2021-01-14 10:25:48 +01:00
Stypox
f6e2dd1480
Merge player classes into a single one
2021-01-14 10:25:44 +01:00
Isira Seneviratne
fa75c79d34
Use view binding (PlayerPopupCloseOverlayBinding) in VideoPlayerImpl.
2021-01-13 20:44:00 +01:00
Isira Seneviratne
0c86a4e608
Use view binding (PlayerBinding) in VideoPlayer.
2021-01-13 20:43:56 +01:00
Tobias Groza
92a87a5ed2
Merge pull request #5310 from khimaros/list-play-kodi
...
add list item to play video on kodi
2021-01-13 17:02:56 +01:00
Mikhail Barashkov
907106156f
When in Fullscreen playback mode, toggle play/pause with the hardware Space button.
2021-01-07 17:32:16 +02:00
khimaros
ac59382b84
pass serviceId instead of item, reduce duplication
2021-01-02 11:24:33 -08:00
Stypox
1b4bde4e78
Merge pull request #5221 from B0pol/notifications
...
Dynamically get package name
2021-01-01 18:05:43 +01:00
Robin
ce2719d77e
Merge pull request #5317 from XiangRongLin/timestamp
...
Fix urls with timestamps not being played
2020-12-31 12:46:40 +01:00
Robin
8193a0df63
Merge pull request #5065 from TacoTheDank/androidx-media-audioreactor
...
Use AndroidX Media compat in AudioReactor
2020-12-31 10:55:11 +01:00
TacoTheDank
ebd589c9cb
Use AndroidX Media compat in AudioReactor
2020-12-30 17:10:57 -05:00
XiangRongLin
1f15368b7b
Fix urls with timestamps not being played
...
Else path is now executed, when a timestamp (item.getRecoveryPosition) is present
2020-12-30 21:07:30 +01:00
Eric Lemieux
0a05534c84
Fix null pointer exception in play button method
...
When the play queue was null, and this method was called a null pointer
exception would be thrown. This change adds an additional check to see
if the play queue is not null before making additional changes.
2020-12-29 14:51:24 -05:00
Isira Seneviratne
b2e9981313
Fix queue display in ServicePlayerActivity.
2020-12-23 20:06:02 +05:30
bopol
2b8837609b
dynamically get package name
...
it fixes issues with forks or debug builds, e.g. when you open two newpipe apps (with debug or fork apps), close one notification, it closes all newpipe notifications
fixes https://github.com/TeamNewPipe/NewPipe/issues/4653
2020-12-20 13:52:20 +01:00
bopol
7a7a90bf79
remove timestamp from share url for all services except youtube
...
It produces not found error for PeerTube, media.ccc.de, SoundCloud
2020-12-20 10:53:22 +01:00
Isira Seneviratne
0fe3fe7594
Use ServiceCompat.stopForeground().
2020-12-19 16:52:17 +05:30
Isira Seneviratne
e6021465f6
Use view binding in ServicePlayerActivity.
2020-12-19 04:21:59 +05:30
Isira Seneviratne
807e4d4af9
Use ActivityCompat.recreate().
2020-12-15 13:55:05 +05:30
Tobias Groza
db9f20a22f
Merge pull request #4961 from TeamNewPipe/lint
...
Fix some Lint errors
2020-12-07 11:19:01 +01:00
Stypox
b66047e084
Fix ktlint errors
2020-11-22 14:03:10 +01:00
Stypox
f0ca916432
Update most dependencies
2020-11-22 14:03:10 +01:00
TobiGr
7a8dab2d58
Fix typos
2020-11-22 10:39:00 +01:00
vkay94
b5321152fd
Player gestures: Fix respecting brightness-volume-gesture settings
2020-11-20 21:08:02 +01:00
Stypox
06b7072240
Merge pull request #4642 from XiangRongLin/hide_thumbnail
...
Add option to hide thumbnail on lock screen
2020-11-20 16:35:10 +01:00
TacoTheDank
2669ba944d
Correct some other small lints
2020-11-19 18:54:27 -05:00
TacoTheDank
0274cd6beb
Lint: Inner class may be static
2020-11-18 18:02:33 -05:00
TacoTheDank
39e5d8ccc2
Lint: Make a bunch of stuff final
2020-11-18 17:50:00 -05:00
TacoTheDank
ea5939c1b7
Kotlin lint fixing
2020-11-18 17:45:19 -05:00
Stypox
7476498823
[Regression] Revert "Removed remember popup properties setting"
...
This reverts commit 314615bfef
.
2020-11-15 22:24:27 +01:00
XiangRongLin
7805f8a9b1
Add option to hide thumbnail on lock screen and inside notification
2020-11-14 10:01:07 +01:00
Stypox
617ee0afc0
Fix brightness and volume scroll swapped
2020-11-08 10:00:28 +01:00
Stypox
1b47a1a994
Fix switching to main player when MainActivity is closed
2020-11-08 10:00:28 +01:00
Stypox
5a87cfc25d
Open mini player if player running on app open
2020-11-08 10:00:28 +01:00
Stypox
2a2c82e73b
More fixes with opening VideoDetailFragment
2020-11-08 10:00:28 +01:00
Stypox
1d42e45d78
Unify all ways of opening VideoDetailFragment
2020-11-08 10:00:27 +01:00
Tobias Groza
f4435f9031
Merge pull request #4555 from Stypox/playqueue-crash
...
Fix NullPointerException in queue handling
2020-11-08 01:19:38 +01:00
Stypox
f1583b6e0c
Merge pull request #4587 from vkay94/separate-player-gesture-logic-ui
...
Separate player gesture logic and UI
2020-11-02 16:36:50 +01:00
vkay94
347566c311
Player gestures: Add multi-double-tap logic
2020-11-02 15:50:34 +01:00
Xiang Rong Lin
974f8f692c
Add option to not colorize notification
2020-11-01 22:13:00 +01:00
TacoTheDank
31cffa68c5
Push conditionals inside branch expressions
2020-10-31 15:57:26 -04:00
vkay94
2683043762
Player gestures: separate logic and UI
2020-10-29 12:46:34 +01:00
Stypox
e406b6f780
Fix NullPointerException in queue handling
2020-10-26 18:15:59 +01:00
vkay94
32a142bf79
Fix PlaylistAppendDialog: Renamed method and replaced with Runnable
2020-10-23 09:44:26 +02:00
vkay94
2680d41a3d
Fix PlaylistAppendDialog showing when no local playlists exist
2020-10-23 09:44:26 +02:00
Stypox
941028ba6f
Don't rearrange lists by dragging the thumbnails
2020-10-17 16:25:06 +02:00
Stypox
ae33c6cf18
Merge pull request #4476 from vkay94/two-finger-to-close-player
...
Two finger to close player gesture
2020-10-11 14:51:45 +02:00
vkay94
f8cd6afbf8
Two finger gesture: Less code lines
2020-10-11 13:56:30 +02:00
vkay94
f6925fc5b8
Added two finger to close player gesture
2020-10-10 15:00:39 +02:00
Isira Seneviratne
58b720b004
Use ContextCompat.getSystemService() and the Context.getSystemService() extension function.
2020-10-09 08:52:05 +05:30
Panorea
314615bfef
Removed remember popup properties setting
2020-10-06 18:32:20 -04:00
Stypox
44e82217c1
Merge pull request #4425 from vkay94/enqueue-stream
...
Replace specific enqueue options with one
2020-10-06 22:37:19 +02:00
vkay94
12f615c6da
Enqueue: Removed unneeded dialog-entries and strings + adjustments
2020-10-06 17:22:12 +02:00
vkay94
ed6fc4d848
Enqueue: Replaced specific StreamDialogEntry items with one
...
The enqueue options won't be shown in the dialogs if the Player service is not running. When it's running one item (enqueue stream) will be shown and enqueues the item into the Player type which is currently selected.
2020-10-06 14:38:48 +02:00
vkay94
cd515993f5
Enqueue: Add auto-select StreamDialogEntry for current PlayerType
2020-10-06 13:33:44 +02:00
Tobias Groza
9f63e2d39a
Merge pull request #4410 from Stypox/notification-fixes
...
Notification fixes
2020-10-05 19:08:26 +02:00
Stypox
a88f5113e0
Hide player notification "when" time
...
It is useless to see how much time ago a player notification was created
2020-10-05 15:57:14 +02:00
Stypox
06fb89fae2
Fix crash on fast forward
2020-10-05 15:55:10 +02:00
Isira Seneviratne
63d54e6570
Use DisplayCutoutCompat in VideoPlayerImpl.
2020-10-04 05:44:13 +05:30
Tobias Groza
83ea91586b
Merge pull request #4362 from Stypox/fix-queue
...
Random fixes and improvements
2020-10-02 16:48:04 +02:00
Tobias Groza
794c74e514
Merge pull request #4360 from avently/player-overlays
...
Player overlays now centered
2020-10-02 15:37:28 +02:00
Stypox
fbcdaa77e3
Initialize player notification asap
...
Otherwise Android's foreground services implementation would complain
2020-10-02 15:17:04 +02:00
Tobias Groza
4e7632949d
Merge pull request #4347 from avently/player-rebind
...
Player rebind
2020-10-01 15:03:43 +02:00
Avently
26a8bd147b
Now player's overlays are aware of insets
2020-10-01 03:10:51 +03:00
Avently
dd726fac02
Skipped interception of buttons in the player in some cases and made image view from playQueue visible
2020-10-01 03:10:42 +03:00
wb9688
f4bd20361a
Fix auto-queue with no next videos
2020-09-29 10:43:17 +02:00
Avently
c1d5a5cd98
Player will be rebound when needed, prev/next/queue buttons, preserving paused state
...
- each time something starts to play in any player VideoDetailFragment will be started (if not yet started) and mini player will show up. It makes possible to see a playing stream in mini player even if the stream was started without using fragment or after player service was closed somehow
- play/next/queue buttons will be updated in realtime when stream was added/removed from queue instead of waiting for a onPlay/onPause action to happen
- when popup or background players start the stream will start playing only if paused state wasn't requested. Which means, for example, if a user opens popup it will be started when START_PAUSED is false. If, for example, the stream was played in main player and then popup was started the stream will still be playing, but if it was paused it still be paused in popup (or background) in APPEND_ONLY mode (but will be playing on new queue initialization)
2020-09-29 06:22:53 +03:00
Avently
0370fa6c00
Merged 'dev' branch
2020-09-27 18:02:31 +03:00
Avently
e53e5ca20e
Disabled nested scrolling of queue
2020-09-27 15:50:21 +03:00
Avently
609bf64856
Merged 'dev' branch
2020-09-27 15:04:20 +03:00
Tobias Groza
d5f603303d
Merge pull request #4259 from TeamNewPipe/pref_migration
...
Add settings migration, remove "Detail page" option from share dialog and minimize to background by default
2020-09-27 11:20:39 +02:00
Tobias Groza
fc9c073a60
Merge pull request #3178 from cool-student/notificationImprovements
...
Notification Improvements
2020-09-27 10:43:11 +02:00
Avently
9a0c2c40bd
Refactoring and made the player returning from landscape & fullscreen on vertical video to portrait after clicking on fullscreen button
2020-09-27 06:39:42 +03:00
Avently
df9823988e
Changes for tablets and device's orientation behavior
...
- the app will not rotate the screen to portrait after video completes, it will just exit from fullscreen mode
- ability to rotate the orientation via fullscreen button from landscape to portrait when device has locked orientation in landscape
- ability to enter/exit to/from fullscreen on tablets with unlocked global orientation in portrait mode
2020-09-27 04:11:38 +03:00
TobiGr
0e5f85db95
Remove "Detail Page" open action from share dialog under certain circumstances
...
With the new application workflow and unified player, video detail page and video player are the same activity. So show only one of these options based on whether autoplay is enabled or not, and show both if using external player
2020-09-26 21:58:34 +02:00
Avently
3add24b8aa
Merged 'dev' branch
2020-09-26 02:42:26 +03:00
Tobias Groza
e0f02d4080
Merge pull request #4246 from avently/preloading
...
Disabled preloading when switching streams
2020-09-25 21:22:31 +02:00
Avently
c843e77183
Made notification thumbnail smaller
2020-09-23 15:20:25 +03:00
Stypox
b4e073cde7
Show replay icon in notification when player state is completed
2020-09-22 18:17:16 +02:00
Stypox
814efbf8df
Remove ACTION_BUFFERING, update buffering only if needed
...
- ACTION_BUFFERING was just wrong: why should the user be able to trigger the internal onBuffering() state by pressing on the buffering button? So that was replaced by a null intent, doing nothing.
- Now updating notification in onBuffering() only when buffering actions are not already buffering, to prevent useless updates
2020-09-22 18:17:16 +02:00
Stypox
11e048abb1
Remove hardcoded and duplicate strings, use exoplayer ones
2020-09-22 18:17:09 +02:00
Avently
518eb97e3a
Variable width for caption button and hiding system UI after popup close
2020-09-19 22:52:59 +03:00
Avently
f41549ccf1
Added a comment and excluded automatic switch of orientation on tablets and Android TVs
2020-09-19 17:21:01 +03:00
Avently
5b8eda4805
Increased performance of the UI. main thread is not as busy as before
2020-09-17 23:42:35 +03:00
Avently
886a949a00
Enable/disable video after screen on/off regardless of background playback setting
2020-09-17 22:30:03 +03:00
Avently
92e13dafe5
Correct exit from fullscreen in case of error or close from notification,
2020-09-17 19:01:20 +03:00
Avently
c9be812330
Fix for untouchable area
2020-09-16 23:41:49 +03:00
Stypox
59e7ebabfa
Random adjustements to notification
2020-09-16 14:00:22 +02:00
Avently
5ada0ae2c7
Hiding controls when orientation changes to landscape
2020-09-15 22:10:38 +03:00
Avently
a5312c1341
Perfect shadow
2020-09-15 19:50:46 +03:00
Avently
150e156d26
Reimagined player positioning
2020-09-15 14:43:43 +03:00
Avently
6d38615ea8
Android 11: transparent navigation and status bars
2020-09-14 11:30:41 +03:00
Avently
883e4fcd7c
Small fixes of issues with old devices support, brightness, etc
2020-09-11 20:52:38 +03:00
Stypox
2017e6a3e3
Refactor MediaSessionManager
2020-09-10 20:36:52 +02:00
Stypox
bccfe500b3
Fix seekbar invisible or not updating
...
Have the notification recreate only when strictly necessary, and recreate it if there was a timeline change, fixing the seekbar not updating at all sometimes
2020-09-10 20:22:22 +02:00
Stypox
52e89c1d1c
Prevent seeking out of video duration in player
2020-09-10 19:47:02 +02:00
Stypox
1605e50cef
Update notification when play queue is edited
2020-09-10 13:36:34 +02:00
Stypox
a13e6b69e3
Merge branch 'dev' into pr3178
2020-09-08 23:58:10 +02:00
Stypox
bc8954fbba
Fix notification content intent not being updated when needed
2020-09-08 22:00:28 +02:00
Stypox
9cf0bc6c82
Make notification creation and cancelling more consistent
2020-09-08 22:00:28 +02:00
Stypox
71b32fe641
Add notification costumization settings menu
2020-09-08 22:00:24 +02:00
Stypox
530f745e44
Merge pull request #4154 from avently/video-placement
...
Prevent jumping of the player and wrong padding on devices with cutout
2020-09-08 19:47:09 +02:00
Avently
31814b70da
Disabled preloading when switching streams
2020-09-07 19:34:10 +03:00
TacoTheDank
06d54ef77e
Clean up SDK version checks
2020-09-06 12:55:30 +02:00
TacoTheDank
f86b40302d
Some general-purpose lint cleanup
2020-09-06 12:55:26 +02:00
TacoTheDank
a4feb3fc09
Fix some deprecations
2020-09-06 12:52:43 +02:00
TacoTheDank
ba6c7de35a
Use AndroidX preference
2020-09-06 12:52:42 +02:00
Stypox
628575dc5f
Clean up MediaSessionManager
2020-09-04 18:44:09 +02:00
Avently
0a22f21410
Small fixes of issues with brightness, background playback, gestures
2020-09-04 05:39:55 +03:00
Stypox
97ff9e9c5b
Merge branch 'dev' into pr3178
2020-09-03 21:56:48 +02:00
Stypox
8b3a09306b
Various notification code improvements
...
Improve builder parameters
Reorder code and extract large icon function
service.startForeground() now is also provided with service type in android versions >= Q
2020-09-03 21:54:31 +02:00
Stypox
7766fd13fd
Extract hardcoded strings into strings.xml and improve them
2020-09-03 21:54:31 +02:00
Stypox
c79997ebe3
Show hourglass icon when buffering
2020-09-03 21:54:28 +02:00
Avently
b8a35e9e4a
Moved device-specific code into DeviceUtils
2020-09-03 15:48:17 +03:00
Avently
e833d415e3
Fixed wrong padding on devices with cutout on vertical videos
2020-09-03 15:48:17 +03:00
TobiGr
c66c81294e
Remove unused and redundant code.
2020-09-01 17:39:06 +02:00
Tobias Groza
bfdc215c65
Merge pull request #4155 from avently/gestures-interception
...
Skipping interception of some gestures
2020-09-01 16:51:34 +02:00
Tobias Groza
8d2ec30818
Merge pull request #4120 from mhmdanas/replace-SubtitlesStream-getURL-with-getUrl
...
Use SubtitlesStream#getUrl instead of getURL
2020-08-26 22:15:44 +02:00
mhmdanas
e5ffddfc6b
Use SubtitlesStream#getUrl instead of getURL
2020-08-26 23:04:18 +03:00
TobiGr
552d585fca
Extract common part from if
2020-08-18 13:28:13 +02:00
Avently
24c24d6c72
Skipping interception of some gestures
2020-08-17 20:42:05 +03:00
Tobias Groza
5485e994ee
Merge pull request #4138 from XiangRongLin/checkstyle_final
...
Add checkstyle rule to show final local variable violations as warning
2020-08-16 11:55:46 +02:00
wb9688
87228673b4
Use final where possible
2020-08-16 10:25:09 +02:00
Stypox
e08480f345
Completely remove old player notification
2020-08-15 22:03:32 +02:00
Stypox
12ac5ef781
[regression] Close player in onPlaybackShutdown()
2020-08-15 15:58:25 +02:00
Stypox
adef9a8acf
Rename notification functions: they are not background player only
2020-08-15 15:16:17 +02:00
nmurali94
04bb070afa
Remove timestamp when sharing a live stream
2020-08-12 09:54:35 -04:00
Stypox
963ee4dbab
Merge branch 'dev' into pr3178
2020-08-02 22:59:43 +02:00
wb9688
6de03f2bf0
Fix crash when playing stream in background with shuffle in notification
2020-07-31 09:25:32 +02:00
wb9688
caf7c55069
Log only in debug build
2020-07-31 09:10:28 +02:00
wb9688
7d499ffba1
Use vector drawables for close and replay
2020-07-31 09:10:28 +02:00
cool-student
4abf6b2f5c
Notification Improvements
...
- add MediaStyle notifications for Background and Popup playback
- reduce excessive notification updating ( / recreating of Notification.Builder object) when playing background / popup media
- add new buffering state indicator (can be disabled)
- upscale close icon / downscale replay icon
- add notification slot settings
- move notification settings to appearance
- fix Metadata (song title, artist and album art) sometimes not being set correctly
- other misc notification fixes
Co-authored-by: wb9688 <wb9688@users.noreply.github.com>
2020-07-31 09:10:28 +02:00
Avently
e41218c46b
Disable starting player service via media button when there is nothing to play (no active play queue)
2020-07-28 21:36:06 +03:00
Avently
68ed738dcd
Renamed files
2020-07-25 09:45:33 +03:00
Avently
5293d17e32
Removed unused files, translations, styles, settings key
2020-07-25 09:39:42 +03:00
Avently
f2e4b69466
Another part of UI improvements for Android TV
...
- focus will be hidden right after start of a video; fullscreen works like this too
- back button will not needed to be pressed one more time like before
- prev & next buttons for playqueue will be hidden with play/pause button before video be ready to play
2020-07-25 07:00:53 +03:00
Avently
08db1d59e5
Android TV: ability to select all buttons in the main player, as well as in the main fragment
2020-07-25 04:14:29 +03:00
Avently
7c79d421e8
Quality selector for external playback and better fullscreen mode for old devices
2020-07-24 00:43:09 +03:00
Avently
91a0257c8f
Fixes for Android API <21
2020-07-22 17:19:32 +03:00
Avently
7aa8a5c368
Fixed a situation when background playback could use a video stream instead of an audio stream
2020-07-22 02:20:58 +03:00
Avently
3ecbbea7cb
Better TV support, icons, activity_main refactoring
...
- on Android TV you'll be able to navigate with D-pad in main fragment and in the player. But not between them for now
- play/pause/next/previous buttons are smaller now
- replaced ic_list with previous version of it
- activity_main looks better which helps with Android TV support
2020-07-22 01:20:30 +03:00
Avently
77cd3182f1
Removed unused line
2020-07-21 01:53:59 +03:00
Avently
c7ccf9bab8
AndroidTvUtils -> DeviceUtils
2020-07-21 01:43:49 +03:00
Avently
06e70abb86
Merged the latest changes
2020-07-21 01:37:36 +03:00
Tobias Groza
19e152a54b
Merge pull request #3689 from wb9688/next-stream
...
Remove calls to getNextStream()
2020-07-18 11:59:04 +02:00
wb9688
4274827dbe
Use relatedItems instead of info.getRelatedStreams()
2020-07-15 18:52:36 +02:00
wb9688
7a30f4a7d2
Remove calls to getNextStream()
2020-07-14 21:27:59 +02:00
wb9688
d0c03a0211
Use androidx.annotation.NonNull instead of io.reactivex.annotations.NonNull
2020-07-14 21:15:29 +02:00
Avently
08412d6108
Mini player slide to botom fix, buttons size fix
2020-07-14 21:52:55 +03:00
Avently
d8f7db4715
Made checkStyle happy
2020-07-14 20:21:32 +03:00
Avently
bff238774e
Small fixes of issues
2020-07-13 23:28:39 +03:00
Avently
d2aaa6f691
Merged the latest changes
2020-07-13 04:17:21 +03:00
Avently
b2164ce5fc
Marked many (too many) variables as final
2020-07-12 03:59:47 +03:00
wb9688
dd57e246b8
Use getNextPage() instead of getNextPageUrl()
2020-07-07 21:03:24 +02:00
Stypox
38c79bbc11
Fix audio/video desync caused by floating point cumulative errors
2020-06-30 22:41:09 +02:00
Tobias Groza
d9100913d5
Merge pull request #3787 from budde25/fix-popup-queue
...
Fixes enqueue resuming paused videos
2020-06-27 11:56:08 +02:00
Avently
a7fbe05a73
Changes for review
2020-06-27 06:25:50 +03:00
Tobias Groza
fe4516ea23
Merge pull request #3752 from Redirion/exoupdate
...
Update to ExoPlayer 2.11.6
2020-06-26 18:33:53 +02:00
Ethan Budd
33266a96ff
fixes enqueue resuming paused videos
2020-06-17 22:15:50 -05:00
wb9688
5cfd8bbb56
Merge pull request #3704 from Stypox/keep-failed-streams
...
Do not remove items generating errors form queue
2020-06-15 15:16:26 +02:00
wb9688
e6fe6fd645
Merge pull request #3437 from TheLastGimbus/fast-rewind-forward-in-background-activity
...
Fast rewind forward in background activity
2020-06-15 15:06:58 +02:00
TheLastGimbus
abe77c4783
Change to final
2020-06-14 19:52:58 +02:00
TheLastGimbus
72af51fe9d
Add speed button to top bar
2020-06-14 15:16:04 +02:00
TheLastGimbus
36b4134838
Remove speed buttons from bottom menu
2020-06-14 15:15:38 +02:00
Robin
145e0a0b7b
Update to ExoPlayer 2.11.5
2020-06-06 15:29:52 +02:00
Stypox
b3db8c9549
Do not remove items generating errors form queue
2020-05-31 14:06:22 +02:00
Stypox
9e57195e14
Fix checkstyle issues
...
Also replace all tabs with 4 spaces
2020-05-21 15:39:36 +02:00
Stypox
e3e2028153
Use AppCompatResources instead of ContextCompat
2020-05-21 15:39:36 +02:00
Stypox
883bcc735d
Fix pause used instead of play in paused popup player when seeking
...
Also use `setBackgroundResource` to automatically obtain PNG drawables (from exoplayer)
2020-05-21 15:39:36 +02:00
Stypox
631dfee763
Readd ic_close and ic_replay PNGs: needed in notifications
...
The other icons used in notifications are taken from exoplayer's ones: `@drawable/exo_controls_*`
2020-05-21 15:39:36 +02:00
Stypox
ea43b28f74
Use vector drawables instead of PNGs for material icons
...
For all manually-created images PNG have been kept.
- rename all icon attrs to have a `ic_` prefix
- always use `_24dp` icons, because there is no real difference, since they are vector drawables
- always use the original name found on material.io for icon drawables, as to not create confusion and possibly duplicates. Icon names can still be different from real drawable names, though I have made some of them compliant to this or maybe more meaningul.
- remove duplicate `getIconByAttr()` in ThemeHelper (use `resolveResourceIdFromAttr()`
- use standard icons for `expand_more` and `expand_less` instead of triangles
- use `play_button_outline` instead of custom PNG as play button in VideoDetailFragment (questionable, as there is no shadow anymore)
2020-05-21 15:39:35 +02:00
Stypox
c05467fb92
Merge pull request #3513 from Stypox/exoplayer
...
Update to ExoPlayer 2.11.4
2020-05-17 22:02:19 +02:00
Tobias Groza
b3eadb557b
Merge pull request #3337 from AioiLight/blocking-gesture-when-touch-from-navbar
...
Block the gesture when touch it from NavigationBar or StatusBar.
2020-05-09 10:43:15 +02:00
AioiLight
0abd2bcba6
Clean up code
...
Follow Checkstyle
Move to PlayerGestureListener from VideoPlayerImpl
Update app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java
Co-authored-by: wb9688 <46277131+wb9688@users.noreply.github.com>
2020-05-09 10:11:46 +02:00
wb9688
b990f30a09
Merge pull request #3545 from Stypox/kore
...
Fix Kodi button showing up with unsupported services
2020-05-07 21:44:09 +02:00
Stypox
5c711322d4
In player hide kodi button if service unsupported
2020-05-07 21:11:34 +02:00
wb9688
ff7344438b
Optimize imports
2020-05-01 20:13:01 +02:00
Stypox
b4ddc8f96c
Update to ExoPlayer 2.11.4
2020-05-01 15:03:54 +02:00
TheLastGimbus
1975973ff2
Update progress bar on fast forward/rewind
2020-04-25 15:46:56 +02:00
bopol
00262b4a49
Better detection of TV devices
...
Some devices were not detected as TV even though they are
2020-04-25 12:04:44 +02:00
Stypox
0ec22c7a6e
Fix pause button is not focused on player control activation
2020-04-21 09:25:09 +02:00
TheLastGimbus
63afacc067
Add listeners in activity
2020-04-14 22:06:32 +02:00
Alexander--
54ceb85ebe
Don't break navigation if player Views other than controls are focused
2020-04-11 16:04:38 +06:59
Alexander--
d1d942f3fd
Fix Checkstyle violations in MediaSourceManager
2020-04-11 09:51:50 +06:59
Alexander--
53b3bda909
Comply with Checkstyle rules
2020-04-11 09:02:22 +06:59
Alexander--
ac5571a363
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-04-11 08:30:40 +06:59
Alexander--
c42f5eca87
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-04-11 08:24:05 +06:59
Stypox
a50e430cd9
Fix checkstyle issues and improve code formatting
...
Also calculate differently the moved distance of a pointer: use euclidean and not manhattan geometry
2020-04-10 22:12:45 +02:00
Harshal Lele
46918ee907
formatting changes
2020-04-10 22:10:32 +02:00
Harshal Lele
fe1889653e
made formatting changes
2020-04-10 22:10:32 +02:00
Harshal Lele
9487b5367d
changed popup resizing
2020-04-10 22:10:32 +02:00
Xiang Rong Lin
3855e488cb
Save and restore playback parameters into/from preferences
...
Playback parameters are speed, pitch and skip silence.
Remove parameters being passed on as intent to the player, since the parameters can be restored from the preferences instead.
# Conflicts:
# app/src/main/java/org/schabi/newpipe/player/BasePlayer.java
2020-04-05 17:46:49 +02:00
AioiLight
562754c0b9
Merge branch 'dev' into blocking-gesture-when-touch-from-navbar
2020-04-04 23:52:06 +09:00
Alexander--
3c193dca58
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-04-03 06:56:52 +06:59
AioiLight
d9c6f7acb6
Block the gesture when touch it from NavigationBar or StatusBar.
2020-04-03 05:11:36 +09:00
wb9688
63bcc04eff
Move things back to its original place
2020-04-02 15:57:50 +02:00
wb9688
fda5405e48
Improve code style to be more consistent
2020-04-02 15:57:50 +02:00
Stypox
00a8906128
Fix mute button causing crashes on API 19
...
Using rootView.getContext() because getApplicationContext() didn't work (it was probably missing information about theme)
2020-04-01 09:08:03 +02:00
Alexander--
6a84f433ea
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-03-30 16:54:51 +06:59
Mauricio Colli
f9b718f1eb
Use correct class for getting a vector drawable in older APIs
2020-03-28 14:30:47 -03:00
bopol
8d068b339a
remove unused imports
2020-03-21 21:54:40 +01:00
bopol
c54ac32732
mute button color for queue
2020-03-21 21:51:11 +01:00
bopol
47c5008871
Change mute button color for more visibility
2020-03-21 16:58:53 +01:00
Alexander--
fa6823599a
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-03-12 04:48:37 +06:59
Avently
398cbe9284
Better backstack, better tablet support, switching players confirmation, fix for background playback
2020-03-10 12:06:38 +03:00
Stypox
8fa29ffc19
Merge pull request #3165 from karkaminski/mute_button
...
Mute button
2020-03-08 10:29:25 +01:00
karol
55d7be0b2f
null risk issue
2020-03-05 19:07:46 +01:00
karol
83c7c4a68e
mute/unmute text change in action bar
2020-03-04 18:53:17 +01:00
karol
1ae8a72ba6
mute icon change in action bar
2020-03-04 18:37:04 +01:00
karol
840bb29c54
icon color change in action bar
2020-03-03 00:01:19 +01:00
karol
c79f09c119
mute button in actionbar, no color change
2020-03-02 22:52:58 +01:00
karol
92ee51b8db
resolved issues
2020-03-02 21:12:02 +01:00
karol
a6fcb70d12
fix typo
2020-03-01 16:42:46 +01:00
karol
ee75909c80
set mute button in main player from other player
2020-03-01 13:02:20 +01:00
Avently
d87e488c23
Fix for a ripple effect on a button
2020-02-29 22:13:07 +03:00
Avently
5c2ff9b777
Better implementation of old code
2020-02-29 02:57:54 +03:00
karol
0400fcb106
mute icon in main refactored
2020-02-27 23:30:17 +01:00
karol
40f54aea53
mute intent send between main-bckgrnd-popup players
2020-02-27 22:30:18 +01:00
Marcel Dopita
91aa65e717
Support display cutout
...
Fixes #2682
2020-02-26 17:47:22 +01:00
Alexander--
56544802e8
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-02-26 05:56:09 +06:59
Avently
6d7e37610c
Vertical videos in portrait & fullscreen, UI enhancements for tablets and phones, fixes
...
- vertical videos now work ok in portrait and fullscreen mode at the same time
- auto pause on back press is disabled for large tablets
- large dragable area for swipe to bottom in fullscreen mode in place of top controls
- appbar will be scrolled to top when entering in fullscreen mode
2020-02-25 02:15:22 +03:00
karol
c4d5886059
icon change implemented in queque
2020-02-23 23:44:16 +01:00
karol
2a63f2a3a6
mute-buton in queue layout and logic, but no icon change
2020-02-23 23:31:30 +01:00
karol
cc559dc9ce
isMuted() added
2020-02-23 22:55:34 +01:00
karol
4415888324
mute-button implementation in main player
2020-02-23 22:32:23 +01:00
Tobias Groza
7da28f28e5
Merge branch 'dev' into unhook-save-restore
2020-02-23 00:19:44 +01:00
TobiGr
0bc769b971
Fix regression: Unable to find explicit activity class
...
See https://github.com/TeamNewPipe/NewPipe/issues/3114#issuecomment-589940878 for info on this crash.
This reverts ef90493c27
partly.
2020-02-22 20:43:38 +01:00
Stypox
c7b4705538
Implement Settings buttons
2020-02-22 10:36:10 +01:00
Alexey Dubrov
e3a891688b
Get brightness from settings if screenBrightness is set to auto
2020-02-17 12:11:00 +03:00
Alexey Dubrov
51f2efd48c
Fix initial brightness value
2020-02-16 16:08:53 +03:00
Avently
a47e6dd8c5
AppBarLayout scrolling awesomeness, PlayQueue layout touches interception, player's controls' margin
...
- made scrolling in appBarLayout awesome
- PlayQueue layout was intercepting touches while it was in GONE visibility state. Now it's not gonna happen
- removed margin between two lines of player's controls
- when a user leaves the app with two back presses the app will not stop MainPlayer service if popup or background players play
2020-02-12 22:33:23 +03:00
Alexander--
e6df041613
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-02-06 02:44:08 +06:59
Avently
f334a2740f
Mini player, ExpandableSurfaceView with ZOOM support, popup
...
- mini player's title, image and author information will be updated in many situations but the main idea is that the info will be the same as currently playing stream. If nothing played then you'll see the info about currently opened stream in fragment. When MainPlayer service stops the info updates too
- made ExpandableSurfaceView to replace AspectRatioFrameLayout. The reason for that is to make possible to use aspect ratio mode ZOOM. It's impossible to show a stream inside AspectRatioFrameLayout with ZOOM mode and to fit the video view to a screen space at the same time. Now the new view able to do that and to show vertical videos in a slightly wide space for them
- refactored some methods to make the code more understandable
- made fixes for player view for landscape-to-landscape orientation change
- added Java docs
- adapted swipe tracking inside bottom sheet
- fixed PlayQueue crashes on clearing
- paddings for popup player now as small as possible
2020-02-05 08:59:30 +03:00
Stypox
0f22833ad5
Save and restore whether pitch and tempo are unhooked or not
...
Fixes #1536
2020-02-02 15:52:35 +01:00
bopol
edc9d47da7
app language: refactoring
...
renamed NewPipe's language into App language, and same for all the
concerning thing (keys, comments…)
we now call assureCorrectAppLanguage(CONTEXT) in activities needing it
instead of changeAppLanguage(getAppLocale(CONTEXT), RESOURCES)
changeAppLanguage becomes private.
2020-01-29 21:21:00 +01:00
Alexander--
caa1de8aff
Rename FireTvUtils to AndroidTvUtils and isFireTv() to isTV()
...
Because those methods are no longer exclusive to Amazon devices
2020-01-29 03:16:33 +06:59
Alexander--
fac13fb8cb
Merge remote-tracking branch 'newpipe/dev' into rebase
2020-01-29 03:10:16 +06:59
B0pol
e94981e6f7
Merge branch 'dev' into dev
2020-01-27 19:24:18 +01:00
Christophe
94403a9c3c
Add send to Kodi button to player next to share button
2020-01-27 10:27:24 +01:00
Tobias Groza
609855f774
Merge pull request #2917 from raphj/patch-1
...
Allow a BasePlayer to start paused
2020-01-26 17:39:39 +01:00
B0pol
e58088d290
Merge branch 'dev' into dev
2020-01-19 18:09:17 +01:00
bopol
b155f23d27
fix: wrong language shown in playback parameters dialog
...
This is a hardly reproduceable bug that I hopefully fixed. After a long time of watching videos, you could have your system language shown in playback parameters dialog.
Calling changeAppLanguage(getAppLocale(…),…) onCreate will most certainly fix this bug
2020-01-18 09:46:38 +01:00
Avently
cc438fdb7b
Player's elements positioning is better for tablet and in multiWindow mode
...
- status bar got a fix for situation when a phone vendor did not provide status bar height for landscape orientation
- popup will not be init'd twice
- also fixed some non-reproduceable bugs
2020-01-17 17:37:53 +03:00
Raphaël Jakse
7dbb2b206c
Simplify an if expression
2020-01-17 11:49:33 +01:00
Raphaël Jakse
ef90493c27
Deduplicate code switching to another player into a function
2020-01-17 11:49:20 +01:00
Raphaël Jakse
570dded8d6
Add field START_PAUSED to the Player Intent
...
This allows fixing spurious playback resume when minimizing to the background player.
2020-01-16 20:57:55 +01:00