subscription: Cover testing for import type fallback

The resolver tests cover the octet-stream, missing-type, and unknown-extension fallbacks. The extractor tests confirm that CSV and Takeout zip inputs parse through the YouTube extractor once the content type is resolved. This keeps the regression coverage tied to the parser path that rejected the Downloads import.
2026-07-28 13:58:51 +00:00 · 2026-07-11 16:14:41 +08:00
parent 91e21cee35
commit cd54f56b3d
1 changed files with 134 additions and 0 deletions
@@ -0,0 +1,134 @@
+package org.schabi.newpipe.local.subscription.workers
+
+import java.io.ByteArrayInputStream
+import java.io.ByteArrayOutputStream
+import java.nio.charset.StandardCharsets
+import java.util.zip.ZipEntry
+import java.util.zip.ZipOutputStream
+import org.junit.Assert.assertEquals
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.Mockito
+import org.mockito.Mockito.`when`
+import org.mockito.Mockito.withSettings
+import org.mockito.junit.MockitoJUnitRunner
+import org.schabi.newpipe.extractor.ServiceList
+import org.schabi.newpipe.extractor.subscription.SubscriptionItem as ExtractorSubscriptionItem
+import org.schabi.newpipe.streams.io.StoredFileHelper
+
+@RunWith(MockitoJUnitRunner::class)
+class SubscriptionImportWorkerTest {
+
+    @Test
+    fun `Octet-stream csv import must resolve to csv`() {
+        assertResolvedContentType("csv", StoredFileHelper.DEFAULT_MIME, "subscriptions.csv")
+    }
+
+    @Test
+    fun `Octet-stream csv import must parse through YouTube extractor`() {
+        val contentType = resolveContentType(StoredFileHelper.DEFAULT_MIME, "subscriptions.csv")
+        val items = ServiceList.YouTube.subscriptionExtractor.fromInputStream(
+            ByteArrayInputStream(SUBSCRIPTIONS_CSV.toByteArray(StandardCharsets.UTF_8)),
+            contentType
+        )
+
+        assertSampleSubscriptions(items)
+    }
+
+    @Test
+    fun `Missing content type csv import must resolve to csv`() {
+        assertResolvedContentType("csv", null, "subscriptions.csv")
+    }
+
+    @Test
+    fun `Octet-stream takeout archive must resolve to zip`() {
+        assertResolvedContentType("zip", StoredFileHelper.DEFAULT_MIME, "takeout.zip")
+    }
+
+    @Test
+    fun `Octet-stream takeout archive must parse through YouTube extractor`() {
+        val contentType = resolveContentType(StoredFileHelper.DEFAULT_MIME, "takeout.zip")
+        val items = ServiceList.YouTube.subscriptionExtractor.fromInputStream(
+            ByteArrayInputStream(createTakeoutZip()),
+            contentType
+        )
+
+        assertSampleSubscriptions(items)
+    }
+
+    @Test
+    fun `Provider content type must be preserved`() {
+        assertResolvedContentType("application/json", "application/json")
+    }
+
+    @Test
+    fun `Unknown octet-stream import must stay octet-stream`() {
+        assertResolvedContentType(StoredFileHelper.DEFAULT_MIME, StoredFileHelper.DEFAULT_MIME, "subscriptions")
+    }
+
+    private fun assertResolvedContentType(
+        expectedContentType: String,
+        contentType: String?,
+        fileName: String? = null
+    ) {
+        assertEquals(expectedContentType, resolveContentType(contentType, fileName))
+    }
+
+    private fun resolveContentType(contentType: String?, fileName: String? = null): String {
+        val fileHelper = Mockito.mock(StoredFileHelper::class.java, withSettings().stubOnly())
+        `when`(fileHelper.type).thenReturn(contentType)
+        if (fileName != null) {
+            `when`(fileHelper.name).thenReturn(fileName)
+        }
+
+        return SubscriptionImportWorker.getInputStreamContentType(fileHelper)
+    }
+
+    private fun createTakeoutZip(): ByteArray {
+        val output = ByteArrayOutputStream()
+        ZipOutputStream(output).use { zip ->
+            zip.putNextEntry(ZipEntry("YouTube and YouTube Music/subscriptions/subscriptions.csv"))
+            zip.write(SUBSCRIPTIONS_CSV.toByteArray(StandardCharsets.UTF_8))
+            zip.closeEntry()
+        }
+        return output.toByteArray()
+    }
+
+    private fun assertSampleSubscriptions(items: List<ExtractorSubscriptionItem>) {
+        assertEquals(SAMPLE_SUBSCRIPTIONS.size, items.size)
+        SAMPLE_SUBSCRIPTIONS.forEachIndexed { index, subscription ->
+            assertEquals(ServiceList.YouTube.serviceId, items[index].serviceId)
+            assertEquals(subscription.url.replace("http://", "https://"), items[index].url)
+            assertEquals(subscription.name, items[index].name)
+        }
+    }
+
+    private data class SampleSubscription(val id: String, val url: String, val name: String)
+
+    companion object {
+        private val SAMPLE_SUBSCRIPTIONS = listOf(
+            SampleSubscription(
+                "UCCj956IF62FbT7Gouszaj9w",
+                "http://www.youtube.com/channel/UCCj956IF62FbT7Gouszaj9w",
+                "BBC"
+            ),
+            SampleSubscription(
+                "UCXuqSBlHAE6Xw-yeJA0Tunw",
+                "http://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw",
+                "Linus Tech Tips"
+            ),
+            SampleSubscription(
+                "UCBJycsmduvYEL83R_U4JriQ",
+                "http://www.youtube.com/channel/UCBJycsmduvYEL83R_U4JriQ",
+                "Marques Brownlee"
+            )
+        )
+
+        private val SUBSCRIPTIONS_CSV = buildString {
+            appendLine("Channel Id,Channel Url,Channel Title")
+            SAMPLE_SUBSCRIPTIONS.forEach { subscription ->
+                appendLine("${subscription.id},${subscription.url},${subscription.name}")
+            }
+        }.trimEnd()
+    }
+}