mirrors
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #8743 from shivambeohar/8615-gap-at-miniplayer-close-button-fix 

Remove padding from the end of the mini-player
This commit is contained in:
Stypox 2022-11-29 12:31:55 +01:00 committed by GitHub
parent 2984649106 2bf58abb89
commit 05903502c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/src/main/res/layout-large-land/fragment_video_detail.xml
View File

@ -603,19 +603,19 @@
android:id="@+id/view_pager" android:id="@+id/view_pager"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
app:layout_behavior="@string/appbar_scrolling_view_behavior" android:paddingBottom="48dp"
android:paddingBottom="48dp"/> app:layout_behavior="@string/appbar_scrolling_view_behavior" />
<com.google.android.material.tabs.TabLayout <com.google.android.material.tabs.TabLayout
android:id="@+id/tab_layout" android:id="@+id/tab_layout"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="bottom|center" android:layout_gravity="bottom|center"
app:tabIndicatorGravity="top" app:elevation="16dp"
app:tabIconTint="?attr/colorAccent"
app:tabBackground="?attr/windowBackground" app:tabBackground="?attr/windowBackground"
app:tabGravity="fill" app:tabGravity="fill"
app:elevation="16dp"/> app:tabIconTint="?attr/colorAccent"
app:tabIndicatorGravity="top" />
</org.schabi.newpipe.views.FocusAwareCoordinator> </org.schabi.newpipe.views.FocusAwareCoordinator>
@ -627,6 +627,7 @@
android:layout_weight="3" /> android:layout_weight="3" />
</LinearLayout> </LinearLayout>
<RelativeLayout <RelativeLayout
android:id="@+id/overlay_layout" android:id="@+id/overlay_layout"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -657,6 +658,7 @@
android:focusable="true" android:focusable="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:orientation="vertical" android:orientation="vertical"
android:theme="@style/ContrastTintTheme"
tools:ignore="RtlHardcoded"> tools:ignore="RtlHardcoded">
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView
@ -694,8 +696,7 @@
android:layout_height="60dp" android:layout_height="60dp"
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:paddingLeft="@dimen/video_item_search_padding" android:theme="@style/ContrastTintTheme"
android:paddingRight="@dimen/video_item_search_padding"
tools:ignore="RtlHardcoded"> tools:ignore="RtlHardcoded">
<ImageButton <ImageButton
@ -703,7 +704,7 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:padding="10dp" android:contentDescription="@string/title_activity_play_queue"
android:scaleType="center" android:scaleType="center"
android:src="@drawable/ic_list" android:src="@drawable/ic_list"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -713,22 +714,22 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:padding="10dp" android:contentDescription="@string/pause"
android:scaleType="center"
android:focusable="true" android:focusable="true"
android:focusedByDefault="true" android:focusedByDefault="true"
android:src="@drawable/ic_play_arrow" android:scaleType="center"
tools:ignore="ContentDescription,RtlHardcoded" /> android:src="@drawable/ic_play_arrow" />
<ImageButton <ImageButton
android:id="@+id/overlay_close_button" android:id="@+id/overlay_close_button"
android:layout_width="40dp" android:layout_width="48dp"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:padding="10dp" android:contentDescription="@string/close"
android:paddingRight="8dp"
android:scaleType="center" android:scaleType="center"
android:src="@drawable/ic_close" android:src="@drawable/ic_close"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="RtlSymmetry" />
</LinearLayout> </LinearLayout>

30
app/src/main/res/layout/fragment_video_detail.xml
View File

@ -41,9 +41,9 @@
android:id="@+id/detail_thumbnail_image_view" android:id="@+id/detail_thumbnail_image_view"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:minHeight="200dp"
android:background="?windowBackground" android:background="?windowBackground"
android:contentDescription="@string/detail_thumbnail_view_description" android:contentDescription="@string/detail_thumbnail_view_description"
android:minHeight="200dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
tools:ignore="RtlHardcoded" tools:ignore="RtlHardcoded"
tools:layout_height="200dp" tools:layout_height="200dp"
@ -586,19 +586,19 @@
android:id="@+id/view_pager" android:id="@+id/view_pager"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
app:layout_behavior="@string/appbar_scrolling_view_behavior" android:paddingBottom="48dp"
android:paddingBottom="48dp"/> app:layout_behavior="@string/appbar_scrolling_view_behavior" />
<com.google.android.material.tabs.TabLayout <com.google.android.material.tabs.TabLayout
android:id="@+id/tab_layout" android:id="@+id/tab_layout"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="bottom|center" android:layout_gravity="bottom|center"
app:tabIndicatorGravity="top" app:elevation="16dp"
app:tabIconTint="?attr/colorAccent"
app:tabBackground="?attr/windowBackground" app:tabBackground="?attr/windowBackground"
app:tabGravity="fill" app:tabGravity="fill"
app:elevation="16dp"/> app:tabIconTint="?attr/colorAccent"
app:tabIndicatorGravity="top" />
</androidx.coordinatorlayout.widget.CoordinatorLayout> </androidx.coordinatorlayout.widget.CoordinatorLayout>
@ -668,8 +668,6 @@
android:layout_height="60dp" android:layout_height="60dp"
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:paddingLeft="@dimen/video_item_search_padding"
android:paddingRight="@dimen/video_item_search_padding"
android:theme="@style/ContrastTintTheme" android:theme="@style/ContrastTintTheme"
tools:ignore="RtlHardcoded"> tools:ignore="RtlHardcoded">
@ -678,7 +676,7 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:padding="10dp" android:contentDescription="@string/title_activity_play_queue"
android:scaleType="center" android:scaleType="center"
android:src="@drawable/ic_list" android:src="@drawable/ic_list"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -688,22 +686,22 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:padding="10dp" android:contentDescription="@string/pause"
android:scaleType="center"
android:focusable="true" android:focusable="true"
android:focusedByDefault="true" android:focusedByDefault="true"
android:src="@drawable/ic_play_arrow" android:scaleType="center"
tools:ignore="ContentDescription,RtlHardcoded" /> android:src="@drawable/ic_play_arrow" />
<ImageButton <ImageButton
android:id="@+id/overlay_close_button" android:id="@+id/overlay_close_button"
android:layout_width="40dp" android:layout_width="48dp"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:padding="10dp" android:contentDescription="@string/close"
android:paddingRight="8dp"
android:scaleType="center" android:scaleType="center"
android:src="@drawable/ic_close" android:src="@drawable/ic_close"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="RtlSymmetry" />
</LinearLayout> </LinearLayout>