Add a little bit of source code checking to Gradle

- Adds a CheckStyle configuration which is pretty similar to CC's
   existing one.
 - Add the Gradle license plugin.
 - Ensure the existing source code is compatible with these additional
   checks.

See #239

src/main/java/dan200/computercraft/api/AbstractTurtleUpgrade.java

@@ -1,9 +1,8 @@
 /*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
+ * This file is part of the public ComputerCraft API - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
+ * For help using the API, and posting your mods, visit the forums at computercraft.info.
  */
-
 package dan200.computercraft.api;
 
 import dan200.computercraft.api.turtle.ITurtleUpgrade;

src/main/java/dan200/computercraft/api/ComputerCraftAPI.java

@@ -438,45 +438,45 @@ public final class ComputerCraftAPI
                 computerCraft_getVersion = findCCMethod( "getVersion", new Class<?>[] {
                 } );
                 computerCraft_createUniqueNumberedSaveDir = findCCMethod( "createUniqueNumberedSaveDir", new Class<?>[] {
-                    World.class, String.class
+                    World.class, String.class,
                 } );
                 computerCraft_createSaveDirMount = findCCMethod( "createSaveDirMount", new Class<?>[] {
-                    World.class, String.class, Long.TYPE
+                    World.class, String.class, Long.TYPE,
                 } );
                 computerCraft_createResourceMount = findCCMethod( "createResourceMount", new Class<?>[] {
-                    Class.class, String.class, String.class
+                    Class.class, String.class, String.class,
                 } );
                 computerCraft_registerPeripheralProvider = findCCMethod( "registerPeripheralProvider", new Class<?>[] {
-                    IPeripheralProvider.class
+                    IPeripheralProvider.class,
                 } );
                 computerCraft_registerTurtleUpgrade = findCCMethod( "registerTurtleUpgrade", new Class<?>[] {
-                    ITurtleUpgrade.class
+                    ITurtleUpgrade.class,
                 } );
                 computerCraft_registerBundledRedstoneProvider = findCCMethod( "registerBundledRedstoneProvider", new Class<?>[] {
-                    IBundledRedstoneProvider.class
+                    IBundledRedstoneProvider.class,
                 } );
                 computerCraft_getDefaultBundledRedstoneOutput = findCCMethod( "getDefaultBundledRedstoneOutput", new Class<?>[] {
-                    World.class, BlockPos.class, EnumFacing.class
+                    World.class, BlockPos.class, EnumFacing.class,
                 } );
                 computerCraft_registerMediaProvider = findCCMethod( "registerMediaProvider", new Class<?>[] {
-                    IMediaProvider.class
+                    IMediaProvider.class,
                 } );
                 computerCraft_registerPermissionProvider = findCCMethod( "registerPermissionProvider", new Class<?>[] {
-                    ITurtlePermissionProvider.class
+                    ITurtlePermissionProvider.class,
                 } );
                 computerCraft_registerPocketUpgrade = findCCMethod( "registerPocketUpgrade", new Class<?>[] {
-                    IPocketUpgrade.class
+                    IPocketUpgrade.class,
                 } );
                 computerCraft_getWirelessNetwork = findCCMethod( "getWirelessNetwork", new Class<?>[] {
                 } );
                 computerCraft_registerAPIFactory = findCCMethod( "registerAPIFactory", new Class<?>[] {
-                    ILuaAPIFactory.class
+                    ILuaAPIFactory.class,
                 } );
                 computerCraft_createWiredNodeForElement = findCCMethod( "createWiredNodeForElement", new Class<?>[] {
-                    IWiredElement.class
+                    IWiredElement.class,
                 } );
                 computerCraft_getWiredElementAt = findCCMethod( "getWiredElementAt", new Class<?>[] {
-                    IBlockAccess.class, BlockPos.class, EnumFacing.class
+                    IBlockAccess.class, BlockPos.class, EnumFacing.class,
                 } );
             }
             catch( Exception e )

src/main/java/dan200/computercraft/api/filesystem/FileOperationException.java

@@ -1,9 +1,8 @@
 /*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
+ * This file is part of the public ComputerCraft API - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
+ * For help using the API, and posting your mods, visit the forums at computercraft.info.
  */
-
 package dan200.computercraft.api.filesystem;
 
 import javax.annotation.Nonnull;
@@ -20,7 +19,7 @@ public class FileOperationException extends IOException
 {
     private static final long serialVersionUID = -8809108200853029849L;
 
-    private String filename;
+    private final String filename;
 
     public FileOperationException( @Nullable String filename, @Nonnull String message )
     {
@@ -31,6 +30,7 @@ public class FileOperationException extends IOException
     public FileOperationException( String message )
     {
         super( Objects.requireNonNull( message, "message cannot be null" ) );
+        this.filename = null;
     }
 
     @Nullable

src/main/java/dan200/computercraft/api/peripheral/IWorkMonitor.java

@@ -1,9 +1,8 @@
 /*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
+ * This file is part of the public ComputerCraft API - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
+ * For help using the API, and posting your mods, visit the forums at computercraft.info.
  */
-
 package dan200.computercraft.api.peripheral;
 
 import javax.annotation.Nonnull;

src/main/java/dan200/computercraft/api/pocket/AbstractPocketUpgrade.java

@@ -1,9 +1,8 @@
 /*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
+ * This file is part of the public ComputerCraft API - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
+ * For help using the API, and posting your mods, visit the forums at computercraft.info.
  */
-
 package dan200.computercraft.api.pocket;
 
 import net.minecraft.item.ItemStack;

src/main/java/dan200/computercraft/api/turtle/event/TurtleInspectItemEvent.java

@@ -1,9 +1,8 @@
 /*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
+ * This file is part of the public ComputerCraft API - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
+ * For help using the API, and posting your mods, visit the forums at computercraft.info.
  */
-
 package dan200.computercraft.api.turtle.event;
 
 import dan200.computercraft.api.lua.ILuaContext;

src/main/java/dan200/computercraft/api/turtle/event/TurtleRefuelEvent.java

@@ -1,9 +1,8 @@
 /*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
+ * This file is part of the public ComputerCraft API - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
+ * For help using the API, and posting your mods, visit the forums at computercraft.info.
  */
-
 package dan200.computercraft.api.turtle.event;
 
 import dan200.computercraft.api.turtle.ITurtleAccess;

src/main/java/dan200/computercraft/client/gui/GuiTurtle.java

@@ -120,7 +120,7 @@ public class GuiTurtle extends GuiContainer
             int slotX = slot % 4;
             int slotY = slot / 4;
             mc.getTextureManager().bindTexture( advanced ? BACKGROUND_ADVANCED : BACKGROUND_NORMAL );
-            drawTexturedModalRect( guiLeft + m_container.m_turtleInvStartX - 2 + slotX * 18, guiTop + m_container.m_playerInvStartY - 2 + slotY * 18, 0, 217, 24, 24 );
+            drawTexturedModalRect( guiLeft + m_container.turtleInvStartX - 2 + slotX * 18, guiTop + m_container.playerInvStartY - 2 + slotY * 18, 0, 217, 24, 24 );
         }
     }
 

src/main/java/dan200/computercraft/client/render/ModelTransformer.java

@@ -94,7 +94,7 @@ public final class ModelTransformer
         private final Point3f[] before = new Point3f[4];
         private final Point3f[] after = new Point3f[4];
 
-        public NormalAwareTransformer( IVertexConsumer parent, Matrix4f positionMatrix, Matrix4f normalMatrix )
+        NormalAwareTransformer( IVertexConsumer parent, Matrix4f positionMatrix, Matrix4f normalMatrix )
         {
             super( parent );
             this.positionMatrix = positionMatrix;

src/main/java/dan200/computercraft/core/apis/FSAPI.java

@@ -43,9 +43,7 @@ public class FSAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "fs"
-        };
+        return new String[] { "fs" };
     }
 
     @Override

src/main/java/dan200/computercraft/core/apis/HTTPAPI.java

@@ -42,9 +42,7 @@ public class HTTPAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "http"
-        };
+        return new String[] { "http" };
     }
 
     @Override

src/main/java/dan200/computercraft/core/apis/ILuaAPI.java

@@ -10,6 +10,7 @@ package dan200.computercraft.core.apis;
  * This exists purely to ensure binary compatibility.
  *
  * @see dan200.computercraft.api.lua.ILuaAPI
+ * @deprecated Use the version in the public API. Only exists for compatibility with CCEmuX.
  */
 @Deprecated
 public interface ILuaAPI extends dan200.computercraft.api.lua.ILuaAPI

src/main/java/dan200/computercraft/core/apis/OSAPI.java

@@ -36,9 +36,9 @@ public class OSAPI implements ILuaAPI
 
     private static class Timer
     {
-        public int m_ticksLeft;
+        int m_ticksLeft;
 
-        public Timer( int ticksLeft )
+        Timer( int ticksLeft )
         {
             m_ticksLeft = ticksLeft;
         }
@@ -46,10 +46,10 @@ public class OSAPI implements ILuaAPI
 
     private static class Alarm implements Comparable<Alarm>
     {
-        public final double m_time;
-        public final int m_day;
+        final double m_time;
+        final int m_day;
 
-        public Alarm( double time, int day )
+        Alarm( double time, int day )
         {
             m_time = time;
             m_day = day;
@@ -78,9 +78,7 @@ public class OSAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "os"
-        };
+        return new String[] { "os" };
     }
 
     @Override
@@ -385,9 +383,7 @@ public class OSAPI implements ILuaAPI
                         // Get in-game epoch
                         synchronized( m_alarms )
                         {
-                            return new Object[] {
-                                m_day * 86400000 + (int) (m_time * 3600000.0f)
-                            };
+                            return new Object[] { m_day * 86400000 + (int) (m_time * 3600000.0f) };
                         }
                     default:
                         throw new LuaException( "Unsupported operation" );

src/main/java/dan200/computercraft/core/apis/PeripheralAPI.java

@@ -36,7 +36,7 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
         private Map<String, Integer> m_methodMap;
         private boolean m_attached;
 
-        public PeripheralWrapper( IPeripheral peripheral, String side )
+        PeripheralWrapper( IPeripheral peripheral, String side )
         {
             super( m_environment );
             m_side = side;
@@ -282,9 +282,7 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "peripheral"
-        };
+        return new String[] { "peripheral" };
     }
 
     @Override
@@ -326,7 +324,7 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             "isPresent",
             "getType",
             "getMethods",
-            "call"
+            "call",
         };
     }
 

src/main/java/dan200/computercraft/core/apis/RedstoneAPI.java

@@ -29,9 +29,7 @@ public class RedstoneAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "rs", "redstone"
-        };
+        return new String[] { "rs", "redstone" };
     }
 
     @Nonnull

src/main/java/dan200/computercraft/core/apis/TermAPI.java

@@ -33,9 +33,7 @@ public class TermAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "term"
-        };
+        return new String[] { "term" };
     }
 
     @Nonnull
@@ -89,9 +87,7 @@ public class TermAPI implements ILuaAPI
 
     public static Object[] encodeColour( int colour ) throws LuaException
     {
-        return new Object[] {
-            1 << colour
-        };
+        return new Object[] { 1 << colour };
     }
 
     public static void setColour( Terminal terminal, int colour, double r, double g, double b )

src/main/java/dan200/computercraft/core/apis/http/Resource.java

@@ -72,7 +72,8 @@ public abstract class Resource<T extends Resource<T>> implements Closeable
      */
     protected void dispose()
     {
-        @SuppressWarnings( "unchecked" ) T thisT = (T) this;
+        @SuppressWarnings( "unchecked" )
+        T thisT = (T) this;
         limiter.release( thisT );
     }
 
@@ -95,7 +96,8 @@ public abstract class Resource<T extends Resource<T>> implements Closeable
 
     public boolean queue( Consumer<T> task )
     {
-        @SuppressWarnings( "unchecked" ) T thisT = (T) this;
+        @SuppressWarnings( "unchecked" )
+        T thisT = (T) this;
         return limiter.queue( thisT, () -> task.accept( thisT ) );
     }
 

src/main/java/dan200/computercraft/core/computer/ComputerSide.java

@@ -30,7 +30,10 @@ public enum ComputerSide
 
     private final String name;
 
-    ComputerSide( String name ) {this.name = name;}
+    ComputerSide( String name )
+    {
+        this.name = name;
+    }
 
     @Nonnull
     public static ComputerSide valueOf( int side )

src/main/java/dan200/computercraft/core/filesystem/FileSystem.java

@@ -46,7 +46,7 @@ public class FileSystem
             m_writableMount = null;
         }
 
-        public MountWrapper( String label, String location, IWritableMount mount )
+        MountWrapper( String label, String location, IWritableMount mount )
         {
             this( label, location, (IMount) mount );
             m_writableMount = mount;
@@ -779,7 +779,7 @@ public class FileSystem
 
         // Clean the path or illegal characters.
         final char[] specialChars = new char[] {
-            '"', ':', '<', '>', '?', '|' // Sorted by ascii value (important)
+            '"', ':', '<', '>', '?', '|', // Sorted by ascii value (important)
         };
 
         StringBuilder cleanName = new StringBuilder();

src/main/java/dan200/computercraft/core/lua/CobaltLuaMachine.java

@@ -550,7 +550,7 @@ public class CobaltLuaMachine implements ILuaMachine
                 {
                     if( ComputerCraft.logPeripheralErrors ) ComputerCraft.log.error( "Error running task", t );
                     m_computer.queueEvent( "task_complete", new Object[] {
-                        taskID, false, "Java Exception Thrown: " + t
+                        taskID, false, "Java Exception Thrown: " + t,
                     } );
                 }
             };

src/main/java/dan200/computercraft/core/terminal/TextBuffer.java

@@ -8,7 +8,7 @@ package dan200.computercraft.core.terminal;
 
 public class TextBuffer
 {
-    public char[] m_text;
+    private final char[] m_text;
 
     public TextBuffer( char c, int length )
     {

src/main/java/dan200/computercraft/shared/computer/apis/CommandAPI.java

@@ -47,9 +47,7 @@ public class CommandAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "commands"
-        };
+        return new String[] { "commands" };
     }
 
     @Nonnull
@@ -62,7 +60,7 @@ public class CommandAPI implements ILuaAPI
             "list",
             "getBlockPosition",
             "getBlockInfos",
-            "getBlockInfo"
+            "getBlockInfo",
         };
     }
 

src/main/java/dan200/computercraft/shared/computer/core/ComputerRegistry.java

@@ -11,9 +11,9 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.Random;
 
-public class ComputerRegistry<TComputer extends IComputer>
+public class ComputerRegistry<T extends IComputer>
 {
-    private Map<Integer, TComputer> m_computers;
+    private Map<Integer, T> m_computers;
     private int m_nextUnusedInstanceID;
     private int m_sessionID;
 
@@ -33,12 +33,12 @@ public class ComputerRegistry<TComputer extends IComputer>
         return m_nextUnusedInstanceID++;
     }
 
-    public Collection<TComputer> getComputers()
+    public Collection<T> getComputers()
     {
         return m_computers.values();
     }
 
-    public TComputer get( int instanceID )
+    public T get( int instanceID )
     {
         if( instanceID >= 0 )
         {
@@ -55,7 +55,7 @@ public class ComputerRegistry<TComputer extends IComputer>
         return m_computers.containsKey( instanceID );
     }
 
-    public void add( int instanceID, TComputer computer )
+    public void add( int instanceID, T computer )
     {
         if( m_computers.containsKey( instanceID ) )
         {

src/main/java/dan200/computercraft/shared/integration/charset/BundledCapabilityProvider.java

@@ -1,9 +1,8 @@
 /*
  * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2018. Do not distribute without permission.
+ * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
  * Send enquiries to dratcliffe@gmail.com
  */
-
 package dan200.computercraft.shared.integration.charset;
 
 import dan200.computercraft.shared.common.TileGeneric;

src/main/java/dan200/computercraft/shared/integration/charset/BundledRedstoneProvider.java

@@ -1,9 +1,8 @@
 /*
  * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2018. Do not distribute without permission.
+ * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
  * Send enquiries to dratcliffe@gmail.com
  */
-
 package dan200.computercraft.shared.integration.charset;
 
 import dan200.computercraft.api.redstone.IBundledRedstoneProvider;

src/main/java/dan200/computercraft/shared/integration/charset/IntegrationCharset.java

@@ -1,9 +1,8 @@
 /*
  * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2018. Do not distribute without permission.
+ * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
  * Send enquiries to dratcliffe@gmail.com
  */
-
 package dan200.computercraft.shared.integration.charset;
 
 import dan200.computercraft.ComputerCraft;

src/main/java/dan200/computercraft/shared/peripheral/PeripheralType.java

@@ -39,5 +39,8 @@ public enum PeripheralType implements IStringSerializable
     }
 
     @Override
-    public String toString() { return name; }
+    public String toString()
+    {
+        return name;
+    }
 }

src/main/java/dan200/computercraft/shared/peripheral/commandblock/CommandBlockPeripheral.java

@@ -52,7 +52,7 @@ public class CommandBlockPeripheral implements IPeripheral
         {
             case 0: // getCommand
                 return context.executeMainThreadTask( () -> new Object[] {
-                    m_commandBlock.getCommandBlockLogic().getCommand()
+                    m_commandBlock.getCommandBlockLogic().getCommand(),
                 } );
             case 1:
             {

src/main/java/dan200/computercraft/shared/peripheral/diskdrive/DiskDrivePeripheral.java

@@ -51,7 +51,7 @@ public class DiskDrivePeripheral implements IPeripheral
             "playAudio",
             "stopAudio",
             "ejectDisk",
-            "getDiskID"
+            "getDiskID",
         };
     }
 

src/main/java/dan200/computercraft/shared/peripheral/modem/ModemPeripheral.java

@@ -87,7 +87,7 @@ public abstract class ModemPeripheral implements IPeripheral, IPacketSender, IPa
             for( IComputerAccess computer : m_computers )
             {
                 computer.queueEvent( "modem_message", new Object[] {
-                    computer.getAttachmentName(), packet.getChannel(), packet.getReplyChannel(), packet.getPayload(), distance
+                    computer.getAttachmentName(), packet.getChannel(), packet.getReplyChannel(), packet.getPayload(), distance,
                 } );
             }
         }
@@ -103,7 +103,7 @@ public abstract class ModemPeripheral implements IPeripheral, IPacketSender, IPa
             for( IComputerAccess computer : m_computers )
             {
                 computer.queueEvent( "modem_message", new Object[] {
-                    computer.getAttachmentName(), packet.getChannel(), packet.getReplyChannel(), packet.getPayload()
+                    computer.getAttachmentName(), packet.getChannel(), packet.getReplyChannel(), packet.getPayload(),
                 } );
             }
         }

src/main/java/dan200/computercraft/shared/peripheral/modem/wired/WiredModemPeripheral.java

@@ -277,7 +277,7 @@ public abstract class WiredModemPeripheral extends ModemPeripheral implements IW
         private final String[] m_methods;
         private final Map<String, Integer> m_methodMap;
 
-        public RemotePeripheralWrapper( WiredModemElement element, IPeripheral peripheral, IComputerAccess computer, String name )
+        RemotePeripheralWrapper( WiredModemElement element, IPeripheral peripheral, IComputerAccess computer, String name )
         {
             m_element = element;
             m_peripheral = peripheral;

src/main/java/dan200/computercraft/shared/peripheral/monitor/TileMonitor.java

@@ -142,7 +142,7 @@ public class TileMonitor extends TileGeneric implements ITilePeripheral, IPeriph
                     for( IComputerAccess computer : monitor.m_computers )
                     {
                         computer.queueEvent( "monitor_resize", new Object[] {
-                            computer.getAttachmentName()
+                            computer.getAttachmentName(),
                         } );
                     }
                 }
@@ -660,7 +660,7 @@ public class TileMonitor extends TileGeneric implements ITilePeripheral, IPeriph
                 for( IComputerAccess computer : monitor.m_computers )
                 {
                     computer.queueEvent( "monitor_touch", new Object[] {
-                        computer.getAttachmentName(), xCharPos, yCharPos
+                        computer.getAttachmentName(), xCharPos, yCharPos,
                     } );
                 }
             }

src/main/java/dan200/computercraft/shared/peripheral/speaker/SpeakerPeripheral.java

@@ -71,8 +71,8 @@ public abstract class SpeakerPeripheral implements IPeripheral
     public String[] getMethodNames()
     {
         return new String[] {
-            "playSound", // Plays sound at resourceLocator
-            "playNote" // Plays note
+            "playSound",
+            "playNote",
         };
     }
 

src/main/java/dan200/computercraft/shared/pocket/apis/PocketAPI.java

@@ -35,9 +35,7 @@ public class PocketAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "pocket"
-        };
+        return new String[] { "pocket" };
     }
 
     @Nonnull
@@ -46,7 +44,7 @@ public class PocketAPI implements ILuaAPI
     {
         return new String[] {
             "equipBack",
-            "unequipBack"
+            "unequipBack",
         };
     }
 

src/main/java/dan200/computercraft/shared/turtle/apis/TurtleAPI.java

@@ -45,9 +45,7 @@ public class TurtleAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] {
-            "turtle"
-        };
+        return new String[] { "turtle" };
     }
 
     @Nonnull

src/main/java/dan200/computercraft/shared/turtle/core/TurtleBrain.java

@@ -908,14 +908,14 @@ public class TurtleBrain implements ITurtleAccess
             else
             {
                 computer.queueEvent( "turtle_response", new Object[] {
-                    callbackID, true
+                    callbackID, true,
                 } );
             }
         }
         else
         {
             computer.queueEvent( "turtle_response", new Object[] {
-                callbackID, false, result != null ? result.getErrorMessage() : null
+                callbackID, false, result != null ? result.getErrorMessage() : null,
             } );
         }
     }

src/main/java/dan200/computercraft/shared/turtle/inventory/ContainerTurtle.java

@@ -26,8 +26,8 @@ public class ContainerTurtle extends Container implements IContainerComputer
 {
     private static final int PROGRESS_ID_SELECTED_SLOT = 0;
 
-    public final int m_playerInvStartY;
-    public final int m_turtleInvStartX;
+    public final int playerInvStartY;
+    public final int turtleInvStartX;
 
     private final ITurtleAccess m_turtle;
     private IComputer m_computer;
@@ -36,8 +36,8 @@ public class ContainerTurtle extends Container implements IContainerComputer
 
     protected ContainerTurtle( IInventory playerInventory, ITurtleAccess turtle, int playerInvStartY, int turtleInvStartX )
     {
-        m_playerInvStartY = playerInvStartY;
-        m_turtleInvStartX = turtleInvStartX;
+        this.playerInvStartY = playerInvStartY;
+        this.turtleInvStartX = turtleInvStartX;
 
         m_turtle = turtle;
         m_selectedSlot = m_turtle.getWorld().isRemote ? 0 : m_turtle.getSelectedSlot();

src/main/java/dan200/computercraft/shared/turtle/items/ItemTurtleLegacy.java

@@ -73,7 +73,10 @@ public class ItemTurtleLegacy extends ItemTurtleBase
     }
 
     @Override
-    public ResourceLocation getOverlay( @Nonnull ItemStack stack ) { return null; }
+    public ResourceLocation getOverlay( @Nonnull ItemStack stack )
+    {
+        return null;
+    }
 
     @Override
     public int getFuelLevel( @Nonnull ItemStack stack )

src/main/java/dan200/computercraft/shared/turtle/upgrades/TurtleHoe.java

@@ -54,7 +54,7 @@ public class TurtleHoe extends TurtleTool
     {
         if( verb == TurtleVerb.Dig )
         {
-            ItemStack hoe = m_item.copy();
+            ItemStack hoe = item.copy();
             ItemStack remainder = TurtlePlaceCommand.deploy( hoe, turtle, direction, null, null );
             if( remainder != hoe )
             {

src/main/java/dan200/computercraft/shared/turtle/upgrades/TurtleShovel.java

@@ -60,7 +60,7 @@ public class TurtleShovel extends TurtleTool
     {
         if( verb == TurtleVerb.Dig )
         {
-            ItemStack shovel = m_item.copy();
+            ItemStack shovel = item.copy();
             ItemStack remainder = TurtlePlaceCommand.deploy( shovel, turtle, direction, null, null );
             if( remainder != shovel )
             {

src/main/java/dan200/computercraft/shared/turtle/upgrades/TurtleTool.java

@@ -48,18 +48,18 @@ import java.util.function.Function;
 
 public class TurtleTool extends AbstractTurtleUpgrade
 {
-    protected ItemStack m_item;
+    protected final ItemStack item;
 
     public TurtleTool( ResourceLocation id, int legacyID, String adjective, Item item )
     {
         super( id, legacyID, TurtleUpgradeType.Tool, adjective, item );
-        m_item = new ItemStack( item, 1, 0 );
+        this.item = new ItemStack( item, 1, 0 );
     }
 
     public TurtleTool( ResourceLocation id, int legacyID, Item item )
     {
         super( id, legacyID, TurtleUpgradeType.Tool, item );
-        m_item = new ItemStack( item, 1, 0 );
+        this.item = new ItemStack( item, 1, 0 );
     }
 
     @Nonnull
@@ -76,7 +76,7 @@ public class TurtleTool extends AbstractTurtleUpgrade
         );
         Minecraft mc = Minecraft.getMinecraft();
         return Pair.of(
-            mc.getRenderItem().getItemModelMesher().getItemModel( m_item ),
+            mc.getRenderItem().getItemModelMesher().getItemModel( item ),
             transform
         );
     }
@@ -124,7 +124,7 @@ public class TurtleTool extends AbstractTurtleUpgrade
         if( hit != null )
         {
             // Load up the turtle's inventory
-            ItemStack stackCopy = m_item.copy();
+            ItemStack stackCopy = item.copy();
             turtlePlayer.loadInventory( stackCopy );
 
             Entity hitEntity = hit.getKey();
@@ -202,7 +202,7 @@ public class TurtleTool extends AbstractTurtleUpgrade
         IBlockState state = world.getBlockState( blockPosition );
 
         TurtlePlayer turtlePlayer = TurtlePlaceCommand.createPlayer( turtle, turtlePosition, direction );
-        turtlePlayer.loadInventory( m_item.copy() );
+        turtlePlayer.loadInventory( item.copy() );
 
         if( ComputerCraft.turtlesObeyBlockProtection )
         {

src/main/java/dan200/computercraft/shared/util/ColourUtils.java

@@ -20,7 +20,7 @@ public final class ColourUtils
         "dyeBlack", "dyeRed", "dyeGreen", "dyeBrown",
         "dyeBlue", "dyePurple", "dyeCyan", "dyeLightGray",
         "dyeGray", "dyePink", "dyeLime", "dyeYellow",
-        "dyeLightBlue", "dyeMagenta", "dyeOrange", "dyeWhite"
+        "dyeLightBlue", "dyeMagenta", "dyeOrange", "dyeWhite",
     };
 
     private static int[] ids;

src/main/java/dan200/computercraft/shared/util/Palette.java

@@ -72,12 +72,11 @@ public class Palette
 
     public static double[] decodeRGB8( int rgb )
     {
-        return new double[]
-            {
-                ((rgb >> 16) & 0xFF) / 255.0f,
-                ((rgb >> 8) & 0xFF) / 255.0f,
-                (rgb & 0xFF) / 255.0f
-            };
+        return new double[] {
+            ((rgb >> 16) & 0xFF) / 255.0f,
+            ((rgb >> 8) & 0xFF) / 255.0f,
+            (rgb & 0xFF) / 255.0f,
+        };
     }
 
     public NBTTagCompound writeToNBT( NBTTagCompound nbt )

src/main/java/dan200/computercraft/shared/util/StringUtil.java

@@ -35,6 +35,7 @@ public final class StringUtil
     /**
      * Translates a Stat name
      */
+    @SuppressWarnings( "deprecation" )
     public static String translate( String key )
     {
         return net.minecraft.util.text.translation.I18n.translateToLocal( key );
@@ -43,6 +44,7 @@ public final class StringUtil
     /**
      * Translates a Stat name with format args
      */
+    @SuppressWarnings( "deprecation" )
     public static String translateFormatted( String key, Object... format )
     {
         return net.minecraft.util.text.translation.I18n.translateToLocalFormatted( key, format );