osmarks/nanogpt-experiments
1
0
Fork 0
mirror of https://github.com/osmarks/nanogpt-experiments.git synced 2024-12-18 14:10:28 +00:00
Code Issues Releases Wiki Activity

rewrite model class so layernorm has an optional bias= parameter

Browse Source
This commit is contained in:
Andrej Karpathy 2023-01-27 20:17:32 +00:00
parent 2892858ce7
commit 2bf07a3fbf
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
model.py
View File

@ -22,14 +22,16 @@ def new_gelu(x):
"""
return 0.5 * x * (1.0 + torch.tanh(math.sqrt(2.0 / math.pi) * (x + 0.044715 * torch.pow(x, 3.0))))
class LayerNormNoBias(nn.Module):
class LayerNorm(nn.Module):
""" LayerNorm but with an optional bias. PyTorch doesn't support simply bias=False """
def __init__(self, ndim):
def __init__(self, ndim, bias=True):
super().__init__()
self.weight = nn.Parameter(torch.ones(ndim))
self.bias = nn.Parameter(torch.zeros(ndim)) if bias else None
def forward(self, input):
return F.layer_norm(input, self.weight.shape, self.weight, None, 1e-5)
return F.layer_norm(input, self.weight.shape, self.weight, self.bias, 1e-5)
class CausalSelfAttention(nn.Module):
@ -89,9 +91,9 @@ class Block(nn.Module):
def __init__(self, config):
super().__init__()
self.ln_1 = LayerNormNoBias(config.n_embd)
self.ln_1 = LayerNorm(config.n_embd, bias=False)
self.attn = CausalSelfAttention(config)
self.ln_2 = LayerNormNoBias(config.n_embd)
self.ln_2 = LayerNorm(config.n_embd, bias=False)
self.mlp = MLP(config)
def forward(self, x):
@ -121,7 +123,7 @@ class GPT(nn.Module):
wpe = nn.Embedding(config.block_size, config.n_embd),
drop = nn.Dropout(config.dropout),
h = nn.ModuleList([Block(config) for _ in range(config.n_layer)]),
ln_f = LayerNormNoBias(config.n_embd),
ln_f = LayerNorm(config.n_embd, bias=False),
))
self.lm_head = nn.Linear(config.n_embd, config.vocab_size, bias=False)
# with weight tying when using torch.compile() some warnings get generated:
@ -148,9 +150,10 @@ class GPT(nn.Module):
torch.nn.init.zeros_(module.bias)
elif isinstance(module, nn.Embedding):
torch.nn.init.normal_(module.weight, mean=0.0, std=0.02)
elif isinstance(module, nn.LayerNorm):
torch.nn.init.zeros_(module.bias)
elif isinstance(module, (LayerNorm, nn.LayerNorm)):
torch.nn.init.ones_(module.weight)
if module.bias is not None:
torch.nn.init.zeros_(module.bias)
def forward(self, idx, targets=None):
device = idx.device
@ -251,7 +254,7 @@ class GPT(nn.Module):
decay = set()
no_decay = set()
whitelist_weight_modules = (torch.nn.Linear, )
blacklist_weight_modules = (torch.nn.LayerNorm, LayerNormNoBias, torch.nn.Embedding)
blacklist_weight_modules = (torch.nn.LayerNorm, LayerNorm, torch.nn.Embedding)
for mn, m in self.named_modules():
for pn, p in m.named_parameters():
fpn = '%s.%s' % (mn, pn) if mn else pn # full param name