7362d55a35
# Description - replaces a bunch of boolean (and like) columns with a single "statuses.flags" column - adds a potential deleted value for the new "statuses.flags" column - replaces useless migration.Down functions with empty txs with empty functions In a future PR this will update our status deletion logic to instead stub-out a particular status row instead of deleting it, where necessary, to maintain status threads. In the process of replacing a bunch of columns with a single bit field this should also free up some storage space on the statuses table! It also replaces a bunch of indices with partials which again should further reduce space! ~~This is yet to be tested, so we shall see :p~~ Just finished testing this on my own instance... - previous database size: 24827580416 - after database size: 21751169024 So 3GB of savings from a 24GB database, that's pretty damn impressive! ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have not used so-called 'AI' to create the proposed changes. - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4716 Co-authored-by: kim <grufwub@gmail.com> Co-committed-by: kim <grufwub@gmail.com>
316 lines
9.8 KiB
Go
316 lines
9.8 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package status_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/ap"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
|
|
"code.superseriousbusiness.org/gotosocial/internal/id"
|
|
"code.superseriousbusiness.org/gotosocial/internal/processing/status"
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
// Test topo sorting of thread replies.
|
|
type topoSortTestSuite struct {
|
|
suite.Suite
|
|
}
|
|
|
|
func statusIDs(apiStatuses []*gtsmodel.Status) []string {
|
|
ids := make([]string, 0, len(apiStatuses))
|
|
for _, apiStatus := range apiStatuses {
|
|
ids = append(ids, apiStatus.ID)
|
|
}
|
|
return ids
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestBranched() {
|
|
// https://commons.wikimedia.org/wiki/File:Sorted_binary_tree_ALL_RGB.svg
|
|
f := >smodel.Status{ID: "F"}
|
|
b := >smodel.Status{ID: "B", InReplyToID: f.ID}
|
|
a := >smodel.Status{ID: "A", InReplyToID: b.ID}
|
|
d := >smodel.Status{ID: "D", InReplyToID: b.ID}
|
|
c := >smodel.Status{ID: "C", InReplyToID: d.ID}
|
|
e := >smodel.Status{ID: "E", InReplyToID: d.ID}
|
|
g := >smodel.Status{ID: "G", InReplyToID: f.ID}
|
|
i := >smodel.Status{ID: "I", InReplyToID: g.ID}
|
|
h := >smodel.Status{ID: "H", InReplyToID: i.ID}
|
|
|
|
expected := statusIDs([]*gtsmodel.Status{f, b, a, d, c, e, g, i, h})
|
|
list := []*gtsmodel.Status{a, b, c, d, e, f, g, h, i}
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.Equal(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestBranchedWithSelfReplyChain() {
|
|
targetAccount := >smodel.Account{ID: "1"}
|
|
otherAccount := >smodel.Account{ID: "2"}
|
|
|
|
f := >smodel.Status{
|
|
ID: "F",
|
|
Account: targetAccount,
|
|
}
|
|
b := >smodel.Status{
|
|
ID: "B",
|
|
Account: targetAccount,
|
|
AccountID: targetAccount.ID,
|
|
InReplyToID: f.ID,
|
|
InReplyToAccountID: f.Account.ID,
|
|
}
|
|
d := >smodel.Status{
|
|
ID: "D",
|
|
Account: targetAccount,
|
|
AccountID: targetAccount.ID,
|
|
InReplyToID: b.ID,
|
|
InReplyToAccountID: b.Account.ID,
|
|
}
|
|
e := >smodel.Status{
|
|
ID: "E",
|
|
Account: targetAccount,
|
|
AccountID: targetAccount.ID,
|
|
InReplyToID: d.ID,
|
|
InReplyToAccountID: d.Account.ID,
|
|
}
|
|
c := >smodel.Status{
|
|
ID: "C",
|
|
Account: otherAccount,
|
|
AccountID: otherAccount.ID,
|
|
InReplyToID: d.ID,
|
|
InReplyToAccountID: d.Account.ID,
|
|
}
|
|
a := >smodel.Status{
|
|
ID: "A",
|
|
Account: otherAccount,
|
|
AccountID: otherAccount.ID,
|
|
InReplyToID: b.ID,
|
|
InReplyToAccountID: b.Account.ID,
|
|
}
|
|
g := >smodel.Status{
|
|
ID: "G",
|
|
Account: otherAccount,
|
|
AccountID: otherAccount.ID,
|
|
InReplyToID: f.ID,
|
|
InReplyToAccountID: f.Account.ID,
|
|
}
|
|
i := >smodel.Status{
|
|
ID: "I",
|
|
Account: targetAccount,
|
|
AccountID: targetAccount.ID,
|
|
InReplyToID: g.ID,
|
|
InReplyToAccountID: g.Account.ID,
|
|
}
|
|
h := >smodel.Status{
|
|
ID: "H",
|
|
Account: otherAccount,
|
|
AccountID: otherAccount.ID,
|
|
InReplyToID: i.ID,
|
|
InReplyToAccountID: i.Account.ID,
|
|
}
|
|
|
|
expected := statusIDs([]*gtsmodel.Status{f, b, d, e, c, a, g, i, h})
|
|
list := []*gtsmodel.Status{a, b, c, d, e, f, g, h, i}
|
|
status.TopoSort(list, targetAccount.ID)
|
|
actual := statusIDs(list)
|
|
|
|
suite.Equal(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestDisconnected() {
|
|
f := >smodel.Status{ID: "F"}
|
|
b := >smodel.Status{ID: "B", InReplyToID: f.ID}
|
|
dID := "D"
|
|
e := >smodel.Status{ID: "E", InReplyToID: dID}
|
|
|
|
expected := statusIDs([]*gtsmodel.Status{e, f, b})
|
|
list := []*gtsmodel.Status{b, e, f}
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.Equal(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestTrivialCycle() {
|
|
xID := "X"
|
|
x := >smodel.Status{ID: xID, InReplyToID: xID}
|
|
|
|
expected := statusIDs([]*gtsmodel.Status{x})
|
|
list := []*gtsmodel.Status{x}
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.ElementsMatch(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestCycle() {
|
|
yID := "Y"
|
|
x := >smodel.Status{ID: "X", InReplyToID: yID}
|
|
y := >smodel.Status{ID: yID, InReplyToID: x.ID}
|
|
|
|
expected := statusIDs([]*gtsmodel.Status{x, y})
|
|
list := []*gtsmodel.Status{x, y}
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.ElementsMatch(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestMixedCycle() {
|
|
yID := "Y"
|
|
x := >smodel.Status{ID: "X", InReplyToID: yID}
|
|
y := >smodel.Status{ID: yID, InReplyToID: x.ID}
|
|
z := >smodel.Status{ID: "Z"}
|
|
|
|
expected := statusIDs([]*gtsmodel.Status{x, y, z})
|
|
list := []*gtsmodel.Status{x, y, z}
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.ElementsMatch(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestEmpty() {
|
|
expected := statusIDs([]*gtsmodel.Status{})
|
|
list := []*gtsmodel.Status{}
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.Equal(expected, actual)
|
|
}
|
|
|
|
func (suite *topoSortTestSuite) TestNil() {
|
|
expected := statusIDs(nil)
|
|
var list []*gtsmodel.Status
|
|
status.TopoSort(list, "")
|
|
actual := statusIDs(list)
|
|
|
|
suite.Equal(expected, actual)
|
|
}
|
|
|
|
func TestTopoSortTestSuite(t *testing.T) {
|
|
suite.Run(t, &topoSortTestSuite{})
|
|
}
|
|
|
|
// Test properties of web contexts.
|
|
type webContextGetTestSuite struct {
|
|
StatusStandardTestSuite
|
|
|
|
indexableAccount1 *gtsmodel.Account
|
|
indexableAccount2 *gtsmodel.Account
|
|
nonindexableAccount1 *gtsmodel.Account
|
|
}
|
|
|
|
// Find a test account by name with a given indexable setting, or fail if we can't.
|
|
func (suite *webContextGetTestSuite) requireIndexableAccount(name string, indexable bool) *gtsmodel.Account {
|
|
account := suite.testAccounts[name]
|
|
if account == nil || account.Indexable == nil || *account.Indexable != indexable {
|
|
suite.FailNowf("expected test account %s's indexable setting to be %v", name, indexable)
|
|
}
|
|
return account
|
|
}
|
|
|
|
func (suite *webContextGetTestSuite) SetupSuite() {
|
|
suite.StatusStandardTestSuite.SetupSuite()
|
|
|
|
suite.indexableAccount1 = suite.requireIndexableAccount("local_account_1", true)
|
|
suite.indexableAccount2 = suite.requireIndexableAccount("admin_account", true)
|
|
suite.nonindexableAccount1 = suite.requireIndexableAccount("local_account_2", false)
|
|
}
|
|
|
|
// Create a status in the test DB, or fail if we can't.
|
|
func (suite *webContextGetTestSuite) createStatus(account *gtsmodel.Account, visibility gtsmodel.Visibility, inReplyTo *gtsmodel.Status) *gtsmodel.Status {
|
|
ctx := suite.T().Context()
|
|
statusID := id.NewULID()
|
|
newStatus := >smodel.Status{
|
|
ID: statusID,
|
|
URI: "https://status-id.test/" + statusID,
|
|
Flags: gtsmodel.StatusFlags(gtsmodel.StatusFlagLocal | gtsmodel.StatusFlagFederated),
|
|
AccountID: account.ID,
|
|
AccountURI: account.URI,
|
|
Visibility: visibility,
|
|
ActivityStreamsType: ap.ObjectNote,
|
|
}
|
|
if inReplyTo != nil {
|
|
newStatus.InReplyToID = inReplyTo.ID
|
|
newStatus.InReplyToAccountID = inReplyTo.AccountID
|
|
}
|
|
if err := suite.db.PutStatus(ctx, newStatus); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
return newStatus
|
|
}
|
|
|
|
// If all visible statuses in a thread are indexable, so is the thread.
|
|
func (suite *webContextGetTestSuite) TestAllVisibleIndexable() {
|
|
ctx := suite.T().Context()
|
|
|
|
op := suite.createStatus(suite.indexableAccount1, gtsmodel.VisibilityPublic, nil)
|
|
_ = suite.createStatus(suite.indexableAccount2, gtsmodel.VisibilityPublic, op)
|
|
webContext, err := suite.status.WebContextGet(ctx, op.ID)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
return
|
|
}
|
|
suite.Len(webContext.Statuses, 2, "precondition failed")
|
|
suite.Equal(0, webContext.ThreadRepliesHidden, "precondition failed")
|
|
|
|
suite.True(webContext.Indexable)
|
|
}
|
|
|
|
// If any visible statuses in a thread are not indexable, so is the thread.
|
|
func (suite *webContextGetTestSuite) TestOneVisibleNonindexable() {
|
|
ctx := suite.T().Context()
|
|
|
|
op := suite.createStatus(suite.indexableAccount1, gtsmodel.VisibilityPublic, nil)
|
|
_ = suite.createStatus(suite.indexableAccount2, gtsmodel.VisibilityPublic, op)
|
|
_ = suite.createStatus(suite.nonindexableAccount1, gtsmodel.VisibilityPublic, op)
|
|
webContext, err := suite.status.WebContextGet(ctx, op.ID)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
return
|
|
}
|
|
suite.Len(webContext.Statuses, 3, "precondition failed")
|
|
suite.Equal(0, webContext.ThreadRepliesHidden, "precondition failed")
|
|
|
|
suite.False(webContext.Indexable)
|
|
}
|
|
|
|
// If the only nonindexable statuses in a thread are also invisible, then the thread is still indexable.
|
|
func (suite *webContextGetTestSuite) TestOneInvisibleNonindexable() {
|
|
ctx := suite.T().Context()
|
|
|
|
op := suite.createStatus(suite.indexableAccount1, gtsmodel.VisibilityPublic, nil)
|
|
_ = suite.createStatus(suite.indexableAccount2, gtsmodel.VisibilityPublic, op)
|
|
_ = suite.createStatus(suite.nonindexableAccount1, gtsmodel.VisibilityUnlocked, op)
|
|
webContext, err := suite.status.WebContextGet(ctx, op.ID)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
return
|
|
}
|
|
suite.Len(webContext.Statuses, 2, "precondition failed")
|
|
suite.Equal(1, webContext.ThreadRepliesHidden, "precondition failed")
|
|
|
|
suite.True(webContext.Indexable)
|
|
}
|
|
|
|
func TestWebContextGetTestSuite(t *testing.T) {
|
|
suite.Run(t, &webContextGetTestSuite{})
|
|
}
|