kim
c40dbf0fb8
Undoes my own recent change that blocks on media loading for timeline endpoints, to improve latency (which definitely had a bit of a regression after v0.21.0). Replaces the existing code that blocks on media loading in the surfacer with a more optimized check that reduces mutex locks and shouldn't lead to any accidental double loads. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4756 Co-authored-by: kim <grufwub@gmail.com> Co-committed-by: kim <grufwub@gmail.com>
113 lines
3.4 KiB
Go
113 lines
3.4 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package common
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/config"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtserror"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
|
|
"code.superseriousbusiness.org/gotosocial/internal/media"
|
|
)
|
|
|
|
// StoreLocalMedia is a wrapper around CreateMedia() and
|
|
// ProcessingMedia{}.Load() with appropriate error responses.
|
|
func (p *Processor) StoreLocalMedia(
|
|
ctx context.Context,
|
|
accountID string,
|
|
data media.DataFunc,
|
|
info media.AdditionalMediaInfo,
|
|
) (
|
|
*gtsmodel.MediaAttachment,
|
|
gtserror.WithCode,
|
|
) {
|
|
// Create a new processing media attachment.
|
|
processing, err := p.media.CreateMedia(ctx,
|
|
accountID,
|
|
data,
|
|
info,
|
|
)
|
|
if err != nil {
|
|
err := gtserror.Newf("error creating media: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
// Immediately trigger write to storage.
|
|
attachment, err := processing.Load(ctx)
|
|
switch {
|
|
case gtserror.LimitReached(err):
|
|
limit := config.GetMediaLocalMaxSize()
|
|
text := fmt.Sprintf("local media size limit reached: %s", limit)
|
|
return nil, gtserror.NewErrorUnprocessableEntity(err, text)
|
|
|
|
case err != nil:
|
|
const text = "error processing media"
|
|
err := gtserror.Newf("error processing media: %w", err)
|
|
return nil, gtserror.NewErrorUnprocessableEntity(err, text)
|
|
|
|
case attachment.Type == gtsmodel.FileTypeUnknown:
|
|
text := fmt.Sprintf("could not process %s type media", attachment.File.ContentType)
|
|
return nil, gtserror.NewErrorUnprocessableEntity(errors.New(text), text)
|
|
}
|
|
|
|
return attachment, nil
|
|
}
|
|
|
|
// StoreLocalMedia is a wrapper around CreateMedia() and
|
|
// ProcessingMedia{}.Load() with appropriate error responses.
|
|
func (p *Processor) StoreLocalEmoji(
|
|
ctx context.Context,
|
|
shortcode string,
|
|
data media.DataFunc,
|
|
info media.AdditionalEmojiInfo,
|
|
) (
|
|
*gtsmodel.Emoji,
|
|
gtserror.WithCode,
|
|
) {
|
|
// Create a new processing emoji media.
|
|
processing, err := p.media.CreateEmoji(ctx,
|
|
shortcode,
|
|
"", // domain = "" -> local
|
|
data,
|
|
info,
|
|
)
|
|
if err != nil {
|
|
err := gtserror.Newf("error creating emoji: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
// Immediately trigger write to storage.
|
|
emoji, err := processing.Load(ctx)
|
|
switch {
|
|
case gtserror.LimitReached(err):
|
|
limit := config.GetMediaEmojiLocalMaxSize()
|
|
text := fmt.Sprintf("local emoji size limit reached: %s", limit)
|
|
return nil, gtserror.NewErrorUnprocessableEntity(err, text)
|
|
|
|
case err != nil:
|
|
const text = "error processing emoji"
|
|
err := gtserror.Newf("error processing emoji %s: %w", shortcode, err)
|
|
return nil, gtserror.NewErrorUnprocessableEntity(err, text)
|
|
}
|
|
|
|
return emoji, nil
|
|
}
|