mirrors
/
ympd
mirror of https://github.com/SuperBFG7/ympd
1
0
Fork 0
Code Issues Releases Wiki Activity

Configured and ran clang-format on src files

This commit is contained in:
Andrew Carr 2021-05-23 04:09:25 +00:00
parent b35e705066
commit 9a0cf4a43b
9 changed files with 441 additions and 292 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

168
.clang-format Normal file
View File

@ -0,0 +1,168 @@
---
Language: Cpp
# BasedOnStyle: Google
AccessModifierOffset: -1
AlignAfterOpenBracket: Align
AlignConsecutiveMacros: false
AlignConsecutiveAssignments: false
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
AlignOperands: true
AlignTrailingComments: true
AllowAllArgumentsOnNextLine: true
AllowAllConstructorInitializersOnNextLine: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortBlocksOnASingleLine: Never
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: None
AllowShortLambdasOnASingleLine: All
AllowShortIfStatementsOnASingleLine: Never
AllowShortLoopsOnASingleLine: true
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: Yes
BinPackArguments: true
BinPackParameters: true
BraceWrapping:
AfterCaseLabel: false
AfterClass: false
AfterControlStatement: true
AfterEnum: false
AfterFunction: false
AfterNamespace: false
AfterObjCDeclaration: false
AfterStruct: false
AfterUnion: false
AfterExternBlock: false
BeforeCatch: false
BeforeElse: false
IndentBraces: false
SplitEmptyFunction: true
SplitEmptyRecord: true
SplitEmptyNamespace: true
BreakBeforeBinaryOperators: None
BreakBeforeBraces: Attach
BreakBeforeInheritanceComma: false
BreakInheritanceList: BeforeColon
BreakBeforeTernaryOperators: true
BreakConstructorInitializersBeforeComma: false
BreakConstructorInitializers: BeforeColon
BreakAfterJavaFieldAnnotations: false
BreakStringLiterals: true
ColumnLimit: 100
CommentPragmas: '^ IWYU pragma:'
CompactNamespaces: false
ConstructorInitializerAllOnOneLineOrOnePerLine: true
ConstructorInitializerIndentWidth: 4
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
DeriveLineEnding: true
DerivePointerAlignment: true
DisableFormat: false
ExperimentalAutoDetectBinPacking: false
FixNamespaceComments: true
ForEachMacros:
- foreach
- Q_FOREACH
- BOOST_FOREACH
IncludeBlocks: Regroup
IncludeCategories:
- Regex: '^<ext/.*\.h>'
Priority: 2
SortPriority: 0
- Regex: '^<.*\.h>'
Priority: 1
SortPriority: 0
- Regex: '^<.*'
Priority: 2
SortPriority: 0
- Regex: '.*'
Priority: 3
SortPriority: 0
IncludeIsMainRegex: '([-_](test|unittest))?$'
IncludeIsMainSourceRegex: ''
IndentCaseLabels: true
IndentGotoLabels: true
IndentPPDirectives: None
IndentWidth: 4
IndentWrappedFunctionNames: false
JavaScriptQuotes: Leave
JavaScriptWrapImports: true
KeepEmptyLinesAtTheStartOfBlocks: false
MacroBlockBegin: ''
MacroBlockEnd: ''
MaxEmptyLinesToKeep: 1
NamespaceIndentation: None
ObjCBinPackProtocolList: Never
ObjCBlockIndentWidth: 2
ObjCSpaceAfterProperty: false
ObjCSpaceBeforeProtocolList: true
PenaltyBreakAssignment: 2
PenaltyBreakBeforeFirstCallParameter: 1
PenaltyBreakComment: 300
PenaltyBreakFirstLessLess: 120
PenaltyBreakString: 1000
PenaltyBreakTemplateDeclaration: 10
PenaltyExcessCharacter: 1000000
PenaltyReturnTypeOnItsOwnLine: 200
PointerAlignment: Left
RawStringFormats:
- Language: Cpp
Delimiters:
- cc
- CC
- cpp
- Cpp
- CPP
- 'c++'
- 'C++'
CanonicalDelimiter: ''
BasedOnStyle: google
- Language: TextProto
Delimiters:
- pb
- PB
- proto
- PROTO
EnclosingFunctions:
- EqualsProto
- EquivToProto
- PARSE_PARTIAL_TEXT_PROTO
- PARSE_TEST_PROTO
- PARSE_TEXT_PROTO
- ParseTextOrDie
- ParseTextProtoOrDie
CanonicalDelimiter: ''
BasedOnStyle: google
ReflowComments: true
SortIncludes: true
SortUsingDeclarations: true
SpaceAfterCStyleCast: false
SpaceAfterLogicalNot: false
SpaceAfterTemplateKeyword: true
SpaceBeforeAssignmentOperators: true
SpaceBeforeCpp11BracedList: false
SpaceBeforeCtorInitializerColon: true
SpaceBeforeInheritanceColon: true
SpaceBeforeParens: ControlStatements
SpaceBeforeRangeBasedForLoopColon: true
SpaceInEmptyBlock: false
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 2
SpacesInAngles: false
SpacesInConditionalStatement: false
SpacesInContainerLiterals: true
SpacesInCStyleCastParentheses: false
SpacesInParentheses: false
SpacesInSquareBrackets: false
SpaceBeforeSquareBrackets: false
Standard: Auto
StatementMacros:
- Q_UNUSED
- QT_REQUIRE_VERSION
TabWidth: 8
UseCRLF: false
UseTab: Never
...

2
.gitignore vendored Normal file
View File

@ -0,0 +1,2 @@
# Build Artifacts
build/

21
DEVELOPMENT.md
View File

@ -10,4 +10,23 @@ Manual Usage:
> npx prettier --write .
```
The C source and header files have been formatted with `clang-format`.
The C source and header files have been formatted with `clang-format`. There's no easy way to manually execute the formatter on all of the C files at the same time. The clang format is based off of the 'Google' style with ajdustments to make the changes not as disruptive. See [.clang-format](./.clang-format) file for the formatting rules. Various editors should be able to automatically format the source on save.
The only files formatted are the non-third party library files.
Manual Usage:
```bash
> clang-format -i -style=file <filename>
```
Manually formatted files:
- http_server.c
- http_server.h
- json_encode.h
- mpd_client.c
- mpd_client.h
- ympd.c
For help with the rules, see [Clang Format Configurator](https://zed0.co.uk/clang-format-configurator/) for an interactive tool and [ClangFormat](https://clang.llvm.org/docs/ClangFormat.html) for the rules reference.

10
src/http_server.c
View File

@ -16,12 +16,11 @@
Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <string.h>
#include "http_server.h"
int callback_http(struct mg_connection *c)
{
#include <string.h>
int callback_http(struct mg_connection *c) {
const struct embedded_file *req_file;
if (!strcmp(c->uri, "/"))
@ -29,8 +28,7 @@ int callback_http(struct mg_connection *c)
else
req_file = find_embedded_file(c->uri);
if(req_file)
{
if (req_file) {
mg_send_header(c, "Content-Type", req_file->mimetype);
mg_send_data(c, req_file->data, req_file->size);

1
src/http_server.h
View File

@ -32,4 +32,3 @@ const struct embedded_file *find_embedded_file(const char *name);
int callback_http(struct mg_connection *c);
#endif

141
src/mpd_client.c
View File

@ -16,15 +16,16 @@
Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <stdlib.h>
#include "mpd_client.h"
#include <libgen.h>
#include <mpd/client.h>
#include <mpd/message.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include "mpd_client.h"
#include "config.h"
#include "json_encode.h"
@ -32,9 +33,7 @@
static int mpd_notify_callback(struct mg_connection *c, enum mg_event ev);
struct t_mpd mpd;
const char * mpd_cmd_strs[] = {
MPD_CMDS(GEN_STR)
};
const char *mpd_cmd_strs[] = {MPD_CMDS(GEN_STR)};
char *get_arg1(char *p) {
return strchr(p, ',') + 1;
@ -44,8 +43,7 @@ char * get_arg2 (char *p) {
return get_arg1(get_arg1(p));
}
static inline enum mpd_cmd_ids get_cmd_id(char *cmd)
{
static inline enum mpd_cmd_ids get_cmd_id(char *cmd) {
for (int i = 0; i < sizeof(mpd_cmd_strs) / sizeof(mpd_cmd_strs[0]); i++)
if (!strncmp(cmd, mpd_cmd_strs[i], strlen(mpd_cmd_strs[i])))
return i;
@ -53,8 +51,7 @@ static inline enum mpd_cmd_ids get_cmd_id(char *cmd)
return -1;
}
int callback_mpd(struct mg_connection *c)
{
int callback_mpd(struct mg_connection *c) {
enum mpd_cmd_ids cmd_id = get_cmd_id(c->content);
size_t n = 0;
unsigned int uint_buf, uint_buf_2;
@ -68,8 +65,7 @@ int callback_mpd(struct mg_connection *c)
cmd_id != MPD_API_GET_MPDHOST && cmd_id != MPD_API_SET_MPDPASS)
return MG_TRUE;
switch(cmd_id)
{
switch (cmd_id) {
case MPD_API_UPDATE_DB:
mpd_run_update(mpd.conn, NULL);
break;
@ -100,8 +96,7 @@ int callback_mpd(struct mg_connection *c)
mpd_run_delete_range(mpd.conn, uint_buf, uint_buf_2);
break;
case MPD_API_MOVE_TRACK:
if (sscanf(c->content, "MPD_API_MOVE_TRACK,%u,%u", &uint_buf, &uint_buf_2) == 2)
{
if (sscanf(c->content, "MPD_API_MOVE_TRACK,%u,%u", &uint_buf, &uint_buf_2) == 2) {
uint_buf -= 1;
uint_buf_2 -= 1;
mpd_run_move(mpd.conn, uint_buf, uint_buf_2);
@ -287,9 +282,11 @@ out_host_change:
free(p_charbuf);
break;
case MPD_API_GET_MPDHOST:
n = snprintf(mpd.buf, MAX_SIZE, "{\"type\":\"mpdhost\", \"data\": "
n = snprintf(mpd.buf, MAX_SIZE,
"{\"type\":\"mpdhost\", \"data\": "
"{\"host\" : \"%s\", \"port\": \"%d\", \"passwort_set\": %s}"
"}", mpd.host, mpd.port, mpd.password ? "true" : "false");
"}",
mpd.host, mpd.port, mpd.password ? "true" : "false");
break;
case MPD_API_SET_MPDPASS:
p_charbuf = strdup(c->content);
@ -312,8 +309,8 @@ out_set_pass:
#endif
}
if(mpd.conn_state == MPD_CONNECTED && mpd_connection_get_error(mpd.conn) != MPD_ERROR_SUCCESS)
{
if (mpd.conn_state == MPD_CONNECTED &&
mpd_connection_get_error(mpd.conn) != MPD_ERROR_SUCCESS) {
n = snprintf(mpd.buf, MAX_SIZE, "{\"type\":\"error\", \"data\": \"%s\"}",
mpd_connection_get_error_message(mpd.conn));
@ -328,8 +325,7 @@ out_set_pass:
return MG_TRUE;
}
int mpd_close_handler(struct mg_connection *c)
{
int mpd_close_handler(struct mg_connection *c) {
/* Cleanup session data */
if (c->connection_param)
free(c->connection_param);
@ -342,8 +338,7 @@ static int mpd_notify_callback(struct mg_connection *c, enum mg_event ev) {
if (!c->is_websocket)
return MG_TRUE;
if(c->callback_param)
{
if (c->callback_param) {
/* error message? */
n = snprintf(mpd.buf, MAX_SIZE, "{\"type\":\"error\",\"data\":\"%s\"}",
(const char *)c->callback_param);
@ -360,20 +355,16 @@ static int mpd_notify_callback(struct mg_connection *c, enum mg_event ev) {
if (mpd.conn_state != MPD_CONNECTED) {
n = snprintf(mpd.buf, MAX_SIZE, "{\"type\":\"disconnected\"}");
mg_websocket_write(c, 1, mpd.buf, n);
}
else
{
} else {
mg_websocket_write(c, 1, mpd.buf, mpd.buf_size);
if(s->song_id != mpd.song_id)
{
if (s->song_id != mpd.song_id) {
n = mpd_put_current_song(mpd.buf);
mg_websocket_write(c, 1, mpd.buf, n);
s->song_id = mpd.song_id;
}
if(s->queue_version != mpd.queue_version)
{
if (s->queue_version != mpd.queue_version) {
n = snprintf(mpd.buf, MAX_SIZE, "{\"type\":\"update_queue\"}");
mg_websocket_write(c, 1, mpd.buf, n);
s->queue_version = mpd.queue_version;
@ -383,8 +374,7 @@ static int mpd_notify_callback(struct mg_connection *c, enum mg_event ev) {
return MG_TRUE;
}
void mpd_poll(struct mg_server *s)
{
void mpd_poll(struct mg_server *s) {
switch (mpd.conn_state) {
case MPD_DISCONNECTED:
/* Try to connect */
@ -398,8 +388,7 @@ void mpd_poll(struct mg_server *s)
if (mpd_connection_get_error(mpd.conn) != MPD_ERROR_SUCCESS) {
fprintf(stderr, "MPD connection: %s\n", mpd_connection_get_error_message(mpd.conn));
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c))
{
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c)) {
c->callback_param = (void *)mpd_connection_get_error_message(mpd.conn);
mpd_notify_callback(c, MG_POLL);
}
@ -407,11 +396,9 @@ void mpd_poll(struct mg_server *s)
return;
}
if(mpd.password && !mpd_run_password(mpd.conn, mpd.password))
{
if (mpd.password && !mpd_run_password(mpd.conn, mpd.password)) {
fprintf(stderr, "MPD connection: %s\n", mpd_connection_get_error_message(mpd.conn));
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c))
{
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c)) {
c->callback_param = (void *)mpd_connection_get_error_message(mpd.conn);
mpd_notify_callback(c, MG_POLL);
}
@ -424,8 +411,7 @@ void mpd_poll(struct mg_server *s)
mpd.conn_state = MPD_CONNECTED;
/* write outputs */
mpd.buf_size = mpd_put_outputs(mpd.buf, 1);
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c))
{
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c)) {
c->callback_param = NULL;
mpd_notify_callback(c, MG_POLL);
}
@ -444,14 +430,12 @@ void mpd_poll(struct mg_server *s)
case MPD_CONNECTED:
mpd.buf_size = mpd_put_state(mpd.buf, &mpd.song_id, &mpd.queue_version);
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c))
{
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c)) {
c->callback_param = NULL;
mpd_notify_callback(c, MG_POLL);
}
mpd.buf_size = mpd_put_outputs(mpd.buf, 0);
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c))
{
for (struct mg_connection *c = mg_next(s, NULL); c != NULL; c = mg_next(s, c)) {
c->callback_param = NULL;
mpd_notify_callback(c, MG_POLL);
}
@ -459,8 +443,7 @@ void mpd_poll(struct mg_server *s)
}
}
char* mpd_get_title(struct mpd_song const *song)
{
char *mpd_get_title(struct mpd_song const *song) {
char *str;
str = (char *)mpd_song_get_tag(song, MPD_TAG_TITLE, 0);
@ -471,8 +454,7 @@ char* mpd_get_title(struct mpd_song const *song)
return str;
}
char* mpd_get_album(struct mpd_song const *song)
{
char *mpd_get_album(struct mpd_song const *song) {
char *str;
str = (char *)mpd_song_get_tag(song, MPD_TAG_ALBUM, 0);
@ -483,8 +465,7 @@ char* mpd_get_album(struct mpd_song const *song)
return str;
}
char* mpd_get_artist(struct mpd_song const *song)
{
char *mpd_get_artist(struct mpd_song const *song) {
char *str;
str = (char *)mpd_song_get_tag(song, MPD_TAG_ARTIST, 0);
@ -495,8 +476,7 @@ char* mpd_get_artist(struct mpd_song const *song)
return str;
}
char* mpd_get_year(struct mpd_song const *song)
{
char *mpd_get_year(struct mpd_song const *song) {
char *str;
str = (char *)mpd_song_get_tag(song, MPD_TAG_DATE, 0);
@ -507,8 +487,7 @@ char* mpd_get_year(struct mpd_song const *song)
return str;
}
int mpd_put_state(char *buffer, int *current_song_id, unsigned *queue_version)
{
int mpd_put_state(char *buffer, int *current_song_id, unsigned *queue_version) {
struct mpd_status *status;
int len;
@ -526,16 +505,11 @@ int mpd_put_state(char *buffer, int *current_song_id, unsigned *queue_version)
" \"songpos\": %d, \"elapsedTime\": %d, \"totalTime\":%d, "
" \"currentsongid\": %d"
"}}",
mpd_status_get_state(status),
mpd_status_get_volume(status),
mpd_status_get_repeat(status),
mpd_status_get_single(status),
mpd_status_get_crossfade(status),
mpd_status_get_consume(status),
mpd_status_get_random(status),
mpd_status_get_song_pos(status),
mpd_status_get_elapsed_time(status),
mpd_status_get_total_time(status),
mpd_status_get_state(status), mpd_status_get_volume(status),
mpd_status_get_repeat(status), mpd_status_get_single(status),
mpd_status_get_crossfade(status), mpd_status_get_consume(status),
mpd_status_get_random(status), mpd_status_get_song_pos(status),
mpd_status_get_elapsed_time(status), mpd_status_get_total_time(status),
mpd_status_get_song_id(status));
*current_song_id = mpd_status_get_song_id(status);
@ -544,8 +518,7 @@ int mpd_put_state(char *buffer, int *current_song_id, unsigned *queue_version)
return len;
}
int mpd_put_outputs(char *buffer, int names)
{
int mpd_put_outputs(char *buffer, int names) {
struct mpd_output *out;
int nout;
char *str, *strend;
@ -561,11 +534,11 @@ int mpd_put_outputs(char *buffer, int names)
if (nout++)
*str++ = ',';
if (names)
str += snprintf(str, strend - str, " \"%d\":\"%s\"",
mpd_output_get_id(out), mpd_output_get_name(out));
str += snprintf(str, strend - str, " \"%d\":\"%s\"", mpd_output_get_id(out),
mpd_output_get_name(out));
else
str += snprintf(str, strend-str, " \"%d\":%d",
mpd_output_get_id(out), mpd_output_get_enabled(out));
str += snprintf(str, strend - str, " \"%d\":%d", mpd_output_get_id(out),
mpd_output_get_enabled(out));
mpd_output_free(out);
}
if (!mpd_response_finish(mpd.conn)) {
@ -577,8 +550,7 @@ int mpd_put_outputs(char *buffer, int names)
return str - buffer;
}
int mpd_put_current_song(char *buffer)
{
int mpd_put_current_song(char *buffer) {
char *cur = buffer;
const char *end = buffer + MAX_SIZE;
struct mpd_song *song;
@ -603,8 +575,7 @@ int mpd_put_current_song(char *buffer)
return cur - buffer;
}
int mpd_put_queue(char *buffer, unsigned int offset)
{
int mpd_put_queue(char *buffer, unsigned int offset) {
char *cur = buffer;
const char *end = buffer + MAX_SIZE;
struct mpd_entity *entity;
@ -655,8 +626,7 @@ int mpd_put_queue(char *buffer, unsigned int offset)
return cur - buffer;
}
int mpd_put_browse(char *buffer, char *path, unsigned int offset)
{
int mpd_put_browse(char *buffer, char *path, unsigned int offset) {
char *cur = buffer;
const char *end = buffer + MAX_SIZE;
struct mpd_entity *entity;
@ -672,14 +642,11 @@ int mpd_put_browse(char *buffer, char *path, unsigned int offset)
const struct mpd_directory *dir;
const struct mpd_playlist *pl;
if(offset > entity_count)
{
if (offset > entity_count) {
mpd_entity_free(entity);
entity_count++;
continue;
}
else if(offset + MAX_ELEMENTS_PER_PAGE - 1 < entity_count)
{
} else if (offset + MAX_ELEMENTS_PER_PAGE - 1 < entity_count) {
mpd_entity_free(entity);
cur += json_emit_raw_str(cur, end - cur, "{\"type\":\"wrap\",\"count\":");
cur += json_emit_int(cur, end - cur, entity_count);
@ -738,8 +705,7 @@ int mpd_put_browse(char *buffer, char *path, unsigned int offset)
return cur - buffer;
}
int mpd_search(char *buffer, char *searchstr)
{
int mpd_search(char *buffer, char *searchstr) {
int i = 0;
char *cur = buffer;
const char *end = buffer + MAX_SIZE;
@ -773,8 +739,7 @@ int mpd_search(char *buffer, char *searchstr)
mpd_song_free(song);
/* Maximum results */
if(i++ >= 300)
{
if (i++ >= 300) {
cur += json_emit_raw_str(cur, end - cur, "{\"type\":\"wrap\"},");
break;
}
@ -788,9 +753,7 @@ int mpd_search(char *buffer, char *searchstr)
return cur - buffer;
}
void mpd_disconnect()
{
void mpd_disconnect() {
mpd.conn_state = MPD_DISCONNECT;
mpd_poll(NULL);
}

9
src/mpd_client.h
View File

@ -21,7 +21,8 @@
#include "mongoose.h"
#define RETURN_ERROR_AND_RECOVER(X) do { \
#define RETURN_ERROR_AND_RECOVER(X) \
do { \
fprintf(stderr, "MPD X: %s\n", mpd_connection_get_error_message(mpd.conn)); \
cur += snprintf(cur, end - cur, "{\"type\":\"error\",\"data\":\"%s\"}", \
mpd_connection_get_error_message(mpd.conn)); \
@ -30,7 +31,6 @@
return cur - buffer; \
} while (0)
#define MAX_SIZE 1024 * 100
#define MAX_ELEMENTS_PER_PAGE 512
@ -69,9 +69,7 @@
X(MPD_API_TOGGLE_CROSSFADE) \
X(MPD_API_TOGGLE_REPEAT)
enum mpd_cmd_ids {
MPD_CMDS(GEN_ENUM)
};
enum mpd_cmd_ids { MPD_CMDS(GEN_ENUM) };
enum mpd_conn_states {
MPD_DISCONNECTED,
@ -117,4 +115,3 @@ int mpd_put_browse(char *buffer, char *path, unsigned int offset);
int mpd_search(char *buffer, char *searchstr);
void mpd_disconnect();
#endif

55
src/ympd.c
View File

@ -16,25 +16,24 @@
Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <getopt.h>
#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdio.h>
#include <unistd.h>
#include <getopt.h>
#include <sys/time.h>
#include <pthread.h>
#include <unistd.h>
#include "mongoose.h"
#include "http_server.h"
#include "mpd_client.h"
#include "config.h"
#include "http_server.h"
#include "mongoose.h"
#include "mpd_client.h"
extern char *optarg;
int force_exit = 0;
void bye()
{
void bye() {
force_exit = 1;
}
@ -61,7 +60,8 @@ static int server_callback(struct mg_connection *c, enum mg_event ev) {
#endif
case MG_AUTH:
// no auth for websockets since mobile safari does not support it
if ( (mpd.gpass == NULL) || (c->is_websocket) || ((mpd.local_port > 0) && (c->local_port == mpd.local_port)) )
if ((mpd.gpass == NULL) || (c->is_websocket) ||
((mpd.local_port > 0) && (c->local_port == mpd.local_port)))
return MG_TRUE;
else {
if ((fp = fopen(mpd.gpass, "r")) != NULL) {
@ -75,8 +75,7 @@ static int server_callback(struct mg_connection *c, enum mg_event ev) {
}
}
int main(int argc, char **argv)
{
int main(int argc, char **argv) {
int n, option_index = 0;
struct mg_server *server = mg_create_server(NULL, server_callback);
unsigned int current_timer = 0, last_timer = 0;
@ -95,6 +94,7 @@ int main(int argc, char **argv)
mpd.gpass = NULL;
strcpy(mpd.host, "127.0.0.1");
/* clang-format off */
static struct option long_options[] = {
{"digest", required_argument, 0, 'D'},
{"host", required_argument, 0, 'h'},
@ -107,9 +107,9 @@ int main(int argc, char **argv)
{"mpdpass", required_argument, 0, 'm'},
{0, 0, 0, 0 }
};
/* clang-format on */
while((n = getopt_long(argc, argv, "D:h:p:l:w:u:d:v:m",
long_options, &option_index)) != -1) {
while ((n = getopt_long(argc, argv, "D:h:p:l:w:u:d:v:m", long_options, &option_index)) != -1) {
switch (n) {
case 'D':
mpd.gpass = strdup(optarg);
@ -134,14 +134,19 @@ int main(int argc, char **argv)
mpd.password = strdup(optarg);
break;
case 'v':
fprintf(stdout, "ympd %d.%d.%d\n"
fprintf(stdout,
"ympd %d.%d.%d\n"
"Copyright (C) 2014 Andrew Karpow <andy@ndyk.de>\n"
"built " __DATE__ " "__TIME__ " ("__VERSION__")\n",
"built " __DATE__
" "__TIME__
" ("__VERSION__
")\n",
YMPD_VERSION_MAJOR, YMPD_VERSION_MINOR, YMPD_VERSION_PATCH);
return EXIT_SUCCESS;
break;
default:
fprintf(stderr, "Usage: %s [OPTION]...\n\n"
fprintf(stderr,
"Usage: %s [OPTION]...\n\n"
" -D, --digest <htdigest>\tpath to htdigest file for authorization\n"
" \t(realm ympd) [no authorization]\n"
" -h, --host <host>\t\tconnect to mpd at host [localhost]\n"
@ -150,14 +155,14 @@ int main(int argc, char **argv)
" -w, --webport [ip:]<port>\tlisten interface/port for webserver [8080]\n"
" -u, --user <username>\t\tdrop priviliges to user after socket bind\n"
" -v, --version\t\t\tget version\n"
" -m, --mpdpass <password>\tspecifies the password to use when connecting to mpd\n"
" --help\t\t\t\tthis help\n"
, argv[0]);
" -m, --mpdpass <password>\tspecifies the password to use when connecting "
"to mpd\n"
" --help\t\t\t\tthis help\n",
argv[0]);
return EXIT_FAILURE;
}
if(error_msg)
{
if (error_msg) {
fprintf(stderr, "Mongoose error: %s\n", error_msg);
return EXIT_FAILURE;
}
@ -173,8 +178,7 @@ int main(int argc, char **argv)
if (run_as_user != NULL) {
error_msg = mg_set_option(server, "run_as_user", run_as_user);
free(run_as_user);
if(error_msg)
{
if (error_msg) {
fprintf(stderr, "Mongoose error: %s\n", error_msg);
return EXIT_FAILURE;
}
@ -183,8 +187,7 @@ int main(int argc, char **argv)
while (!force_exit) {
mg_poll_server(server, 200);
current_timer = time(NULL);
if(current_timer - last_timer)
{
if (current_timer - last_timer) {
last_timer = current_timer;
mpd_poll(server);
}