From d692a1858b544c34f171ba9b24847af8799022f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Mang?= Date: Mon, 23 Jul 2018 09:07:13 +0200 Subject: [PATCH 1/3] fix: use queryselector to remove dragover class --- htdocs/js/mpd.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/js/mpd.js b/htdocs/js/mpd.js index 8b7128d..dae10cc 100644 --- a/htdocs/js/mpd.js +++ b/htdocs/js/mpd.js @@ -292,7 +292,7 @@ function appInit() { domCache.progressBar.value = 0; domCache.progressBar.addEventListener('change', function(event) { - if(current_song && current_song.currentSongId >= 0) { + if (current_song && current_song.currentSongId >= 0) { var seekVal = Math.ceil(current_song.totalTime * (domCache.progressBar.value / 100)); sendAPI({"cmd": "MPD_API_SET_SEEK", "data": {"songid":current_song.currentSongId,"seek": seekVal}}); } @@ -408,7 +408,7 @@ function appInit() { document.getElementById(event.dataTransfer.getData('Text')).remove(); dragEl.style.display = ''; queueBody.insertBefore(dragEl, event.target.parentNode); - var tr = queueBody.getElementsByTagName('tr'); + var tr = queueBody.querySelectorAll('.dragover'); var trLen = tr.length; for (var i = 0; i < trLen; i++) { tr[i].classList.remove('dragover'); From 5fdc7aa7dcbf2fc270be262a0ab4963669d2aef3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Mang?= Date: Mon, 23 Jul 2018 15:36:50 +0200 Subject: [PATCH 2/3] Run perl under sudo --- mkrelease.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mkrelease.sh b/mkrelease.sh index 3761f48..5806d19 100755 --- a/mkrelease.sh +++ b/mkrelease.sh @@ -44,8 +44,8 @@ sudo sed -i -e 's/mpd\.css/mpd\.min\.css/' -e 's/player\.js/player\.min\.js/' /u sudo sed -i -e 's/mpd\.css/mpd\.min\.css/' -e 's/mpd\.js/mpd\.min\.js/' -e 's/player\.js/player\.min\.js/' /usr/share/mympd/htdocs/sw.min.js sudo sed -i -e 's/\/sw\.js/\/sw\.min\.js/' /usr/share/mympd/htdocs/js/mpd.min.js echo "Minifying html" -perl -i -pe 's/^\s*//gm; s/\s*$//gm' /usr/share/mympd/htdocs/index.html -perl -i -pe 's/^\s*//gm; s/\s*$//gm' /usr/share/mympd/htdocs/player.html +sudo perl -i -pe 's/^\s*//gm; s/\s*$//gm' /usr/share/mympd/htdocs/index.html +sudo perl -i -pe 's/^\s*//gm; s/\s*$//gm' /usr/share/mympd/htdocs/player.html echo "Fixing ownership of /var/lib/mympd" sudo chown nobody /var/lib/mympd From 59dcd48e03157e7c70f5d1f8756f8ed359a15890 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Mang?= Date: Mon, 23 Jul 2018 15:37:48 +0200 Subject: [PATCH 3/3] Update mkrelease.sh --- mkrelease.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mkrelease.sh b/mkrelease.sh index 5806d19..28f044c 100755 --- a/mkrelease.sh +++ b/mkrelease.sh @@ -65,9 +65,9 @@ then if [ contrib/mympd.service -nt /etc/systemd/system/mympd.service ] then sudo cp -v contrib/mympd.service /etc/systemd/system/ - systemctl daemon-reload + sudo systemctl daemon-reload fi - systemctl enable mympd + sudo systemctl enable mympd fi if [ -d /etc/mympd/ssl ] @@ -75,7 +75,7 @@ then echo "Certificates already created" else echo "Creating certificates" - contrib/crcert.sh + sudo contrib/crcert.sh fi echo "myMPD installed"