mirrors/ngircd
1
0
Fork 0
mirror of https://github.com/osmarks/ngircd.git synced 2024-12-13 18:30:27 +00:00
Code Issues Releases Wiki Activity

Don't set a penalty time when doing DNS lookups

Browse Source 
The logic isn't as described in the source and intended by this code:
ngIRCd doesn't wait for the asynchronous resolver process until the set
penalty time is over, but until the forked process terminates or the
initial connection timeout (= PongTimeout) triggers.

So don't set the penalty time at all and remove the wrong comment.
This commit is contained in:
Alexander Barton 2010-05-21 23:47:28 +02:00
parent 60f5dd5b29
commit d4632a727f
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ngircd/conn.c
View File

@ -1382,11 +1382,6 @@ New_Connection(int Sock)
Resolve_Addr(&My_Connections[new_sock].proc_stat, &new_addr, Resolve_Addr(&My_Connections[new_sock].proc_stat, &new_addr,
identsock, cb_Read_Resolver_Result); identsock, cb_Read_Resolver_Result);
/* ngIRCd waits up to 4 seconds for the result of the asynchronous
* DNS and IDENT resolver subprocess using the "penalty" mechanism.
* If there are results earlier, the delay is aborted. */
Conn_SetPenalty(new_sock, 4);
Account_Connection(); Account_Connection();
return new_sock; return new_sock;
} /* New_Connection */ } /* New_Connection */