mirrors/ngircd
1
0
Fork 0
mirror of https://github.com/osmarks/ngircd.git synced 2025-01-19 12:02:52 +00:00
Code Issues Releases Wiki Activity

Spoofed prefixes: close connection on non-server links only

Browse Source 
On server-links, spoofed prefixes can happen because of the asynchronous
nature of the IRC protocol. So don't break server-links, only log a message
and ignore the command.

This fixes bug 113, see:
<https://arthur.barton.de/bugzilla/show_bug.cgi?id=113>
This commit is contained in:
Alexander Barton 2011-07-19 16:00:55 +02:00
parent b7780e3f2a
commit 6cbe13085d
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ngircd/parse.c
View File

@ -325,13 +325,21 @@ Validate_Prefix( CONN_ID Idx, REQUEST *Req, bool *Closed )
/* check if the client named in the prefix is expected /* check if the client named in the prefix is expected
* to come from that direction */ * to come from that direction */
if (Client_NextHop(c) != client) { if (Client_NextHop(c) != client) {
if (Client_Type(c) != CLIENT_SERVER) {
Log(LOG_ERR, Log(LOG_ERR,
"Spoofed prefix \"%s\" from \"%s\" (connection %d, command \"%s\")!", "Spoofed prefix \"%s\" from \"%s\" (connection %d, command \"%s\")!",
Req->prefix, Client_Mask(Conn_GetClient(Idx)), Idx, Req->prefix, Client_Mask(Conn_GetClient(Idx)), Idx,
Req->command); Req->command);
Conn_Close(Idx, NULL, "Spoofed prefix", true); Conn_Close(Idx, NULL, "Spoofed prefix", true);
*Closed = true; *Closed = true;
} else {
Log(LOG_INFO,
"Ignoring spoofed prefix \"%s\" from \"%s\" (connection %d, command \"%s\").",
Req->prefix, Client_Mask(Conn_GetClient(Idx)), Idx,
Req->command);
}
return false; return false;
} }
return true; return true;