mirrors/ngircd
1
0
Fork 0
mirror of https://github.com/osmarks/ngircd.git synced 2025-03-12 20:18:11 +00:00
Code Issues Releases Wiki Activity

Fix secret channel information leak

Browse Source 
/who on a secret channel that the user is not a member of
now returns proper RPL_ENDOFWHO_MSG instead of nothing.

[picked from 12cd554af1709c44f35024d7d2fc368fb22f133d; without testcase]
This commit is contained in:
Ali Shemiran 2008-05-09 21:52:54 +02:00 committed by Florian Westphal
parent c5ba599140
commit 2e0c62df91
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -9,6 +9,9 @@
-- ChangeLog -- -- ChangeLog --
ngIRCd 0.12.X
- Fix Bug: 85: "WHO #SecretChannel" that user is not a member of now returns
proper RPL_ENDOFWHO_MSG instead of nothing. (Ali Shemiran)
ngIRCd 0.12.0-pre2 (2008-04-29) ngIRCd 0.12.0-pre2 (2008-04-29)

2
src/ngircd/irc-info.c
View File

@ -718,7 +718,7 @@ IRC_Send_WHO(CLIENT *Client, CHANNEL *Chan, bool OnlyOps)
/* Secret channel? */ /* Secret channel? */
if (!is_member && strchr(Channel_Modes(Chan), 's')) if (!is_member && strchr(Channel_Modes(Chan), 's'))
return CONNECTED; return IRC_WriteStrClient(Client, RPL_ENDOFWHO_MSG, Client_ID(Client), Channel_Name(Chan));
cl2chan = Channel_FirstMember(Chan); cl2chan = Channel_FirstMember(Chan);
for (; cl2chan ; cl2chan = Channel_NextMember(Chan, cl2chan)) { for (; cl2chan ; cl2chan = Channel_NextMember(Chan, cl2chan)) {