mirrors/ngircd
1
0
Fork 0
mirror of https://github.com/osmarks/ngircd.git synced 2025-02-07 12:50:03 +00:00
Code Issues Releases Wiki Activity

Revert "Show allowed channel types in ISUPPORT(005) numeric only"

Browse Source 
The ISUPPORT(005) numeric lists only channel prefixes which are listed
in the "AllowedChannelTypes" configuration option. And if this is the
empty string ("") for example, this now results in IRC clients assuming
"oh, no channel prefix characters at all, so no channels at all, so no
PRIVMSG can go to any channel" -- which is not the case when there are
pre-defined channel set up or other servers still having channels!

So "allowed channel types" != "supported channel types", and we always
have to list all supported ones in the ISUPPORT(005) numeric!

This reverts commit 4b7e8db418340576c95f1edad8470b66d6fe886d.

Closes #285.
This commit is contained in:
Alexander Barton 2020-11-02 11:45:41 +01:00
parent 5cf0eabd84
commit 2056de82ae
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ngircd/irc-info.c
View File

@ -1565,8 +1565,7 @@ IRC_Send_ISUPPORT(CLIENT * Client)
Conf_Network)) Conf_Network))
return DISCONNECTED; return DISCONNECTED;
if (!IRC_WriteStrClient(Client, RPL_ISUPPORT1_MSG, Client_ID(Client), if (!IRC_WriteStrClient(Client, RPL_ISUPPORT1_MSG, Client_ID(Client),
Conf_AllowedChannelTypes, Conf_AllowedChannelTypes, CHANTYPES, CHANTYPES, Conf_MaxJoins))
Conf_MaxJoins))
return DISCONNECTED; return DISCONNECTED;
return IRC_WriteStrClient(Client, RPL_ISUPPORT2_MSG, Client_ID(Client), return IRC_WriteStrClient(Client, RPL_ISUPPORT2_MSG, Client_ID(Client),
CHANNEL_NAME_LEN - 1, Conf_MaxNickLength - 1, CHANNEL_NAME_LEN - 1, Conf_MaxNickLength - 1,