mirrors/ngircd
1
0
Fork 0
mirror of https://github.com/osmarks/ngircd.git synced 2025-11-07 01:03:00 +00:00
Code Issues Releases Wiki Activity

Don't send trailing space in MODE messages

Browse Source 
Under some circumstances ngIRCd currently issues a channel MODE message
with a trailing space after the last parameter, which isn't permitted by
the grammar in RFC 2812 section 2.3.1:

http://tools.ietf.org/html/rfc2812#section-2.3.1

The following patch modifies mode-test.e to expose this, and modifies
irc-mode.c to correct it.
This commit is contained in:
Dana Dahlstrom
2008-02-16 11:27:48 +00:00
committed by Florian Westphal
parent 634ef8c131
commit 1784180bf3
3 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/testsuite/mode-test.e
View File

@@ -1,4 +1,4 @@
# $Id: mode-test.e,v 1.6 2004/03/10 20:40:06 alex Exp $
# $Id: mode-test.e,v 1.7 2008/02/16 11:27:49 fw Exp $
spawn telnet localhost 6789
expect {
@@ -72,7 +72,7 @@ expect {
send "mode #channel +v nick\r"
expect {
timeout { exit 1 }
"@* MODE #channel +v nick"
"@* MODE #channel +v nick\r"
}
send "mode #channel +I nick1\r"
@@ -96,7 +96,7 @@ expect {
send "mode #channel -vo nick nick\r"
expect {
timeout { exit 1 }
"@* MODE #channel -vo nick nick"
"@* MODE #channel -vo nick nick\r"
}
send "quit\r"