1
0
mirror of https://github.com/osmarks/mycorrhiza.git synced 2025-04-20 09:43:16 +00:00

Don't exit when removing socket fails (#260)

Prior to migrating to slog, errors when removing the socket were
ignored.
This is fine and desirable: the most likely error condition is that the
socket did not exist in the first place. Exiting on error in that case
effectively prevents Mycorrhiza to be used with unix sockets.
If the removal fails for another reason, then starting the server will
fail, so logging a warning is sufficient for troubleshooting.
This commit is contained in:
novenary 2024-12-11 23:20:24 +02:00 committed by GitHub
parent 727280147a
commit 0f7525a23c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -32,7 +32,7 @@ func serveHTTP(handler http.Handler) (err error) {
func startUnixSocketServer(server *http.Server, socketPath string) error {
err := os.Remove(socketPath)
if err != nil {
return err
slog.Warn("Failed to clean up old socket", "err", err)
}
listener, err := net.Listen("unix", socketPath)