From d457aa5951d739ab16c2d871dcdffd18c003249a Mon Sep 17 00:00:00 2001 From: Calvin Rose Date: Wed, 30 Dec 2020 10:22:45 -0600 Subject: [PATCH] Deprecate file/popen. os/spawn is the prefered way of creating a subprocess and communicating with it. --- CHANGELOG.md | 1 + src/core/io.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7d42e893..9c33e830 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ All notable changes to this project will be documented in this file. ## Unreleased - ??? +- Deprecate `file/popen` in favor of `os/spawn`. - Add `:all` keyword to `ev/read` and `net/read` to make them more like `file/read`. However, we do not provide any `:line` option as that requires buffering. - Change repl behavior to make Ctrl-C raise SIGINT on posix. The old behavior for Ctrl-C, diff --git a/src/core/io.c b/src/core/io.c index 47376290..8bdb3202 100644 --- a/src/core/io.c +++ b/src/core/io.c @@ -777,7 +777,7 @@ static const JanetReg io_cfuns[] = { #ifndef JANET_NO_PROCESSES { "file/popen", cfun_io_popen, - JDOC("(file/popen command &opt mode)\n\n" + JDOC("(file/popen command &opt mode) (DEPRECATED for os/spawn)\n\n" "Open a file that is backed by a process. The file must be opened in either " "the :r (read) or the :w (write) mode. In :r mode, the stdout of the " "process can be read from the file. In :w mode, the stdin of the process "