From 7d2bf334c80371b0b6c0e0fbe4953ba742b5c895 Mon Sep 17 00:00:00 2001 From: llmII Date: Tue, 7 Sep 2021 16:11:37 -0500 Subject: [PATCH] Fix incorrect error when argv[3] is null The `janet_get_addrinfo` function retained code that was meant for compliance with 3 separate function signatures under a single function name. Changing things to be a single function signature was broken until the code pertaining to the aforementioned was stripped out. --- src/core/net.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/core/net.c b/src/core/net.c index 12397177..8f522a27 100644 --- a/src/core/net.c +++ b/src/core/net.c @@ -301,12 +301,7 @@ static struct addrinfo *janet_get_addrinfo(Janet *argv, int32_t offset, int sock /* when is_bind is set, we're performing a connect, but wanting to * specify from where we connect, and in general don't care about a * port */ - /* TODO: remove check, argv[3] is where our bindhost is at! */ - int32_t current_offset = 2; - if (janet_checktype(argv[current_offset], JANET_KEYWORD)) { - current_offset++; - } - host = (char *)janet_getcstring(argv, current_offset); + host = (char *)janet_getcstring(argv, 3); port = NULL; err = "could not get address info for connect bind: %s"; }