From 166862ecff0cc443322992cd57646675ce4d7275 Mon Sep 17 00:00:00 2001 From: Calvin Rose Date: Sat, 27 Jul 2019 11:34:47 -0500 Subject: [PATCH] Hold off on adding file associations on windows. --- CHANGELOG.md | 1 - janet-installer.nsi | 7 ------- 2 files changed, 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b0f1ab9..c491a41a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,6 @@ All notable changes to this project will be documented in this file. ## Unreleased -- Add file associations on windows with default install. - Add `(dyn :executable)` at top level to get what used to be `(process/args 0)`. - Add `:linux` to platforms returned by `(os/which)`. diff --git a/janet-installer.nsi b/janet-installer.nsi index 3fe1dd9d..8cbb35b6 100644 --- a/janet-installer.nsi +++ b/janet-installer.nsi @@ -18,7 +18,6 @@ VIFileVersion "${PRODUCT_VERSION}" !include "MultiUser.nsh" !include "MUI2.nsh" !include ".\tools\EnvVarUpdate.nsh" -!include ".\tools\FileAssociation.nsh" !include "LogicLib.nsh" # Basics @@ -118,9 +117,6 @@ section "Janet" BfWSection !insertmacro WriteEnv JANET_LIBPATH "$INSTDIR\C" !insertmacro WriteEnv JANET_BINPATH "$INSTDIR\bin" - # File Association - ${registerExtension} "$INSTDIR\bin\janet.exe" ".janet" "Janet Source File" - SendMessage ${HWND_BROADCAST} ${WM_WININICHANGE} 0 "STR:Environment" /TIMEOUT=5000 # Update path @@ -175,9 +171,6 @@ section "uninstall" ${un.EnvVarUpdate} $0 "PATH" "R" "HKCU" "$INSTDIR\bin" ; Remove ${un.EnvVarUpdate} $0 "PATH" "R" "HKLM" "$INSTDIR\bin" ; Remove - # Unregister file assocations - ${unregisterExtension} ".janet" "Janet Source File" - # make sure windows knows about the change SendMessage ${HWND_BROADCAST} ${WM_WININICHANGE} 0 "STR:Environment" /TIMEOUT=5000