From b18c7e78e631d49405e9b889606bec31ec3c00bc Mon Sep 17 00:00:00 2001
From: "Joseph C. Sible" <josephcsible@users.noreply.github.com>
Date: Mon, 8 Sep 2025 19:42:49 -0400
Subject: [PATCH] Fix number_dialog_help when ptr is null

Dereferencing a null pointer is undefined behavior even if you don't use the
result.
---
 dialogs.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/dialogs.cpp b/dialogs.cpp
index db23892b..3c2e3237 100644
--- a/dialogs.cpp
+++ b/dialogs.cpp
@@ -1370,7 +1370,6 @@ EX namespace dialog {
     };
 
   void number_dialog_help :: operator() () {
-    auto ne = *ptr;
     init("number dialog help");
     dialog::addBreak(100);
     dialog::addHelp(XLAT("You can enter formulas in this dialog."));
@@ -1380,7 +1379,7 @@ EX namespace dialog {
     dialog::addBreak(100);
     dialog::addHelp(XLAT("Constants and variables available:"));
     addHelp(available_constants());
-    if(ptr && ne.animatable) {
+    if(ptr && ptr->animatable) {
       dialog::addBreak(100);
       dialog::addHelp(XLAT("Animations:"));
       dialog::addHelp(XLAT("a..b -- animate linearly from a to b"));
@@ -1395,7 +1394,7 @@ EX namespace dialog {
     
     #if CAP_ANIMATIONS
     dialog::addBreak(50);
-    auto f = find_edit(!ptr ? nullptr : ne.intval ? (void*) ne.intval : (void*) ne.editwhat);
+    auto f = find_edit(!ptr ? nullptr : ptr->intval ? (void*) ptr->intval : (void*) ptr->editwhat);
     if(f)
       dialog::addHelp(XLAT("Parameter names, e.g. '%1'", f->name));
     else