From f22615282999cf005a10cff4e58b2f24c292aab7 Mon Sep 17 00:00:00 2001
From: Carles Fernandez <carles.fernandez@gmail.com>
Date: Fri, 17 Dec 2021 22:01:45 +0100
Subject: [PATCH] CI: make clang-tidy happy. Was:
 modernize-use-default-member-init

---
 .../gps_l1_ca_pcps_acquisition_test.cc            | 15 +++++++--------
 .../libs/acquisition_dump_reader.cc               | 11 +----------
 .../galileo_e1_dll_pll_veml_tracking_test.cc      |  8 +++-----
 3 files changed, 11 insertions(+), 23 deletions(-)

diff --git a/src/tests/unit-tests/signal-processing-blocks/acquisition/gps_l1_ca_pcps_acquisition_test.cc b/src/tests/unit-tests/signal-processing-blocks/acquisition/gps_l1_ca_pcps_acquisition_test.cc
index b8501dd29..e9c5d9e45 100644
--- a/src/tests/unit-tests/signal-processing-blocks/acquisition/gps_l1_ca_pcps_acquisition_test.cc
+++ b/src/tests/unit-tests/signal-processing-blocks/acquisition/gps_l1_ca_pcps_acquisition_test.cc
@@ -71,7 +71,7 @@ private:
     GpsL1CaPcpsAcquisitionTest_msg_rx();
 
 public:
-    int rx_message;
+    int rx_message{0};
     ~GpsL1CaPcpsAcquisitionTest_msg_rx() override;  //!< Default destructor
 };
 
@@ -98,8 +98,8 @@ void GpsL1CaPcpsAcquisitionTest_msg_rx::msg_handler_channel_events(const pmt::pm
 
 
 GpsL1CaPcpsAcquisitionTest_msg_rx::GpsL1CaPcpsAcquisitionTest_msg_rx()
-    : gr::block("GpsL1CaPcpsAcquisitionTest_msg_rx", gr::io_signature::make(0, 0, 0), gr::io_signature::make(0, 0, 0)),
-      rx_message(0)
+    : gr::block("GpsL1CaPcpsAcquisitionTest_msg_rx", gr::io_signature::make(0, 0, 0), gr::io_signature::make(0, 0, 0))
+
 {
     this->message_port_register_in(pmt::mp("events"));
     this->set_msg_handler(pmt::mp("events"),
@@ -124,9 +124,8 @@ class GpsL1CaPcpsAcquisitionTest : public ::testing::Test
 {
 protected:
     GpsL1CaPcpsAcquisitionTest()
-        : item_size(sizeof(gr_complex)),
-          doppler_max(5000),
-          doppler_step(100)
+        : item_size(sizeof(gr_complex))
+
     {
         config = std::make_shared<InMemoryConfiguration>();
         gnss_synchro = Gnss_Synchro();
@@ -141,8 +140,8 @@ protected:
     std::shared_ptr<InMemoryConfiguration> config;
     Gnss_Synchro gnss_synchro{};
     size_t item_size;
-    unsigned int doppler_max;
-    unsigned int doppler_step;
+    unsigned int doppler_max{5000};
+    unsigned int doppler_step{100};
 };
 
 
diff --git a/src/tests/unit-tests/signal-processing-blocks/libs/acquisition_dump_reader.cc b/src/tests/unit-tests/signal-processing-blocks/libs/acquisition_dump_reader.cc
index 78a7c6603..66a6ebf7b 100644
--- a/src/tests/unit-tests/signal-processing-blocks/libs/acquisition_dump_reader.cc
+++ b/src/tests/unit-tests/signal-processing-blocks/libs/acquisition_dump_reader.cc
@@ -196,16 +196,7 @@ Acquisition_Dump_Reader::Acquisition_Dump_Reader(const std::string& basename,
     unsigned int samples_per_code,
     int channel,
     int execution)
-    : acq_doppler_hz(0.0),
-      acq_delay_samples(0.0),
-      test_statistic(0.0),
-      input_power(0.0),
-      threshold(0.0),
-      positive_acq(0),
-      PRN(0),
-      num_dwells(0),
-      sample_counter(0),
-      d_basename(basename),
+    : d_basename(basename),
       d_sat(sat),
       d_doppler_max(doppler_max),
       d_doppler_step(doppler_step),
diff --git a/src/tests/unit-tests/signal-processing-blocks/tracking/galileo_e1_dll_pll_veml_tracking_test.cc b/src/tests/unit-tests/signal-processing-blocks/tracking/galileo_e1_dll_pll_veml_tracking_test.cc
index a17d9682c..734d70af2 100644
--- a/src/tests/unit-tests/signal-processing-blocks/tracking/galileo_e1_dll_pll_veml_tracking_test.cc
+++ b/src/tests/unit-tests/signal-processing-blocks/tracking/galileo_e1_dll_pll_veml_tracking_test.cc
@@ -41,9 +41,7 @@ class GalileoE1DllPllVemlTrackingInternalTest : public ::testing::Test
 {
 protected:
     GalileoE1DllPllVemlTrackingInternalTest()
-        : item_size(sizeof(gr_complex)),
-          stop(false),
-          message(0)
+        : item_size(sizeof(gr_complex))
     {
         factory = std::make_shared<GNSSBlockFactory>();
         config = std::make_shared<InMemoryConfiguration>();
@@ -60,8 +58,8 @@ protected:
     std::shared_ptr<InMemoryConfiguration> config;
     Gnss_Synchro gnss_synchro{};
     size_t item_size;
-    bool stop;
-    int message;
+    bool stop{false};
+    int message{0};
 };