mirrors/gnss-sdr
1
0
Fork 0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2025-10-31 07:13:03 +00:00
Code Issues Releases Wiki Activity

Fix more defects detected by Coverity Scan

Browse Source
This commit is contained in:
Carles Fernandez
2023-12-03 14:33:23 +01:00
parent 906d717381
commit e286a0d807
5 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/apps/volk_gnsssdr_profile.cc
View File

@@ -47,7 +47,7 @@ void set_benchmark(bool val) { test_params.set_benchmark(val); }
void set_tolerance(float val) { test_params.set_tol(val); }
void set_vlen(int val) { test_params.set_vlen((unsigned int)val); }
void set_iter(int val) { test_params.set_iter((unsigned int)val); }
void set_substr(std::string val) { test_params.set_regex(val); }
void set_substr(std::string val) { test_params.set_regex(std::move(val)); }
bool update_mode = false;
void set_update(bool val) { update_mode = val; }
bool dry_run = false;

3
src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/lib/qa_utils.cc
View File

@@ -20,8 +20,7 @@
#include <limits> // for numeric_limits
#include <map> // for map
#include <random> // for random_device, default_random_engine, uniform_real_distribution
#include <utility>
#include <vector> // for vector
#include <vector> // for vector
template <typename T>
void random_values(T *buf, unsigned int n, std::default_random_engine &e1)

9
src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/lib/qa_utils.h
View File

@@ -19,6 +19,7 @@
#include <cstdlib> // for NULL
#include <map> // for map
#include <string> // for string, basic_string
#include <utility> // for move
#include <vector> // for vector
@@ -69,14 +70,14 @@ private:
public:
// ctor
volk_gnsssdr_test_params_t(float tol, lv_32fc_t scalar, unsigned int vlen, unsigned int iter,
bool benchmark_mode, std::string kernel_regex) : _tol(tol), _scalar(scalar), _vlen(vlen), _iter(iter), _benchmark_mode(benchmark_mode), _kernel_regex(kernel_regex){};
bool benchmark_mode, std::string kernel_regex) : _tol(tol), _scalar(scalar), _vlen(vlen), _iter(iter), _benchmark_mode(benchmark_mode), _kernel_regex(std::move(kernel_regex)){};
// setters
void set_tol(float tol) { _tol = tol; };
void set_scalar(lv_32fc_t scalar) { _scalar = scalar; };
void set_vlen(unsigned int vlen) { _vlen = vlen; };
void set_iter(unsigned int iter) { _iter = iter; };
void set_benchmark(bool benchmark) { _benchmark_mode = benchmark; };
void set_regex(std::string regex) { _kernel_regex = regex; };
void set_regex(std::string regex) { _kernel_regex = std::move(regex); };
// getters
float tol() { return _tol; };
lv_32fc_t scalar() { return _scalar; };
@@ -103,10 +104,10 @@ public:
volk_gnsssdr_test_params_t test_parameters() { return _test_parameters; };
// normal ctor
volk_gnsssdr_test_case_t(volk_gnsssdr_func_desc_t desc, void (*kernel_ptr)(), std::string name,
volk_gnsssdr_test_params_t test_parameters) : _desc(desc), _kernel_ptr(kernel_ptr), _name(name), _test_parameters(test_parameters), _puppet_master_name("NULL"){};
volk_gnsssdr_test_params_t test_parameters) : _desc(desc), _kernel_ptr(kernel_ptr), _name(std::move(name)), _test_parameters(std::move(test_parameters)), _puppet_master_name("NULL"){};
// ctor for puppets
volk_gnsssdr_test_case_t(volk_gnsssdr_func_desc_t desc, void (*kernel_ptr)(), std::string name,
std::string puppet_master_name, volk_gnsssdr_test_params_t test_parameters) : _desc(desc), _kernel_ptr(kernel_ptr), _name(name), _test_parameters(test_parameters), _puppet_master_name(puppet_master_name){};
std::string puppet_master_name, volk_gnsssdr_test_params_t test_parameters) : _desc(desc), _kernel_ptr(kernel_ptr), _name(std::move(name)), _test_parameters(std::move(test_parameters)), _puppet_master_name(std::move(puppet_master_name)){};
};
/************************************************

3
src/tests/unit-tests/signal-processing-blocks/pvt/serdes_monitor_pvt_test.cc
View File

@@ -17,6 +17,7 @@
#include "serdes_galileo_eph.h"
#include "serdes_monitor_pvt.h"
#include <memory>
#include <utility>
TEST(Serdes_Monitor_Pvt_Test, Simpletest)
{
@@ -41,7 +42,7 @@ TEST(Serdes_Monitor_Pvt_Test, GalileoEphemerisSerdes)
eph->tow = true_tow;
Serdes_Galileo_Eph gal_serdes = Serdes_Galileo_Eph();
std::string serialized_data = gal_serdes.createProtobuffer(eph);
std::string serialized_data = gal_serdes.createProtobuffer(std::move(eph));
gnss_sdr::GalileoEphemeris ephgal;
ephgal.ParseFromString(serialized_data);

3
src/tests/unit-tests/signal-processing-blocks/telemetry_decoder/galileo_fnav_inav_decoder_test.cc
View File

@@ -28,6 +28,7 @@
#include <iterator> // for std::back_inserter
#include <string>
#include <unistd.h>
#include <utility>
class Galileo_FNAV_INAV_test : public ::testing::Test
@@ -102,7 +103,7 @@ public:
if (page_part_bits[0] == 1)
{
// DECODE COMPLETE WORD (even + odd) and TEST CRC
INAV_decoder.split_page(page_String, flag_even_word_arrived);
INAV_decoder.split_page(std::move(page_String), flag_even_word_arrived);
if (INAV_decoder.get_flag_CRC_test() == true)
{
crc_ok = true;