fixing coverity issues: unitialized members

src/core/receiver/control_thread.cc

@@ -95,6 +95,7 @@ DEFINE_string(config_file, std::string(GNSSSDR_INSTALL_DIR "/share/gnss-sdr/conf
 ControlThread::ControlThread()
 {
     configuration_ = std::make_shared<FileConfiguration>(FLAGS_config_file);
+    delete_configuration_ = false;
     init();
 }
 
@@ -102,6 +103,7 @@ ControlThread::ControlThread()
 ControlThread::ControlThread(std::shared_ptr<ConfigurationInterface> configuration)
 {
     configuration_ = configuration;
+    delete_configuration_ = false;
     init();
 }
 
@@ -936,7 +938,7 @@ void ControlThread::keyboard_listener()
     char c;
     while(read_keys)
         {
-            c = std::cin.get();
+            std::cin.get(c);
             if (c =='q')
                 {
                     std::cout << "Quit keystroke order received, stopping GNSS-SDR !!" << std::endl;

src/core/system_parameters/galileo_almanac.cc

@@ -30,5 +30,67 @@
 
 #include "galileo_almanac.h"
 
-Galileo_Almanac::Galileo_Almanac() {}
+Galileo_Almanac::Galileo_Almanac()
+{
+    /*Word type 7: Almanac for SVID1 (1/2), almanac reference time and almanac reference week number*/
+    int IOD_a_7 = 0;
+    WN_a_7 = 0.0;
+    t0a_7 = 0.0;
+    int SVID1_7 = 0;
+    DELTA_A_7 = 0.0;
+    e_7 = 0.0;
+    omega_7 = 0.0;
+    delta_i_7 = 0.0;
+    Omega0_7 = 0.0;
+    Omega_dot_7 = 0.0;
+    M0_7 = 0.0;
+
+    /*Word type 8: Almanac for SVID1 (2/2) and SVID2 (1/2)*/
+    int IOD_a_8 = 0;
+    af0_8 = 0.0;
+    af1_8 = 0.0;
+    E5b_HS_8 = 0.0;
+    E1B_HS_8 = 0.0;
+    E5a_HS_8 = 0.0;
+    int SVID2_8;
+    DELTA_A_8 = 0.0;
+    e_8 = 0.0;
+    omega_8 = 0.0;
+    delta_i_8 = 0.0;
+    Omega0_8 = 0.0;
+    Omega_dot_8 = 0.0;
+
+    /*Word type 9: Almanac for SVID2 (2/2) and SVID3 (1/2)*/
+    int IOD_a_9 = 0;
+    WN_a_9 = 0.0;
+    t0a_9 = 0.0;
+    M0_9 = 0.0;
+    af0_9 = 0.0;
+    af1_9 = 0.0;
+    E5b_HS_9 = 0.0;
+    E1B_HS_9 = 0.0;
+    E5a_HS_9 = 0.0;
+    int SVID3_9;
+    DELTA_A_9 = 0.0;
+    e_9 = 0.0;
+    omega_9 = 0.0;
+    delta_i_9 = 0.0;
+
+    /*Word type 10: Almanac for SVID3 (2/2)*/
+    int IOD_a_10 = 0;
+    Omega0_10 = 0.0;
+    Omega_dot_10 = 0.0;
+    M0_10 = 0.0;
+    af0_10 = 0.0;
+    af1_10 = 0.0;
+    E5b_HS_10 = 0.0;
+    E1B_HS_10 = 0.0;
+    E5a_HS_10 = 0.0;
+
+    /*GPS to Galileo GST conversion parameters*/
+    A_0G_10 = 0.0;
+    A_1G_10 = 0.0;
+    t_0G_10 = 0.0;
+    WN_0G_10 = 0.0;
+}
 

src/core/system_parameters/galileo_almanac.h

@@ -96,10 +96,10 @@ public:
     double E5a_HS_10;
 
     /*GPS to Galileo GST conversion parameters*/
-    double A_0G_10 = 0;
+    double A_0G_10;
-    double A_1G_10 = 0;
+    double A_1G_10;
-    double t_0G_10 = 0;
+    double t_0G_10;
-    double WN_0G_10 = 0;
+    double WN_0G_10;
 
     Galileo_Almanac();  //!< Default constructor
 };

src/core/system_parameters/galileo_ephemeris.cc

@@ -67,8 +67,22 @@ Galileo_Ephemeris::Galileo_Ephemeris()
     E1B_HS_5 = 0;
     E5b_DVS_5 = 0;
     E1B_DVS_5 = 0;
-    BGD_E1E5a_5 = 0;        //!< E1-E5a Broadcast Group Delay [s]
+    BGD_E1E5a_5 = 0;        // E1-E5a Broadcast Group Delay [s]
-    BGD_E1E5b_5 = 0;        //!< E1-E5b Broadcast Group Delay [s]
+    BGD_E1E5b_5 = 0;        // E1-E5b Broadcast Group Delay [s]
+
+    Galileo_satClkDrift = 0.0;
+    Galileo_dtr = 0.0;
+
+    // satellite positions
+    d_satpos_X = 0.0;
+    d_satpos_Y = 0.0;
+    d_satpos_Z = 0.0;
+    // Satellite velocity
+    d_satvel_X = 0.0;
+    d_satvel_Y = 0.0;
+    d_satvel_Z = 0.0;
+
+    i_satellite_PRN = 0;
 }
 
 

src/core/system_parameters/galileo_navigation_message.cc

@@ -206,6 +206,21 @@ void Galileo_Navigation_Message::reset()
     Time_0 = 0;
     WN_0 = 0;
     TOW_0 = 0;
+
+    flag_TOW_6 = false;
+
+    Galileo_satClkDrift = 0.0;
+    Galileo_dtr = 0.0;
+
+    // satellite positions
+    galileo_satpos_X = 0.0;
+    galileo_satpos_Y = 0.0;
+    galileo_satpos_Z = 0.0;
+    // Satellite velocity
+    galileo_satvel_X = 0.0;
+    galileo_satvel_Y = 0.0;
+    galileo_satvel_Z = 0.0;
+
 }
 
 
@@ -555,6 +570,8 @@ Galileo_Ephemeris Galileo_Navigation_Message::get_ephemeris()
     ephemeris.BGD_E1E5a_5 = BGD_E1E5a_5;        // E1-E5a Broadcast Group Delay [s]
     ephemeris.BGD_E1E5b_5 = BGD_E1E5b_5;        // E1-E5b Broadcast Group Delay [s]
 
+    ephemeris.Galileo_satClkDrift = Galileo_satClkDrift;
+
     return ephemeris;
 }
 

src/core/system_parameters/gps_acq_assist.cc

@@ -32,5 +32,18 @@
 
 #include "gps_acq_assist.h"
 
-Gps_Acq_Assist::Gps_Acq_Assist() {}
+Gps_Acq_Assist::Gps_Acq_Assist()
+{
+    i_satellite_PRN = 0;
+    d_TOW = 0.0;
+    d_Doppler0 = 0.0;
+    d_Doppler1 = 0.0;
+    dopplerUncertainty = 0.0;
+    Code_Phase = 0.0;
+    Code_Phase_int = 0.0;
+    GPS_Bit_Number = 0.0;
+    Code_Phase_window = 0.0;
+    Azimuth = 0.0;
+    Elevation = 0.0;
+}