Improve includes with the aid of include-what-you-use (IWYU)

See rationale at https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/WhyIWYU.md

src/algorithms/observables/adapters/hybrid_observables.cc

@@ -33,6 +33,7 @@
 #include "hybrid_observables.h"
 #include "configuration_interface.h"
 #include <glog/logging.h>
+#include <ostream>  // for operator<<
 
 
 HybridObservables::HybridObservables(ConfigurationInterface* configuration,
@@ -44,7 +45,7 @@ HybridObservables::HybridObservables(ConfigurationInterface* configuration,
     dump_mat_ = configuration->property(role + ".dump_mat", true);
     dump_filename_ = configuration->property(role + ".dump_filename", default_dump_filename);
 
-    observables_ = hybrid_make_observables_gs(in_streams_, out_streams_, dump_, dump_mat_, dump_filename_);
+    observables_ = hybrid_observables_gs_make(in_streams_, out_streams_, dump_, dump_mat_, dump_filename_);
     DLOG(INFO) << "Observables block ID (" << observables_->unique_id() << ")";
 }
 

src/algorithms/observables/adapters/hybrid_observables.h

@@ -36,6 +36,9 @@
 
 #include "hybrid_observables_gs.h"
 #include "observables_interface.h"
+#include <gnuradio/gr_complex.h>     // for gr_complex
+#include <gnuradio/runtime_types.h>  // for basic_block_sptr, top_block_sptr
+#include <cstddef>
 #include <string>
 
 class ConfigurationInterface;

src/algorithms/observables/gnuradio_blocks/CMakeLists.txt

@@ -37,13 +37,13 @@ target_link_libraries(obs_gr_blocks
     PUBLIC
         Boost::boost
         Gnuradio::blocks
-        core_system_parameters
     PRIVATE
+        algorithms_libs
+        core_system_parameters
         Gflags::gflags
         Glog::glog
         Boost::filesystem
         Matio::matio
-        algorithms_libs
 )
 
 if(ENABLE_CLANG_TIDY)

src/algorithms/observables/gnuradio_blocks/hybrid_observables_gs.cc

@@ -30,23 +30,24 @@
  */
 
 #include "hybrid_observables_gs.h"
-#include "GPS_L1_CA.h"
-#include "display.h"
+#include "GPS_L1_CA.h"       // for GPS_STARTOFFSET_MS, GPS_TWO_PI
+#include "MATH_CONSTANTS.h"  // for SPEED_OF_LIGHT
+#include "gnss_circular_deque.h"
 #include "gnss_sdr_create_directory.h"
+#include "gnss_synchro.h"
 #include <boost/filesystem/path.hpp>
 #include <glog/logging.h>
 #include <gnuradio/io_signature.h>
 #include <matio.h>
-#include <algorithm>
-#include <cmath>
-#include <cstdlib>
-#include <exception>
-#include <iostream>
-#include <limits>
-#include <utility>
+#include <cmath>      // for round
+#include <cstdlib>    // for size_t, llabs
+#include <exception>  // for exception
+#include <iostream>   // for cerr, cout
+#include <limits>     // for numeric_limits
+#include <utility>    // for move
 
 
-hybrid_observables_gs_sptr hybrid_make_observables_gs(unsigned int nchannels_in, unsigned int nchannels_out, bool dump, bool dump_mat, std::string dump_filename)
+hybrid_observables_gs_sptr hybrid_observables_gs_make(unsigned int nchannels_in, unsigned int nchannels_out, bool dump, bool dump_mat, std::string dump_filename)
 {
     return hybrid_observables_gs_sptr(new hybrid_observables_gs(nchannels_in, nchannels_out, dump, dump_mat, std::move(dump_filename)));
 }

src/algorithms/observables/gnuradio_blocks/hybrid_observables_gs.h

@@ -34,21 +34,24 @@
 #ifndef GNSS_SDR_HYBRID_OBSERVABLES_GS_H
 #define GNSS_SDR_HYBRID_OBSERVABLES_GS_H
 
-#include "gnss_circular_deque.h"
-#include "gnss_synchro.h"
-#include <boost/dynamic_bitset.hpp>
-#include <gnuradio/block.h>
-#include <fstream>
-#include <string>
-#include <utility>
-
+#include <boost/circular_buffer.hpp>  // for boost::curcular_buffer
+#include <boost/shared_ptr.hpp>       // for boost::shared_ptr
+#include <gnuradio/block.h>           // for block
+#include <gnuradio/types.h>           // for gr_vector_int
+#include <cstdint>                    // for int32_t
+#include <fstream>                    // for string, ofstream
+#include <vector>                     // for vector
 
+class Gnss_Synchro;
 class hybrid_observables_gs;
 
+template <class T>
+class Gnss_circular_deque;
+
 using hybrid_observables_gs_sptr = boost::shared_ptr<hybrid_observables_gs>;
 
 hybrid_observables_gs_sptr
-hybrid_make_observables_gs(unsigned int nchannels_in, unsigned int nchannels_out, bool dump, bool dump_mat, std::string dump_filename);
+hybrid_observables_gs_make(unsigned int nchannels_in, unsigned int nchannels_out, bool dump, bool dump_mat, std::string dump_filename);
 
 /*!
  * \brief This class implements a block that computes observables
@@ -63,7 +66,7 @@ public:
 
 private:
     friend hybrid_observables_gs_sptr
-    hybrid_make_observables_gs(uint32_t nchannels_in, uint32_t nchannels_out, bool dump, bool dump_mat, std::string dump_filename);
+    hybrid_observables_gs_make(uint32_t nchannels_in, uint32_t nchannels_out, bool dump, bool dump_mat, std::string dump_filename);
     hybrid_observables_gs(uint32_t nchannels_in, uint32_t nchannels_out, bool dump, bool dump_mat, std::string dump_filename);
     bool interpolate_data(Gnss_Synchro& out, const uint32_t& ch, const double& ti);
     bool interp_trk_obs(Gnss_Synchro& interpolated_obs, const uint32_t& ch, const uint64_t& rx_clock);