From 9551c5e5a163b2cd108c9c7d9046acad6b87e8f7 Mon Sep 17 00:00:00 2001 From: Carles Fernandez Date: Tue, 12 Feb 2019 02:44:44 +0100 Subject: [PATCH 1/2] clang-tidy: apply performance-unnecessary-value-param check --- src/core/monitor/gnss_synchro_monitor.cc | 2 +- src/core/monitor/gnss_synchro_monitor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/monitor/gnss_synchro_monitor.cc b/src/core/monitor/gnss_synchro_monitor.cc index 0454c19eb..35c0aee79 100644 --- a/src/core/monitor/gnss_synchro_monitor.cc +++ b/src/core/monitor/gnss_synchro_monitor.cc @@ -57,7 +57,7 @@ gnss_synchro_monitor_sptr gnss_synchro_make_monitor(unsigned int n_channels, gnss_synchro_monitor::gnss_synchro_monitor(unsigned int n_channels, int output_rate_ms, int udp_port, - std::vector udp_addresses) : gr::sync_block("gnss_synchro_monitor", + const std::vector& udp_addresses) : gr::sync_block("gnss_synchro_monitor", gr::io_signature::make(n_channels, n_channels, sizeof(Gnss_Synchro)), gr::io_signature::make(0, 0, 0)) { diff --git a/src/core/monitor/gnss_synchro_monitor.h b/src/core/monitor/gnss_synchro_monitor.h index 7c22a1290..ae95fb012 100644 --- a/src/core/monitor/gnss_synchro_monitor.h +++ b/src/core/monitor/gnss_synchro_monitor.h @@ -74,7 +74,7 @@ public: gnss_synchro_monitor(unsigned int nchannels, int output_rate_ms, int udp_port, - std::vector udp_addresses); + const std::vector& udp_addresses); ~gnss_synchro_monitor(); //!< Default destructor From ef0da0a9733e2b5f1dd1269477fd870d94bf66e5 Mon Sep 17 00:00:00 2001 From: Carles Fernandez Date: Tue, 12 Feb 2019 09:16:22 +0100 Subject: [PATCH 2/2] clang-tidy: apply performance-unnecessary-value-param check --- src/core/monitor/gnss_synchro_monitor.cc | 4 ++-- src/core/monitor/gnss_synchro_monitor.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/monitor/gnss_synchro_monitor.cc b/src/core/monitor/gnss_synchro_monitor.cc index 35c0aee79..f8997d6a3 100644 --- a/src/core/monitor/gnss_synchro_monitor.cc +++ b/src/core/monitor/gnss_synchro_monitor.cc @@ -45,12 +45,12 @@ using google::LogMessage; gnss_synchro_monitor_sptr gnss_synchro_make_monitor(unsigned int n_channels, int output_rate_ms, int udp_port, - std::vector udp_addresses) + const std::vector& udp_addresses) { return gnss_synchro_monitor_sptr(new gnss_synchro_monitor(n_channels, output_rate_ms, udp_port, - std::move(udp_addresses))); + udp_addresses)); } diff --git a/src/core/monitor/gnss_synchro_monitor.h b/src/core/monitor/gnss_synchro_monitor.h index ae95fb012..a0a8e470a 100644 --- a/src/core/monitor/gnss_synchro_monitor.h +++ b/src/core/monitor/gnss_synchro_monitor.h @@ -48,7 +48,7 @@ using gnss_synchro_monitor_sptr = boost::shared_ptr; gnss_synchro_monitor_sptr gnss_synchro_make_monitor(unsigned int n_channels, int output_rate_ms, int udp_port, - std::vector udp_addresses); + const std::vector& udp_addresses); /*! * \brief This class implements a block that computes the PVT solution with Galileo E1 signals @@ -59,7 +59,7 @@ private: friend gnss_synchro_monitor_sptr gnss_synchro_make_monitor(unsigned int nchannels, int output_rate_ms, int udp_port, - std::vector udp_addresses); + const std::vector& udp_addresses); unsigned int d_nchannels;